GitLab

This resolves the following 'gn check' error:

  ERROR at //base/prefs/mock_pref_change_callback.cc:5:11: Include not allowed.
  #include "base/prefs/mock_pref_change_callback.h"
            ^-------------------------------------
  It is not in any dependency of //base:prefs_test_support
  The include file is in the target(s):
    //base:base_unittests
  which should somehow be reachable from //base:prefs_test_support

Review URL: https://codereview.chromium.org/378653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282042 0039d316-1c4b-4281-b951-d872f2087c98

As client certificate information is now retrieved from policy, most of NetworkUIData can be removed except ONCSource to indicate whether a network was managed after the policy got removed.

BUG=391292
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/370623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282038 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/381663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377497
NOTRY=true

Review URL: https://codereview.chromium.org/377753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282036 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, we eagerly cleaned up purgeable resources when the
ServiceWorkerStorage object is initialized, which could result in an IO
flurry at browser startup. This patch:
- Cleans up uncommitted resources (not just purgeable resources) left
over from the last browser session
- Performs that cleanup lazily, when a mutation of the
purgeable or uncommitted resources is about to occur

BUG=388095

Review URL: https://codereview.chromium.org/374873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
NOTRY=True

Review URL: https://codereview.chromium.org/378323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282034 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the create flag, and makes the Open operation fail if a file
doesn't exist. This is because a separate event for creating files is coming
soon.

TEST=unit_tests, browser_tests: *FileSystemProvider*Open*, *FileSystemProvider*ReadFile*
BUG=391362

Review URL: https://codereview.chromium.org/379743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282033 0039d316-1c4b-4281-b951-d872f2087c98

- Move constants into *_constants.{cc,h}.
- Remove unused constants.
- Lay foundation for detailed process exit codes.

BUG=385419

Review URL: https://codereview.chromium.org/365143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282032 0039d316-1c4b-4281-b951-d872f2087c98

Revert the content shell portion of:
  https://codereview.chromium.org/329223002/
This will enable landing of:
  https://codereview.chromium.org/371943003/

There is an unexplained error when the chromium linker is turned on for
the content shell.  It manifests (in logcat) as:

0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: FATAL EXCEPTION: ChildProcessMain
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: Process: org.chromium.content_shell_apk:sandboxed_process0, PID: 23281
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: java.lang.RuntimeException: Parcel android.os.Parcel@420d90b8: Unmarshalling unknown type code 6881388 at offset 244
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Parcel.readValue(Parcel.java:2080)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Parcel.readArrayMapInternal(Parcel.java:2314)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Bundle.unparcel(Bundle.java:249)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at android.os.Bundle.keySet(Bundle.java:345)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.Linker.createLibInfoMapFromBundle(Linker.java:1090)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.Linker.useSharedRelrosLocked(Linker.java:737)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.Linker.finishLibraryLoad(Linker.java:443)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:179)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.base.library_loader.LibraryLoader.loadNow(LibraryLoader.java:125)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at org.chromium.content.app.ChildProcessService$2.run(ChildProcessService.java:149)
0a3b6:  07-08 13:40:43.925 23281 23295 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:841)

This does not occur with the chrome shell.  The change in

  https://codereview.chromium.org/371943003/

corrects chromium linker operation and resolves crbug/388356, but to land that
requires that we turn off the chromium linker on the content shell first.

BUG=388356

Review URL: https://codereview.chromium.org/379603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282030 0039d316-1c4b-4281-b951-d872f2087c98

This is required to free the internal resources allocated when creating
the stats table

BUG=392244
R=marja@chromium.org

Review URL: https://codereview.chromium.org/377163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282029 0039d316-1c4b-4281-b951-d872f2087c98

At the time LoginDisplayHostImpl decides whether enrollment flow is to be
started, policy hasn't been read yet, so LoginDisplayHostImpl is not in a
position to decide whether recovery is required.  To work around this, upon
policy load on machines requiring recovery, a flag is stored in prefs which
is accessed by LoginDisplayHostImpl early during (next) boot.

Enrollment recovery depends on the availability of the machine id and is
silently skipped when the latter is missing.  There'll be a separate CL to
have session manager provide the machine id on devices that require recovery.

BUG=389481

Review URL: https://codereview.chromium.org/374573006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282028 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282027 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177645:177730&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/379783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282026 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282025 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff dslomov@chromium.org in case of problems.

TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/378233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282024 0039d316-1c4b-4281-b951-d872f2087c98

These messages allow requesting display updates and performing basic display
configuration.

BUG=377497
NOTRY=true

Review URL: https://codereview.chromium.org/378673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282022 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a build failure. I also did some refactoring.
This is a re-land that fixes a build error.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804

Review URL: https://codereview.chromium.org/376733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282021 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282020 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
NOTREECHECKS=true

TBR=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/376143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282019 0039d316-1c4b-4281-b951-d872f2087c98

Currently, it returns 'const PasswordFormMap'. While returning a value, marking it const does not make much sense (it's a copy anyway). So it should be either 'const PasswordFormMap&' or just 'PasswordFormMap'. The only place this call is used at makes a copy of the result anyway, so I chose the former. That also seems to be a more versatile choice -- if somebody needs just a read-only copy in the future, returning by value would result in an unnecessary copy.

BUG=261628
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/382493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282018 0039d316-1c4b-4281-b951-d872f2087c98

This patch is mainly for merging into M37. In trunk, we should fix
base:: conversion routines instead.

Blink UTF conversion routines are considerably faster than the ones
from base::, especially on strings that only contain Latin-1 characters,
so use them instead. This gives a 9% speed gain on Cordova's "exec"
benchmark.

BUG=391492

Review URL: https://codereview.chromium.org/377173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282017 0039d316-1c4b-4281-b951-d872f2087c98

onc_validator had some deviations from the onc_spec.
This updates the onc_spec.

BUG=386182
R=davidroche@chromium.org, pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/366273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282016 0039d316-1c4b-4281-b951-d872f2087c98

This CL does the 3 following things to allow the mojo shell to run:

- Updates java_apk.gypi to allow bundling additional libs.
- Bundle the network service with the mojo shell.
- Updates the shell to look for .so and .cr.so file in the local file
  system for android component build.

Review URL: https://codereview.chromium.org/334783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282015 0039d316-1c4b-4281-b951-d872f2087c98

The only reason this flag is still around is because the buildbots still pass it to Telemetry.

BUG=None

Review URL: https://codereview.chromium.org/348223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/378223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389016

Review URL: https://codereview.chromium.org/363853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282012 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282010 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of NaCl: Update revision in DEPS, r13441 -> r13452 (https://codereview.chromium.org/371413003/)
> 
> Reason for revert:
> Suspect this is causing PPAPINaClNewlibTest.FileIO to crash on Mac:
> 
> http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%283%29/builds/3112
> 
> Original issue's description:
> > NaCl: Update revision in DEPS, r13441 -> r13452
> > 
> > This pulls in the following Native Client changes:
> > 
> > r13442: (dyen) Added support for log uploading for commands in toolchain_build.
> > r13443: (noelallen) Rolls DEPS file to get deps aware toolchains.
> > r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes.
> > r13446: (ncbray) Factor arg parsing in sel_ldr into its own function.
> > r13447: (ncbray) Add my chromium account to OWNERS with my google account.
> > r13448: (dyen) Fixed repo_tools invalid reference to pynacl.
> > r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck.
> > r13450: (ncbray) Consolidate sel_ldr's configuration logic.
> > r13451: (dyen) Package Version script now supports downloading build logs.
> > r13452: (hamaji) Non-SFI Mode: Add isatty interface
> > 
> > BUG=none
> > TEST=browser_tests and nacl_integration
> > CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281849
> 
> TBR=bradnelson@google.com,ncbray@chromium.org,mseaborn@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Review URL: https://codereview.chromium.org/379663002

Reverting this causes new failure. Hence reverting the revert.

TBR=samuong@chromium.org

Review URL: https://codereview.chromium.org/379153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282009 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 281831 "Fix nacl_integration to run 32bit tests with 32bi..."
> 
> > Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel.
> > 
> > detect_host_arch.py already knows how to figure this out, so reuse it.
> > (It could probably be used in the darwin and maybe even in the windows
> > branch too.)
> > 
> > BUG=368384
> > TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green
> > TBR=mseaborn@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/373253002
> 
> Suspect this is causing the failure http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/13394
> 
> TBR=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/374383002

Reverting the revert since it doesn't seem to cause the problem

TBR=kaliamoorthi@chromium.org

Review URL: https://codereview.chromium.org/378283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282008 0039d316-1c4b-4281-b951-d872f2087c98

This test relies on data extracted from the Chrome DevTools (Blink-side)
frontend JavaScript code in a controversial manner

BUG=392430
TBR=stgao@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/379833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282007 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs '.active' and you will be able to access
an active worker via 'navigator.serviceWorker.active'.


BUG=379012
TEST=content_unittest --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html
TEST=run_webkit_tests.py  http/tests/serviceworker/active.html (http://crrev.com/373013002)

Review URL: https://codereview.chromium.org/354643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282006 0039d316-1c4b-4281-b951-d872f2087c98

The TableList specifies the overflow property depending on its height. If it
specifies 'hidden', the list cannot be scrolled even if the Files.app specific
scroll bar is visible.

BUG=391698
TEST=manually

Review URL: https://codereview.chromium.org/376123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282005 0039d316-1c4b-4281-b951-d872f2087c98

What this patch does:

 -- plumbs in GinJavaBridge... instead of JavaBridge... classes on
    browser and renderer sides;

 -- fixes the issue with adding JavaScript interfaces to popup windows
    created via WebChromeClient.onCreatePopup;

 -- updates JavaBridge tests to match the behaviour of the new
    implementation.

BUG=355644

Review URL: https://codereview.chromium.org/353163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282004 0039d316-1c4b-4281-b951-d872f2087c98

- move all the generic permission settings from gcm to content_settings
- delete the midi implementation in favour of this one.

Some important changes in midi.

Clicking Yes/No on Bubbles did not save the permission for future uses,
while when using infobars it was saved. Now it is saved in both cases

The existing midi implementation had some renderer crashes that have now
been fixed. It also had a browser race when tring to run the result
callback. Both issues are fixed in this implementation.

The midi cancel closure is not implemented, it does not seem to be used
anywhere and the paradigm was a bit convoluted
(passing it as an out pointer in RequestMidiSysExPermission)

The old midi infobar used to say Allow/Deny but the bubble said Allow/Block,
now it says Allow/Block in both cases.

BUG=392145

Review URL: https://codereview.chromium.org/365123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282003 0039d316-1c4b-4281-b951-d872f2087c98

Expose SyncProcessRunner's constants to use it in the test code.

BUG=344769

Review URL: https://codereview.chromium.org/375123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282002 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/372843006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282001 0039d316-1c4b-4281-b951-d872f2087c98

Previously, DevToolsWindow relied on DevToolsClientHost life time,
which is error prone and introduced quite a few bugs.

BUG=392180

Review URL: https://codereview.chromium.org/371363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282000 0039d316-1c4b-4281-b951-d872f2087c98

> Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel.
> 
> detect_host_arch.py already knows how to figure this out, so reuse it.
> (It could probably be used in the darwin and maybe even in the windows
> branch too.)
> 
> BUG=368384
> TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green
> TBR=mseaborn@chromium.org
> 
> Review URL: https://codereview.chromium.org/373253002

Suspect this is causing the failure http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/13394

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/374383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/375273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=279351

Review URL: https://codereview.chromium.org/364883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281997 0039d316-1c4b-4281-b951-d872f2087c98