- 10 Sep, 2019 40 commits
-
-
rbpotter authored
- Add test for ignore comments for js_modulizer script - Fix bug in the script, where an ignore starting at the very beginning of the line did not get removed - Remove dummy importHtml and instead use the new ignore comments to remove these calls in tests. Bug: 965770 Change-Id: I6f63861bef6e93ae918d54273f905c0cc372dbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793743Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695381}
-
Evan Stade authored
Instead use OnProfileAdded Bug: 268984 Change-Id: I733936856f025703272724349de3447aa5313dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793930Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#695380}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /device/bluetooth/bluez. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mcchou@chromium.org Bug: 891670 Change-Id: I7aaa1219ecbb2e87d39d7a0920f822a749d4d9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787102 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#695379}
-
siyua authored
So when fetching authentication challenge fails, update the pending WebAuthn offer dialog to the error state and show new contents. Mock: https://docs.google.com/presentation/d/16gfVy4EJ0hPibnOWZ8pqMF09Uy6uCWW2mCd1et9ILDw/edit?ts=5d670e48#slide=id.g33e66b3a17_12_0 Uploaded implementation screenshot in bug comment 11 1) Added function in CCFA to update dialog if error-ed. 2) Added more DialogState enum in model. 3) Changed the way how MVC works. Previously the controller talked to view directly. Now the controller updates model, and view, as an observer, observing any state change and updates itself. Bug: 991037 Change-Id: Ia5159d64f411d51bdcab6d3d1b72638fe014de40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785627Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#695378}
-
Tommy Steimel authored
This CL makes |MediaToolbarButtonController::Session| a |WebContentsObserver| so that we get notified when a tab is closed. This allows us to immediately remove a notification and hide the toolbar icon when a tab is closed instead of freezing it. Bug: 994509 Change-Id: I751e3c8a8c0cc696984a9581b7f9dbfe39ed69e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793235Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695377}
-
Dana Fried authored
Missed this in the last CL; see: https://chromium-review.googlesource.com/c/chromium/src/+/1793544 Change-Id: I71563a1892af642d13786cf35cb267e107dc1748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796751 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#695376}
-
Min Qin authored
When strong validators are not present, we don't resume download if CONTENT_LENGTH_MISMATCH error happens. However, according to UMA, more than 99% of the cases more data will be received after a CONTENT_LENGTH_MISMATCH error if strong validators are present. And since we are launching the feature to allow download resumption without strong validators, many of these interrupted downloads can now resume. BUG=1002591 Change-Id: I75facafef994e6c4637e52b340dddc05fca94833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795761Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695375}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53a5a5042e54..dbca865e55f7 git log 53a5a5042e54..dbca865e55f7 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 ehmaldonado@chromium.org depot_tools: Bootstrap Python 3 on Linux/Mac 2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@dbca865e55f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: Ieeacbbcdf91d0f20ccddfe592c41418a94b7f905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695374}
-
Changwan Ryu authored
This reduces complexity of the code in preparation for the multi-window support. Bug: 994939 Change-Id: I9fbb0658135b0b26c40644607d09baa1b56309b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796889Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695373}
-
Eric Karl authored
The impl tree viewport changes caused by |top_controls_shown_ratio_| changes are not reflected on the main thread when the top controls are partially shown. This causes a mismatch each time we push property trees from main > impl. This change provides a temporary fix by updating the viewport any time we push main > impl when in a partially shown state. Long term we should propagate these changes to the main tree and avoid this workaround. Bug: 875943 Change-Id: I47e6a5127e6a2c76b5286e257904d2501e3859a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795572 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695372}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ios/net/cookies. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mrefaat@chromium.org Bug: 891670 Change-Id: I860cd4deb1e73ac378a2fa8fc21ebee528a69a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787214 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#695371}
-
Yue Zhang authored
TabGridSheetToolbarCoordinator, TabGridSheetViewBinder and TabGridSheetProperties are shared by TabGridDialog and TabGridSheet. This CL renames shared components as TabGridPanel*. Bug: 987669 Change-Id: I542963909c55c96f5c2a44fbd88dd0c367aeaae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790647Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695370}
-
James Cook authored
When SplitSettings is enabled (the default) the browser Appearance section opens in a tab. In this case, use the "external" link out icon. https://screenshot.googleplex.com/47LQzbfZeTx If SplitSettings is disabled, keep the normal in-page link icon. Bug: 999354 Change-Id: I7f70ac3a18c4a92b7d24a5b0be926488ec0010b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796784 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
James Cook authored
One of my recent CLs added an include of the "settings-shared" CSS styles to basic_page.html: https://chromium-review.googlesource.com/c/chromium/src/+/1783060 This added CSS rules for <h2> that matched the "Advanced" toggle button container and added unwanted padding and text color. Fix by explicitly setting the padding and color to the correct values. See bug for screenshots pre-regression, post-regression, and with this fix. Bug: 1002422 Change-Id: Ia25ef9b5f4183633f1a1cdd1a15e8a741e7a7513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795498Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#695368}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/548a26302ef5..881c56bc0687 git log 548a26302ef5..881c56bc0687 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 thestig@chromium.org Roll third_party/icu/ 682a23092..53f6b233a (6 commits) 2019-09-10 thestig@chromium.org Roll third_party/freetype/src/ 543a3b939..3de1b8d0b (5 commits) 2019-09-10 thestig@chromium.org Roll base/trace_event/common/ cfe8887fa..5e4fce17a (3 commits) 2019-09-10 thestig@chromium.org Roll third_party/libjpeg_turbo/ 81aef9014..baa5dc242 (6 commits) 2019-09-10 thestig@chromium.org Roll third_party/zlib/ 2b4888a46..8c79b6c8d (10 commits) 2019-09-10 thestig@chromium.org Roll third_party/android_ndk/ 4e2cea441..099a70aef (1 commit) 2019-09-10 awscreen@chromium.org Remove leading space in .gitattributes Created with: gclient setdep -r src/third_party/pdfium@881c56bc0687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iddb32291ac356bcf50e5cf7fe17b81cf755ed397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795996Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e47094cfbc5..2f637a9deab9 Created with: gclient setdep -r src-internal@2f637a9deab9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:1002650 Change-Id: Id393a02403575b0cb0277a1b24b9a0a2a4ec8c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795320Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695366}
-
Tarun Bansal authored
This reverts commit 62e19745. Reason for revert: Suspicious CL for build errors on chromium.linux/Deterministic Fuchsia (dbg). See https://bugs.chromium.org/p/chromium/issues/detail?id=1002719 Original change's description: > [fuchsia] Implement fuchsia.web.Frame/SetUrlRequestRewriteRules. > > * Implement the fuchsia.web.Frame/SetUrlRequestRewriteRules API. > * Add a mojo interface to provide the renderers with new rules. > * This interface is implemented in the browser in > UrlRequestRewriteRulesManager, which also takes care of validating > and converting the rules from FIDL to Mojo, and providing them to > the WebEngineURLLoaderThrottles in the browser. > * In the renderer, there is one rules receiver per RenderFrame, > implemented in UrlRequestRulesReceiver. They cache the rules and > provide them to the WebEngineURLLoaderThrottles in the renderer. > * Add unit tests and browser tests for the new API. > > Bug: 976975 > Change-Id: I446ea4838d50e65c568e7e2cbcd32c23d64af426 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659677 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695298} TBR=dcheng@chromium.org,wez@chromium.org,rockot@google.com,kmarshall@chromium.org,sergeyu@chromium.org,fdegans@chromium.org Change-Id: I606924bbcd98df82f2e9a8bb4e37dea8055a8571 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797127Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695365}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1cf2cc2..75ba649d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibd6e97ec57772ca3daa0fd709f39b436c820d524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795673Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695364}
-
Meilin Wang authored
A new |RUNNING| state was put into use to indicate the assistant service enabled with UI shown on the screen, while the old |NOT_READY| state is now narrowed down to only represent assistant service runnning without UI showed up. This rule change caused the tests running with UI already shown on screen to fail because we only checked for |NOT_READY| state before. This change fixed the test failure by adapting to the new rule and checking for |RUNNING| state as well. BUG=None. TEST=tast -verbose run DUT_ip ui.AlssistantSimpleQueries ui.AssistantTimeQuery ui.AssistantVolumeQueries Change-Id: I75427b64604217b1dc6a76ec9585b416e491bcbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777107 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#695363}
-
Roger Tawa authored
Bug: 1002517 Change-Id: Ie68223675f5802619ae3c317e0e06fbd8bb4ac9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796043 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#695362}
-
Steven Bennetts authored
Bug: 853953 Change-Id: Iaeebe3b1040379e9488ce9e9855ac194b215e7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796312Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695361}
-
Mehran Mahmoudi authored
This is the first step in a series of CLs for moving the AddToHomescreen component to MVC in Android. This CL renames AddToHomescreenDialog to AddToHomescreenView. It also moves AddToHomescreenView and AddToHomescreenManager to the newly created addtohomescreen folder. Next step CL: crrev.com/c/1793633 Design doc: http://go/a2hs-mvc NOPRESUBMIT=true Bug: 994759 Change-Id: I79e7456328301796dc43da440d6025aaa93235ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795992Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695360}
-
Justin DeWitt authored
This is the next step in unlaunching server suggested tiles on mobile. Note that this launch is approved in crbug.com/920756 Bug: 1002131 Change-Id: Ic0ae10cacd3877bc823b7095b9126e6f3c6aaf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791801 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695359}
-
Adrienne Walker authored
This parallels Storage.Blob.FileReaderLoader.FailureType, but for blobs loaded by url instead. Bug: 1001677 Change-Id: I9fd5a75d71fe03b80acacd55fd82b6569df9c985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788457Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#695358}
-
Mei Liang authored
This CL updates the DragToMerge IPH item to use the dark mode color palette in incognito GTS. Change-Id: Ic7daf73870238385a3a4dde9a1e2da6e36a2e761 Bug: 997879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772062Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Tarun Bansal authored
This reverts commit d3864a14. Reason for revert: Breaks content_unittests and snapshot_unittests See https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/83015 and crbug.com/1002716 Original change's description: > [base] Reduce TaskEnvironment default Run() timeout. > > Reduce the default Run() timeout set by TaskEnvironment from > TestTimeouts::action_max_timeout() to action_timeout(). This typically > reduces the timeout from 30s (45s in Debug) down to 10s. > > Sheriffs! This may result in: > - Failures on slow builds, which are not on CQ. Please consider adding > an #ifdef to restore those builds to action_max_timeout(), rather > than simply reverting. > - Flakiness in tests which are too close to the new timeout. Please > consider whether such tests should really be taking so long, and > whether they can be fixed-forward with a ScopedRunTimeoutForTest > rather than reverting (see ThroughputAnalyzerTest in this CL). > > Bug: 922098 > Change-Id: Icd75af79f6d9d3555c91b33ea2566fe7c56cd2f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548382 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695252} TBR=wez@chromium.org,gab@chromium.org,morlovich@chromium.org Change-Id: Ibc71ddd4780bdeb9afd0d3f5f24fb61fec7637d7 No-Tree-Checks: true Bug: 922098, 1002716 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796528 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Joey Arhar authored
This adds icons to the set-cookie headers in the request headers view to show when a cookie was not stored successfully. Screenshots: https://imgur.com/a/1SLbEmI Bug: 856777 Change-Id: Iec08ddc39999407608d1bb0c8d3511a286b47e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795310 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#695355}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f60522f5a467..619935f7f249 git log f60522f5a467..619935f7f249 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@619935f7f249 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I240ac6bd3c6a3dd909eabad493118bdeb6f03b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795314Reviewed-by:
-
Jazz Xu authored
Restrict PiP window aspect ratio when updating PiP window size. Bug: 1000999 Change-Id: I4a729d30cd93195cbd493a14dbdedda9536e4ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788232 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
-
Hesen Zhang authored
- Return early if icon store input is empty. Avoid calls to protodb. Bug: 963290 Change-Id: Ic037a5853c81afdfc74c95126f86f961f6adbd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793751Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1002686 Change-Id: I4b4da5a83454ebe8cc2924466eac83e1ba80bd24 Tbr: caseq@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795897Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695351}
-
Umesh Patil authored
Bug: b/139671272, b/139691389, b/139693028 Change-Id: Ice36b283cbca06ab7f005b0f6c058716985c8233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796267Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Umesh Patil <upatil@google.com> Cr-Commit-Position: refs/heads/master@{#695350}
-
Ryan Hansberry authored
Only display and activate the HID detection screen for form factors without built in input: Chromebases, Chromebits, and Chromeboxes. Bug: 965765 Change-Id: I9a5b8ac882e8fba74bef1c4d29e2c23dd563213b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758837 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#695349}
-
Theresa Wellington authored
And clean up a bunch of old code from "ntp button" (aka clear tab) experiment. Some homepage MV tile code is still left and will be handled separately in crbug.com/1001542 BUG=971877 Change-Id: Ib111079c015e44ba9ad6eea6766b6780ee0da8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789985Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#695348}
-
Shakti Sahu authored
This CL provides an ephemeral tab implementation using bottom sheet and thin webview. The toolbar UI will be added in a next CL. Bug: 998826 Change-Id: Ic62eaa551ffc2e45fbe5daa1a484685674409152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774977Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695347}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/467073a0c18f..52f7ae7c8988 git log 467073a0c18f..52f7ae7c8988 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 perkj@webrtc.org Make NetworkStateEstimator injectable in RemoteBitrateEstimator Created with: gclient setdep -r src/third_party/webrtc@52f7ae7c8988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ife95fd3daecc0ae70c6e2a9faf1a1d3de96aee9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796882Reviewed-by:
-
rbpotter authored
- Autogenerate Polymer 3 version of cr-link-row and tests - Add to demo page Bug: 965770 Change-Id: Ie375a47e04063909db61c360ced871f521f61985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789977Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695345}
-
Yue Zhang authored
Right now, when the font size is set to largest in Accessibility setting, the dialog content of the drag-and-drop IPH gets a little clipped. This CL fixes this issue. Bug: 1001147 Change-Id: I0d3c8fd30deba85a4cfc87d96a056bb901bc1848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788501Reviewed-by:
-
Evan Stade authored
Uses BubbleDialogDelegateView::set_accept_events and removes BubbleFrameView::set_hit_test_transparent See related https://crbug.com/978985 Change-Id: I659e208f886aea331f18317ada532e0bef7797e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678949Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#695343}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e63cab2e8fb..c0c05047c21b git log 8e63cab2e8fb..c0c05047c21b --date=short --no-merges --format='%ad %ae %s' 2019-09-10 senorblanco@chromium.org Dawn: implement Sampler cache (optimization). 2019-09-10 jvanverth@google.com Wrap MTLEvent code in availability attributes. Created with: gclient setdep -r src/third_party/skia@c0c05047c21b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Id99428929c8b74714c03efe58363a54a7a7c90b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796752Reviewed-by:
-
