- 24 Sep, 2019 40 commits
-
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: I296c93d354cc4b49c5bcdc416cd495b352aa0617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817601 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699388}
-
Sigurdur Asgeirsson authored
Bug: 1003391 Change-Id: Ibdc72029f647eff989bebb9b6542cffb8273064a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815847Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699387}
-
Sam Maier authored
This allows other users of Chromium's zlib library who don't depend on //base (for example, V8), to reuse some boilerplate code. Bug: 833361 Change-Id: Ifc9023fdb9915e0452d424b030e8a8e5ae1c0df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819838Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#699386}
-
Kaan Alsan authored
virtual/threaded/external/wpt/css/css-scroll-snap/scroll-margin.html was failing because the expected output file for Win7 was not deleted. Bug: 964239 Change-Id: Ie49db2682d1e0148e60a03bea8f752165d2b1d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821824 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#699385}
-
Roman Sorokin authored
Also removed learn-more node handling from the public session pods. Filed crbug.com/1007193 to get rid of public account pods. Also Added restart at the end of enrollment if device policy has public accounts. This should fix most of the cases. One rare case when WebUI public accounts will be shown: After enterprise enrollment (w/o public accounts) device policy changes to have public accounts. This should trigger public session pods on the WebUI login screen. Bug: 1000990, 943720 Change-Id: Ib9672821ef8fec303fc83c3d5f57952fb7f90c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820800 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#699384}
-
Chandani Shrestha authored
This change addresses all accessiblity issues listed by AXE accessiblity tool: a. <html> element must have a lang attribute b. Document must have one main landmark c. Page must contain a level-one heading d. All page content must be contained by a landmarks e. Page must have a means to bypass repeated blocks Verified screen reader reads content on the page. a. Screen reader was working as expected when accessing links. This was already working. b. Added a role heading with level 1 value for header of the links to inspectables pages. Verified keyboard accessibility: Scenario 1: Launch browser without custom flag e.g. chrome.exe --remote-debugging-port=9222 http://localhost:9222 If the url of page doesn't contain '#custom=true' flag e.g. http://localhost:9222 User can navigate to any inspectable page link using Tab and pressing Enter opens the link This was already working as expected before this change. https://imgur.com/7zZ9BIn Scenario 2: Launch remote debugging using npm run start If the url of page has '#custom=true' flag e.g. http://localhost:9222/#custom=true&experiments=true This change adds tabIndex=0 to element which holds of the remote-url. Pressing Enter or Space copies the url value. https://imgur.com/aWShNVk Gif: Showing keyboard accessibility in remote debugging page where it has a #custom flag in url e.g. http://localhost:9222/#custom=true&experiments=true which is a default url opened up by 'npm run start' in devtools https://imgur.com/l2j75TD Bug: 963183 Change-Id: Ifc3dfc288591fd198c1e9e99d4828d0ebd933894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788287Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699383}
-
Arthur Hemery authored
A few other payment API tests are failing with BFCache on, adding to the list. BUG=1006256 Change-Id: I0d183349311457b2f93cefcd6560a51d5e1f5bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821600Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699382}
-
Fernando Serboncini authored
This class was wrongfully attached to all WorkerGlobalScope. This fixes it and aligns us to the spec. Bug: 1003442 Change-Id: I829620997d0149da36d036eaba40c569f899991b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807576Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699381}
-
Lei Zhang authored
Incorrect base::NoDestructor usage generated 11 static initializers. As is, the static globals have to be initialized when the program begins. Move the declarations so they become static local constants that are instead initialized on first use. Also fix lint errors and use constexpr in more spots. Bug: 537099 Change-Id: I604e1a5828646b17340ce0986a2653fc75ba8dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819656Reviewed-by:
A Olsen <olsen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699380}
-
Lei Zhang authored
Incorrect base::NoDestructor usage generated 6 static initializers. As is, the static global has to be initialized when the program begins. Move the declaration so it becomes a static local constant that is instead initialized on first use. Bug: 537099 Change-Id: Ieb64c7ba476331cd22ae2fb98960301166200d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820262Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699379}
-
Alex Khouderchah authored
CL:1591595 removed kStateDisconnect usage/support from NetworkState because Shill had not been using that Service state for years. $bug led to the conclusion that Shill should have a disconnecting state so that the potentially non-negligible time between beginning a disconnection and completing the disconnection will be clear (both internally to Shill and for Shill D-Bus clients), rather than having the Service Disconnect D-Bus method block until completion. This CL is done in preparation of re-introducing the disconnect state to Shill, such that future Shill CLs will cause Chrome to trigger DCHECKs. Note that many of the changes in CL:1591595 are necessary in order to avoid a future scenario where different usages of the kStateDisconnect state (received from Shill vs Chrome-internal usages) have different semantics. Bug: 989361 Change-Id: I3d2ef136d531a39d5e1f89da77321d1866ac28aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819630 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699378}
-
Eugene But authored
Previously Stability.iOS.UTE.HasPossibleExplanation would always be true if OSRestartedAfterPreviousSession is true. But according to M78 UMA OSRestartedAfterPreviousSession is true in more than 50% of UTEs, which suggests that most restarts don't actually cause UTE. Relax the logic to take into account OSRestartedAfterPreviousSession only if battery level at 1%. Also remove deviceWasInLowPowerMode from logging condition as it seem irrelevant. Bug: 1006928 Change-Id: I583f0aaeff842ea058a54315dd27d79537242296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819884Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699377}
-
Mark Mentovai authored
When installing from .dmg, the relauncher process is hosted by the helper app in the the newly installed copy. Since it's invoked by the original browser .app running from the .dmg, the path service can't be used to obtain the path. When the bundle layout changed (bug 958976), the path built for the relauncher process executable by the install-from-.dmg wasn't updated. Bug: 1004398 Change-Id: I54da7688c162349efa2db78022b3dffc378f2828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822158Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699376}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ifa6933d2b5e85e4a03f59c0a82ec465c881bf194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820320 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699375}
-
Rouslan Solomakhin authored
Before this patch, skip-the-sheet flow on Android would attempt to animate out the browser sheet when showing transaction errors, even though the sheet was not shown. This patch checks for presence of the sheet before animating it. After this patch, the browser checks for existence of the sheet before animating it out. Bug: 952283 Change-Id: I7e7179edce53f10d8d156159192a31e2cc2d5795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818223 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699374}
-
Fredrik Söderquist authored
Per SMIL[1], all the values in a key spline should be within [0, 1], but to be consistent with CSS' timing function, allow y-values to be outside that range (at least for now). While in ParseKeySplinesInternal(...), rename the |pos_*| local variables to something that carries a little bit more semantic meaning. [1] https://www.w3.org/TR/SMIL3/smil-animation.html#adef-keySplines Bug: 1006544 Change-Id: I6baa4085943eca8144605fb0a5c442bc8486ad87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821158Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#699373}
-
George Steel authored
https://github.com/w3c/csswg-drafts/pull/4306 Change-Id: Icb7d01affc85d997e9a3e06f09bae77b4cd915a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807297Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Auto-Submit: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699372}
-
Peter Kasting authored
Bug: 82078 Change-Id: I84094d348d5f012968d4f4db0b0d2ea88f969e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820537 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#699371}
-
Mandy Chen authored
The backend changes[1] for localizing devtools leverage the existing webui functionalities, which consume a list of id mappings from the id of a string used in the frontend (i.e. the English string) to the IDS_ key of the string in the corresponding grdp file. Example: const LocalizedString kLocalizedStrings[] = { ... {"Editable", IDS_DEVTOOLS_2c09e798bf8c5a82d211331c82893a0f}, ... } This patch adds scripts that generate the structure. The output will be two files, devtools_ui_strings_map.h and .cc, under <generated files root directory>/chrome/browser/ui/webui (e.g. D:/chromium/src/out/Release/gen/chrome/browser/ui/webui). The design is to create a build step that calls generate_devtools_ui_strings.py, which then calls generate_devtools_ui_strings.js. Integration into the build system will come as a another patch, because it depends on the first set of changes[2]. Example arguments to generate_devtools_ui_strings.js to generate output files (invoke under '--root_gen_dir', e.g. D:/chromium/src/out/release/gen in the example below): ['D:/chromium/src/third_party/node/win/node.exe', 'D:/chromium/src/third_party/blink/renderer/devtools/scripts/build/generate_devtools_ui_strings.js', '--root_gen_dir', 'D:/chromium/src/out/release/gen', '--output_header', 'chrome/browser/ui/webui/devtools_ui_strings_map.h', '--output_cc', 'chrome/browser/ui/webui/devtools_ui_strings_map.cc'] [1]: https://crrev.com/c/1672628 [2]: https://crrev.com/c/1628927 Bug: 941561 Change-Id: Ic03dae24cd074219790c6eec5df3183c24bf15a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671848Reviewed-by: -
Peter Kasting authored
Bug: 82078 Change-Id: Iaa5d62ebb39e94c7a83b627c4ae75534e7b7223f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820016 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699369}
-
Abigail Klein authored
Bug: 959368, 785493 Change-Id: I291305ac9f12eba161e369e71e46e0bee1c537a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816804 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699368}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3c049a34714d..01f7e545a37e git log 3c049a34714d..01f7e545a37e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 jmadill@chromium.org Vulkan: Make SharedResourceUse a custom type. Created with: gclient setdep -r src/third_party/angle@01f7e545a37e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: If77976bfde79481aee3227d1c9e3940a3b6218ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699367}
-
Friedrich Horschig authored
This CL adds the grd file for touch to fill strings to the translation expectations which should unblock starting the pipeline. Bug: 1006869 Change-Id: I28888d550aab6cad5d6c880387d0e6de75d3ee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820797Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699366}
-
Rune Lillesveen authored
Bug: 1004647 Change-Id: Ic78a40f06ba80aa90a62a85641ecb6468ac2abb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821080 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#699365}
-
Roman Sorokin authored
Bug: 922689 Change-Id: I44e7b3df06cbd522076a65caeee288fd494afb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820577Reviewed-by:
-
Moja Hsu authored
From this CL:1643677, R8 as texture source was removed. We need to remove it in the chrome side too. Bug: b:141328294 Test: CCA works on kukui. Change-Id: I6ea25754f5217d53f82dc019cf6a9134e719c4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816005Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699363}
-
Khushal authored
R=ericrk@chromium.org Bug: 1006001 Change-Id: Ia661fe3672d93e2267af326451f0754cfcf1d9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814502Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699362}
-
Carlos Caballero authored
MessageLoop is going away soon and with it message_loop.h. A lot of files depend on headers included by message_loop.h. This patch changes all those to directly include what they need. Bug: 891670 Change-Id: Iaf68a62b015a57cb9bada0bc96e5c76bba43c36b Mechanical change per TBR=gab@chromium.org https: //chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes Change-Id: Iaf68a62b015a57cb9bada0bc96e5c76bba43c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819303 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699361}
-
Leon Scroggins III authored
Bug: skia:8046 This is currently a dummy file, but will contain the method SkParseEncodedOrigin, which is used by both SkJpegCodec and SkWebpCodec. Currently the method lives in SkJpegCodec.cpp, so you cannot build SkWebpCodec without SkJpegCodec. Change-Id: I6d0d22b5076a84a0931ff0e0cb92fc5ce0631f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821979 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#699360}
-
Roman Sorokin authored
In case OOBE is already in the test mode Bug: 989333 Change-Id: I86e7c9ceef1c33370df740b303012e5ce25e1b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821781Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f6fe231. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox drott@chromium.org: external/wpt/css/css-text-decor eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/IndexedDB external/wpt/resources meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-ui external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2f3a455c0ed5855201df787d78311f2462741f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821549Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699358}
-
Dan Beam authored
* Remove basically duplicate (X) icon * Make this dialog look/work(?) better in RTL * Make the (X) look better in dark mode * Make tab order more intuitive Screenshots: * screen/xyCOXTEUxeX * screen/7ij36gXapJG * screen/o1qc5HRYT53 * screen/gAThdeM3i07 R=kmilka@chromium.org BUG=none Change-Id: Ia1c3783c9215015c2e63ca3f0e20fb8da26d4105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818608 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#699357}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ff9cca70ed5..a4f7741ee65c Created with: gclient setdep -r src-internal@a4f7741ee65c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0011757b32938a9161df8b46d0445f5dba276c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821998Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699356}
-
Vladimir Levin authored
This patch ensures that we skip child layout when doing LayoutGrid block layout. R=chrishtr@chromium.org, rego@igalia.com Bug: 1006250 Change-Id: Ib44ec18b9733b708278dbe49d4481bb2de91b51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819633Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL moves call to |ScheduleOverlayPlane| just after |FinishPaintCurrentFrame| which was deferred till SwapBuffers in https://crrev.com/c/1787356 Bug: 1006758 Change-Id: Ic2307bba3da5530b1ca3d36d0ff0e1439fe42fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819557Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#699354}
-
Guido Urdaneta authored
Always expect success in getDisplayMedia with the fake UI. Bug: 1002984 Change-Id: If576d6cc26fff459732a5740a48c525fcbad8aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821719 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#699353}
-
Zhongyi Shi authored
Note this change also removes server migration configuration path on desktop. This feature has been minimally tested on a local machine, see more metials in the associated bug. Bug: 999285 Change-Id: Iffb2fc6c1b02bedaf91491a2f1831d3a43ca6cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820042 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699352}
-
Dominic Farolino authored
This CL adds more web-platform-tests for the `Referer` on worklet descendant requests. This CL introduces tests where we fetch a same-origin descendant script from a cross-origin worklet script served with varying referrer policies. The tests are similar to those introduced in crrev.com/c/1809205 for module scripts, and will pass once crrev.com/c/1808663 is merged. R=ikilpatrick@chromium.org, kouhei@chromium.org Bug: 786862,1004083 Change-Id: I4425be4264424b52e4ec307513a404541869f2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813122Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#699351}
-
Al Muthanna Athamina authored
This commit migrates the dom-extension test from a layout test to a Karma test. It also splits up the test in three separate cases for readability purposes. Note that this does not currently run on Chromium infrastructure yet. That will be fixed in a follow-up CL. Change-Id: Ib10e81bb30094dbf2c18ed73a57e894c8de3a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821517Reviewed-by:
-
David Van Cleve authored
This CL adds a new feature, kNoReferrers, to subsume the functionality of the --no-referrers switch. When the feature is *true*, the kEnableReferrers pref will have its default value set to *false*. This is the current effect of setting the --no-referrers switch. A separate CL, crrev.com/c/1808144, is in progress to remove the switch itself. This is one of a series of changes adding functionality to run a Finch experiment exploring different levels of referrer policy and caps. R=creis, mmenke depending on the value of the feature. Test: Added browser test to confirm that the pref is set correctly Bug: 1004486 Change-Id: If250cf4f29523328e540aa23672436071fbbb10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806080 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699349}
-
