- 13 Feb, 2020 40 commits
-
-
btolsch authored
Change-Id: I0ffe49f994a3f2094f36544028854b3dcd1e8634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038174 Auto-Submit: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#740998}
-
Henrik Boström authored
This reverts commit a4cdec69. Reason for revert: Speculatively reverting: FullscreenControllerTests are failing after this CL on Linux ASAN (e.g. [1] and [2]) and this CL is changing fullscreen related stuff. [1] https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36919 [2] https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36920 Original change's description: > Fix orientation change test full-screen-orientation-change.html > > There are two ways to trigger fullscreen, either by user activation or by > a user generated orientation change. When we enter the fullscreen mode, > we should not consume the user activation in the browser side when the > fullscreen is triggered by a user generated orientation change, so we > need to set the orientation change flag in the browser side when we are > calling the mock function setMockScreenOrientation through a mojo > message. > > The CL that consumes the user activation on both the browser and > renderer sides when entering fullscreen: > https://chromium-review.googlesource.com/c/chromium/src/+/1903675 > > > Bug: 1046933 > Change-Id: I1eb86205bc82ac237bc12d63bbdb0c8985c06090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026170 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740812} TBR=kenrb@chromium.org,alexmos@chromium.org,lanwei@chromium.org Change-Id: I76212e8f7633537774323776091f16795bc6d46c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054184Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740997}
-
Naoki Fukino authored
Filling the missing comment on the new parameter. This also makes the paramater camelCase to be consistent. Bug: 1040049 Test: Run existing tests Change-Id: Icc3907675d57bb87bd55dfffe02d3e76d6460ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053906Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740996}
-
Colin Blundell authored
This CL moves the special-casing of the legacy Symantec error to have a special support URL from ChromeSecurityBlockingPageFactory to be internalized within the //components-level SSLErrorHandler. The motivation and behavioral impact is two-fold: 1. The support URL should actually *not* be overridden for dynamic interstitials, which have their own custom support URL. By moving this overriding into SSLErrorHandler::ShowSSLInterstitial() this desired behavior is now obtained, as the showing of dynamic interstitials does not go through that code path. 2. Any consumer of SSLErrorHandler should inherit this functionality rather than it being localized in //chrome. Notably, WebLayer will now get this functionality. Bug: 1030692 Change-Id: I5415f90809a88984fa5551490e3ff34d21f92cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044100Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#740995}
-
Eriko Kurimoto authored
This CL adds names to each shared workers in shared-worker-options-type.html. to make the test work correctly. Without this change, 'module' shared workers tests don't actually run. This test would fail without this change when #5258 is implemented: https://github.com/whatwg/html/pull/5258 Bug: 1051779 Change-Id: I7b5ea901b07cfb9f5b73e8948e1e7757ab7c5c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050051 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#740994}
-
Yutaka Hirano authored
In order to deprecate Platform::CreateDefaultURLLoaderFactory, this change removes its call from SVGImageLocalFrameClient. Only data: URL loading needs to be supported by SVGClient, so the WebURLLoaderFactoy doesn't need to load anything at all. Define FailingLoader which fails every request, and returns a factory which creates FailingLoaders. This is based on lukasza@'s work: https://crrev.com/c/1372559 Bug: 1049618 Change-Id: I70beb55830501e5a05b9ae8b604c3f56a0f90601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043259Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#740993}
-
Eriko Kurimoto authored
This CL fixes addressspace-sharedworker-basic.html by giving unique names for each shared workers. Bug: 1051412, 1051779 Change-Id: I7442198738dda6615a6da5d344e9ea9c653790d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050416Reviewed-by:
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so the goal is to delete the Blink-specific histogram helpers and standardize on //base. Bug: 1047547 Change-Id: I6a796dde4437d58b67875edc9b535b761394b509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053966 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740991}
-
matterchen authored
As part of the port forwarding work, when user's interact with the UI the profile preferences for port forwarding should be updated. This CL includes the changes to update the preferences when a user activates or deactivates an existing port as well as unit tests to support. Bug: 848127 Test: crostini_port_forwarder_unittest.cc Change-Id: I42e563056dccd486929f76e757e87429ee8b4847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049149 Commit-Queue: Matthew Chen <matterchen@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#740990}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - use the standardized count helpers where possible instead of using custom counts Bug: 1047547 Change-Id: I4dfd32d321c6afa900fec5506d85c7a94cbfa682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043945 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
After PlatformEvent migration CL has landed (crrev.com/c/2022280), building ui::Events out of XEvents has been moved exclusively to x11_event_translation.{h,cc} helper code. With this change the bogus timestamp correction has been mistakenly lost. This CL restores it as well as adds a unit test to prevent future similar regressions. R=sadrul@chromium.org Bug: 965991 Test: events_unittests --gtest_filter=XEventTranslationTest.BogusTimestampCorrection Change-Id: I238d7dba7586be0dd7cf70475c0705b2303ca225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040563 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#740988}
-
Isabella Scalzi authored
Change Quick View test |openQuickViewDeleteEntireCheckSelection| to check that the next file to be shown in Quick View has loaded in its <webview> before attempting to delete it. This will hopefully fix the "Cannot read property 'contentWindow' of null" error that was seen when running this test on RELEASE bot. Bug: 803259 Change-Id: I950d37f5df045e0f9058e22b26b9a6abe8b7a8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053224 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740987}
-
Julien Isorce authored
There is currently a GetSurface() api but it only gives access to the plane 0. This new api GetPlaneSurface allows to get access to any planes to support YUV formats. Bug: 1043007 Test: ./out/ozone_build/ozone_unittests Change-Id: I4116affcf168cdaeebf3b405234aa3e5f55cc30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032060Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#740986}
-
Yoshisato Yanagisawa authored
Since Chromium officially stopped MSVC support, we do not need to keep these builders any more. Bug: b/78251210 Change-Id: I7d80c1f8c1b107db5b6791603fe750a5f1a71a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053652 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#740985}
-
Henrique Ferreiro authored
//ui/base/cursor/cursor.h has an unused //ui/base/cursor/cursor_size.h include. Bug: 1040499 Change-Id: I26ee59be9b67b2ea07da5efac4aa6b0f6923cc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983168Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#740984}
-
Alexey Baskakov authored
Disable it on Win ASAN only. TBR=groby@chromium.org Bug: 1051777 Change-Id: I950c3301391d3c34c611eb40f768a5aae9f4c1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053265Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#740983}
-
Yuki Shiino authored
Only minor changes. Bug: 839389 Change-Id: Iee8ff27ff2ee0b9066950b36429c5839b4880dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053903Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740982}
-
Kenichi Ishibashi authored
Once ServiceWorkerStorage is moved to the Storage Service, NewVersionId() will become an async operation. This CL is a preparation for the move. ServiceWorkerRegistry::CreateNewVersion() becomes async as well because it depends on NewVersionId(). Bug: 1046335 Change-Id: I223fddffa2a83e2e0f5fdac3335cc937b3bbdbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035824 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740981}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c4a5eb705f5..e9ed65aa1904 git log 0c4a5eb705f5..e9ed65aa1904 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 sque@google.com Add tikuta, <user>@chromium.org to GOMA_OWNERS Created with: gclient setdep -r src/third_party/depot_tools@e9ed65aa1904 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I09a7bf58cf02864cbe0349b161b51daa203e4ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740980}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6e714d975619ce318f1434aeb0be03f6af0c3501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053525Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a733b5b760a..1d1333fcedf8 git log 1a733b5b760a..1d1333fcedf8 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e1ccac7ff9f0..74ab0bffb526 (10 commits) 2020-02-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6cbb02e0dc93..ac4e1d236088 (2 commits) Created with: gclient setdep -r src/third_party/skia@1d1333fcedf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I5e69d41a0d7a920c9076bc34919f2c453f5d4e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053846Reviewed-by:
-
Eric Willigers authored
Various tests are moved from hosted_app_browsertest.cc to web_app_browsertest.cc and now also run with the BMO flag enabled. Bug: 1026080 Change-Id: Ie4165aa97b4beac92a62ef0912d2d7c76fbf4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046664 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts FrameHostMsg_Are3DAPIsBlocked to a sync blink::mojom::LocalFrameHost API call and fetches the top origin from the browser side frame tree instead of untrusted renderer content. Bug: 1041088 Change-Id: Id456ea5aa1743d6b05f51675b97266cf774f4049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049151 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
After crbug.com/957373 is fixed, <embed> and <object> elements should be loaded using the navigation code path. The special case logic in CanHandleDataURLRequestLocally was introduced at [1] to support them, but now they should be supported by some logic in the navigation code, not by this logic. 1: https://codereview.chromium.org/1091253004 Change-Id: I240cf868923c766391f2dab906ba07919030edcd Bug: 1049618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545313 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Eric Willigers authored
LaunchService now has static methods to read the app id from tab helpers, and so set the app id on tab helpers. These methods support both web apps and Chrome platform apps. Web app uninstall tests now run for each configuration of the web app feature flags (DesktopPWAsWithoutExtensions and kDesktopPWAsUnifiedUiController). For example, we test that when a web app is open in a browser window tab (as opposed to an app window), and the app is uninstalled, the tab is not closed. Bug: 1049906 Change-Id: I1b0af85cec9e4908c9d1d18817ca7d671f07b78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044261 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Alan Cutter authored
The distinction between a web app being installed from the install icon and "Create shortcut" was lost in https://chromium-review.googlesource.com/c/chromium/src/+/1950367. Previously we relied on the web app's scope being populated to indicate how the web app was installed by the user. This is no longer a reliable signal. This CL is removing the misleading data in the interest of removing an invalid dependency on web app scope being optional as part of making PWAs and "shortcut apps" behaviourally equivalent. Bug: 910016 Change-Id: Ida8a094897bfc9c51c3de8310c4ff66ea1996a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049007 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#740973}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b064c40a632..974547616075 Created with: gclient setdep -r src-internal@974547616075 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic51316cf04f28318a8e0b124c0dd7e7fe26fc574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053374Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740972}
-
Kenichi Ishibashi authored
This method was introduced to make response writer creation async but this isn't needed any more. The plan has changed to expose async version of GetNewResourceId() instead of making response writer creation async. Bug: 1046335 Change-Id: I4644aa2cd61ad61290ab64584ecc27a0fe3417cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051876Reviewed-by:
-
Keita Suzuki authored
This commit updates websocket handlers in net/data/websocket to support python 3 compatibility. Change-Id: I2f2bae4938c8abdfe2964e4973aecef6776d58d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051903Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#740970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6029cbd560b7..1a733b5b760a git log 6029cbd560b7..1a733b5b760a --date=short --first-parent --format='%ad %ae %s' 2020-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b4a3bf71..07e508f1 (402 commits) Created with: gclient setdep -r src/third_party/skia@1a733b5b760a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I9e9111da739a36912b59ace1ab23a9e344b4e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053615Reviewed-by:
-
Trent Apted authored
This will hold the CIPD package coming in crrev.com/i/2543523 It's not possible to directly replace the git DEPS path without exploding the build for everyone. Bug: 1051776 Change-Id: Ibe1f631fd32711aba4c56030da04363f1167d0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053486Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#740968}
-
Alex Danilo authored
Bug: 992823 Change-Id: I8aa0e374431882c4c3bf90720006405416e2689d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053229Reviewed-by:
-
Regan Hsu authored
Bug: 1049830 Change-Id: Iee409159c737ec2c833374b7a0b7da583a61b23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051038 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#740966}
-
Chris Harrelson authored
Bug: 1043628 Change-Id: Ib5c73b0099f54b339a790bdc8b6e0abd63f721dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044667 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740965}
-
Yu Han authored
Prior to this fix, when a select element's popup is open, a script in the background can modify the page's DOM that changes the position of select element on the screen. However, select popup remains stationary thus appearing disconnect from the select element. The select popup also doesn't update to the correct size if the script adds an new option with a long text. The reason is that select element doesn't check to see if the position or size of the select element popup relative to the document changed. For example, after the popup is displayed, a script could modify the document that changes the position of the select element. It doesn't notify its popup, thus makes them appear as disconnected. The fix is to update the select popup, its position and size, at the end of frame's life-cycle phase. This will guarantee that all elements in the frame have been styled and layout correctly. At this point, we can update the popup if its owner's position and size has been changed. The fix also removes the PostTask as a performance and simplicity optimization. An alternative proposal, use intersection observer on the owner element, was discussed. However, it still has the draw backs of post task. Plus, it may not capture all cases. In addition, I also considered and tried using PostTask within the UpdateLifecycle method. However, that's not optimal since within the popup's update method, it requires another call to UpdateStyleAndLayout because the layout could have been dirtied since the time PostTask was added into the queue. InternalPopupMenu::Update() also updates the select element's internal state, options. I saw some intermittent failures in couple of tests that validate options index. These tests use SetTimeout(), which may partly be aggravate by PostTask. I didn't investigate further as this is not the approach to take. This fix works for both Linux and Windows. I updated test popup-menu-resize-after-open to reflect that. In addition, I removed the (TODO) in listPicker.js. This fixes select popup when placed inside an iframe. For platforms that use external_popup_menu, mac and android, will be migrated to use internal_popup_menu when forms-refresh is rolled out to those platforms in M83. One of the biggest problem I encountered when doing this fix is that popup content doesn't updated when the popup is moved only. This is the same issue as crbug.com/633140. This review, https://codereview.chromium.org/2228093003, goes into more details on popup bounds synchronization between browser and renderer. Regardless, I had to make a similar fix in web_page_popup_impl.cc, calling SetWindowRect() when force_update is true. Bug: 137495 Change-Id: I7ef4c09a6d3d7bee3ef8988c815e07efa72d4a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013470 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740964}
-
Lukasz Anforowicz authored
Bug: 1051674 Change-Id: I2fdb3e015b0bc7648dc433afd21b358a17887adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050757 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#740963}
-
Joey Scarr authored
Fixed: 1007827 Change-Id: Ieb75e6fe3241f2ed1d9f97db5e1f67a8f8c05e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050408 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#740962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fd442ed0588..6b064c40a632 Created with: gclient setdep -r src-internal@6b064c40a632 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia8019ac085828502169bce67b227937dbb6bb6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053437Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/021ee4d7bbcf..dd239e7b7edc git log 021ee4d7bbcf..dd239e7b7edc --date=short --first-parent --format='%ad %ae %s' 2020-02-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@dd239e7b7edc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I507a8979be26ac89e77bcb691ea00022e3370a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053371Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9102c86a81ad..6029cbd560b7 git log 9102c86a81ad..6029cbd560b7 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@6029cbd560b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I450a81355fb3fc13de5d43b73b41efd2a8745019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053432Reviewed-by:
-
