GitLab

This CL adds a warning message in "NFC devices" site settings category
so that user can turn on NFC if needed.

Screenshots: https://photos.app.goo.gl/ZAsjS97LyRqQq5tH9

Change-Id: I439d0c68414e29b765408d979850ea6eca0b97c4
Bug: 520391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954004
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725647}

ARC play store is a special case, which is blacklisted apps and its app
window is created by both ARC and extension apps. So it should still be
added to instance.

ARC app window OnTaskSetActive is called from OnWindowActivated, so
implement the same code in AppService app window:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc?q=OnTaskSetActive&l=449&dr=C

When the ARC play store window is created after extension play store
window, OnItemDelegateDiscarded is called, so implement the same
code in AppService app window:
Callstack:
RegisterApp -> SetShelfItemDelegate -> OnItemDelegateDiscarded

https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc?q=SetShelfItemDelegate&l=205&dr=C
https://cs.chromium.org/chromium/src/ash/public/cpp/shelf_model.cc?dr=Ss&q=observer.ShelfItemDelegateChanged&g=0&l=305
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc?q=OnItemDelegateDiscarded&l=58&dr=C

BUG=1011235

Change-Id: Ib10c1fa45d2a902709ed3258aa8c84d5e3fc9e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966986Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725646}

Since GCA and Migration app are removed from system image, we should
unconsolidate camera icons and cleanup the codebase to make the logic
cleaner and make it easier to maintain.

In this CL, what we did is:
1. Remove "Camera Internal App" since we don't need a consolidated icon
anymore.
2. Remove ids for legacy camera app, google camera app, migration camera
app.
3. Modify some unit tests to meet current behaviors.
4. Cleanup unused resources.
5. Migrate pinned position from legacy camera app to CCA.

Bug: b/144144757
Test: Manually test and only one camera icon is shown in the launcher.
Test: Checked camera app is still pinned after applying this CL.

Change-Id: I040a45b910d445c8032f60d52785b83cb6b13831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935643Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725645}

Update icon from white to grey_300.

Bug: 997045
Change-Id: I80bb46d07d624b6882f0f158db7bf065296a3a09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967696Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#725644}

Bug: 987646
Change-Id: I86af406446b1b74f1336cf0e6d6efc7c15e3ffa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970737
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725643}

This call is blowing a DCHECK on eng builds, does not appear to be
permitted. The information it provides is not needed, so we can just
remove it.

Bug: b/146374483
Test: manual
Change-Id: Ica8503839c9cac0ff0096eef551f5585313cc843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972471Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725642}

For blink to depend on native typemappings they need to be in ui/events
as opposed to content. With this change we will be able to
use the mojo type directly in blink's mojom interfaces.

BUG=1008432

Change-Id: I8d2b1227439d1f3bc264d107daad91b10c2b3c9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965978Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725641}

* Creates a helper class in resource_utils.py for .res.info
* Shrinks the files by removing values/ entries
* Applies all renames before writing the file (main simplification)
* Changes delimiter from "," to "\t", because I don't trust
  aapt2 name minification to not include commas.
* Adds a check that all entries from a single run are unique
  (bug 935982)

Bug: 935982
Change-Id: I34cd651bfe677d54db4e4164301eaca88b17ec6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970644Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725640}

There are conflicts between the switch and the feature (for example,
kukui has the switch added to its overlay, yet PMs may want to disable
the feature for demos).

Remove the switch for now. It was only used to enable for Kukui, but
this is no longer required because Kukui are dogfooder only, and all
dogfooders have the feature enabled via finch.

The actual switch will be removed in a later CL. This was made to be
merge-friendly.

Bug: 1034626
Change-Id: Ia2a47a3875def2b1c434deabfdbf512ae01baa5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970142Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725639}

Change-Id: I826d9dc1a3a94053095810ab52782d3c39a986bf
Bug: 1026610, 1025251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970373
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Auto-Submit: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725638}

Rename KeyframeEffect::target_ (private) to effect_target_.
Copy KeyframeEffect::target() to EffectTarget() and change non-idl call sites.

The IDL version of target() will diverge in the next cl to always return
a DOM element. Callers relying on target() to return the blink::Element for
pseudo-element animations have been changed to use EffectTarget().

Split from crrev.com/c/1921343

Bug: 981894
Change-Id: I698f7daa98a2ecba052e7de003fa38c23c34b322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966497
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725637}

Change-Id: Idb429635cb9c9a38d06e2cd120a59fd1280ab425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971841
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725636}

This reverts commit 608ac152.

Reason for revert: Sorry for the bad review and the revert.  libvulkan1 is not available on Ubuntu Trusty or Debian Jessie, so we cannot add the dependency on vulkan just yet.

Original change's description:
> Whitelist libvulkan1
> 
> To finch Vulkan Skia-Adapter Layer on Linux, libvulkan1 needs to be installed.
> 
> Bug: 1034606
> Change-Id: I937a317bc87f1d174c96ccbda3e034fc6574cda9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970745
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#725593}

TBR=thomasanderson@chromium.org,fangzhoug@chromium.org

Change-Id: I267a55366b060c75710ebe0e4a6a074792959be0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1034606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972530Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725635}

ChromeDriverTest.testActionsMultiTouchPoint is only flaky on Mac now,
because Mac does not support touch events, so it is safe to disable
this touch test on Mac.

Add time delay on testActionsMouseDrag test to avoid flakiness when
performing actions.

Bug: 1011225, 1033382
Change-Id: I891516824391c467707453a213a00eb48f43101a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970748Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725634}

This reverts commit cd448f73.

Reason for revert: Fixed. Fixes in 2nd patchset.

Bug: b/146374483

Original change's description:
> Revert "[chromecast] Add more attributes for webview navigation requests"
> 
> This reverts commit 360b6277.
> 
> Reason for revert: DCHECK failure in NavigationRequest::GetPreviousURL()
> 
> 12-16 19:23:01.896  2677  2677 I cast_shell: [2678:2678:FATAL:navigation_request.cc(3788)] Check failed: state_ == DID_COMMIT || state_ == DID_COMMIT_ERROR_PAGE.
>     #0 0x005584445134 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:843:39
>     #1 0x0055843a9f60 in StackTrace ./../../base/debug/stack_trace.cc:206:12
>     #2 0x0055843a9f60 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28
>     #3 0x0055843b81e8 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:628:29
>     #4 0x005582187520 in content::NavigationRequest::GetPreviousURL() ./../../content/browser/frame_host/navigation_request.cc:0:3
>     #5 0x005581eea278 in chromecast::WebviewController::SendNavigationEvent(chromecast::WebviewNavigationThrottle*, content::NavigationHandle*) ./../../chromecast/browser/webview/webview_controller.cc:142:26
>     #6 0x005581eea98c in chromecast::WebviewNavigationThrottle::WillStartRequest() ./../../chromecast/browser/webview/webview_navigation_throttle.cc:24:16
>     #7 0x00558218b898 in ExecuteNavigationEvent ./../../content/browser/frame_host/navigation_throttle_runner.cc:0:0
>     #8 0x00558218b898 in content::NavigationThrottleRunner::ProcessInternal() ./../../content/browser/frame_host/navigation_throttle_runner.cc:161:9
>     #9 0x00558218b698 in content::NavigationThrottleRunner::ProcessNavigationEvent(content::NavigationThrottleRunner::Event) ./../../content/browser/frame_host/navigation_throttle_runner.cc:70:3
>     #10 0x005582180ef8 in content::NavigationRequest::WillStartRequest() ./../../content/browser/frame_host/navigation_request.cc:3152:21
>     #11 0x00558217f3f0 in content::NavigationRequest::BeginNavigation() ./../../content/browser/frame_host/navigation_request.cc:1232:3
>     #12 0x00558218cbf8 in content::NavigatorImpl::Navigate(std::__1::unique_ptr<content::NavigationRequest, std::__1::default_delete<content::NavigationRequest> >, content::ReloadType, content::RestoreType) ./../../content/browser/frame_host/navigator_impl.cc:329:44
>     #13 0x0055821724e8 in content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&) ./../../content/browser/frame_host/navigation_controller_impl.cc:2965:22
>     #14 0x005582171d28 in content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&) ./../../content/browser/frame_host/navigation_controller_impl.cc:983:3
>     #15 0x005582171bf4 in content::NavigationControllerImpl::LoadURL(GURL const&, content::Referrer const&, ui::PageTransition, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../content/browser/frame_host/navigation_controller_impl.cc:945:3
>     #16 0x005581eb8974 in chromecast::CastWebContentsImpl::LoadUrl(GURL const&) ./../../chromecast/browser/cast_web_contents_impl.cc:203:34
>     #17 0x005581eea0d0 in chromecast::WebviewController::ProcessRequest(chromecast::webview::WebviewRequest const&) ./../../chromecast/browser/webview/webview_controller.cc:98:29
>     #18 0x005581ad1760 in void base::internal::FunctorTraits<void (base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > >::*)(std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> >), void>::Invoke<void (base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > >::*)(std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> >), std::__1::unique_ptr<base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > >, std::__1::default_delete<base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > > > > const&, std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > >(void (base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > >::*)(std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> >), std::__1::unique_ptr<base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > >, std::__1::default_delete<base::internal::AdaptCallbackForRepeatingHelper<std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> > > > > const&, std::__1::unique_ptr<device::BluetoothDiscoverySession, std::__1::default_delete<device::BluetoothDiscoverySession> >&&) ./../../base/bind_internal.h:498:12
>     #19 0x005581ee7634 in void base::internal::Invoker<base::internal::BindState<void (chromecast::PlatformViewsRpcInstance::*)(std::__1::unique_ptr<chromecast::webview::WebviewRequest, std::__1::default_delete<chromecast::webview::WebviewRequest> >), base::internal::UnretainedWrapper<chromecast::PlatformViewsRpcInstance>, base::internal::PassedWrapper<std::__1::unique_ptr<chromecast::webview::WebviewRequest, std::__1::default_delete<chromecast::webview::WebviewRequest> > > >, void ()>::RunImpl<void (chromecast::PlatformViewsRpcInstance::*)(std::__1::unique_ptr<chromecast::webview::WebviewRequest, std::__1::default_delete<chromecast::webview::WebviewRequest> >), std::__1::tuple<base::internal::UnretainedWrapper<chromecast::PlatformViewsRpcInstance>, base::internal::PassedWrapper<std::__1::unique_ptr<chromecast::webview::WebviewRequest, std::__1::default_delete<chromecast::webview::WebviewRequest> > > >, 0ul, 1ul>(void (chromecast::PlatformViewsRpcInstance::*&&)(std::__1::unique_ptr<chromecast::webview::WebviewRequest, std::__1::default_delete<chromecast::webview::WebviewRequest> >), std::__1::tuple<base::internal::UnretainedWrapper<chromecast::PlatformViewsRpcInstance>, base::internal::PassedWrapper<std::__1::unique_ptr<chromecast::webview::WebviewRequest, std::__1::default_delete<chromecast::webview::WebviewRequest> > > >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) ./../../base/bind_internal.h:671:12
>     #20 0x0055843f3c5c in Run ./../../base/callback.h:98:12
>     #21 0x0055843f3c5c in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33
>     #22 0x00558440aa28 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:365:23
>     #23 0x00558440a748 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:219:7
>     #24 0x0055844697c4 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:208:55
>     #25 0x00558440b358 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:463:12
>     #26 0x0055843dd148 in base::RunLoop::Run() ./../../base/run_loop.cc:156:14
>     #27 0x005581ea7c00 in chromecast::shell::CastBrowserMainParts::MainMessageLoopRun(int*) ./../../chromecast/browser/cast_browser_main_parts.cc:694:14
>     #28 0x00558204e040 in content::BrowserMainLoop::RunMainMessageLoopParts() ./../../content/browser/browser_main_loop.cc:1058:29
>     #29 0x00558204fc5c in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:150:15
>     #30 0x00558204c308 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:47:28
>     #31 0x005583ce35d0 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:527:10
>     #32 0x005583ce40b8 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:962:10
>     #33 0x005583ce3dec in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:870:12
>     #34 0x005585378c30 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:423:29
>     #35 0x005583ce30c0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #36 0x0055814d8cac in main ./../../chromecast/app/cast_main.cc:13:10
> 
> Bug: b/146374483
> 
> Original change's description:
> > [chromecast] Add more attributes for webview navigation requests
> > 
> > Adds some more information to webview navigation decision requests, to
> > allow the client to make a distinction between user vs non-user
> > initiated events, among other things.
> > 
> > Bug: internal b/143139483
> > Test: manual
> > Change-Id: If4e3daae7815ed8d453db1c2c39157e9125e2bf8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953183
> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > Commit-Queue: Ryan Daum <rdaum@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#722046}
> 
> TBR=dnicoara@chromium.org,rdaum@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: internal b/143139483
> Change-Id: I8c844f27b8dbc0295b227f62062e51860e6d0346
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970913
> Reviewed-by: Michael Spang <spang@chromium.org>
> Reviewed-by: Ryan Daum <rdaum@chromium.org>
> Commit-Queue: Michael Spang <spang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#725349}

TBR=spang@chromium.org,dnicoara@chromium.org,rdaum@chromium.org

Change-Id: I28207d516f976642d8c9b3207ec2c4d4e8159e76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/146374483, internal b/143139483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972432Reviewed-by: Ryan Daum <rdaum@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725633}

Use SharedPreferencesManager consistently instead of SharedPreferences
directly.

The keys in the following classes are moved:
- FirstRunSignInProcessor
- FirstRunStatus
- FirstRunUtils

Bug: 1022108
Change-Id: I557a43c978e0b2700a84086ca86baed207e33116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960075
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725632}

Using wpt-import in Chromium 2056875a.
With Chromium commits locally applied on WPT:
c15c1083 "Add test that datachannels close when connection does."
fadf6027 "[css-pseudo] Recalculate viewport units in ::marker"
044ad8ad "[OT-PW] Make it work with OOP-R"
6e0efac2 "Use LayoutUnit for SVGImage's "container size""
920881ea "[ResourceTiming] Fix flakiness in workerStart test"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-ui

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I4d31fbcbb511bdbb889a5f757f2fd3e31227d375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971791Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#725631}

https://android.googlesource.com/platform/external/perfetto.git/+log/c18669643541..7d43fe3b8117

git log c18669643541..7d43fe3b8117 --date=short --first-parent --format='%ad %ae %s'
2019-12-17 khokhlov@google.com Merge changes I5ad9e5a5,Ief74d748
2019-12-17 lalitm@google.com trace_processor: move all containers to new subfolder
2019-12-17 lalitm@google.com Merge "trace_processor: reduce code on RowMap::FilterInto hot path"

Created with:
  gclient setdep -r src/third_party/perfetto@7d43fe3b8117

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:135177627
Tbr: perfetto-bugs@google.com
Change-Id: Idf5ae4cd1168026ad15544d97299870271fa37e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972014Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#725630}

These are unlikely to catch issues related to WCv0 feature removal,
and they clog up the rest of the test system. Removing them.

Bug: 937746
Change-Id: Ie0ae3157367d69e089e8d8fa846d0d23945e6876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970743
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725629}

Also update the network-related ownership so that it applies to both
"internet" and "network".

Change-Id: I205eca5089d1251dbbaedea9234e3a4ec232512b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970916
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725628}

One test in this suite
(CanApplyOptimizationAndPopulatesMetadataWithFirstOptThatMatchesWithExp) seems
to almost always hit the specific data race mentioned on the bug.

Bug: 1035004
Change-Id: Idf8b24e8ecac5af25ff1505d259f81cfa5dd8445
Tbr: tbansal@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969076Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725627}

This property is quite special, since it's a longhand that's equivalent
to the border-image shorthand. When the property is applied, we need to
set the slots for all of the border-image-* longhands. We also have to
apply -webkit-border-image before any border-image-* longhands, otherwise
we'd have to support some kind of partial Apply to correctly resolve the
case where a border-image-* longhand of a higher priority was applied
before -webkit-border-image.

BUG=947004

Change-Id: I59a76863e024ddbad9c534c09c2657a4a1da409d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965670
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725626}

SessionRestorationAgent will be the central Object that is used by
each Browser instance to save/restore sessions. For now it's still owned
by TabModel as TabModel implement sessionRestorateWindow protocol.
Migration from TabModel will be done step by step as Browser is not accessible
from everywhere yet. So for now TabModel methods for session restoration forward
the calls to sessionRestorationAgent and the agent handles them. Also the
agent can be observed through SessionRestorationObserver which notifies observers
with session restoration events (Starting of a restoration and end of restoration)
For now TabUsageRecorder and WebStateListMetricsObserver will use this observer
to handle session restoration events.



Change-Id: I14474fe35edb2806b3d772e733ac0de6e6686317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958287
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725625}

Updates the expires_after attribute for 22 histograms that show
frequent access in the past 90 days.  These are the 80% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-06-14.

Change-Id: I9fa6108ba8e88533e71cc070269430ce66ee3fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970713
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725624}

Hotseat jumps from states instead of animating due to re-layout on each
hotseat change.
This is a regression caused by addressing https://crbug.com/1025270. To
achieve the same effect, we can just call SetBorderOnChild() on the
last visible element during hotseat changes instead of re-laying the
whole hotseat.

Bug: 1025270, 1032770
Change-Id: Ia3301ad934e8c926dfa1f2ede218f34e05c48117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970374
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725623}

This CL inlines the static method
IdentityServicesProvider.getAccountTrackerService.
Presubmit is deactived as it requires to replace the use of
SharedPreferences which is not related to this CL.

Bug: 1032542
Change-Id: I38b4bd10334ddcff9149836b7baabe5ded8973c8
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967186
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725622}

Instead of relying on renderer-provided information, this CL changes
the way the URL matching is implemented by using the browser provided
API.

Bug: 1032170
Change-Id: I3dc23dcbcb95649106a0be6e24124617eb6c2b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960277
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725621}

This cl disables test to land crrev.com/1959984

Tbr: yangguo@chromium.org
Bug: chromium:1030258
Change-Id: I7d90a347ee3b5b159eec9ee0453478304bf48bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971848
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725620}

Bug: 1035011
Change-Id: Ic5ec3092ba8c12e001452617616f78f01e4852a1
Tbr: lazyboy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970857Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725619}

TBR=eugenebut@google.com

Change-Id: I2939e3c7c55cd3efc417b7649989e48b3516fbf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969782Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#725618}

https://skia.googlesource.com/skia.git/+log/dd699690d0ec..f11fd1f6e72d

git log dd699690d0ec..f11fd1f6e72d --date=short --first-parent --format='%ad %ae %s'
2019-12-17 fmalita@chromium.org Python3 tweaks

Created with:
  gclient setdep -r src/third_party/skia@f11fd1f6e72d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: I975e7278dd36a7743bdf864a89f83639a9daa47b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#725617}

Add more button to the bottom row that opens the system share sheet when
pressed. Refactor the logic into the coordinator to seperate the top and
bottom rows of the sharing hub.

screenshot: http://screen/Rr6LdXLb9W6.png

Bug: 1009124
Change-Id: I4208871ca049bdb722ca238de344737fe75dbc09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951653
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725616}

* List more build targets in README.
* Add security.md describing sandbox setup.

R=proberge

Change-Id: I4f9668b44427cebe7879545e212504e49d61aee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960528
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725615}

The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make
HistoryServiceBackend's task runner dispatch to the ThreadPool instead
of a dedicated base::Thread. The tests need to be prepared to stay
functional when that happens.

This is done as the last mile of the chrome-wide effort to coalesce as
much work as possible to the ThreadPool.

Bug: 661143
Change-Id: Ia8cbe38a5155a947de5cd04a41fb0d9134379050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965151
Auto-Submit: Oliver Li <olivierli@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725614}

Various fixes for the feed library tests that were just imported. Now
all tests should be running.

Bug: 1024945
Change-Id: Id0184faabc21e77ee0bb2677dbf55b3091249aa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953570Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725613}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba4699fef545..115b7179356c

git log ba4699fef545..115b7179356c --date=short --first-parent --format='%ad %ae %s'
2019-12-17 pkasting@chromium.org Escape forward slash to avoid undesired path conversion in Git 2.24.1(2).

Created with:
  gclient setdep -r src/third_party/depot_tools@115b7179356c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I9a862e9e8778455572849873a940f065eec32278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971851Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#725612}

https://webrtc.googlesource.com/src.git/+log/6fd58b338859..768c5f438cad

git log 6fd58b338859..768c5f438cad --date=short --first-parent --format='%ad %ae %s'
2019-12-17 yvesg@webrtc.org Roll chromium_revision faed30b4..98124fd6 (724977:725465)

Created with:
  gclient setdep -r src/third_party/webrtc@768c5f438cad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I46497605989bff0cc34991f759a1c05b96b1e5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971779Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#725611}

This leverages some new built-in functionality in FlexLayout and
AnimatingLayoutManager to make the icon container behave the way we want
it to in most (hopefully all!) cases.

Bug: 995448
Change-Id: I349f1e3dd57669848f936e9b531797bc087bad50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968244Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725610}

On the Windows+UIA platform, Narrator was not announcing recently
deleted characters in an <input type="text"> field when 'backspacing'
over them.

Comparing the UIA implementation in Chromium & EdgeHTML, we found that
we should fire a TextChanged event in addition to the ValueChanged event
in this scenario.

Bug: 1034729
Change-Id: Ib7423bd22cd709ac4813cfb3c0813911c704430e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970765Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#725609}

--fetch will default to update.CLANG_REVISION if specified without an
argument

BUG=

Change-Id: I2f5f5b7c9c446c92d9983d1f5a6ea01aee7f927c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970769Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725608}