GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88418 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus
Review URL: http://codereview.chromium.org/7046058

TBR=cevans@chromium.org
Review URL: http://codereview.chromium.org/7003071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88415 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus
Review URL: http://codereview.chromium.org/7046058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88414 0039d316-1c4b-4281-b951-d872f2087c98

This increments the promo version in PromoResourceService so that users will fetch the new promo immediately after upgrading to M13, rather than having to wait up to 48 hours.

BUG=84561
TEST=none


Review URL: http://codereview.chromium.org/7104063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88413 0039d316-1c4b-4281-b951-d872f2087c98

(Also moves the image forcing to after the image is set so it doesn't get
reset.)

BUG=85443
TEST=compiles

Review URL: http://codereview.chromium.org/7003066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88412 0039d316-1c4b-4281-b951-d872f2087c98

The test previously failed to wait for the 'pkill chrome' command to finish
killing the relevant chrome processes.

BUG=chromium-os:16297
TEST=None

Review URL: http://codereview.chromium.org/7108023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7108007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88408 0039d316-1c4b-4281-b951-d872f2087c98

Icons in the download DOM UI were very fuzzy.

This was a regression due to r76743.

The problem was that IconLoad was returning a multi-resolution image but callers weren't multi-resolution aware.

For example, the download DOM UI would encode the image to PNG but it would just pick the first bitmap which happened to be 16x16. This caused icons in the DOM UI to look fuzzy.

I think there are two fixes for this:
1. Change IconLoader so that callers no longer specify the icon size. Instead, callers must pick the right resolution when they get the icon loaded callback.
2. Have callers specify that they want all resolutions.

I went with 2 because always loading all icon sizes can be expensive.

BUG=84741
TEST=Ran and verified that the downloads UI looks good.


Review URL: http://codereview.chromium.org/6995068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88406 0039d316-1c4b-4281-b951-d872f2087c98

This logging is inspired by Xiyuan's change in http://codereview.chromium.org/7038026/

BUG=81451
TEST=none

Review URL: http://codereview.chromium.org/7104049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88405 0039d316-1c4b-4281-b951-d872f2087c98

Every time the dialog is loaded, the read-only email address would be appended
to the span.

BUG=84665
TEST=manual


Review URL: http://codereview.chromium.org/7054062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Preview a webpage. Enter a page range text. If the text is invalid, an error message is displayed.


Review URL: http://codereview.chromium.org/7003060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88402 0039d316-1c4b-4281-b951-d872f2087c98

Adding padding at the bottom of internet details page, so we make room for button strip (and avoid its overlapping with page contents)

BUG=chromium-os:12995
TEST=Made sure buttons on the internet details dialog don't overlapp with contents in any of its tabs.
Review URL: http://codereview.chromium.org/7054056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88401 0039d316-1c4b-4281-b951-d872f2087c98

Use the System URL Request Context in the web resource service instead of the default profile's context.

This change should be made because there will be no more default profile, because these services should be able to run without being attached to a specific profile, and because they should only ever fetch json data from controlled URLs.

BUG=64339
TEST=all current web resource tests continue to work.
Review URL: http://codereview.chromium.org/7099004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85081
TEST=Open print preview tab, print a doc. Reopen, the last used printer should be pre-selected.


Review URL: http://codereview.chromium.org/7042034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/7058055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16264
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7046050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run remoting_simple_host --me2mom without cached credentials.


Review URL: http://codereview.chromium.org/7041006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88394 0039d316-1c4b-4281-b951-d872f2087c98

Fix a browser, renderer, plugin deadlock caused by the change to reparent plugin windows in the browser
process. Reparenting occurs via Windows API calls on the IO thread which can result in window messages
being dispatched to plugin windows which may be blocked on outgoing sync calls.

Fix is to execute the Windows API calls on the UI thread.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=85397

BUG=85397
Review URL: http://codereview.chromium.org/6995082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88393 0039d316-1c4b-4281-b951-d872f2087c98

The signature changed from (commit bf2f7326):
virtual void OnViewAdded(View* parent, View* child);

To:
virtual void OnViewAdded(const View& parent, const View& child);

BUG=72040
TEST=None

R=ben@chromium.org,sky@chromium.org,pkasting@chromium.org

Review URL: http://codereview.chromium.org/7104042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88392 0039d316-1c4b-4281-b951-d872f2087c98

Use the original non-incognito profile instead of backing off to the default profile when we're in incognito mode.

BUG=64339
TEST=extension webstore private browsertest keeps working.
Review URL: http://codereview.chromium.org/7041007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88391 0039d316-1c4b-4281-b951-d872f2087c98

Add apitest for InputUI extension API.

BUG=Crashes when extension calls a undefined function
TEST=Manually

Review URL: http://codereview.chromium.org/7104002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88390 0039d316-1c4b-4281-b951-d872f2087c98

on different threads than the one on which it's written.

R=eroman@chromium.org


Review URL: http://codereview.chromium.org/7135005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88389 0039d316-1c4b-4281-b951-d872f2087c98

- UserScript reference from BufferedResourceHandler.
- ExtensionInfoMap references from RenderMessageFilter and WorkerProcessHost
and ResourceContext.

BUG=76697

Review URL: http://codereview.chromium.org/7135003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88388 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies message routing to the compositor thread a bit.

Review URL: http://codereview.chromium.org/7129006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88387 0039d316-1c4b-4281-b951-d872f2087c98

See also http://codereview.chromium.org/149741/

BUG=16963
TEST=Observe that the theme image is tiled on a new tab page. Observe that all variables are replaced to their values in chrome://theme/css/newtab.css, i.e. the newtab.css contains no variables like "$$1" or "$$$1".


Review URL: http://codereview.chromium.org/6897002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88386 0039d316-1c4b-4281-b951-d872f2087c98

All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
See the bug for a disussion of this change.

BUG=84424
TEST=none

Review URL: http://codereview.chromium.org/6995085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88385 0039d316-1c4b-4281-b951-d872f2087c98

Note this doesn't need to use IPC at all, so it's a little strange.

Made test for pp::Var/PPB_Var that does only strings (copied from test_var_deprecated.cc).  Fixed string var tracking so test can pass out-of-process (aside from invalid UTF8 checking, which is still not implemented o-o-p).

BUG=85236
TEST=test_var.cc, run tests manually out-of-process.

Review URL: http://codereview.chromium.org/6995083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88384 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a real bug, because e.g. chrome/browser/chromeos/frame/browser_view.cc
has a scoped_ptr<views::MenuDelegate> that it sets to a
SimpleMenuModelDelegateAdapter object. (That class ends up not having a destructor
and no non-POD members, so it's just a latent bug.)

BUG=84424
TEST=none


Review URL: http://codereview.chromium.org/7109037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88383 0039d316-1c4b-4281-b951-d872f2087c98

Only list user certificates in the TPM in the Wi-Fi connection certificate list, as those are the only ones available via PKCS#11 to flimflam and wpa_supplicant.

BUG=chromium-os:16032
TEST=manual, see bug

Review URL: http://codereview.chromium.org/7046051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88381 0039d316-1c4b-4281-b951-d872f2087c98

This should make it possible to run on a VM, and still find the private key created for the owner in the software slot.

BUG=chromium-os:15817
TEST=Built an image and tried it on a VM and a device. Both showed restricted users list.

Review URL: http://codereview.chromium.org/7066070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88380 0039d316-1c4b-4281-b951-d872f2087c98

Since benchmarking results represent only a sample of the entire population of
results, it would be better to calculate the sample standard deviation, which
is an unbiased estimator of the population variance.  Also, since the Array.avg
function throws out the min and max, this function should not be used when
calculating the variance.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7108006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88379 0039d316-1c4b-4281-b951-d872f2087c98

10.6 added object_destructInstance() as a wrapper around
object_cxxDestruct() and also releasing associated objects.  As a
bonus, it's available via dlsym() rather than nlist().

BUG=82937
TEST=none

Review URL: http://codereview.chromium.org/7084017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88378 0039d316-1c4b-4281-b951-d872f2087c98

Patch for 88373 (clang errors)

BUG=chromium-os:15598
TEST=Clang compile succeeds

Review URL: http://codereview.chromium.org/7046055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88377 0039d316-1c4b-4281-b951-d872f2087c98

that care send the correct message. This change is motivated by
wanting to remove SessionID from content. At later cl will remove
TabContentsDelegate::RenderViewCreated.

BUG=none
TEST=none
R=jam@chromium.org,mpcomplete@chromium.org

Review URL: http://codereview.chromium.org/7046041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88376 0039d316-1c4b-4281-b951-d872f2087c98

Revert stubs that were added in r88040.  We need proper interfaces around features that need to be compiled out, instead of adding stubs.
Review URL: http://codereview.chromium.org/7046052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88374 0039d316-1c4b-4281-b951-d872f2087c98

This is a regression caused by http://codereview.chromium.org/6881073/

BUG=chromium-os:15598
TEST=Opening a large window using JS window.open from a panel should open a new tab in the parent browser. See issue for repro.

Review URL: http://codereview.chromium.org/7101008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88373 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85310

TBR=

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88371 0039d316-1c4b-4281-b951-d872f2087c98