GitLab

No need to export PowerMonitorBroadcastSource.

BUG = 647247

Review-Url: https://codereview.chromium.org/2565293002
Cr-Commit-Position: refs/heads/master@{#437859}

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None

Review-Url: https://codereview.chromium.org/2569663002
Cr-Commit-Position: refs/heads/master@{#437858}

BUG=673296
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2568793002 .
Cr-Commit-Position: refs/heads/master@{#437857}

This is refactoring only, with the exception of VRDisplay.cpp, which
changes from unprefixed to prefixed.

As per the TODO, the idea is to make the default type depend on
RuntimeEnabledFeatures::fullscreenUnprefixedEnabled().

Also make RequestType an enum class while in the area.

BUG=402376

Review-Url: https://codereview.chromium.org/2565203002
Cr-Commit-Position: refs/heads/master@{#437856}

The class is providing APIs to read/write payment app related data(e.g. manifest
and associated service worker). It can be shared between payment_app_manager.cc
and payment_app_context.cc.

The payment_app_manager.cc contains a actual implementation of the
PaymentAppManager interface[1] used on the page or worker.
Also, the payment_app_context.cc can be used to query all manifests data[2]
in order to update payment request UI in Chrome layer.

We can summarize this CL as follows.
  1. Rename PaymentAppContext in content/browser/payments to
     PaymentAppContextImpl and then add PaymentAppContext interface in
     content/public to expose some APIs to Chrome layer.
  2. Write PaymentAppDatabase class and then move most of logics to access
     database from PaymentAppManager to the new class.
  3. Add a interface to query all manifests data in Chrome layer but it's not
     implemented yet in this CL. It will be implemented in follow-up CL[2].

[1] https://w3c.github.io/webpayments-payment-apps-api/#payment-app-manager
[2] https://codereview.chromium.org/2556433002

BUG=661608
TEST=existing unittests

Review-Url: https://codereview.chromium.org/2560293002
Cr-Commit-Position: refs/heads/master@{#437855}

This is mostly about mechanical changes such as:

- Move InputMethodController-related logic inside InputMethodController
  and call it first - such that we can expand the logic there.
- Rename method name for better readability.

Also, there are subtle logical changes:

1) Try finishComposingText() even when the current input type is NONE.
   This should not have any effect.

2) When finishComposingText() returns false, we no longer call
   UpdateTextInputState(). This should not have any effect.

3) When finishComposingText() returns false, we no long call
   UpdateCompositionInfo(). This is used by Android and Mac.
   Previously, there was a chance that we propagate InvalidRange() all the
   way up to the keyboard app. Now ShouldUpdateCompositionInfo() returns
   false to make it clear.

This is originally found in resolving crbug.com/664317, but is also
needed for crbug.com/630137 because if we no longer cancel composition
on selection change, then WebViewTest may fail because it uses
TestWebViewClient which does not implement resetInputMethod().

BUG=664317, 630137

Review-Url: https://codereview.chromium.org/2561543003
Cr-Commit-Position: refs/heads/master@{#437854}

Implemented analogously to font-feature-settings, as their definition in
the spec is quite similar as well [1].

Add an experimental web platform features flag for CSSVariableFonts.

[1] https://drafts.csswg.org/css-fonts-4/#low-level-font-variation-settings-control-the-font-variation-settings-property

TEST=fast/css/font-variation-settings-css-support.html
BUG=669455,669460

Review-Url: https://codereview.chromium.org/2558053002
Cr-Commit-Position: refs/heads/master@{#437853}

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176

Review-Url: https://codereview.chromium.org/2562303002
Cr-Commit-Position: refs/heads/master@{#437852}

Add the android.permission.INTERNET permission to the standalone
WebView's apk, to allow Services belonging to WebView's package to
connect to the internet.

BUG=673280

Review-Url: https://codereview.chromium.org/2562353002
Cr-Commit-Position: refs/heads/master@{#437851}

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169

Review-Url: https://codereview.chromium.org/2568023002
Cr-Commit-Position: refs/heads/master@{#437850}

It was missing from https://codereview.chromium.org/2547533002

BUG=326572
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2561163005
Cr-Commit-Position: refs/heads/master@{#437849}

Revert of Disable UI options that allow new tabs before FRE. (patchset #4 id:60001 of https://codereview.chromium.org/2559573002/ )

Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
http://crbug/673212

Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002

TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149

Review-Url: https://codereview.chromium.org/2566963002
Cr-Commit-Position: refs/heads/master@{#437848}

This CL wires up the experiment settings for tuning WebRTC's gain
control. Four different new values are provided as feature flags (to
be controlled by a Finch experiment or directly from command line
flags).

BUG=chromium:672476,webrtc:6622

Review-Url: https://codereview.chromium.org/2560173002
Cr-Commit-Position: refs/heads/master@{#437847}

Rename old target //ios/chrome/app/resources to the more correct name
//ios/chrome/app/resources:ios_resources.

Add a new group target //ios/chrome/app/resources to allow multiple
target to get all resources required in the application bundle and
to act as "chrome" target (i.e. EarlGrey tests).

BUG=672516

Review-Url: https://codereview.chromium.org/2563023002
Cr-Commit-Position: refs/heads/master@{#437846}

This test is flaky on chromium.linux Android Tests and Android Tests (dbg).

BUG=646843
TBR=michaelbai@chromium.org

Review-Url: https://codereview.chromium.org/2568073002
Cr-Commit-Position: refs/heads/master@{#437845}

BUG=673126
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2565363002 .
Cr-Commit-Position: refs/heads/master@{#437844}

The code for fetching and filtering payment instruments in
PaymentRequestImpl is asynchronous anyway, so this change is not too
intrusive. The main thing is to insert an extra asynchronous step to
populate the mApps list before payment instrument filtering starts.

If we want to take this further, a good next step would be to start
showing apps as they are discovered, instead of waiting until we have
received all the payment apps. It would also be a good thing to
refactor some of this functionality out of the PaymentRequestImpl, as
it is growing quite complex.

Other changes that went into this commit:

* Change the PaymentAppFactory into a singleton, rather than being a
  holder class for static functions.

* Extend the AdditionalPaymentFactory functionality, so that the
  PaymentAppFactory can have many additional factories. This lets us
  make the ServiceWorkerPaymentAppBridge an additional factory, and
  normalize the relationship between the two classes.

* Add two unit tests for testing delayed payment app creation.

BUG=661608

Review-Url: https://codereview.chromium.org/2559153002
Cr-Commit-Position: refs/heads/master@{#437843}

All downstream target have been cleaned up, so remove the support for
overridding write_pkg_info from ios_app_bundle template.

BUG=672516

Review-Url: https://codereview.chromium.org/2563013002
Cr-Commit-Position: refs/heads/master@{#437842}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/921d884f..1ba626d6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2563373002
Cr-Commit-Position: refs/heads/master@{#437841}

As the first step of implementing Idle Time Spell Checker, this patch adds
a new runtime enabled feature IdleTimeSpellChecking, and exits the existing
spell-checking code paths when the feature is enabled.

BUG=671922

Review-Url: https://codereview.chromium.org/2566043003
Cr-Commit-Position: refs/heads/master@{#437840}

Revert of ServiceWorker: Change DCHECK to CHECK for debugging process allocation (patchset #1 id:1 of https://codereview.chromium.org/2528333002/ )

Reason for revert:
There was no crash came from this CHECK.

Original issue's description:
> ServiceWorker: Change DCHECK to CHECK for debugging process allocation
>
> This patch is to confirm if the process allocation works well.
>
> BUG=668633
>
> Committed: https://crrev.com/21c5638d913d1147a0a3e6a69c69ebe9bfa993bb
> Cr-Commit-Position: refs/heads/master@{#434628}

TBR=falken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668633

Review-Url: https://codereview.chromium.org/2563583002
Cr-Commit-Position: refs/heads/master@{#437839}

The goal is to list the top domains that show non-real icons and then
debug them individually. If we find evidence that such domains do
actually provide large icons, it would suggest there's client-side bugs
that prevent from displaying this icon (either it wasn't fetched, the
wrong version was kept around, it was garbage-collected, etc.).

BUG=672411

Review-Url: https://codereview.chromium.org/2557513007
Cr-Commit-Position: refs/heads/master@{#437838}

The purpose of this CL is to provide a mechanism for enabling or
disabling SubresourceFilter's performance measuring on a per-page basis,
i.e. consistently for all DocumentSubresourceFilter instances of a page.

A decision on whether to measure performance (currently always true)
originates in ContentSubresourceFilterDriverFactory. It is distributed
to SubresourceFilterAgents first in the ActivateForProvisionalLoad
message, and eventually reaches individual DocumentSubresourceFilter
instances corresponding to each subframe document.

BUG=672519

Review-Url: https://codereview.chromium.org/2556433003
Cr-Commit-Position: refs/heads/master@{#437837}

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2565333002
Cr-Commit-Position: refs/heads/master@{#437836}

test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.

Also update vp9 md5 for RK3399.

BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0

Review-Url: https://codereview.chromium.org/2553653002
Cr-Commit-Position: refs/heads/master@{#437835}

Revert of Simple BlinkGC heap compaction. (patchset #22 id:420001 of https://codereview.chromium.org/2531973002/ )

Reason for revert:
Speculative revert for a layout test breakage. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13912

Original issue's description:
> Simple BlinkGC heap compaction.
>
> This implements heap compaction for the Blink GC infrastructure
> (Oilpan), compacting the arenas of the BlinkGC heap which are most
> susceptible to becoming fragmented during actual use.
>
> Fragmentation is a real problem and a growing one while browsing anything
> but static pages: the amount of unused, but allocated, memory is
> fluctuating higher over time.
>
> To avoid leaving increasing amounts of unused holes in our heaps,
> heap compaction will periodically squeeze out the unused portions,
> packing together the live objects. The heap pages that are then
> left as unused, are subsequently released and returned to the OS.
>
> Due to a fortunate property of Blink heap collection types, providing
> such compaction is within relatively easy reach. Experiments show that
> the arenas which hold such collection objects ("backing stores") are
> the ones that develop fragmentation the most & persistently. While not
> a complete heap compactor of all Blink GC arenas, it addresses the
> fragmentation problem where it is most pressing. More can be done, later.
>
> Explainer / design document:
>
>  https://docs.google.com/document/d/1k-vivOinomDXnScw8Ew5zpsYCXiYqj76OCOYZSvHkaU
>
> R=haraken
> BUG=672030
>
> Review-Url: https://codereview.chromium.org/2531973002

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672030

Review-Url: https://codereview.chromium.org/2570483002
Cr-Commit-Position: refs/heads/master@{#437834}

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest

Review-Url: https://codereview.chromium.org/2568473002
Cr-Commit-Position: refs/heads/master@{#437833}

Cr-Commit-Position: refs/heads/master@{#437832}

This patch adds a FlakyTest annotation for testAddInvalidAddressAndCancel

BUG=673136
TBR=dfalcantara

Review-Url: https://codereview.chromium.org/2566923003
Cr-Commit-Position: refs/heads/master@{#437831}

If the crash still occurs and the CHECKs pass, we know the null
active version is due to SWRegistration::DeleteVersion.

BUG=655910

Review-Url: https://codereview.chromium.org/2570453002
Cr-Commit-Position: refs/heads/master@{#437830}

This implements heap compaction for the Blink GC infrastructure
(Oilpan), compacting the arenas of the BlinkGC heap which are most
susceptible to becoming fragmented during actual use.

Fragmentation is a real problem and a growing one while browsing anything
but static pages: the amount of unused, but allocated, memory is
fluctuating higher over time.

To avoid leaving increasing amounts of unused holes in our heaps,
heap compaction will periodically squeeze out the unused portions,
packing together the live objects. The heap pages that are then
left as unused, are subsequently released and returned to the OS.

Due to a fortunate property of Blink heap collection types, providing
such compaction is within relatively easy reach. Experiments show that
the arenas which hold such collection objects ("backing stores") are
the ones that develop fragmentation the most & persistently. While not
a complete heap compactor of all Blink GC arenas, it addresses the
fragmentation problem where it is most pressing. More can be done, later.

Explainer / design document:

 https://docs.google.com/document/d/1k-vivOinomDXnScw8Ew5zpsYCXiYqj76OCOYZSvHkaU

R=haraken
BUG=672030

Review-Url: https://codereview.chromium.org/2531973002
Cr-Commit-Position: refs/heads/master@{#437829}

This patch is an initial try to setup call flows and produces fragment
tree for inline layout, a step towards to NG inline layout to produce
LayoutObject tree.

Most of the necessary logic are still missing. For sizing the block
container, the logic should be shared with NGBlockLayoutAlgorithm using
composition. This will be filled in future patches.

For more steps of inline layout (e.g., line breaking, bidi reordering),
making the fragment tree meaningful, copying the fragment tree to
LayoutObject tree, etc. will be in future patches too.

NGInlineLayoutTest is changed to test the result after layout completes,
as NGInlineBox collects inline text during the layout in this patch.

BUG=636993

Review-Url: https://codereview.chromium.org/2551793002
Cr-Commit-Position: refs/heads/master@{#437828}

Memory-Infra on Windows doesn't use memory usage reported by the OS (proportional set size, private dirty, etc.) yet.

This CL added functionality to calculate proportional set size for a process.

BUG=623499

Review-Url: https://codereview.chromium.org/2549803003
Cr-Commit-Position: refs/heads/master@{#437827}

The JoystickScrollProvider Java class used to emulate a View
scroll events and call ContentViewCore.scrollBy(), now it
emulates the mouse wheel events directly, dropping the calculation
of the current event position (it is set to (0,0)).

This CL also removes JoystickScrollProvider dependency on
ContentViewCore, it talks to its own native counterpart.

BUG=620929, 650351

Review-Url: https://codereview.chromium.org/2548363007
Cr-Commit-Position: refs/heads/master@{#437826}

This CL adds a Java-side interface to the Site Engagement Service, as
well as a basic integration test for the interface. This allows Java
code (particularly tests) to programatically adjust and retrieve the
score.

BUG=671100

Review-Url: https://codereview.chromium.org/2553013002
Cr-Commit-Position: refs/heads/master@{#437825}

https://skia.googlesource.com/skia.git/+log/2790c52e36dd..bbab477b49e2

$ git log 2790c52e3..bbab477b4 --date=short --no-merges --format='%ad %ae %s'
2016-12-08 jvanverth Add documentation for Viewer

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2570433003
Cr-Commit-Position: refs/heads/master@{#437824}

Also add a hook for content::RenderThreadObserver implementations, such
as ChromeRenderThreadObserver, to register their Mojo interfaces.

Tested manually, by creating a new Chrome extension a la
https://developer.chrome.com/extensions/getstarted
and replacing its popup.js script with:

document.addEventListener('DOMContentLoaded', function() {
  document.getElementById('status').textContent =
    'inIncognitoContext: ' + chrome.extension.inIncognitoContext;
});

BUG=577685

Review-Url: https://codereview.chromium.org/2531133002
Cr-Commit-Position: refs/heads/master@{#437823}

https://crrev.com/2558743002 fixed a bug that loading metric doesn't
work for webview traces. This patch re-enables page_cycler_v2 and
loading.mobile benchmarks on webview bots.

BUG=651188
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2564773002
Cr-Commit-Position: refs/heads/master@{#437822}

Now that ContextLifecycleObserver clears its observing context after calling
contextDestroyed. So there is no need to explicitly call clearContext().

BUG=610176

Review-Url: https://codereview.chromium.org/2552703006
Cr-Commit-Position: refs/heads/master@{#437821}

This is a rename requested by https://codereview.chromium.org/2554813002/.

Previously ActiveDOMObject was used to implement hasPendingActivity() of DOM wrappers,
where the name "ActiveDOMObject" made sense. Then we moved hasPendingActivity() to
ActiveScriptWrappable. Now ActiveDOMObject is a class that just provides resume/suspend.
It would make more sense to rename it to SuspendableObject.

BUG=610176
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2567913002
Cr-Commit-Position: refs/heads/master@{#437820}