- 02 Feb, 2018 40 commits
-
-
Christian Fremerey authored
In Issue 807887, ClusterFuzz provided a very useful stack trace demonstrating a use after free, which is likely the same as Issue 777608. Root cause was a Mojo connection error getting invoked on a base::Unretained() pointer to a deleted object. I added a unit test case the reproduced the issue before the fix. There are two possible fixes. 1. In ~DeviceMediaToMojoAdapter() call Stop() in order to reset the connection error handler before it gets invoked. 2. Use base::WeakPtr. I am opting for option 2. because seeing/proving that solution 1. is effective is unreasonably complex and also requires more code. Test: services_unittests --gtest_filter="DeviceMediaToMojoAdapterTest.*" Bug: 807887, 777608 Change-Id: If42094796fbb095caccad7af9f72263b1d5f3ed6 Reviewed-on: https://chromium-review.googlesource.com/898256 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534199}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constant twice with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch inlines the constants in chrome_visibility_observer.cc and desktop_session_duration_tracker.cc. Bug: 746957 Change-Id: I1b7d4b2f4a83a8a75c248f07199af6f4e72e87f5 Reviewed-on: https://chromium-review.googlesource.com/897533 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#534198}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and if that causes there to be overloaded functions, the address operator won't know what function's address the code refers to. This happens in base::Bind, and results in compilation failures. In preparation for jumbo in chrome/browser, this patch renames the three OnAcquireFileAccessPermissionDone to OnDownloadAcquireFileAccessPermissionDone OnThrottleAcquireFileAccessPermissionDone OnOfflinePageAcquireFileAccessPermissionDone Bug: 746957 Change-Id: I6bd1fa44e9cc1ab44d9bdb653dd8117280ff9325 Reviewed-on: https://chromium-review.googlesource.com/897943Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534197}
-
Sam Clegg authored
This was broken by https://chromium-review.googlesource.com/728950 Change-Id: I913650b267bb42ee9d4bf0d64b03b22eadb9f04a Reviewed-on: https://chromium-review.googlesource.com/900295Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#534196}
-
Allen Bauer authored
Bug: 654142 Change-Id: I0bd9cd4fcf4337b20809a99329e429f62f14994f Reviewed-on: https://chromium-review.googlesource.com/896165 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#534195}
-
Katie D authored
Previously, we tracked inlineTextBox nodes using their index in the staticText parent. However, if the container holding the text was resized, the staticText parent indices change as the flow of boxes within them changes. This change removes all dependency on the index of the inlineTextBox within the staticText node, and instead relies purely on character indices to determine nodes to highlight. Bug: 800912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c0ecb2f78912b376040cc029f77a32fec6f5c85 Reviewed-on: https://chromium-review.googlesource.com/898206 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#534194}
-
bsheedy authored
Adds the option of not specifying initial good/bad values for the VR bisect script. If not specified, the script will run additional tests at the good/bad revisions to determine the initial values. Change-Id: Ic15cad0968b2a6154e342f3fca799bf7784e02e6 Reviewed-on: https://chromium-review.googlesource.com/899607Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534193}
-
David Tseng authored
Bug: 796861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I54973fff39522225398d490877c2d03690dfd71f Reviewed-on: https://chromium-review.googlesource.com/889040 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#534192}
-
Khushal authored
Transport the target color space for OOP raster in BeginRasterCHROMIUM to ensure we set up a color transform canvas for raster if necessary. R=enne@chromium.org, piman@chromium.org Bug: 757610 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8cf03e9f129d2c004f4e228dffa6621d964bf6f0 Reviewed-on: https://chromium-review.googlesource.com/894860 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534191}
-
Jérôme Lebel authored
Tracking: src/components/ButtonBar/src/ColorThemer/MDCButtonBarColorThemer.h src/components/ButtonBar/src/ColorThemer/MDCButtonBarColorThemer.m src/components/ButtonBar/src/MDCButtonBarButton.h src/components/ButtonBar/src/private/MDCButtonBarButton+Private.h src/components/ButtonBar/src/private/MDCButtonBarButton.m Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e77cf843916da31fb574993729a37137b05bb23 Reviewed-on: https://chromium-review.googlesource.com/897863Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#534190}
-
Daniel Cheng authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib40ea583e23fb46aec4f56fc3328fee7107c89fe Reviewed-on: https://chromium-review.googlesource.com/898243Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534189}
-
https://pdfium.googlesource.com/pdfium.git/+log/f7c84e910899..bbeb10daef8b $ git log f7c84e910..bbeb10dae --date=short --no-merges --format='%ad %ae %s' 2018-02-02 tsepez Small tidy of fxjs 2018-02-02 tsepez Remove V8 context from CJS_V8 2018-02-02 tsepez Make global object function names clearer. 2018-02-02 hnakashima Add asm.js to third_party/build/build_config.h. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic357d112579ce8a96f85647099e9d25a3c0d4a85 Reviewed-on: https://chromium-review.googlesource.com/900209 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534188}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69113b91..0f936675 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I78d7df35df64b7cab881f4002f65131f04f9e603 Reviewed-on: https://chromium-review.googlesource.com/899990Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534187}
-
Ria Jiang authored
Currently, HitTestAggregator is owned by RootCompositorFrameSinkImpl, which would only work for the viz display compositor (OOP-D) case. In non-viz, we use DirectLayerTreeFrameSink, and it calls to create a CompositorFrameSinkSupport with |is_root| equal to true through HostFrameSinkManager. 1. This changes CompositorFrameSinkSupport to own the HitTestAggregator when it is a root CFSS, and pass its FrameSinkId to the HTA. 2. Change FrameSinkManagerImpl to be a HitTestAggregatorDelegate. 3. Update DirectLayerTreeFrameSink to activate HitTestAggregator:: Aggregate(). Bug: 805581 Test: viz_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0d3d93405dc99e7a5a6edb8f0587c5d0d24ffad7 Reviewed-on: https://chromium-review.googlesource.com/884324 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#534186}
-
Weidong Guo authored
Changes: Using system display api setDisplayProperties to turn on mirror mode is deprecated. Replace the usage in display.js with the new api setMirrorMode. BUG=807825 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86458ebf7aaa446d6ff23cde05c7eae819d11558 Reviewed-on: https://chromium-review.googlesource.com/896796 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534185}
-
Christopher Grant authored
- Plumb more Autocomplete request information out of the UI - Include input and autocompletion text in suggestions - Augment Text/TextInput to display a selection, if specified - Add selection colors to the colorscheme - Make the testapp's fake keyboard act much more like a keyboard BUG=799201 R=vollick, ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6371875a93149496aee4ac80f9fad3b78ebed245 Reviewed-on: https://chromium-review.googlesource.com/899905 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#534184}
-
Nico Weber authored
No behavior change. Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7d5d28d208cca14819572e9a982ea155d6c725df Reviewed-on: https://chromium-review.googlesource.com/899113 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constants and helper functions in several files will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch deduplicates the GetWebContents() helper function and the constants kOMADrmMessageMimeType, kOMADrmContentMimeType, kOMADrmRightsMimeType1, kOMADrmRightsMimeType2. Bug: 746957 Change-Id: Ie268f77c7a099a8de01ae08c70870306f38fc05a Reviewed-on: https://chromium-review.googlesource.com/897612Reviewed-by:
-
Kyle Horimoto authored
This UI is shown on the settings page when a phone tells the Chromebook that it does not have GmsCore notifications enabled. Note: This CL's contents were already landed in https://chromium-review.googlesource.com/c/chromium/src/+/894729. However, part of that CL needed to be merged to the M-65 branch, so I'm re-landing two separate CLs and only merging the other one to the M-65 branch. Bug: 793936, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I647fd141415bf4d255405eec4989aebf19aef9e8 Reviewed-on: https://chromium-review.googlesource.com/898547Reviewed-by:
-
Theresa authored
BUG=808524 TBR=mthiesse@chromium.org Change-Id: If2c4030ca63dc472a1894993f9633e029d021f7f Reviewed-on: https://chromium-review.googlesource.com/900208Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534180}
-
Marijn Kruisselbrink authored
This test makes assumptions about ordering of different task sources that are not guaranteed by either the spec or the implementation. Bug: 784909 Change-Id: I6c5d25fd5c684594ca272a84a664692c90caff6e Reviewed-on: https://chromium-review.googlesource.com/896034 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534179}
-
Tim Dresser authored
Previously we excluded swiping input. We now include swipes (map panning, carousel rotation), but still exclude scroll. Also records a UKM. Bug: 803935 Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2 Reviewed-on: https://chromium-review.googlesource.com/894826 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534178}
-
https://chromium.googlesource.com/angle/angle.git/+log/c7295f4d363d..df9ad2be8c97 $ git log c7295f4d3..df9ad2be8 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 jmadill Vulkan: Minor refactor to RendererVk::initialize. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I1d7b04ed3de3ce740beadff1ebfb8cca0c9df6b8 Reviewed-on: https://chromium-review.googlesource.com/900124 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534177}
-
Saman Sami authored
Seems like we don't embed the LocalSurfaceId allocated in WindowPortMus::AllocateLocalSurfaceId with --mash. Embed it. Bug: 807448 Change-Id: Id4c03c01d714de010a8306fc97bcd1a98dfaa3cb Reviewed-on: https://chromium-review.googlesource.com/895926 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
-
Chris Harrelson authored
A previous refactor accidentally omitted delegation to the parent class when recomputing overflow for LayoutTable. Bug:807900 Change-Id: I68c415de59162a29b642ad697e7b8ab8dc19f530 Reviewed-on: https://chromium-review.googlesource.com/900044Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534175}
-
Alex Clarke authored
We provide a way for Headless C++ embedders to enable virtual time and override base::Time when the renderer is created (that's the only safe point to do so). We intend to implement something similar for Puppeteer at a later date. Bug: 777763 Change-Id: I267efcc9ed09245f19592237c8dbf8b28fd2d898 Reviewed-on: https://chromium-review.googlesource.com/894402 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534174}
-
https://skia.googlesource.com/skia.git/+log/68c5632d9216..dd3eca1fc5e7 $ git log 68c5632d9..dd3eca1fc --date=short --no-merges --format='%ad %ae %s' 2018-02-02 stephana [skqp] More args for skqp related scripts 2018-02-02 caryclark handle degenerate cubic loops 2018-02-02 reed add new gm for cmoposeshader 2018-02-02 halcanary SkQP: stop using global across jni calls 2018-02-02 csmartdalton ccpr: Don't use flat interpolation when it is slow 2018-02-01 robertphillips Disable texture strip atlasing for DDL Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I9a2d01ed50053d72bf05e9746a8d0b1dc542e9f1 Reviewed-on: https://chromium-review.googlesource.com/900091 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534173}
-
Dale Curtis authored
This reverts commit 2d7795fe. Reason for revert: DXVA resolution checks are for explicit w:h pairs, adding portrait prevents landscape from working... This needs to be reworked to return multiple supported profiles. Original change's description: > Add 4K+ portrait resolutions for the H264 and VP9 DXVA decoders. > > H264 is most affected since VP9 gets 4K portrait support by virtue > of supporting 8K decoding. This cl also adds 8K portrait mode > support for VP9. > > BUG=806568 > TEST=manually verified video in bug gets GpuVideoDecoder. > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I4c622e3d3e54c43f85c6d3af0d7624f66a0639b6 > Reviewed-on: https://chromium-review.googlesource.com/891670 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532710} TBR=dalecurtis@chromium.org,liberato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806568 Change-Id: I44fe795c02660f0aa8149bf1b9107a54eeb06923 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/900142Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#534172}
-
Hector Carmona authored
- Update a11y exceptions in edit_dictionary_a11y_test.js - Delete unused copy of edit_dictionary_a11y_test.js R=dpapad@chromium.org Bug: 807475 Change-Id: Id3b166b1e253c90d697e3b6752d48fefa52e717e Reviewed-on: https://chromium-review.googlesource.com/898488 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#534171}
-
Sergey Ulanov authored
Updated the script to use list comprehension, which is supported on all versions of python above 2.0 TBR=wez@chromium.org Change-Id: I8f7ffad323c40a51e77374c8baba40ebbf463061 Reviewed-on: https://chromium-review.googlesource.com/900132Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#534170}
-
Mike Dougherty authored
Remove exposed plugin API since all logic is now contained to a single file and it runs immediately upon injection. The unittests are now obsolete because no API is exposed. However, all previous unittest scenarios are covered by the PluginPlaceholderTestCase EarlGrey tests. Bug: 802344 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2f31af1fe9fa4f94f678064fe2a8cc316b837757 Reviewed-on: https://chromium-review.googlesource.com/899914 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534169}
-
Joone Hur authored
First, we need to enable Intel driver by building Mesa 17.0.2 with --with-egl-platform=surfaceless --with-dri-drivers=i965 BUG=733450 TEST=ozone_demo $ cd ~/git/chromium/src $ gn gen out/Release "--args=use_ozone=true ozone_platform_gbm=true use_intel_minigbm=true" $ ninja -C out/Release ozone_demo $ export EGL_PLATFORM=surfaceless $ out/Release/ozone_demo Change-Id: Ic560b2b4f36701f3c159fd35e771d04c2e1ec97e Reviewed-on: https://chromium-review.googlesource.com/886836Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#534168}
-
Jacob Dufault authored
Bug: 808486 Change-Id: If818ae74618847671f6f0ed2ecddb2ed804fa429 Reviewed-on: https://chromium-review.googlesource.com/900131Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#534167}
-
https://chromium.googlesource.com/catapult.git/+log/d7e6289f3f76..ec32a8f0bee7 $ git log d7e6289f3..ec32a8f0b --date=short --no-merges --format='%ad %ae %s' 2018-02-02 eakuefner [TBMv2] Add missing import in breakdown_tree_helpers Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibc55ee155417c819c277e2623c62b0abae8196c1 Reviewed-on: https://chromium-review.googlesource.com/899919 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534166}
-
Daniel Cheng authored
Since there are no sequencing guarantees when evaluating function arguments, it's possible that context could be dereferenced after the state has already been consumed by the move constructor. Bug: 805881 Change-Id: Ia23c0dc593a08d024392918dcb6988f6e07dd68d Reviewed-on: https://chromium-review.googlesource.com/900045 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#534165}
-
https://webrtc.googlesource.com/src.git/+log/1d0b9d04bd87..cc7125f2400b $ git log 1d0b9d04b..cc7125f24 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I30c799a50895f447dd19a39963600f462259354b Reviewed-on: https://chromium-review.googlesource.com/900061Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534164}
-
Danyao Wang authored
This is a reland of 091e44cb. It fixes the regression in WebUITestCase/testChromeURLBackAndForwardAndReloadNavigation. WebUI needs special handling in reload because calling [WKWebView -reload] simply reloads WKWebView.URL (which is an app-specific URL in this case) and results in a provisional load failure. The other suspected test failure (ContextMenuJsTest.LinkOfTextWithCalloutNone) is not caused by the original CL. It seems to be flaky. It failed again after the revert: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2532 and it failed before the original CL was checked in: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2504 Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692}t Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If0bb1c907472ec402931c69f347c9259907c4f28 Reviewed-on: https://chromium-review.googlesource.com/899916Reviewed-by:
-
Ian Vollick authored
Should have had a break; it got missed. Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I517d26a99ad55823b946a76865fa86c4a93ab3ca Reviewed-on: https://chromium-review.googlesource.com/899585Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#534162}
-
agrieve authored
This reverts commit bc25fa08. Reason for revert: Bot is running out of memory (see bug) Original change's description: > Increases link_pool from 3 to 8 for static and minimal_symbols android builder > > This is mainly for proguard steps which make build slow due to restricted parallelism on android_n5x_swarming_rel builder. > Example build traces from slow builds: > https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave954-c4/ninja_log.slave954-c4.chrome-bot.20180131-023634.24049.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351638 > https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave617-c4/ninja_log.slave617-c4.chrome-bot.20180131-021253.3583.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351634 > https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave980-c4/ninja_log.slave980-c4.chrome-bot.20180131-021148.4142.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351629 > > I investigate peak memory usage of some large/long time targets with args.gn of android_n5x_swarming_rel. > |--------------------------------------------------------+-------------| > | target | peak memory | > |--------------------------------------------------------+-------------| > | chrome_public_apk.proguard.jar | 843076 KB | > | chrome_public_test_apk__apk.proguard.jar | 995208 KB | > | chrome/android/monochrome_public_apk/classes.dex | 1178664 KB | > | lib.unstripped/lib_unit_tests__library.so | 3181252 KB | > | android_clang_arm/lib.unstripped/libmonochrome.so | 2718856 KB | > | android_clang_arm/lib.unstripped/libwebviewchromium.so | 2362328 KB | > |--------------------------------------------------------+-------------| > > So 4GB is sufficient. > I tested the builder by modifing base_export.h to run linker for many targets in https://chromium-review.googlesource.com/c/894928/4 > > Bug: 804251 > Change-Id: Ic5f985dba29d063a7541553813561f85c9dd3278 > Reviewed-on: https://chromium-review.googlesource.com/894928 > Commit-Queue: Takuto Ikuta <tikuta@google.com> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533547} TBR=dpranke@chromium.org,agrieve@chromium.org,tikuta@google.com,jbudorick@chromium.org NOTRY=true # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 804251, 808582 Change-Id: Iceb52c1bb4e506d9d7fa2eebfd8bdd6f67fa2722 Reviewed-on: https://chromium-review.googlesource.com/900063 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#534161}
-
Kevin McNee authored
We were substituting GFS events with GSE events when bubbling scroll from an OOPIF. This was done to prevent an OOPIF based guest from consuming a fling that is intended for bubbling (see crbug.com/770852). It seems that this can lead to an invalid input event stream. Fortunately, the main concern in that bug was with GestureScrollUpdates. The fling was a minor issue. The filtering of GSU events is still valid, so we only remove the GFS substitution. Bug: 770852, 806940, 802085 Change-Id: I647471ea4ff94396ef6e6af21fb89e1841a0eaf7 Reviewed-on: https://chromium-review.googlesource.com/899878Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#534160}
-
