GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1805a6699248..1a930646662a


git log 1805a6699248..1a930646662a --date=short --no-merges --format='%ad %ae %s'
2019-02-26 drinkcat@chromium.org HACK: Do not upload goma logs


Created with:
  gclient setdep -r src/third_party/chromite@1a930646662a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I3ea13d2ae2a296b9561d350ae5c8633f68fda64e
Reviewed-on: https://chromium-review.googlesource.com/c/1489455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635644}

Bug: 930926
Change-Id: I9f00d56238325d9b98b80756469ea8307b8ff594
Reviewed-on: https://chromium-review.googlesource.com/c/1488887
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635643}

Up from their faulty 2min timeout.

Bug: 933069
Change-Id: I3ecda356c30166a2267fef022379f341de704051
Reviewed-on: https://chromium-review.googlesource.com/c/1489309Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635642}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Patch is updating enum to @IntDef and upgrading @IntDef inside Cronet with form common with other Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I0ef5412d6fc0aaf48f860da286eb6c0995f0bcdc
Reviewed-on: https://chromium-review.googlesource.com/c/1477125Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#635641}

Following bot results are included.
15722 15734 15743 15752 15760 15769 15771 15778 15790

1 lines were removed and 2 lines were deflaked by consecutive
results since 15701.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: Id76a71e448f042038fa23ab31815e3253aa1214d
Reviewed-on: https://chromium-review.googlesource.com/c/1487431Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635640}

Bug: 923943
Change-Id: I0de67c1481a2396245725fe567af640344135826
Reviewed-on: https://chromium-review.googlesource.com/c/1484075Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635639}

Bug: 928772
Change-Id: I400d7905162643dc7e542812179dd3163e7a0581
Reviewed-on: https://chromium-review.googlesource.com/c/1489100
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635638}

Tbr: hiroshige@chromium.org
NoTry: True
Bug: 936083
Change-Id: I6dfc848edbaa6abe7624cd6763532f6b1564bb05
Reviewed-on: https://chromium-review.googlesource.com/c/1489427Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635637}

Bug: 935572
Change-Id: I4de12ad684bcc2b26138bf21aa1c73f76a554af9
Reviewed-on: https://chromium-review.googlesource.com/c/1489571
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635636}

Mark layout bar as translucent so it doesn't take up space when
we are hiding it.

BUG=935015

Change-Id: I85821d773728b73b7f867af6add4665b7f840cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1487831Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635635}

Resorting the code into snapshot method as to make easier to understand.
Now snapshot will effectively ask for a GetImage in case that the context
is ImageBitmapRenderer.

Adding some comments to html_canvas_element.h to explain the types of
contexts that can be into the html_canvas_element and adding future todo.

Adding test to validate that getDataURL works on the bitmaprenderer context.

Bug: 932266, 838108
Change-Id: I96aa25a3db624a2ddf457ae7349e345955e9ad50
Reviewed-on: https://chromium-review.googlesource.com/c/1481107Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635634}

Bug: 935277
Change-Id: I5992ec261fa91dc2809451a19850c4ac6813228e
Reviewed-on: https://chromium-review.googlesource.com/c/1487178Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#635633}

It's now used for device tests too, so the hard-coded references to
VMs are a bit out of place.

Bug: 866062
Change-Id: I78621e2c615307e3f05a78b5fe40366124a0541b
Reviewed-on: https://chromium-review.googlesource.com/c/1385004Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635632}

This is a multi-valued flag that allows forcibly downgrading the render
path to a different supported mode.  In the default case, the gvr
scheduler will choose the best supported mode.  This change removes the
ability to select a lower quality mode, ensuring that the best
available render mode is selected.

Bug: 932726
Change-Id: I2f374e8de18a11c777939158f393e9b90a22708c
Reviewed-on: https://chromium-review.googlesource.com/c/1487074Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635631}

Change-Id: Ie28c6659ff11b1f2137ffc53323b4569d5283965
Reviewed-on: https://chromium-review.googlesource.com/c/1487197Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635630}

The backend team has asked that we send the total count of files and
directories within archives. This CL adds this information to the
download ping for RAR archives.

Bug: 926586
Change-Id: Id24838c5984a72740ff3776dd26ef49965113d7b
Reviewed-on: https://chromium-review.googlesource.com/c/1487193Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635629}

Change-Id: I6972e64eccf682e9028dcf69991450dd3ecd8319
Reviewed-on: https://chromium-review.googlesource.com/c/1488019
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635628}

Postmortem Bug: https://monorail-staging.appspot.com/p/chromium/issues/detail?id=899293

Bug: 931710
Change-Id: I94c3e321d77890c59987894ce00f16a3d7ec2128
Reviewed-on: https://chromium-review.googlesource.com/c/1479910
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635627}

This patch improves the logic in PaintTextChild so that:
1. Move DrawingRecorder code after the check of
   ShouldPaintTextFragment and have_selection. This matches
   to InlineTextBoxPainter logic order, avoiding
   instantiation of DrawingRecorder if nothing are painted.
2. Check LayoutObject::IsSelected before
   ComputeLayoutSelectionStatus. This matches to legacy
   InlineTextBoxPainter, avoiding a few unnecessary function
   calls when there is no selection on the LayoutObject.

These are not the primary goal of issue 936024, but found
during the review and has positive impacts on blink_perf:
https://pinpoint-dot-chromeperf.appspot.com/job/1184c765340000

Bug: 936024
Change-Id: Idda53c9f41476d6024c6f5855594b3bd7dd35418
Reviewed-on: https://chromium-review.googlesource.com/c/1487432Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635626}

This configures cookie settings in the NetworkContext, based on
non-service code path (defined in WebView's CookieManager). This
refactors the cookie-path logic to a shared location in
AwBrowserContext.

Specifically, this configures the following:

 * save and restore session cookies
 * cookies should persist to disk

This also does some minor refactoring for the HTTP cache, for
consistency.

Bug: 933456, 933457, 902641
Test: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ib53d4cbab8ccdf2f916a256f6d549bea644b6611
Reviewed-on: https://chromium-review.googlesource.com/c/1385492
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635625}

This reverts commit 60cd9d98 now that we
don't need to work around the VC++ bug.

The array was subsequently changed from char[] to StringPiece so it's
not really a revert but an adding back of const to where it used to be,
with somewhat different semantics.

Bug: 934323
Change-Id: I821025578923e91218b8827d1d6cdd3553c252b2
Reviewed-on: https://chromium-review.googlesource.com/c/1484415
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635624}

Bug: 932135
Change-Id: I7a80eb9717914b2b092714146e2c15727cc9f546
Reviewed-on: https://chromium-review.googlesource.com/c/1477917Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635623}

Added test for supported patterns.

Updated AXPlatformNodeTest::Init to take from 1 to 12 nodes

Bug: 847971
Change-Id: Ifc40a52f8a3c6299616e8e75fc42222c007d6f00
Reviewed-on: https://chromium-review.googlesource.com/c/1488067
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635622}

Change-Id: I482f1700acd480dca9f5818762b2769a831f6c0e
Reviewed-on: https://chromium-review.googlesource.com/c/1488187
Auto-Submit: Jared Saul <jsaul@google.com>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635621}

This CL adds an accessibility text to SyncAndServicesPreferences that is
only used when this screen is opened from the sign-in screen.

Bug: 924359
Change-Id: I721a8e3c0c333f224a48e05f10ce67cd24dd2164
Reviewed-on: https://chromium-review.googlesource.com/c/1474667
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635620}

WebContentCaptureClient is an interface that is used by ContentCapture
to communicate with chromium's components peer, it provides methods to
- Check if ContentCapture enabled.
- Send the captured content to chromium peer.

This patch replaced ContentCaptureClient with WebContentCaptureClient
to avoid the unnecessary wrapper.

Bug: 924681

Change-Id: Icf22bfb416843888dfc3e63ed9a5b39103573fe4
Reviewed-on: https://chromium-review.googlesource.com/c/1468598Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635619}

This patch does not update fooder, i.e. the suggestion chips during
voice query.

Bug: 924624
Test: manual
Change-Id: Idaae11a321d0d7571aa4d1d4d467066bfc34c0f1
Reviewed-on: https://chromium-review.googlesource.com/c/1487799Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635618}

During the name fix flow, the cardholder name is empty at times (reason unknown,
but mostly because of sync)
In such a scenario, we should have the save card button on the dialog
disabled by default

Bug: 929421
Change-Id: I195422134a263bc201caec2059f4834f7476eb43
Reviewed-on: https://chromium-review.googlesource.com/c/1487144Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635617}

Manually import all WPT WebDriver tests without two-way syncing with the upstream
WPT Webdriver tests. This test suit will be maintained manually until the two-sync infrastrcuture
is created in the subsequently CLs.

The WPT WebDriver tests result in linux_rel roughly aligns with the result in upstream - https://staging.wpt.fyi/results/webdriver?label=master&product=chrome%5Bexperimental%5D&product=edge&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&aligned

No-Export: True
Bug: 881513
Change-Id: Ie25710416d611a819d643024de40d3ebde558997
Reviewed-on: https://chromium-review.googlesource.com/c/1459922
Commit-Queue: Kyle Ju <kyleju@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635616}

Fixes a race between sampling Now() on an idle content_unittests helper
thread and ~ScopedTimeClockOverrides. TSAN log:
https://paste.googleplex.com/6136256530481152

Attempt to avoid requiring TSAN suppression @
https://chromium-review.googlesource.com/c/chromium/src/+/1488877

R=kylechar@chromium.org

Bug: 910524
Change-Id: Ida3a3d8fe689a3d51a6f6f6d6870e2dca443f5d1
Reviewed-on: https://chromium-review.googlesource.com/c/1489297Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635615}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/178ac93d6e98..538f9f9de3d6

$ git log 178ac93d6..538f9f9de --date=short --no-merges --format='%ad %ae %s'
2019-02-26 metzman [libFuzzer] Remove extra semicolons

Created with:
  roll-dep src/third_party/libFuzzer/src

Bug: 935572
Change-Id: I747ed63183914e3bbd9f7039304e01c70f8c637f
Reviewed-on: https://chromium-review.googlesource.com/c/1489473
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Auto-Submit: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635614}

[Sheriff] Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-cyclic-invalid.html as failure on Mac

Bug: 935689
Tbr: xiaochengh@chromium.org
NoTry: True
Change-Id: I58d01d3aeac71a3fdeb6b18c5f13b26eac482b0c
Reviewed-on: https://chromium-review.googlesource.com/c/1489534Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635613}

Bug: 926235
Change-Id: I1c9f46a30392258e553a51d1033fde4d41e04210
Reviewed-on: https://chromium-review.googlesource.com/c/1489180
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635612}

Tbr: jdufault@chromium.org
NoTry: True
Bug: 936041
Change-Id: I902079d170183936b331d7d187baa2ec039748a0
Reviewed-on: https://chromium-review.googlesource.com/c/1489532Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635611}

Bug: 934227
Change-Id: I071dca790484580d1e499b9fe36e7f74aeb5cf42
Reviewed-on: https://chromium-review.googlesource.com/c/1489205Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635610}

Makes Primary Toolbar contain Location Bar to get the view events at
the correct times.
Also clears selection when the omnibox is disappearing to prevent the
selection handles from showing in the tab grid.

Bug: 823423
Change-Id: I848ee9b7ba00bf83614e20fbbd37fe971a92caa7
Reviewed-on: https://chromium-review.googlesource.com/c/1429989
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635609}

Change-Id: I1c2903e46e002a5a0f3bd3507563b56d66b6b7ea
Reviewed-on: https://chromium-review.googlesource.com/c/1484589Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635608}

This CL will rework the attaching logic for frame-based
MimeHandlerViewGuest. The notable change is the addition of a new public
API to RenderFrameHost which will (asynchronously) prepare the
FrameTreeNode for attaching an inner WebContents so that its usage with
the attaching API, WebContents::AttachToOuterContentsFrame is safe.
Previously this was achieved by navigating the current RenderFrameHost
to "about:blank" but that proved to have certain issues such as
navigation races as well as inefficient handling of the 'beforeunload'
handlers (from outside content layer it is nearly impossible to determine
whether a beforeunload modal is shown and is blocking the
navigation).

In summary, with this CL:
  1- There is no longer a need for a navigation to about:blank for
  every embedded PDF.
  2- There is no need for adding navigation throttles.
  3- beforeunload is properly addressed (an improvement over the
  previous approach of waiting for a timeout to decide navigation was
  actually blocked).
  4- Less lines of code and a more tractable attaching code.

Bug: 659750, 911161
Change-Id: Ib8981744b5683bb1cb8d557322bfc40f08bb4ccb
Reviewed-on: https://chromium-review.googlesource.com/c/1407596
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635607}

Bug: none
Change-Id: I36d0ac15f4852bada843e2bc4e4330f6f4c082d4
Reviewed-on: https://chromium-review.googlesource.com/c/1489240
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635606}

The current check fail message for ~TestBrowserThreadBundle can be augmented
by listing all pending tasks. This should make it easier to diagnose flakes.

I've seen this happen in ParentAccessServiceTest.NoValidConfigAvailable

Bug: 935515
Change-Id: If88ce656091ba4176cfdbf2c7313a7861b64379a
Reviewed-on: https://chromium-review.googlesource.com/c/1486352Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635605}