- 06 Jun, 2019 40 commits
-
-
Xiaocheng Hu authored
When a block ends with <br>, |NextWordPositionInternal| used to return BR@AfterNode as the next word position of BR@BeforeNode. This is incorrect as there's no visible position after a block's trailing BR, and therefore the caret ends up not moved. This patch detects this case and moves to the next block if we have reached the end of a block that ends with a BR. Bug: 968334 Change-Id: I277821ef5e85f54e080047750d1c54f68c4f4120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642035 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666577}
-
Kinuko Yasuda authored
This reverts commit 25552431. Reason for revert: In order to revert the culprit CL for MSAn failure (see https://chromium-review.googlesource.com/c/chromium/src/+/1647177) Original change's description: > Roll src/third_party/skia e0d90c84e42f..6b43c30cd702 (3 commits) > > https://skia.googlesource.com/skia.git/+log/e0d90c84e42f..6b43c30cd702 > > > git log e0d90c84e42f..6b43c30cd702 --date=short --no-merges --format='%ad %ae %s' > 2019-06-05 mtklein@google.com add mad_unorm8 instruction > 2019-06-05 mtklein@google.com use u32 in mul_unorm8 > 2019-06-05 mtklein@google.com tidy up register allocation > > > Created with: > gclient setdep -r src/third_party/skia@6b43c30cd702 > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jcgregorio@google.com > > Change-Id: Ieb1d0f381d488539549978a12e36fb9012d3c083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646895 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#666516} TBR=jcgregorio@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I0602aef6efe5a1810c37ec7b053628601c69df87 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646799Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666576}
-
Takuto Ikuta authored
bots adding CL is https://chrome-internal-review.googlesource.com/c/infradata/config/+/1362351 Bug: 954450 Change-Id: Iabc0c3f2aaecde421e6c25afd88e6e9525d3be8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645452Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#666575}
-
Chih-Yu Huang authored
This CL implements V4L2SliceVideoDecoder, which is aimed to replace V4L2SliceVideoDecodeAccelerator. BUG=941330 TEST=Run video_decode_accelerator_tests with local change Change-Id: Ib2ec460bf63bcc3c7c0e0b5ab200ca60a7f1cf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519907Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666574}
-
Ting Shao authored
Extend FakeNetworkURLLoaderFactory by making response headers, body and completion status configurable. Bug: 648295 Change-Id: Ib033ab617fb8efba8d3d81c9ea5651801a60a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595656 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666573}
-
tby authored
For some upcoming logging, we want to log some data most easily available from ash. However, we'd also like to log the subtype (history, bookmark, etc.) of an Omnibox search result. This is currently exposed via ChromeSearchResult::GetSubType. This CL replaces that, moving the data into ash::SearchResultMetadata, so that it's also exposed in ash and available for logging. Bug: 931149 Change-Id: Ieea7461e2f50a0c3503862bd73d03f4ad0b8cfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642909 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666572}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c84b2216ee6c..e86e1fed26da Created with: gclient setdep -r src-internal@e86e1fed26da The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I348d95585c7561dce6a86ff83bfc9457cd959ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647458Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666571}
-
Jihwan Marc Kim authored
So far, scroll-margin-*, scroll-margin-block-*, scroll-margin-inline-* are defined as simple length property in |IsSimpleLengthPropertyID|. But scroll-margin should not accept percentages, therefore these properties are removed from simple length property. https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-margin https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-margin-block The properties are only supported by Blink and Firefox, and Firefox already correctly rejects percentages: https://wpt.fyi/results/css/css-scroll-snap/parsing Bug: 930517 Change-Id: Iaf7286552a8b352c2901a42b8fadc83ce79c9077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640259 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#666570}
-
Sam McNally authored
Background pages must be non-persistent for extensions with this permission. Bug: 967262 Change-Id: Ice9f3070f98455c171123701ebacab5652141637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630377 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666569}
-
Sam McNally authored
The natively_connectable field is an allow-list for native messaging hosts allowed to initiate a native messaging connection to the extension. The native messaging host must still list the extension's origin in its allowed_origins manifest field for a connection to be allowed. Bug: 967262 Change-Id: Icddddcad8acc68d8169d82209736f93783dfaf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630074 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666568}
-
Luciano Pacheco authored
Change file list and file grid view to announce file selection changes when triggered by user input (keyboard, mouse and tap). The following actions are announced on selection changes, via aria-live: 1. Selecting a single file entry. 2. Selecting a range of file entires. 3. Adding a file entry to the current selection. 4. Removing a file entry from the current selection. 5. Selecting all file entries. 6. Deselecting all files entries. Add i18n translation support for these messages. Change ToolbarController, FileGrid and FileTable to receive an {A11yAnnounce} implementation to be able to send aria-live messages. Add getItemLabel to FileGrid, FileTable and FileTableList to be able to retrieve item's label based on the selection index to be able to add the item name/label to the aria message. Change test util RemoteCall.waitAndClickElement to accept modifier keys so we can send Ctrl and Shift modifiers for testing multiple file entry selection in FilesApp integration test. While here, change == and != to === and !==. Also call the constructor |super| instead of "cr.ui.table.TableList.prototype.mergeItems.call". NOTE: Add tests only for Keyboard and Mouse for now, because the touch emulation event isn't triggering file selections yet. Test: browser_tests --gtest_filter="*KeyboardSelectionA11y* : *MouseSelectionA11y*" Bug: 888636 Change-Id: I1bfdcf3987a7bcf8d29bfce6468c3b109f5fb239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638299 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666567}
-
Marijn Kruisselbrink authored
Permissions are still auto-granted, but this at least hooks up the various mojo exposed operations to check for read or write access. Bug: 878585 Change-Id: I99cfde0451adc87f39ae8314881d0671dd06a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636399 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#666566}
-
Yue Li authored
If the Assistant is disabled by dasher domain admin, disable the Assistant in settings and disallow user to enable it. Also update tests for opt-in flow and settings. AssistantOptInFlowTest.* in browser_tests Bug: b/130424602 Test: run CrSettingsGoogleAssistantPageTest.All and Change-Id: Ieb040d54f5cb9127d8bcaaf3e7b4eb825593eb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633649Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#666565}
-
Ted Meyer authored
Not used since background video track disabling has launched. Bug: 864331 Change-Id: I18e8c198f7f8a80cf95a1602ccad0eb11cbac1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644422Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#666564}
-
François Degros authored
Bug: 778674 Change-Id: I4f545b2c914adc2dff16489610f4134b062609e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647494 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666563}
-
Stefan Zager authored
Some bots -- Mac VM's in particular -- have constrained CPU resources, so they may run system timers slowly. This test only needs to distinguish between 100ms and 1000ms intervals, so we can still get sufficient coverage with the bigger tolerance value. BUG=971031 R=kinuko@chromium.org Change-Id: I40e90cb4a4f9140ee932142caf5cb7962e50b55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645164 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#666562}
-
Anand K. Mistry authored
When the user opens the SMB Add Share dialog, an inderminate progress bar is shown under the share URL field to indicate share discovery is happening in the background. This bar disappears when discovery has finished. BUG=945188 Change-Id: Id4ef414f20f317d580a78d0a8f7caa70d53cee38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644541 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666561}
-
Will Cassella authored
The base::UmaHistogramTimes makes the need to have separate instantiations of SessionTimerImpl for each histogram unnecessary. This CL merges all of those into a single class (SessionTimer). Bug: 789758 Change-Id: Ifc9dede14fe6c9becc8e2acd43cfb000fa334e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643500 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666560}
-
François Degros authored
Bug: 778674 Change-Id: If91d9b6de12f4a66e7b929d200835c4242341122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646829 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666559}
-
François Degros authored
Bug: 778674 Change-Id: If2d9f1db2c103b89cf8919141cf29cfbbaed9e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646828 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666558}
-
François Degros authored
Bug: 778674 Change-Id: I210459cd62fca98836ad40f66bd011da4c412b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646796 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666557}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/900e4713287f..c84b2216ee6c Created with: gclient setdep -r src-internal@c84b2216ee6c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790671,chromium:790669,chromium:790667,chromium:790665,chromium:790663,chromium:790662,chromium:968231 TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I43cde67518ca6b137dbf7ea7ff6f370fa8f93739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666556}
-
Alex Danilo authored
This CL adds success/failure state indication to the feedback panel items. Also adds property setters and attribute handling to control the visual presentation of the indication state. If the state indicator is set to something invalid, it defaults to the circular progress indicator to keep the layout from collapsing on the left hand side of the panel. Bug: 947388 Change-Id: I8712619f15963dfd931cb277064132ec82efb1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634572Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666555}
-
Charlie Reis authored
Bug: None Change-Id: I6ba28908cb1a662ae97dc4db6284f47fd4e1355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646856Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Charlie Reis <creis@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#666554}
-
Mike Jackson authored
This test was disabled when the IncrementalShadowDOM flag was turned on, since it relied on the timing of the UpdateDistribution phase of ShadowDOM, when dumping out the elements tree. This change proposes that we force a style recalc in the test, to ensure that the appropriate DOM domain events are sent and processed by the front end. (e.g. ChildNodeCountUpdated, DistributedNodesChanged, AttrModified, etc). Bug: 840238 Change-Id: I90207b8109c951e7c7b826cbce1b8f9e28143351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638851 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#666553}
-
Andrew Comminos authored
Given a v8::CpuProfile from a blink::Profiler, constructs a trace object with appropriate cross-origin resource filtering and substack caching. Bug: 956688 Change-Id: Ib41877f18efee83b75cf7be549b4141943e6ba55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629334Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#666552}
-
Giovanni Ortuño Urquidi authored
As a first step towards using new primitive types, replace internal use of Proxy and Target with Remote and Receiver. Bug: 968369 Change-Id: Ib37130094c9ec85ac8d0f8346910c00764519cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636255 Auto-Submit: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#666551}
-
Alex Danilo authored
CL:1631149 disabled two integration test for checking if the FilesApp can make the browser open a file that has been content sniffed as text/plain (e.g. if the file has no filename extension). This CL re-renables those tests as this is working correctly for browser display. Bug: 772600 Tests: Enabled integration tests again. Change-Id: Ia6ec09e5b9c3fcf541a95c3906afa8f3ee4533a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645133Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666550}
-
Marijn Kruisselbrink authored
No prompting for permissions is implemented yet, so all permissions are always denied unless chrome was launched with --enable-experimental-web-platform-features. This implements the plumbing/ground work on top of which prompting and a more complicated permission model will be added. Also operations don't actually check if permissions have been granted, that too will be added in a follow-up CL. Tbr: jbroman Bug: 878585 Change-Id: I2325fdcebbc3ccf1f688b101f01fd5b20437d3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636471 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#666549}
-
François Degros authored
Passed to ExitParser's constructor an object that actually implements the expected interface MetadataParserLogger. Change-Id: Ifad809c2bed7d334c62fc4ecd1c244d5ef218c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646795Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#666548}
-
Ahmed Fakhry authored
Per PM/UX request, when a minimized window is dragged to another desk, it should show up in the mini_view, and should be unminimized in the target desk after it has been move to it. Otherwise, the experience will be confusing since it will just disappear once dropped. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=971417#c2 BUG=971417 TEST=Manually, added test. Change-Id: I9da54f39cad662080a54c4e234254fb7ef651c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647187 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#666547}
-
Maggie Chen authored
Those header files are not used in gpu_watchdog_thread.h nor gpu_watch_thread.cc Bug: 949839 Change-Id: I08c38f2edf9d3de5462f03280c2f087e0fae549e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647175 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666546}
-
Yue Li authored
Only sync status at the first init to prevent unexpected corner cases. Bug: 960509 Test: Manual Test Change-Id: I5f21f9467f6ee39a722b665a08c6e16c25141dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643610 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#666545}
-
Tommy Steimel authored
This CL adds logic to hide the System Media Transport Controls on the lock screen unless the media is currently playing. If media is playing on the lock screen and is then paused, we want to hide the SMTC after 5 seconds. Bug: 970353 Change-Id: I9fae652594381de05338ba0947fd18eed6ff7573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643733 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#666544}
-
Kristi Park authored
- Combine the mv-tile and mv-tile-container elements. - Combine the icon img and the icon container elements. - Remove the mv-title-container div. - Remove extraneous selectors from some CSS rules. Bug: 969818 Change-Id: I78d3c068fd70efc3d0f62555f2af8503e6f58bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644462Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666543}
-
Kenichi Ishibashi authored
This is similar to crrev.com/c/1630085 but for shared worker. Don't rely on the shadow page when creating WorkerSettings. Bug: 538751 Change-Id: I9d508fa5ec85d80ee1e0d38cf59e21e7323bea45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631245 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#666542}
-
Antonio Gomes authored
Posted tasks are expected to be invoked once. Hence the use of CrossThreadBindOnce is appropriated. BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: Ifdec982750fcb4179baa1936232e89c2ef74a743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646073 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666541}
-
Aaron Colwell authored
- Added logic to allow CreateForURL() to return a default SiteInstance for URLs that do not need to be isolated. - Added a --enable-default-site-instance command-line flag to turn on this new functionality so it isn't on by default yet. This flag allows the full set of changes needed to support default SiteInstances to be spread across multiple CLs. - Updated tests so they can pass when --enable-default-site-instance is specified. Bug: 958060 Change-Id: Ie3f9297f31f5c2e5803c2c27aa809b1541b4d76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612025Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#666540}
-
Alex Danilo authored
CL:1631149 disabled the integration test for checking if the quickview panel in FilesApp can display content in a file that has been content sniffed as text/plain (e.g. if the file has no filename extension). This CL re-renables that test as this is working correctly for quickview. Bug: 772600 Tests: Enabled integration test again. Change-Id: I69bf2feefe5e28860dfd62a47593cb179256bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644856Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666539}
-
Peter Kasting authored
This will make it more feasible to replace child_count() with children().size(). This has a large number of followon effects. Bug: 956419 Change-Id: I2c4d1700571a7cd00cef926beb525661c7073e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636254 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#666538}
-