- 01 Dec, 2017 40 commits
-
-
Maxim Kolosovskiy authored
Bug: 699530 Change-Id: I6325ed2be5868d519c5b0d0cb720d09e7b80da4d Reviewed-on: https://chromium-review.googlesource.com/759792 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521018}
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::LinesBoundingBox()| to work with LayoutNG by utilizing |NGInlineFragmentIterator| to collect box fragments associated to |LayoutInline|. This patch also changes |ShouldCreateBoxFragment()| to return |true| for producing box fragements for plain SPAN to avoid using "culled inline box", which is collected by traversing descendants of layout tree. Note: Exclude master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia71db55d551a8ee8e5e36019ab94e7fb18479198 Reviewed-on: https://chromium-review.googlesource.com/768599 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521017}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dabac34e. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6555 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=qyearsley No-Export: true Change-Id: I6f3b9d5038ac5bf49a87c119a402e62bcfe2a84c Reviewed-on: https://chromium-review.googlesource.com/803116 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521016}
-
sczs authored
Adds a Toolbar Button that will be used to contract the toolbar/omnibox. The contract button is only shown when the Toolbar is expanded. A simple animation is used. Currently the button has no functionality, that will be added in a follow up CL. Screenshot: https://drive.google.com/open?id=1UIiS-Y1JTKwuU7lrQACtDK8RL1g10_7K Bug: 790763 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf2d7e3b866c2f87f7346556f41328ba19044bfd Reviewed-on: https://chromium-review.googlesource.com/802831 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521015}
-
Christos Froussios authored
We now have a general implementation for dedicated TaskRunners for OSCrypt's backends. The custom threading implementation for KeyStorageKeyring can be removed and replaced with the general one. Bug: 782851 Change-Id: I61b0df8568504d4160bbcce7301e99fbdb86609a Reviewed-on: https://chromium-review.googlesource.com/804094Reviewed-by:
-
Xing Liu authored
Currently it's flaky on Android, other platforms seem fine. Disable for now for further investigation. Bug: 786626 Change-Id: I1399f8212ab3a6c58959032313301b6f8d4a3714 Reviewed-on: https://chromium-review.googlesource.com/804134Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521013}
-
Tom Anderson authored
BUG=787223 R=dpranke@chromium.org Change-Id: I1c3aada842bba899c20d5e2c1b0dceb818f118d2 Reviewed-on: https://chromium-review.googlesource.com/784093Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521012}
-
rbpotter authored
Also add a test to verify, and only show rasterize checkbox on non- Windows/Mac. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I430f138db14cbe2e456023ba93292ddbd5c49dbe Reviewed-on: https://chromium-review.googlesource.com/802356 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521011}
-
rbpotter authored
All observers of print job notifications have this notification commented with don't care, and don't do anything with it. Remove. Bug: None Change-Id: Ia669135a311ad1fc3090bb7de974c4a0718a4d0a Reviewed-on: https://chromium-review.googlesource.com/802755Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521010}
-
Nathan Bruer authored
Overrides will now change projects before the navigation happens allowing it to rewrite requests when navigating cross-origin. R=caseq,lushnikov,einbinder BUG=754371 Change-Id: I0201a2a714c06bc7d4babb59e6d02b51c8e1f5e3 Reviewed-on: https://chromium-review.googlesource.com/799682Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#521009}
-
Greg Thompson authored
This reverts commit a75a06d7. Reason for revert: DCHECK in WebServiceWorkerRegistrationImpl::OnConnectionError being hit on Windows debug interactive_ui_tests; see https://crbug.com/790935. Original change's description: > [ServiceWorker] Detach lifetime of SWRegistrationObjectHost from SWProviderHost > > This is a follow-up of > https://chromium-review.googlesource.com/c/chromium/src/+/773452. > > After this CL: > - SWRegistrationObjectHost lifetime is strongly bound on its binding > set, and independent with SWProviderHost lifetime. > - the mapping in SWProviderHost does not own SWRegistrationObjectHosts > anymore and has only one functionality: reuse registration object > host per registration id. > - The complex lifetime management of WebSWRegistrationImpl brought by > https://chromium-review.googlesource.com/c/chromium/src/+/732998 > becomes simpler, there is only one destruction scenario now: > Blink GC removes all references to |this|, |this| closes > SWRegistrationObjectHost Mojo connection causing the > content::SWRegistrationObjectHost in the browser process destroys > (closes SWRegistrationObject Mojo connection), then |this| is > deleted by the error connection handler. > > BUG=758151 > > Change-Id: I21c0f0eef7e93f723e2a37ec02f1c43bf84385bf > Reviewed-on: https://chromium-review.googlesource.com/778360 > Commit-Queue: Han Leon <leon.han@intel.com> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520479} TBR=falken@chromium.org,kinuko@chromium.org,rockot@chromium.org,yzshen@chromium.org,shimazu@chromium.org,leon.han@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758151 Change-Id: I843abecbab693cae6484477cfadcf0d98e12b4ad Reviewed-on: https://chromium-review.googlesource.com/803516Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521008}
-
Min Qin authored
There is no reason for this class to be RefCountedThreadSafe. All the posted tasks doesn't needs to be member functions. And the scoped_refptr could get deleted after DownloadManager is destroyed. This causes flakiness shown in https://chromium-swarm.appspot.com/task?id=39ca6d4e03fa4210&refresh=10&show_raw=1 Also switched to use RunLoop as QuitWhenIdleClosure() is deprecated. BUG=754679 Change-Id: I7eb5084b4f623929e2553487c6eec34352e72c98 Reviewed-on: https://chromium-review.googlesource.com/794832 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521007}
-
Klaus Weidner authored
Add a wrapper around SlidingAverage that uses TimeDelta instead of integer microseconds, and use that for timing calculations in VrShellGl. Get the nominal vsync interval based on the display refresh rate in AndroidVSyncHelper and use that instead of the last interval in timing heuristics, this avoids glitches when the last interval is a >1x multiple of the expected interval due to dropped frames. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8fa9c46560f6aed80aa6457f98aee63d0c4706e Reviewed-on: https://chromium-review.googlesource.com/797236Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521006}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=rch@chromium.org Change-Id: Ia760b6366e6434d821476c23999963ddc5553a36 Reviewed-on: https://chromium-review.googlesource.com/799533Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521005}
-
Scott Graham authored
Failing on tree. LastUsedDateForDisplay is returning "Last used over a year ago", rather than "last used Nov 30" as of today, Dec 1. NOTRUE=true TBR: sebsg@chromium.org Bug: 791067 Change-Id: I7bb1deeb3a7fa7439c9e15bbe8d3e47951091a7b Reviewed-on: https://chromium-review.googlesource.com/803657Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521004}
-
Matt Menke authored
Do this by moving ProxyConfigService creation and ownership from the legacy IOThread/ProfileIOData classes on the IO thread to a new ProxyConfigMonitor class, which lives on the UI thread and is owned by the new SystemNetworkContextManager and ProfileNetworkContextService classes. Chrome's ProxyConfigService now sends messages to the network stack over a Mojo pipe from the UI thread over to the IO thread (or the network process) instead of plugging directly in to the ProxyService on the IO thread. This effectively adds support for non-PAC proxy configurations when the network service is enabled. This CL also makes NetworkContext default to using direct connections, instead of the system proxy configuration, both to ensure a NetworkContext can always successfully be created, and because it's more sandbox friendly. Included in this CL because without it, tests fail on Linux and ChromeOS when the network service is enabled, because the legacy in-process URLRequestContextBuilder can't create a ProxyConfigService on those platforms. Bug: 754007 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I537514ae8bf3726b3215bcf9b9b27f2d8ae2a951 Reviewed-on: https://chromium-review.googlesource.com/760538 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521003}
-
edchin authored
The infobar controller needs a base view controller, from which to present the accounts selector. Bug: 785319 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If1e4b70f58d0cb47b83524f064039cc1e2c2d607 Reviewed-on: https://chromium-review.googlesource.com/802457Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521002}
-
Brian White authored
Turns out that there are cases where a process has started exiting (and thus can't be terminated) but still isn't ready to be reaped. Thus, a wait timeout is required in this case as well. Bug: 757946 Change-Id: Iaf79092a991200c14d321963d9a20bfc191867bc Reviewed-on: https://chromium-review.googlesource.com/803837Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#521001}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f6b946d71d43..6c5a1c4c3c97 $ git log f6b946d71..6c5a1c4c3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ifbf62979680ab39ce29ee6aaca4ffb346adfd581 Reviewed-on: https://chromium-review.googlesource.com/803860Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521000}
-
Christos Froussios authored
We want to show a basic error message to the user, if exporting the passwords to the filesystem fails. Bug: 789561 Change-Id: Ieff5a590dd882374494c3d23c2aef0ff89734545 Reviewed-on: https://chromium-review.googlesource.com/803484 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Balazs Engedy authored
This ensures that in browser tests where the sync state is toggled off and on in quick succession, the first AffiliationBackend instance will have always closed the affiliation database before the second instance tries to open it again. Bug: 786157 Change-Id: I9dc724fc198c95de15ae6d877a298695162d80c3 Reviewed-on: https://chromium-review.googlesource.com/803494Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#520998}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1980f10ff2b8..1f0d1fda6db8 $ git log 1980f10ff..1f0d1fda6 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 thestig Encapsulate CPDF_Type3Char members. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifcdb5c4e858f06870e6705b5a527c4ed66c26320 Reviewed-on: https://chromium-review.googlesource.com/803896 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520997}
-
Tom Sepez authored
This allows the readlink call to trap into a broker process rather than being denied inside a sandbox. Bug: 715679 Change-Id: Id03f45b298ba3c09de9a9b8ac3afc93a368bb4d5 Reviewed-on: https://chromium-review.googlesource.com/795012Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#520996}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/54a29ffd82e7..361df070323f $ git log 54a29ffd8..361df0703 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 jiawei.shao ES31: Implement Geometry Shader resource queries on OpenGL 2017-11-20 jiajia.qin ES31: Add atomic counter buffer data size 2017-11-30 jmadill Vulkan: Implement basic TexSubImage2D. 2017-12-01 xinghua.cao Refactor: replace SamplerType with ShaderType 2017-11-29 yunchao.he Code refactoring for angle::BitSet and EXPECT_GL_TRUE/FALSE. 2017-11-28 oetuaho Clean up storing struct types in the symbol table 2017-11-24 oetuaho Reset symbol unique id counter between compilations 2017-11-30 jmadill Vulkan: Clean up VAO cached resources. 2017-11-30 jmadill Vulkan: Implement a RenderPass cache. 2017-11-30 jmadill Vulkan: Remove std::vector arg from beginRenderPass. 2017-11-28 oetuaho Refactor TStructure 2017-11-28 oetuaho Clean up MatchOutputCodeTest usage 2017-11-27 fjhenigman docs: fix links and typos 2017-11-27 jmadill Add a gl::AttribArray helper type. 2017-11-27 jmadill Isolate GlslangWrapper header from most of ANGLE. 2017-11-28 geofflang Add extra warnings for narrowing and bool conversion. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I82d6d11b95432db1c045a71da4022d66669bab8d Reviewed-on: https://chromium-review.googlesource.com/803859Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520995}
-
Kevin Bailey authored
And fix exception unsafe code. Bug: Change-Id: Ie09069136196c7987b1838cb453f6babec767561 Reviewed-on: https://chromium-review.googlesource.com/803856Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#520994}
-
Kurt Horimoto authored
This allows its settable state to be updated via the ChromeBroadcaster. This CL also updates ChromeBroadcastObserverBridge classes/tests to no longer include tab strip visibility. Bug: 785663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic928bc902ef21fb403ab35bc60432dcbcb002bed Reviewed-on: https://chromium-review.googlesource.com/802317Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#520993}
-
Fabio Tirelo authored
Bug: 776538 Change-Id: If7988655050a3415d77fa551cbf9fff617d6a69d Reviewed-on: https://chromium-review.googlesource.com/794531Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#520992}
-
edchin authored
Bug: 790924 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5cc7e7ce0c848619867832eca6e8e7d807617a69 Reviewed-on: https://chromium-review.googlesource.com/802760Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520991}
-
Adrienne Walker authored
Alignment code was showing up in paint op serialization perf, so this patch makes alignment explicit instead of implicit. Callers that know that their writes are already aligned aren't forced into extra work. DrawRectOp serialization is 6.2x faster and deserialization is 2.2x faster. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5678c0510c3200eff496c07a6fbb88e70054b27b Reviewed-on: https://chromium-review.googlesource.com/798470 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520990}
-
Stuart Langley authored
This CL lays the groundwork for removing WFT::WeakPtr and replacing it with base::WeakPtr. Note: WTF::WeakPtr is already just an alias for base::WeakPtr, so there is no change in functionality. WTF::WeakPtrFactory wraps base::WeakPtrFactory and is using "USING_FAST_MALLOC" but I don't see this type being explicitly new'd up, so I don't think changing to base::WeakPtrFactory is of any consequence. Changes in the CL: - Update presubmit script to allow base::WeakPtr & base::WeakPtrFactory from blink code. - Update all the DEPS files to allow "base/memory/weak_ptr.h" to be used from blink code. - Make changes to some files in (core|modules|platform) to use base::WeakPtr(Factory) to validate above changes. - In places remove "platform/wtf/WeakPtr.h" where it's no longer used in the file. - In places where base::WeakPtr was already being used but it was transitively included, fix the includes. - Where we are now using base::WeakPtr(Factory) use base:: to lookup the right WeakPtr. The subsequent CL will remove WTF::WeakPtr. I was going to try and do it all in 1 CL but it got too big to review. Bug: 789697 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifce07560e5da85b007696989c50229134458f4ea Reviewed-on: https://chromium-review.googlesource.com/801410Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#520989}
-
Dale Curtis authored
The previous change 973509d4, which added querying of stream latency, incorrectly uses the device id for querying the stream latency. We must instead, first query the list of stream ids and query the latency of a given stream. While there may be multiple streams, we can't do anything with that information; e.g., to handle that case we would need to attempt to synchronize all streams to the highest latency. Apple instead recommends just taking the latency of the first stream since that will cover the majority of cases. BUG=783282 TEST=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I98b65b1fa7030f63abbb6d96c7540352d1bb896b Reviewed-on: https://chromium-review.googlesource.com/802194Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#520988}
-
Sergey Ulanov authored
CastMediaShlib::Initialize() was calling logging::SetLogItems() and chromecast::InitCommandLineShlib(). On Fuchsia the media backend is compiled statically with cast_shell, so these calls make little sense. Removed them. Bug: 772488 Change-Id: Ia7ec535e9afc891f00dd32f3a1e179d36707b092 Reviewed-on: https://chromium-review.googlesource.com/801351Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520987}
-
Takumi Fujimoto authored
This removes the extension_view_wrapper view that hosted the extensionview route controller. This also removes the MediaRouterUIRouteController feature that was used for enabling/disabling the WebUI route controller; it will now always be enabled. MediaRoute's custom_controller_path attribute will be removed in a separate patch. Bug: 787588 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I47ac68774dc47d4574125b0ba7730c7567443332 Reviewed-on: https://chromium-review.googlesource.com/775553Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#520986}
-
Hiroshige Hayashizaki authored
Now that ScriptResource is used only in DCHECK()s in V8ScriptRunner, this CL removes ScriptResource entirely from V8ScriptRunner. V8ScriptRunner no longer needs to check the consistency between ScriptResource and other arguments, which is/should be checked by its callers instead. This is preparation for removing ScriptSourceCode::Resource(). Bug: 788828 Change-Id: Id41e634b384e04ab2881c317b1f5e661c6026954 Reviewed-on: https://chromium-review.googlesource.com/786533 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520985}
-
Kurt Horimoto authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c19a4f3cdc8cdf00ade25bf76280fbb957f071d Reviewed-on: https://chromium-review.googlesource.com/802622 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Groups textfield methods so that overrides are together and are marked. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If47169cccf774f51b86776e3084ba99283808d30 Bug: 788636 Reviewed-on: https://chromium-review.googlesource.com/758850 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Joshua Bell authored
Now that [SecureContext] works with interfaces, resolve some TODOs and align the implementation of NavigationPreloadManager with the spec. Change-Id: I6a8d156182112ee972eb4720e7fa478e784e73bc Reviewed-on: https://chromium-review.googlesource.com/802620Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#520982}
-
Peter Beverloo authored
A connection is now always obtained through one of the navigation:* interface providers, so it doesn't have to be in this one anymore. Bug: 595685 Change-Id: I280dfce5d876329baff8f469790ded8b320ae7ca Reviewed-on: https://chromium-review.googlesource.com/796412Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#520981}
-
Christos Froussios authored
Dbus, which we use to communicate with KWallet, requires to be called on a dedicated thread. Bug: 782851 Change-Id: I7c55c0c6cec03d3cf688b6f1ad60326e4d5f417f Reviewed-on: https://chromium-review.googlesource.com/803481 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
edchin authored
Bug: 785394 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia69c6d950726b4e6a7d5559865102e06ac2db372 Reviewed-on: https://chromium-review.googlesource.com/802623Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520979}
-
