GitLab

Bug: 991989
Change-Id: Ib1e4102664a9be9e110199e386c31aaae7271702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743732Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685243}

Follow-up to https://crrev.com/c/1733793. We can remove the #include
statements as well.

Bug: 990490
Test: N/A
Change-Id: I4703be8307d2bb744179eec8a0e110ba5e292fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743061
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685242}

This reverts commit 3ce9f4d8.

Reason for revert: Broke browser_tests on win-asan bot.

https://ci.chromium.org/p/chromium/builders/ci/win-asan/6832

Original change's description:
> Make ResourcePrefetchPredictor use correct NetworkIsolationKeys.
> 
> ResourcePrefetchPredictor was always using the origin of the initial
> page being navigated to in constructing the NetworkIsolationKey.
> With this CL, it uses the origin it expects the page to redirect to
> instead.
> 
> Bug: 987735
> Change-Id: Ic66c33bb5f99a9a00485ffe46c70e0947e0e430b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730782
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685173}

TBR=pasko@chromium.org,mmenke@chromium.org,tbansal@chromium.org

Change-Id: I7af5589722eafc8a0157c639acb357e8d28ae0bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 987735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744512Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685241}

Bug: 986322
Change-Id: I282d1f1fd87ee03394857a21c612ba8d1be987b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736361Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685240}

This reverts commit c3311e2b.

Reason for revert: Chromium OS can continue to use the std::deque version, since it checks out this directory at a specific commit. Chromium can revert to using the circular_deque variant.

This means that there will be a transitional discrepancy between MidiMessageQueue implementations in Chromium and Chromium OS, but
those should be resolved once libchrome in Chromium OS gets uprev-ed.

BUG=chromium:787643
TEST=None

Original change's description:
> midi: Use std::deque for MidiMessageQueue
> 
> For the purposes of this class, the semantics of circular_deque and
> std::deque are the same. Switching to std::deque will make this class
> easier to re-use outside of Chrome, by reducing its dependency on
> src/base/containers.
> 
> BUG=chromium:701005
> TEST=MIDI works on Chrome.
> 
> Change-Id: Iae83c69ef85682fbde75e6078cd5eb262b9f4082
> Reviewed-on: https://chromium-review.googlesource.com/784010
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518599}

TBR=toyoshim@chromium.org,pmalani@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:701005
Change-Id: Id061ff49297b1b40b3e0417ad3022e744a7c2fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743035Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Prashant Malani <pmalani@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685239}

This method was only used for reseting the background.

Bug: None.
Change-Id: I64b35e1832cf739324230d1b4e5460a18d83d0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719831
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685238}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I3fc53be382f582d7eb482058fb24a6b5b2afe485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744279Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685237}

An <input type='url'> should have LocalizedControlType of "url"
per https://w3c.github.io/html-aam/#el-input-url

Currently its LocalizedControlType is "edit".  This change updates it
to the correct value by adding an entry to
BrowserAccessibility::GetLocalizedStringForRoleDescription().

Bug: 990386
Change-Id: I92cee38c5fb0b9c81229cb6070784271187f4154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733202Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#685236}

Callers of this method seem to only care whether the effective
SameSite is None, so just give them that.

This is for prophylaxis of subtle bugs that may arise from
GetEffectiveSameSite now possibly returning different values if called
at different times.

Bug: None
Change-Id: If2c9cd38f2be41d039b144e1af6a043f799ab0da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743131Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685235}

https://webrtc.googlesource.com/src.git/+log/efffd0a5fa22..940c2b500589

git log efffd0a5fa22..940c2b500589 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 gustaf@webrtc.org AEC3: Reduce level of log messages
2019-08-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5744654b..498f5876 (685023:685149)
2019-08-08 tommi@webrtc.org Remove MediaTransport from Call.
2019-08-08 asapersson@webrtc.org Update test::CreateVideoStreams to use configured scale_resolution_down_by if set.
2019-08-08 oprypin@webrtc.org Delete shim of PRId64 et al. on Windows
2019-08-08 nisse@webrtc.org Change return type of of ReceiveStatistics::Create to unique_ptr.
2019-08-08 sprang@webrtc.org Remove unused fallbacks in PacedSender
2019-08-08 peah@webrtc.org Removing unused fallback variant for the reverb computation
2019-08-08 tommi@webrtc.org Call Call::GetStats() from the correct thread in ProbingEndToEndTest.
2019-08-08 tommi@webrtc.org Call Call::GetStats() from the correct thread in VideoSendStreamTest.

Created with:
  gclient setdep -r src/third_party/webrtc@940c2b500589

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:none
Change-Id: I19e1508a1421f78de872effd98f1a13c8456331e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744275Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685234}

This is to be followed by a move of this file to Blink.

Bug: 704136
Change-Id: Ib75c46e895b585cc6da84d67c5d9388551df0d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744426Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685233}

This crash could possibly happen since we are clearing out the downloads
in OnDownloadRemoved rather than OnDownloadDestroyed. The destroyed is
a super set and is safer to use.

Bug:991621

Change-Id: Id90e8b259b36a3886ff16cd321363e25c81a6c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742530Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685232}

This class will handle the interactions with FCM, routing messages to the
appropriate callback, and managing the lifetime of the InstanceID token.
At the moment, the InstanceID token is created and never deleted, but in
the future we may want to manage the lifetime of the token.

Bug: 980784
Change-Id: I605affb03cd2e01eb258b15ebdc147b15a022a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731542
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685231}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d88a2079b485..fa26b6523911


Created with:
  gclient setdep -r src-internal@fa26b6523911

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I272225f8fb4e9ff13316a5376c3e432384dc02a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744273Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685230}

This reverts commit 88f1169d.

Reason for revert: Was not the cause of a flaky test failure, see: https://crbug.com/990692#c7.

Original change's description:
> Revert "Paint non-fast scrollable regions for resize handles"
> 
> This reverts commit 0c4a415f.
> 
> Reason for revert: reverting to see if this is causing consistent failures on Linux MSan Tests, browser_tests, DevToolsSanityTest.TestDeviceEmulation (timeout)
> 
> Original change's description:
> > Paint non-fast scrollable regions for resize handles
> >
> > Non-fast scrollable regions are regions on a cc::Layer where the
> > compositor should not handle scroll events. These are primarily for non-
> > composited scrollers but are also used for resize handles and plugins.
> > This patch paints non-fast scrollable regions for resize handles.
> >
> > The interesting code change is in ScrollableAreaPainter::PaintResizer
> > where we now emit a ScrollHitTestDisplayItem for resizers. This fixes
> > a class of bugs such as non-fast regions being on the wrong cc::Layer
> > (https://crbug.com/968691) and having the wrong offset
> > (https://crbug.com/989038).
> >
> > Design doc:
> > https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj
> >
> > Bug: 864567, 968691, 989038
> > Change-Id: I8193077279617418433306912d712c31d99149f3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730521
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Commit-Queue: Philip Rogers <pdr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#683670}
> 
> TBR=pdr@chromium.org,chrishtr@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 864567, 968691, 989038, 990692
> Change-Id: I1986b58522d7658109155e811419a6d3ae1d2dbd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736702
> Reviewed-by: Chris Sharp <csharp@chromium.org>
> Commit-Queue: Chris Sharp <csharp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683991}

TBR=pdr@chromium.org,csharp@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864567, 968691, 989038, 990692
Change-Id: I40cfb1cb50e2487d6f0dac74fd20292dcfb8a786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744277Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685229}

Bug: 988538
Change-Id: I2d15cd3634332d39538f7f9d084db62bc9db50a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731758Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685228}

Change-Id: I932940a233e7e92c6474d4d3d85c69e92eae8eb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739158Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685227}

This should make the builders more resilient to LKGM updates when no
SDK is available at the version for one of the multiple boards we use.

Bug: 921048
Change-Id: I6084e7238c4b57d182ea945417f93a7e6ca45106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739112Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685226}

No change to logic. This removes obsolete references to kNetworkService
now that this feature is enabled by default. This cleans up the
corresponding include macros as well.

Bug: 989104
Test: run_android_webview_unittests (tests still pass)
Change-Id: Icf4f2d5821c90f95fc1cd7f3619355f8ff8c4ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737821
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685225}

Add logging for daily refresh toggle/enabled to the RP.

Bug: 984752
Change-Id: I4c401a92b9ff41f769d1f95b4cae6deec23dfae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729065
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685224}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a062e707..0fe515a8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8d455d2da7ea252114a3ea2d2f77b5aab8945c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744049Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685223}

This change adds a menu for the Native File System write permission in
chrome://settings/content. This permission controls whether sites are
allowed to ask the user for permission to save to the original file that
the user previously selected using the Native File System API.

Bug: 982904
Change-Id: I97bdedaed31cfff6c54b6c2a89efdb374f0b2951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696390
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685222}

This CL turns on by default support for sites to lazily load <img> and
<iframe> elements by specifying "loading=lazy".

This CL also changes automatic lazy loading to by default get restricted
to lite mode users only, to more closely match what will be launched,
and updates the default distance-from-viewport loading threshold for
"Unknown" effective connection types to match the "4G" values, since
"4G" is the most common effective connection type.

Bug: 990967
Change-Id: I5ea3a5f03acc38b8d3475a847c14075e78cc1d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740307Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685221}

Bug: None
Change-Id: Iad4bf594dbc90c9e246d43fe9729e4b56fed9679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740128Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#685220}

https://android.googlesource.com/platform/external/perfetto.git/+log/07dff948a085..b307d657e8b7

git log 07dff948a085..b307d657e8b7 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 treehugger-gerrit@google.com Merge "Use noice-json-rpc for the extension to communicate with devtools"

Created with:
  gclient setdep -r src/third_party/perfetto@b307d657e8b7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3172b428cecdb8b3029bfe59045dafa792bf12a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744276Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685219}

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
https://github.com/w3c/csswg-drafts/issues/4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685218}

This CL sends scrollend event if GSE is being
handled on the main thread after the snap (if
the snap has started after GSE). It also takes
care of sending scrollend event for snap after
fling.

Bug: 907601
Change-Id: I21aba5d098b25ddc765d78a7792ec8a2fb7987cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743253Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685217}

The WebUIListener type is referenced in WebUIListenerBehavior, so export
it and import it in the behavior.

This is to prevent a closure error when compiling modules that use the
behavior, specifically:
gen/ui/webui/resources/js/web_ui_listener_behavior.m.js:19:
ERROR - [JSC_UNRECOGNIZED_TYPE_ERROR] Bad type annotation.
Unknown type WebUIListener
     * @private {!Array<!WebUIListener>}


Bug: 965770
Change-Id: I442a476b178fbbcab75de551b2501f9481b61125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743249Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685216}

These are now equivalent to if this is the default (Google) NTP.

Bug: 869931
Change-Id: Iac37cb3584da352215128b4077ae75999e98d937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730588Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685215}

Some crashes happen in WebFramesManagerImpl::OnFrameBecameAvailable,
probably due to a lifecycle issue of WebStateImpl/CRWWebController.
When these classes are destroyed, WebFramesManagerImpl::OnWebViewUpdate
should be called and callbacks for JS messages should be unregistered.
However this might not be true according to crash reports.

Use WeakPtr in WebFramesManagerImpl for callbacks should help suppress
crashes, and we need further investigation to fix the lifecycle issue
and revert this patch.

Bug: 990842,991616,991950
Change-Id: I746c53eaa920bd96d6820edd563d2b7f94f7eb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742135Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685214}

This adds the inteended launching arm of LightweightNoStatePrefetch to
the field trial testing config file based on experimental results so
far.

Bug: 934466
Change-Id: I86fac0798ae0cf8cfc539c65386761f41c4d6c94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742516Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685213}

Show debug borders for DC layers (red for overlay, blue for underlay)
with --show-dc-layer-debug-borders flag.  The debug borders are drawn
at an offset for visibility.  This will be useful for debugging webgl
overlays.

Also includes minor cleanup in the non-root render pass path.

Bug: 939658
Change-Id: I88ae03444b92e4fcfbd3d332ce68a862431c4c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730296
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685212}

Moved unit test delegate to general test launcher tests
to share results file parsing.

Added test for unit test delegate and test launcher to
launch 3 tests, and validate their results.

Windows versions prior to Windows 8 required a new flag
'dont-use-job-objects' to avoid unsupported nested job objects.

This test is more comprehensive, and also tests
the gtest xml results parsing of the delegate.

Bug: 936244
Change-Id: I28afe983f8960c366f9b61a22c05103b32fafaa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732885
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685211}

Properly set the GLSurface size.

Bug: 990535
Change-Id: If5d5cc513693463d994d07f5361996db795f4a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742208Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685210}

TBR=blundell@chromium.org

Bug: 942244
Change-Id: I720e5b692a8c6e785811e8547a889c916973e16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739977
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685209}

Bug: 951969
Change-Id: Ia7c033604400393c55dea4d2895f5a2d320264d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710886
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685208}

Both this and PreviousOnLineInlineNG had the same typo, but
PreviousOnLineInlineNG was fixed in r659579
(http://crrev.com/c/1608867).

Unlike http://crrev.com/c/1608867, unfortunately this does
not seem to have a test coverage.

Change-Id: I707884c83e9c5bf711def37ceee888a294409e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739235
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685207}

A few methods in Map and Vector classes (and private classes)
miss the override keyword. This can break compilation.

This CL adds override keyword to those methods.

BUG=728870

Change-Id: If518719dd7a06a9474a8f4691302a7af5fdd4a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742131
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685206}

Bug: 983940
Change-Id: I6e590a6464a880eb5cac2f1b587cb43b0f2a860f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735465Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685205}

As part of preparation for adding secure remote powerwash command, change the
remote command infrastructure so it supports receiving secure remote commands.

Design doc go/cros-secure-commands

TBR=pbond@chromium.org

Bug: 967383
Change-Id: I8da7b6d7195331fb071418ba91bb1ffe499a6b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731894
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685204}