- 21 Oct, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91b5a03b..56dc7021 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I390276168fe6863094fa2a81e653a45ca643dccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871894Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707957}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::EngineFileRequests interface. Bug: 955171 Change-Id: Ia3c314bb521e11a60c3562b976f4a70870977a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852248Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#707956}
-
Martin Kreichgauer authored
While at the CTAP layer, the excludeList parameter is optional, omitting it is equivalent to sending an empty array. Furthermore, an absent PublicKeyCredentialCreationOptions.excludeCredentials at the Blink layer is translated into an empty list at the Authenticator mojo interface (where the corresponding field is non-optional), which demonstrates that we don't care about the distinction anyway. Note that while previously, a present-but-empty CTAP excludeList was marshaled into an empty CBOR Array (inside `AsCTAPRequestValuePair(const CtapMakeCredentialRequest& request)`), this CL changes it to be omitted instead. Change-Id: I8cb72be56351057766c83eb097f9c780fb1567ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867385Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#707955}
-
Nicolás Peña Moreno authored
This CL removes window.location.href usage in element-timing tests and uses window.location.origin instead, which makes the pathname computation cleaner. It also adds t.step_func where it is missing. Change-Id: Iabaac33eb65f9ed24f68e7fa583c8de05d1264c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872762Reviewed-by:
Tom McKee <tommckee@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707954}
-
Jordan Bayles authored
This patch uncomments out and updates/fixes the ChromeUdpSocket class, part of Open Screen's embedder platform code. Change-Id: Ia66f2e92336f99202b33be7c2636f805e2e0dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851230Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#707953}
-
Philip Rogers authored
We recently learned that Compositing.Renderer.GPUMemoryForTilingsInKb is a pre-existing metric tracking GPU tile memory which makes TileManager.TilesGPUMemoryUsage redundant. Bug: 1008942 Change-Id: I56826b3d79a6bfad070201bddca1d22b6013b03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842509Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707952}
-
Anastasia Helfinstein authored
There are 7 flags owned by the Accessibility team that expired before M79. Of these, two are unused and being removed; three are still under active development and are being extended substantially; and two still contain code that needs to be launched and/or cleaned up, and are being extended through M79 to allow a few weeks to wrap up the current state. Bug: 1016510 Change-Id: If6160da6897dff5f1af282f2c92e4cafc60aa40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863470Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#707951}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5b6f3adef16..5f192c2cad99 Created with: gclient setdep -r src-internal@5f192c2cad99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I8ca23f3c9146e611593807f831b825a7e6adf842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872749Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707950}
-
Yue Zhang authored
This CL adds a class for testing mult-window related operations in GTS. It only contains one test case so far for GTS without group enabled. Will add group related tests in a later patch. Bug: 983170 Change-Id: I36761705effba417abbcb715c8e4bbb6c2b266dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857604Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707949}
-
Kevin Bailey authored
Adds a fuzzer for parsing search suggestion JSON results. Change-Id: Idd83201c62cb36d22251442d94fdeb7a84470abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866605 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#707948}
-
Nicolás Peña Moreno authored
This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at https://github.com/WICG/element-timing/pull/38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707947}
-
wutao authored
In embedded Assistant UI experiment, we will move the web view to its own container. This cl is the first part to add the container. A follow up cl will handle the back arrow. Bug: b/141268413 Test: new unittest Change-Id: I9d3b9663b7a60f02e9f50e0076d9c342c299d8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837294 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#707946}
-
Francois Doray authored
This is our only histogram to ensure that first run startup performance doesn't regress. Bug: 975341 Change-Id: Id99f2638f1fd0714bfb673d36801982ff125ce40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872314 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#707945}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/80bbce361517..dd6606f6cee7 git log 80bbce361517..dd6606f6cee7 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 treehugger-gerrit@google.com Merge changes I60caeb0a,I217ed568 2019-10-21 chiur@google.com Merge "Add new MeasureUnits for GpuCounterDescriptor" 2019-10-21 eseckler@google.com Merge "processor: Make metrics an optional compile-time dep" Created with: gclient setdep -r src/third_party/perfetto@dd6606f6cee7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I113c3282b6f314715ae39b32bfdcff4f2e91c569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707944}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d578b2973f62..8c61f5295030 git log d578b2973f62..8c61f5295030 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 yyanagisawa@chromium.org cros_chrome_sdk: stop using host pkg-config. Created with: gclient setdep -r src/third_party/chromite@8c61f5295030 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I94b5b00bdd182264f0ae4517dcb9023232c12db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872750Reviewed-by:
-
Yue Li authored
We have different specs for modal dialogs on device with smaller screen. See the bug for more information. Bug: 1012793 Test: Manual Test Change-Id: Iee662c6c0fb04afb0d00614262cac7002395b1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868093 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This reverts commit ffe8de71. Reason for revert: Branch point has passed. Original change's description: > Reland "Disable use_dawn for the branch point." > > Original change's description: > > Revert "Disable use_dawn for the branch point." > > > > > This flag controls the inclusion of Dawn and the availability of WebGPU > > > which we want to keep limited to Canary for now. > > > > > Bug: chromium:985142 > Change-Id: If23eeb89a3130eafe1def72e293d60c0bd0222e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867091 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707156} TBR=kbr@chromium.org,cwallez@chromium.org,kainino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:985142 Change-Id: I913a829a911296f1e1c437a72e8eb976dbefeb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872640 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707941}
-
Manas Verma authored
If the user is definitely opted-in to the new auth flow, Payments sends a list of instrument IDs in the GDFGRP call, and Chrome makes the final call on whether CVC or WebAuthn should be shown. Logging whether CVC or WebAuthn is prompted. Bug: 949269 Change-Id: I4239d7b0c7d029889a0c44a35bdcd41493feba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812099 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#707940}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b74d5548a435..4f50bdda1019 git log b74d5548a435..4f50bdda1019 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-21 mtklein@google.com remove SkBitmapProcState::fInvKy 2019-10-21 senorblanco@chromium.org Dawn: fix rendering to mipmapped textures. 2019-10-21 mtklein@google.com remove SkBitmapProcState::fInvType 2019-10-21 kjlubick@google.com [canvaskit] Include CodeReviewSystem on JSON uploaded 2019-10-21 fmalita@chromium.org [skottie] Add DataURI image support in utils/tools 2019-10-21 mtklein@google.com remove unused SkBitmapProcState fields 2019-10-21 fmalita@chromium.org [skottie] Frame-index seek API (seekFrame) 2019-10-21 jvanverth@google.com Metal: adjust framebuffer size by contentsScale. 2019-10-21 herb@google.com Use common fallback code for drawing an SkGlyphRun 2019-10-21 kjlubick@google.com [CanvasKit] More Paragraph things 2019-10-21 senorblanco@chromium.org Dawn: don't pretend to support 565, 4444 or Gray_8 pixel configs. Created with: gclient setdep -r src/third_party/skia@4f50bdda1019 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ia1600c7bf3fd6775dd5421e632e98d841a3978d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872751Reviewed-by:
-
John Abd-El-Malek authored
This is needed for embedders to calculate metrics. Change-Id: Id804dab8eea8e55eebdde52f0aa44157e9a7be5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869339 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707938}
-
Corentin Wallez authored
libdawn is deprecated and was split in libdawn_proc and dawncpp so each could be used separately. Make Chromium use the split targets so the temporary libdawn group used for backwards compatibility can be removed. BUG=dawn:22 Change-Id: I2db79b5b14c12b10111bd03bf66ca2692c07c200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869209Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#707937}
-
Philip Rogers authored
In crbug.com/1012775 we are unifying how trivial 3d transforms are handled across platforms by making them not a compositing hint. This caused performance regressions in tough_animation_cases, tough_canvas_cases, and tough_scrolling_cases which were using trivial 3d transforms as a compositing hint. This patch updates these tests to be more explicit about layer triggers by using "will-change: transform". Bug: 1012775, 1016320 Change-Id: Ia2978b867e439bbffa173da747cda7ecd5a9f2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872743 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707936}
-
Philip Rogers authored
The DoNotCompositeTrivial3D flag has changed many performance tests (e.g., twitter, see crbug.com/1016343). To reduce the chances of breaking real sites, I would like to switch to rolling this out via a (forward) finch experiment. This patch switches the flag to be disabled-by-default, and I will enable this via finch. TBR=chrishtr Bug: 1012775 Change-Id: Ifc9cf670fb95b48995a5072f95eea1e3c570c063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872659Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Remove FrameHostMsg_DidContainInsecureFormAction and FrameHostMsg_DidDisplayInsecureContent legacy IPC messages and replace them we new mojo APIs on the LocalFrameHost interface. BUG=1008432 Change-Id: I84258d4175466f89c0a288196a75889ffddd102d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872452Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#707934}
-
Eric Willigers authored
Bookmark apps are no longer created in views tests using extensions-specific code. Bug: 966290 Change-Id: I9596d498421d6d5d180861bad2969d369f159cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865741Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#707933}
-
Francois Doray authored
Failure log https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904107524722548848/+/steps/browser_tests__with_patch_/0/logs/Flaky_failure:_TabManagerTest.TabManagerBasics__status_CRASH_SUCCESS_/0 shows error when navigating to WebUI pages. Since the test doesn't depend on navigating to a WebUI, this CL changes it to navigate to a simple test page. Bug: 997719 Change-Id: Ifcc53fb9d4df5f144e99c2e9c9eaf41614778c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869480Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#707932}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3ad81b16a00a8226641458a793618302ae90e31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872748Reviewed-by:
-
Francois Doray authored
These histograms will be used to assess the impact of fully launching tab freezing in M81. Bug: 986508, 986510 Change-Id: Iaed38a46e755d231872355d0a866c0c09bdff499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872291 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
Ella Ge authored
The test was flaky with RunLoopFor. Make the test_environment use MOCK_TIME and FastForward. Bug: 992784 Change-Id: Ie54cf62078fc994b68d921692ddbc672581dddf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869395Reviewed-by:
-
Miriam Zimmerman authored
Previously, https://crrev.com/c/1863363 changed the describedby tag so that "File will be sent to google for debugging" is read along with the upload selector. However, with that change, the text is also read when a screen reader navigates to the next item. Mark the label as hidden, so screen readers skip it when navigating. (But not when reading the description of the "Choose File" button.) TEST=Load onto an eve, navigate with screen reader. BUG=chromium:1005528 Change-Id: If693cdc2f5cd434d5d4def7a1482399fd108d2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869560 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707928}
-
Elly Fong-Jones authored
The flag 'unsafely-treat-insecure-origin-as-secure' was being used in this test to test the behavior of ORIGIN_LIST_VALUE_TYPE flags; that made it impossible for that flag to expire or be removed without breaking the test. This change: 1) Introduces about_flags::testing::SetFeatureEntries() to override the flags list for testing purposes 2) Has AboutFlagsBrowserTest use it to set the flag set to a single test flag. As a side-effect, this hugely speeds up this test suite since the page now contains far less data. 3) Undoes a bit of confusion in the tests: they treated "switch" and "flag" as synonyms throughout, which is not correct. A followup change will fix https://crbug.com/1010678 and re-enable these tests on the bots. Bug: 1010678 Change-Id: I91f39fb8b3e000a824d8cf85fd3daa51d9a247af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872318 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#707927}
-
Ken Rockot authored
This removes util.cc/h from the leveldb service's client library. This is the last bit of remaining code from the service apart from LevelDBDatabaseImpl itself, which will be simplified and moved into the Storage Service as a wrapper around DomStorageDatabase. The utility functions here are used almost exclusively in tests, and are all trivial. In many cases their use can be eliminated by proving the surrounding APIs (e.g. taking spans instead of vectors, or introducing a more robust key/value type) or by inlining direct use of base and STL APIs which essentially solve the same problems. For now, their definitions have been duplicated in the few places they are used. Bug: 1000959 Change-Id: I568ac5d829b643d332783faddffa2bc63685e211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868847Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707926}
-
Tommy Li authored
This CL makes the Remove Suggestion button only appear on hover. It also prohibits showing the Remove Suggestion button when the Tab Switch button is visible. I did this because it insert the X on the far-right on-hover, since it shifts the Tab Switch button. Additionally, it seems like if the user has the tab open, it's not important to offer to delete that suggestion. The user is still clearly interested in that content. Bug: 1014788, 929477, 1205 Change-Id: I49684914e94ce5d6e884597c3d3b0bb612c5ebfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869555Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707925}
-
Brian Sheedy authored
Temporarily switches the GPU Win10 Intel experimental builder to trigger tests on the stable driver version so that the existing bots with the older experimental driver can be upgraded to the newer version without a loss of capacity. TBR=kbr@chromium.org Bug: 1016459 Change-Id: Ie50166147eadb89a7b4f970ddd21cbd9b5a4e7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872742Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Ken MacKay authored
Change-Id: I3d09f627e3e3e808ecf5a288c39d048bf3a34852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872128Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#707923}
-
Elly Fong-Jones authored
This layer of delegation originally existed to allow for both Cocoa and Views versions of this dialog to share logic. Since the Cocoa versions are now gone, the remaining logic can be folded into the Views versions. This change: 1) Adds ExternalProtocolHandler::Delegate::OnSetBlockState, to allow tests to listen directly for block state changes; 2) Folds the body of ExternalProtocolDialogDelegate into ExternalProtocolDialog; 3) Removes ProtocolDialog (interface only) and ExternalProtocolDialog (interface & implementation) 4) Reworks the ExternalProtocolDialogDelegate browser tests to test "one layer up" - instead of using a test delegate for the dialog, they use the normal production behavior of the dialog, but hook into the ExternalProtocolHandler system at the ExternalProtocolHandler::Delegate layer. This provides better fidelity to the production behavior in the test and simplifies the tests considerably. Next steps here: As the ongoing DialogDelegate refactor proceeds (see https://crbug.com/1011446), ExternalProtocolDialog will shrink further until it contains only Accept and Cancel. Bug: None Change-Id: I90518f8086db4127d41776ad086210c6db9d7462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872411 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707922}
-
Ella Ge authored
This CL marks InputEventPrediction.Accuracy metrics obsolete and also removes related code. The Accuracy.Scroll.* metrics is replaced by new prediction metrics introduced in crrev.com/c/1764409 Mouse* and Touch* are lack of use now so they are safe to remove. Similar new metrics will be add for Mouse/Touch too. Bug: 988625 Change-Id: Ic86de9e27c370f7ea5f6b01880b899ff11fd6867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849093 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Adrienne Walker authored
In http://crbug.com/957175, wanderview@ added an optimization for BlobReader where it would add an extra hop when finishing a stream. Many blobs size mojo::DataPipe to exactly fit the blob size, and so this can be quite common. As SourceStreamToDataPipe is going to be used in this CL (https://chromium-review.googlesource.com/c/chromium/src/+/1830360), that optimization needs to be carried forward. Bug: 1012869,957175 Change-Id: I9f7fc006b633a248fe3b726ac78d1fe4773472a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862253Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#707920}
-
John Lee authored
Bug: 989131 Change-Id: I2245020cc33911dfba7e1bc1942168c3321b5e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869338 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#707919}
-
Maksim Orlovich authored
This reverts commit a88c5fe6. Reason for reland: The test was/is flaky on that bot in the first place, the name change just makes it look different. Original change's description: > Revert "Adjust tests for upcoming cross-site cookie requirements" > > This reverts commit 83b71438. > > Reason for revert: SitePerProcessSSLBrowserTest.UnloadHandlersArePowerful* > failing on Android. Please see bug. > > Bug: 1014956 > Original change's description: > > Adjust tests for upcoming cross-site cookie requirements > > > > They will need to be marked explicitly and secure, so adjust some tests to > > be over SSL and mark those cookies appropriately > > > > Bug: 1006816 > > Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Maksim Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706108} > > TBR=avi@chromium.org,morlovich@chromium.org > > Change-Id: I982bc1590171f92883000c8315d3be77f7b35b9f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1006816 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865249 > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#706453} TBR=avi@chromium.org,parastoog@google.com,morlovich@chromium.org Change-Id: I51c863c89ade36edddc4b1b7a3f16d82c9f855f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014956, 1006816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866614Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#707918}
-
