GitLab

Add "DirectCompositionPreferNV12Overlays" feature flag to use NV12
for creating overlay swap chains when NV12 hardware overlays are
supported.

Bug: 869677
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I50ad546e1f0e3cdc27a1c3dad74f52d91f6555e6
Reviewed-on: https://chromium-review.googlesource.com/1159838Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581986}

Renames existing old Function to CallbackFunctionTreatedAsScriptValue
in *.idl so that we can introduce new Function type that is type of
|any ()|.

Function type is now defined in core/dom/common_definitions.idl,
and v8_function.{h,cc} are now code-generated (not yet used
though).

Bug: chromium:871208
Change-Id: I395c49e5d664cec14ad3b29653b10c4bb000f4fe
Reviewed-on: https://chromium-review.googlesource.com/1166931Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581985}

This function is being removed and currently always returns true.

While this mode was enabled, the bubble alignment was effectively
ALIGN_EDGE_TO_ANCHOR_EDGE and paint type was PAINT_NONE. This change
reflects that and cleans up a ton of code to paint and place the
arrows that are no longer visible.

Since images were only used when paint type was not PAINT_NONE related
arrow and shadow images are also removed.

Bug: chromium:867557
Change-Id: I22f9abcf55867bebb00d857324fdf6d7aeaccbc3
Reviewed-on: https://chromium-review.googlesource.com/1168108
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581984}

This is a reland of af3a6bdc31c29746d749ba0ab9e7181c49c11642

Original change's description:
> Omnibox Refresh UI: Hide placeholder text when keyword is selected
>
> Previously, when a keyword was selected, i.e. "Search Yahoo", we would
> still show the placeholder text in the Omnibox when unfocused, like:
> "Search Google or enter a URL".
>
> That is plainly not applicable to the selected keyword case. We don't
> need to show placeholder text at all when there is a selected keyword,
> since the selected keyword label itself gives ample instruction to the
> user.
>
> Bug: 872327
> Change-Id: I84fd06964808554e5c606d2f2f371bea9c44b465
> Reviewed-on: https://chromium-review.googlesource.com/1168506
> Reviewed-by: Kevin Bailey <krb@chromium.org>

TBR=krb@chromium.org

Bug: 872327
Change-Id: I978f264d1d37b883e6e75b460b923573b01ada61
Reviewed-on: https://chromium-review.googlesource.com/1169931
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581983}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I47c41909035edd1b5424fe8314914692249eca81
Reviewed-on: https://chromium-review.googlesource.com/1170302Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581982}

This is just a reland of crrev.com/c/1167474; it got reverted
due to infra issues (Gerit outage), see crbug.com/872722 and/or
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/YnUEOtzCrzs

TBR=fserb@chromium.org

Original CL description ------------------------------------------------

This CL simplifies OffscreenCanvasResourceProvider:

- Removes the unused member variables |width_|, |height_|
 and |frame_provider_|.
- Removes superfluous method Reshape().
- Forward declares a few data types ISO including files.
- Uses early return for easier indenting.

This is inspired by junov@'s crrev.com/c/1103011 (in the follow
up CL crrev.com/c/1167907 I'll fold OffscreenCanvasResourceProvider
into CanvasResourceDispatcher, but it's easier to review in two
steps).

Bug: 839970
Change-Id: Ic4d3a6002cec32c01e8914a11d3c392981dae8b5
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1167474Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1169829Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581981}

As the comment in nss_profile_filter_chromeos.h by mattm@,
remove CertNotAllowedForProfilePredicate and use labmda in the
client.
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I601067a66f04827e5da361b90e939f67468a8b24
Reviewed-on: https://chromium-review.googlesource.com/1165262Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581980}

Some test expectations have been already removed in r545969, but have
been in the meantime readded in r550463.  Some test expectations were
missed and were left in place in r545969.  Some tests are still failing.

FWIW, the affected tests pass when run 20 times locally.

Bug: 794631
Change-Id: I22ae64eab4a82c92542b65d6d336fa3832742091
Reviewed-on: https://chromium-review.googlesource.com/1169916
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581979}

It's got a second e in it. Like in POSIX!
http://pubs.opengroup.org/onlinepubs/007904975/functions/creat.html

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2de5f0d0031b6faa2eae9eca234778e6315b10f3
Reviewed-on: https://chromium-review.googlesource.com/1169870Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581978}

A QuicChromiumPacketReader::StartReading() should only be called once.
It will read again automatically when the previous read result has been
processed. Calling StartReading on a started reader may break the
invariant and cause bugs like http://crbug.com/872011

Bug: 872011
Change-Id: I6dde0a3daacb9ed9b6d7d4781de3c132e0a6aad7
Reviewed-on: https://chromium-review.googlesource.com/1166340
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581977}

$ git log 2d9a32526..714bf84e5 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 alanbaker Split mode setting opcode validation into new file.
2018-08-08 alanbaker Split annotation opcode validation into new file.
2018-08-08 alanbaker Replace asserts with returns
2018-08-08 alanbaker Split debug opcode validation into new file
2018-08-03 alanbaker Move type instruction validation into separate file
2018-08-08 31666470+s-perron Validate the input to Optimizer::Run (#1799)
2018-08-03 alanbaker Unify validation of OpCopyMemory*
2018-08-03 alanbaker Refactor where opcodes are validated
2018-08-07 shartte When clang is used as a MSVC frontend (clang-cl.exe) it does not behave exactly as GCC would. I.e. -Wall translates to /Wall, which is an alias for -Weverything. This causes massive C++98 compat warnings logspam. (#1808)
2018-08-07 dj2 Remove unused bit stream methods. (#1807)
2018-08-07 dj2 Simplify MoveToFront (#1806)
2018-08-07 dj2 Fixup readabilty/inheritance warnings (#1805)
2018-08-07 dj2 Fix readbility/braces warnings (#1804)
2018-08-03 dj2 Cleanup includes. (#1795)

Created with:
  roll-dep src/third_party/SPIRV-Tools/src

Bug: 870510, 870571, 870681, 871065, 872572

TBR=dneto@chromium.org

Change-Id: I6e50c26fb10368a912c9f7e95b12dd789f0bf5f5
Reviewed-on: https://chromium-review.googlesource.com/1169129Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581976}

This CL adds x-frame-options headers support for network service. It is
similar to what ChromeResourceDispatcherHostDelegate::OnResponseStarted()
does which is for the case when network service is not enabled.

Bug: 852877
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0a66d6c4f8e91ee05baa00e918480653653b635b
Reviewed-on: https://chromium-review.googlesource.com/1157524Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581975}

Optimize to only send SSLInfo from network service on top-level requests.
Changes GetURLLoaderOptions to only set
kURLLoadOptionSendSSLInfoWithResponse when |is_main_frame| is true and
sets new default to kURLLoadOptionNone.

This also makes a change in WebContentsImpl to fetch SSLInfo only on
main frame navigations.

Bug: 787535
Change-Id: Ie4a929ba90e4c358d111e174a3c399298f22b5f3
Reviewed-on: https://chromium-review.googlesource.com/1148239Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581974}

Change-Id: Ia4f0ccf2a9c896d21f299606adfad6904457984f

Bug: crbug.com/871407
Change-Id: Ia4f0ccf2a9c896d21f299606adfad6904457984f
Reviewed-on: https://chromium-review.googlesource.com/1164065Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581973}

Previously, opening a browser tab would cause Assistant UI to hide.
Now, we'll remain open but go into mini UI mode.

In mini UI mode, we'll show the active query (if there is one) in lieu
of the default prompt string. Stylus behavior remains unchanged.

This CL also adds an AssistantContainerLayout to serve as the layout
manager for AssistantContainerView. This was done to setup for
additional motion specs as well as to fix a crash.

See bug for demo.

Bug: b:112376466
Change-Id: Ia920f3c2509eb6f255d5eb6d508dfb650383773b
Reviewed-on: https://chromium-review.googlesource.com/1168654
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581972}

This is a reland of 7aaa0d3df4a9d7d7c24b8f20d8362e76e1569e16
No code change.
Previous revert is due to Gerrit outage http://crbug.com/872722

Original change's description:
> Pass advanced protection bit to AccountInfo via DiceReponseHandler
>
> When DiceResponseHandler retrieves refresh token, update the AccountInfo
> to reflect the advanced protection status of this Gaia account.
>
> Note, incognito mode sign-in behavior is not changed.
>
> Bug: 866620
> Change-Id: Ib70f9056b565476bf2a7293255eaffa503ca9682
> Reviewed-on: https://chromium-review.googlesource.com/1159470
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>

TBR=msarda@chromium.org

Bug: 866620
Change-Id: I3fe1ef45690ab17cb00754deb9b7f8778fb08aca
Reviewed-on: https://chromium-review.googlesource.com/1169926
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581971}

This is a reland of 04b716f7

Original change's description:
> ChromeOS OOBE: Add Welcome screen animations.
> 
> This Cl replaces static images with animations.
> 
> Bug: 852038
> Change-Id: I8185420aed0ed23c080ac0bc7a2270d3ac4c5b7b
> Reviewed-on: https://chromium-review.googlesource.com/1166590
> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581735}

Bug: 852038
Change-Id: I50659b137bc2e4c1facb7a3b3b734e1a1d3a6500
Reviewed-on: https://chromium-review.googlesource.com/1168328Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581970}

Bug: 872052
Test: SplitViewTabDraggingTest.ShowNewWindowItemWhenDragStarts
Change-Id: Ib7a563d350fb5d789495518b414f7a319bc9063b
Reviewed-on: https://chromium-review.googlesource.com/1168592
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581969}

Shipped in M64, this feature allows developers to selectively enable
and disable use of autoplay through the feature policy HTTP header
or the <iframe> "allow" attribute.

https://chromium-review.googlesource.com/831520
https://www.chromestatus.com/features/5100524789563392

BUG=788390

Change-Id: I0f4346bc75dc922c8004f0008921d68a5a3beede
Reviewed-on: https://chromium-review.googlesource.com/1166614
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581968}

This is used to ensure that ExternalBeginFrameSources have a unique
|source_id| after the GPU process is restarted.

Bug: 871755
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic5d6066fa2bcdee3c796f9f56967ffcd51e230f1
Reviewed-on: https://chromium-review.googlesource.com/1165888Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581967}

Bug: none
Change-Id: Icf7f6223f2f3e9c652d5d3dcacf7f652869490a5
Reviewed-on: https://chromium-review.googlesource.com/1169767
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581966}

The full list of isolated origins might include sensitive info in
upcoming field trials, so show the number of isolated origins instead
of actual list.

Bug: 872375
Change-Id: I944919cc9ce2afa953bbca77a489c9df62105ab8
Reviewed-on: https://chromium-review.googlesource.com/1167962Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581965}

When AddOrReplaceEntry() posts a UpdateDownloadDB task, RemoveEntry()
could be called before the posted task to get a executed.
This will cause the DCHECK to fail.

BUG=872279

Change-Id: I90c19a66814b050ef4cded72ee35380790d16d4c
Reviewed-on: https://chromium-review.googlesource.com/1169979Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581964}

Also move the function and its helpers to ModuleCache.

BUG=803276
TBR=dcheng@chromium.org
TBR=wittman@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/1166206Reviewed-by: Mike Wittman <wittman@chromium.org>
Change-Id: I28ad62df7a3f2f597f1a4f36069c51b541e7dc29
Reviewed-on: https://chromium-review.googlesource.com/1169533Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581963}

Bug: b/112431554
Test: Manual
Change-Id: I10e52dad59b2989fe9ba223b3c8cf130143ea9b8
Reviewed-on: https://chromium-review.googlesource.com/1170031
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581962}

Targets like ui/file_manager/file_manager/foreground/js:closure_compile
were causing js_compile.py to spend upwards of one minute of CPU time
in Python before even invoking the closure compiler.

Caching dependency subtrees takes the python CPU time down to about 50
milliseconds. That is, a 1000x performance boost.

Note the _set_ of arguments passed to closure is identical. However, the
order can change slightly without violating dependencies specified. This
shuffling exposed a couple of errors due to underspecified dependencies.
(Fix them):

ui/file_manager/file_manager/background/js/test_util_base.js:589:
  ERROR - Property args never defined on request

chrome/browser/resources/settings/site_settings/site_data_entry.js:15:
  ERROR - Variable referenced before declaration: I18nBehavior

TBR=hcarmona@chromium.org

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10c27bb76b404bb40828dfd54f99be059adf0fdb
Reviewed-on: https://chromium-review.googlesource.com/1166775
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581961}

In BridgedContentView, change most calls that refer to the views::View
hostedView_ to be routed through the BridgedNativeWidgetHost interface.

Leave keyboard events, text input, and a11y unchanged for now.

Add a BridgedNativeWidgetHostImpl::SetRootLayer method which now calls
through to BridgedNativeWidget::SetRootLayer. Once the remaining uses
of hostedView_ are removed, the BridgedNativeWidget::SetRootLayer method
will be removed.

Bug: 859152
Change-Id: I2a010b3149357af4f9aeaec0088eb9fcde53db13
Reviewed-on: https://chromium-review.googlesource.com/1168459
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581960}

This reverts commit f6c63d90d7b8a6f689b135fefc181a8e539debf9.

Reason for revert: Commit queue is working now.

Original change's description:
> Revert "Changed STDMETHODIMP to IFACEMETHODIMP and long to LONG where appropriate"
> 
> This reverts commit 641067d28a56deb5b2432a3f603eae029f461170.
> 
> Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > Changed STDMETHODIMP to IFACEMETHODIMP and long to LONG where appropriate
> > 
> > 1. STDMETHODIMP is defined as
> > HRESULT STDCALL
> > but the new macro IFACEMETHODIMP is defined as having an additional override modifier which
> > checks that the method we are defining or declaring is indeed an override of a method in a superclass.
> > 2. long is the same as LONG on Windows, but in order to avoid any confusion or any linter errors, I changed all uses to the capitalized version LONG.
> > 
> > Advantages:
> > A) This sends the message to developers that this is not the standard long type. It is actually an int.
> > B) It is the same as the type used in most of the MS documentation.
> > TBR=dtseng@chromium.org, dmazzoni@chromium.org, aleventhal@chromium.org
> > Change-Id: Ib73dc3b362c0297f7a9038f289710d66fa5c698c
> > Reviewed-on: https://chromium-review.googlesource.com/1169305
> > Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> 
> TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,aleventhal@chromium.org
> 
> Change-Id: Ia0655ece63c2dea8819130c0041e3cc4fd24a345
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1169848
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,tandrii@chromium.org,aleventhal@chromium.org

Change-Id: I997abd90e3da0f4424d4e61853fdbb17cbae0cd2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1169883Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581959}

WebGL conformance suppressions:
  conformance2/textures/misc/tex-mipmap-levels.html
  conformance2/textures/misc/tex-base-level-bug.html

Pixel test suppressions:
  Pixel_CSSFilterEffects
  Pixel_WebGLSadCanvas

Tbr: ynovikov@chromium.org
Bug: 870856, 872423
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1420fe20b7a64bb40f3ba0209fd9bb08b3213b14
Reviewed-on: https://chromium-review.googlesource.com/1168470Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581958}

When Chrome is killed in the background while VR mode is on, we can't
turn VR mode off (the platform doesn't respect VR mode changes for
backgrounded apps).

We also can't check whether VR mode is currently on on Android N, so
instead this CL records whether we were in VR mode when killed using
saved instance state, and turns VR mode off on startup when restoring.

Test/Repro steps:
1. Turn on "Don't keep activities" in developer settings
2. Launch Chrome in VR
3. Press the Daydream controller Home button
4. Exit VR
5. Use task switcher to return to Chrome.

> Chrome should resume without VR mode on (the display will flicker
if it's on)

Bug: 854740
Change-Id: I4fc8e9c076a8cb31ca2bdb74be1124bec3826193
Reviewed-on: https://chromium-review.googlesource.com/1167116
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581957}

This reverts commit 4af14ca3c99bd7edbf100e05db93564b7107cc62.

Reason for revert: relanding once the outage is over.

Original change's description:
> Revert "Deflake inspector-protocol/input/dispatchKeyEvent-focus.js"
> 
> This reverts commit 27378e0364b705643275c861f4ba64b70572dff1.
> 
> Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > Deflake inspector-protocol/input/dispatchKeyEvent-focus.js
> > 
> > The keystrokes injected via Input.dispatchKeyEvent through the browser are
> > racing against Runtime.evaluate in the renderer, so we need to wait for
> > the async completion of the last dispatchKeyEvent before validating the
> > tests results with evaluate.
> > 
> > Bug: 872081
> > Change-Id: Ic5ef41feba6a877c76c05de2e09e019a826756a1
> > Reviewed-on: https://chromium-review.googlesource.com/1168200
> > Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
> 
> TBR=dgozman@chromium.org,lushnikov@chromium.org,caseq@chromium.org
> 
> Change-Id: I6f7e8e41eab2c756875103cae24576c37784baf3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 872081
> Reviewed-on: https://chromium-review.googlesource.com/1169789
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=dgozman@chromium.org,lushnikov@chromium.org,caseq@chromium.org,tandrii@chromium.org

Change-Id: Ia8e5d3e56d923c31451474969afad7450e8e734d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872081
Reviewed-on: https://chromium-review.googlesource.com/1170007Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581956}

This will help debug the linked bug, by comparing S13nServiceWorker on
vs off.

Bug: 866335
Change-Id: Idd1d027971cb9fd5122cda4f1cf383b55119fa83
Reviewed-on: https://chromium-review.googlesource.com/1168952Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581955}

DecoderSelector provides an InitCB that destroys the VideoDecoder
immeidately when initialization fails. This means that |this| is
invalidated immedately upon calling |init_cb_| in MojoVideoDecoder.

This CL adds a WeakPtr-based test for |this| destruction to the
potentially problematic callbacks in MojoVideoDecoder::Stop().

Bug: 839881
Change-Id: I9b1302ad3007a834c95ed1d3845e24b0d07158f8
Reviewed-on: https://chromium-review.googlesource.com/1169907Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581954}

This CL moves the picker UI triggered from extensions into
DesktopMediaPickerFactoryImpl which lives under
/chrome/browser/media. We are planning to use this common
implementation to trigger the same picker UI for getDisplayMedia().

Bug: 326740
Change-Id: Idb8b9d094ce55ecc8281c3db1f1acb0f5e3a24f1
Reviewed-on: https://chromium-review.googlesource.com/1169594
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581953}

While migrating some classes from URLFetcher to SimpleURLLoader,
it is useful to have the size of the resulting decompressed body.

In case of DownloadToString* calls, this is straightfoward:
the length to the string is the size.
However, in the case of DownloadTo{Temp}File calls, where only the
resulting file path is passed to the completion callback, having
an API to get the decompressed body size is useful. It also avoids
sync calls to access the file data.

This CL adds a SimpleURLLoader::GetContentSize API that provides such
value. When used with SimpleURLLloader::SetAllowPartialResults(true),
the API returns the total decompressed body size even in the case of
errors.

BUG=773295,844972

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia8cdb3326b5d5c74276e384f966a7e98f61a8c46
Reviewed-on: https://chromium-review.googlesource.com/1167683Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581952}

This differs from the first version in that SetFocus(null) now returns
true. As you suggested in the last patch, returning false caused the
client to attempt to revert, which lead to some oddities. So, it seems
safer to return true.

views_mus_unittests no longer fails with this version, and
https://chromium-review.googlesource.com/c/chromium/src/+/1169525 fixs the
issue with the browser_test NavigatingExtensionPopupBrowserTest.Webpage.

Here's my comment as to why this is ignored:

  // The client is asking to remove focus from a window. This is typically a
  // side effect of the window becoming, or about to become, an unfocusable
  // Window (for example, the Window is hiding). Windows becoming unfocusable is
  // handled locally. Assume the request is for such a scenario and return
  // true. Returning false means the client will attempt to revert to the
  // previously focused window, which may cause unexpected activation changes.
  //
  // To process null requests conflicts with top-level activation changes. For
  // example, the typical sequence when a window is hidden is to first remove
  // focus, and then hide the window. FocusController keys off window hiding to
  // move activation. If this code were to set focus to null, FocusController
  // would not see the window hiding (because the active window was set to null)
  // and not automatically activate the next window.
  //
  // Another possibility for this code is to handle null as a signal to move
  // focus to the active window (if there is one). I'm going with the simpler
  // approach for now.

BUG=867654, 871652
TEST=covered by tests

Change-Id: Iff2ddb31c2b99b977bca8e56fb653b6ce4eb6813
Reviewed-on: https://chromium-review.googlesource.com/1165692
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581951}

Should be a good number of teensy layout test diffs.

Change-Id: I3dc74252fab7ec8ee4aa38d95ba1f60ed3e96b01
Reviewed-on: https://chromium-review.googlesource.com/1169313
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581950}

Bug: internal b/112331554
Test: manual
Change-Id: Ib7670d56a1d8444ac895cae7117365ccda0ef9e4
Reviewed-on: https://chromium-review.googlesource.com/1168507Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581949}

This CL removes some obselete sizing-* CSS rules that were
inadvertently causing a scrollbar to appear in the overflow menu at
certain zoom levels.

Bug: 851492
Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810
Reviewed-on: https://chromium-review.googlesource.com/1168394Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581948}

This is needed to make content_browsertests happy under mash.

Bug: 866942
Change-Id: I21885e4328706f83bb57805abe4cff581551120a
Reviewed-on: https://chromium-review.googlesource.com/1168143Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581947}