- 21 Jul, 2020 40 commits
-
-
Matthias Körber authored
Tools to build patterns for parsing autofill types from named capture groups. Bug: 1099202 Change-Id: I2bf6f1e3ed0e767c897830732adc6b508cbf99db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302172 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#790416}
-
Matthias Körber authored
expressions. This utility class lazily builds the patterns, compiles and caches enumerated regular expressions that are used for parsing and matching. The justification for this is that it becomes unnecessary to repeatedly rebuild patterns and pass them around the code. Further, a future integration of a component updater to change the patterns behind on of the expressions becomes minimally invasive. Change-Id: Icb7082e504603b43358a6d84f853e7b5336c3cad Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299632 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#790415}
-
Ben Goldberger authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2196817 Bug: 1079458 Change-Id: I22dc45f0399b3978e494ab20b66ef5126ccea580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231906 Auto-Submit: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790414}
-
Alice Wang authored
This CL renames some account picker bottom sheet tests to make all test names consistent and put the if branch in the account picker view binder in to the nest to make the view binding if branches more consistent. Bug: 1106442 Change-Id: I33b84a7bca0513ce443b63c3bcd2895031de003b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308418 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790413}
-
chrome://internals/web-appAlan Cutter authored
This code path forgot to early exit from the function. Bug: 1104250 Change-Id: I16cdbfeaa8028998014476f590ebe6067eff1c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308438 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#790412}
-
Julian Mentasti-Meza authored
Generates a PDF of the webView and invokes the callback with the NSData of the PDF or nil if a PDF couldn't be generated. The WebState calls the WebController that will invoke WKWebViewUtility's CreateFullPagePDF with the current webView. The callback is passed though at each step. Bug: 1103777 Change-Id: I3b83082937849e2851f6ceb1954b91cc0bc242ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295784 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#790411}
-
Andrew Grieve authored
This reverts commit 57deecbb. Reason for reland: Suppressed cast lint warning Reverted in: 339e6581. > Original change's description: > > Android: Updates to warnings-as-errors when building > > > > * Delete java_warnings_as_errors > > * Use treat_warnings_as_errors for android rules > > * warnings-as-errors is now default true for debug builds > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > > so that these warnings can all be turned off locally. > > * Made build_utils.CheckOutput fail by default when stderr or stdout is > > printed. This should prevent build logs from creaping in. > > * Added "you should use treat_warnings_as_errors=false" into error > > message when builds fail due to warnings. TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org Bug: 1029357 Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790410}
-
Edward Lesmes authored
Bug: 949535 Change-Id: I725ec313f78b7551839c6fd3454bb3f7edeab07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309033Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#790409}
-
Marc Treib authored
- Remove unnecessary indentation - Use "show-on-attach" attribute instead of custom code - s/Tap/Click/ Inspired by comments on crrev.com/c/2288850 Bug: none Change-Id: If0bc7fb58e2d0a41fa272cf90feb014ad859d739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309430Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790408}
-
kylechar authored
Change SkiaRenderer to use similar logic to GLRenderer on context loss where the loss is considered a synthetic loss unless it was triggered by the GL robustness extension. Synthetic loss doesn't trigger GPU process restart. Bug: 1091787 Change-Id: Ie3613dff69f9a0e8816d17f344ff690b297153de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302924 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790407}
-
Darwin Huang authored
Removed unused versioning support in ClipboardInternal. This allowed for multiple ClipboardData items on a clipboard stack, but the stack size was limited to 1, and no logic existed to exercise use of any stack items except the top item on the stack. Therefore, this essentially amounted to extra logic that wasn't actually needed or used. Versioning support has been available since at least 2012, when https://crrev.com/10829341 first introduced this file as a "sketch of a clipboard implementation for linux_aura". Change-Id: I7615a97bdd4ef038b0684c75536d2417d746bffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309549 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790406}
-
Mehrdad Hessar authored
Bug: 1099030 Change-Id: Ibab49ba7816720c3abcba35dafd09be553788bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309140Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Cr-Commit-Position: refs/heads/master@{#790405}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 93a6ebbe. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic73a79c2780d253155f967a9f0af579265f6bbf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310109Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790404}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c29401c0..df76b72e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3607fb2a33e315036823aed599ac9b683ad537ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310149Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790403}
-
Evan Stade authored
DisplayCutoutController is split into DisplayCutoutController (destined for //components) and DisplayCutoutTabHelper (which stays in //chrome). Relocation/reuse will occur in a follow up CL. TBR=dtrainor@chromium.org Bug: 1095714 Change-Id: Ie119069ae4756baf73acc23d655665fce1d4c035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296888 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790402}
-
Torne (Richard Coles) authored
Move the dependency on downstream code needed for new Android releases from the APK target to the WebView Java target. This ensures that monochrome_public will also get the dependency when appropriate, and removes the need to duplicate this condition in the downstream targets. Bug: 1106471 Change-Id: Idc9938eb5dc7f0738f539ac8561bab7abc52f0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309810 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790401}
-
Mohsen Izadi authored
INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT has been removed from the code since r748271. Event.Latency.BlockingTime.* metrics that used to use this component were also removed in r780806. Similarly, Event.Latency.QueueingTime.* metrics are removed in r780806. INPUT_EVENT_LATENCY_RENDERER_MAIN_COMPONENT is not used anyomore in reporting latency metrics, but it still seems to be used by devtools, so we are not removing it, yet. This CL updates the latency_info.dot to match these changes. Bug: 849719 Change-Id: I0d5485bbb6b28f775459dbb2f7c930b3c19c5cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305118Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790400}
-
Sreeja Kamishetty authored
Bug: 1102629 Change-Id: Iaa4440558f32459c6253d669f65a2354d31c93fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309983Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#790399}
-
Adam Rice authored
The WebSocketReassembleShortMessages experiment, which uses the Net.WebSocket.CloseCode as one of its metrics, has been extended to beta, and will probably be extended to stable. Extend the life of the Net.WebSocket.CloseCode histogram all the way to December 2020 so hopefully we won't have to extend it again. BUG=1104953 Change-Id: I6e8edc2d7204628901e870c97a9248e5fcbe99b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298867 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790398}
-
Pavol Marko authored
This change makes PlatformKeysServiceImpl independent of BrowserContext/Profile. All BrowserContext-specific calls have been extracted into a PlatformKeysServiceImplDelegate. This has the advantage that for device-wide usage of the PlatformKeysService, a delegate can be created which does not depend on a Profile (avoiding using the sign-in Profile for that use case). The CertProvisioningScheduler use case has been migrated to this pattern. As the device-wide PlatformKeysService lives "forever" but the underlying system token NSSCertDatabase does not, PlatformKeysService can now explicitly "shut down" when the underlying NSSCertDatabase is being destroyed. After it is shut down all operations on the PlatformKeysService will fail with an error (except for removing observers). Note: The PlatformKeysService still works for the sign-in Profile which is important for the sign-in screen extensions use case. Bug: 1045895, 1073512 Test: browser_tests Change-Id: I09b855c61caaa744bf8618073eaa2854a609df84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188633 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#790397}
-
Joshua Pawlicki authored
This reverts commit 4d324410. Reason for revert: Breaks mac ASAN bot :( Original change's description: > Updater: AppWake starts the server instead of doing an update check. > > Bug: 1105589 > > Change-Id: I6d7e8b0b7858a4f1a538684758644f134318c0a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298045 > Commit-Queue: Mila Green <milagreen@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790139} TBR=sorin@chromium.org,waffles@chromium.org,milagreen@chromium.org,norberg@google.com Change-Id: I507f6a05ec9e7764b6517279579bbfbb93d12aa6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308872Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#790396}
-
arthursonzogni authored
Context: https://chromium-review.googlesource.com/c/chromium/src/+/2232320/2/content/browser/form_controls_browsertest.cc#141 This patch fixes the typo and uses the more common MAYBE_ pattern. BUG=1091661 Change-Id: I916faa0c88697ae4887d38ec4591c00a9330ae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307214Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790395}
-
Christopher Cameron authored
Bug: 894929 Change-Id: I6e3672659337dd4150de67cb62f5d5dcb27db9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309047 Auto-Submit: ccameron <ccameron@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790394}
-
David Roger authored
Screenshot with this CL: https://drive.google.com/file/d/1b-x0NrGnycEfV24EQ9pb_vKBHfPc2X60/view Mock: https://drive.google.com/file/d/1ckOFYd_eFQ1UK5byLkeXOuNqo0Fskxj2/view?usp=sharing Bug: 1076880 Change-Id: I5d0b4ab2194899039e97f86a90b1aa3d578bd78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292300Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#790393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83406a9d26a2..86079a48c157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andruud@google.com Change-Id: Ib406ebfd527185fc1d8bb3c31cbd2313d6dfc2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309970Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790392}
-
Victor Hugo Vianna Silva authored
This CL accomplishes two things. 1) Make sure test coverage is not lost when the feature is enabled. crrev.com/c/2299353 hardcoded that many tests should consider the feature as enabled/disabled. This CL makes sure that: a) Tests that are agnostic to the feature don't specify this. b) Most tests that do depend on the feature now use conditional setup/ expectations when appropriate. c) Only tests that are specific to one state of the feature (enabled/ disabled) specify this. 2) Make sure all existing tests pass when the feature is enabled. Bug: 1105795 Change-Id: I5825afe82041f7d91d7dcbf3d63f64ad74590ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309699 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790391}
-
Roberto Moura authored
Change-Id: Id063eac00a170b1e66a177bf705de712b7c060a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306038 Commit-Queue: Roberto Moura <mouraroberto@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#790390}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/97f9923235cf..c5d08140dbeb 2020-07-21 capn@google.com Regres: Don't test changes with negative scores If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3369195a91e592ccb1c7e46232705501551ecbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790389}
-
Anders Hartvoll Ruud authored
This eliminates the final call-site for MatchResult::AuthorRules, which means we can (in a future CL) remove MatchResult::UaRules, ::UserRules and ::AuthorRules. Also establish a common pattern for use-counting in StyleCascade, isolating as much use counting "noise" as possible into separate functions. Finally, this CL adds a unit test for kSummaryElementWithDisplayBlock- AuthorRule, since we didn't have one already. Change-Id: I4693fd8ee538da88fea0648eda8ccfac31818dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307238 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790388}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/57d7441b354d..62ab4833a6a1 2020-07-21 jacktfranklin@chromium.org Remove incorrect DEPs from formatter worker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba7911e9f340c026dab8cc712cea79484b3f163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790387}
-
Stepan Khapugin authored
Remove this UI blocker because there's now one owned by the scene that's showing the FRE, so this one is unnecessary. Bug: none Change-Id: I742f0e432fdec3e33fd4434bcbba7c3440eba07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289858Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790386}
-
Jérôme Lebel authored
default_world_favicon was duplicated in: + ios/chrome/credential_provider_extension/ui/resources/ + ios/chrome/common/ui/resources/ This patch moves default_world_favicon.imageset to: + ios/chrome/common/ui/resources/ Change-Id: I997e35b4ee695b24c1b6ffbf66e97fc5e2131f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308720 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#790385}
-
Gavin Williams authored
Using on-blur simplifies closing the dropdown for clicks registered outside of print preview. And now that we don't have to specifically listen for clicks outside of print preview, on-click can be used instead of pointerdown. Bug: 1059607 Change-Id: I9225ec9e06e3197b9f2eae4ac078b29fa232a791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303368 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790384}
-
Michele Mancina authored
Change-Id: Ia351a4496c5e782c283e2aea08e6d20393979391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297562 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#790383}
-
Richard Stotz authored
Bug: 1097126 Change-Id: I3775c97543b4603e910f5cf4ec1f5a7207fd7276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308420Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790382}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 Partially implement the QueueAccessReport function. A simple report is sent containing: - disposition - effective-policy - property but missing for now: - blocked-window-url - source-file - line-no - col-no - violation-type COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] this patch. Bug: chromium:1090273 Change-Id: Ib5ed9fc598f437459a6b57e35875be6fbf5a63b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273120 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790381}
-
Mugdha Lakhani authored
This is so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: Iedae9f5248d37da9aacd9c739719c9889c1949bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236482Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#790380}
-
Marc Treib authored
It was referencing a closed bug. Bug: 1107741 Change-Id: I54d8c4a7eff4ebc555943ba0436f725f9da46c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309690 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#790379}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e875f72dc66f..c1eb58de32c0 2020-07-21 reed@google.com MallocPixelRef should always allocate as large as computeByteSize() says 2020-07-21 robertphillips@google.com Convert more tests to GrRecordingContext/GrDirectContext 2020-07-21 adlai@google.com Reland "Remove more GrContext imports & usage" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103827 Tbr: robertphillips@google.com Change-Id: I55a75abf9a0d247acbb41268e81b0b52b84f2443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790378}
-
Mark Brand authored
Removes support for the legacy Ptr, Request, AssociatedPtr, AssociatedRequest types. This will break while there are .mojom files that use any of these types. Change-Id: I221115bc89989a73beebb2d5fcdd7fc51d60cfd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247727 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#790377}
-