- 30 Jun, 2020 40 commits
-
-
Nektarios Paisios authored
Harmonized word boundaries exposed through accessibility APIs with the words produced by cursor navigation When using a screen reader and the user is moving by word throughout a webpage, both in editable and in non-editable content, the assistive software should announce either the word the user's cursor moved over or the word to the right of the cursor, depending on platform, and using accessibility APIs exposed by Chromium. To navigate in editable content the user uses Chromium's word navigation functionality, such as Ctrl+Left/Right arrow or Option-Left/Right arrow. In non-editable content, the user relies on screen reader shortcuts, which in turn rely on the same accessibility APIs. The bug is caused by the fact that commands such as Ctrl+Left/Right do not use the same word boundaries as the accessibility APIs. This patch harmonizes the two sets of boundaries. To do this, I used and was guided by the following: 1. ICU's word break iterator whose rules are found at http://userguide.icu-project.org/boundaryanalysis and http://www.unicode.org/reports/tr29/#Word_Boundaries 2. Idiosyncrasies of the Blink editing code which are based on established platform behavior that Chromium needs to replicate. //third_party/blink/renderer/core/editing/selection_adjuster.cc StartOfWordPosition, EndOfWordPosition. //third_party/blink/renderer/core/editing/visible_units_word.cc StartOfWordPositionInternal, EndOfWordPositionInternal, NextWordPositionInternal, PreviousWordPositionInternal. AX-Relnotes: Screen reader reads the correct word when moving forward or backward by word and there are punctuation marks or line breaks in the text. R=aleventhal@chromium.org, dmazzoni@chromium.org, chrishtr@chromium.org Change-Id: I2915fb4243f74f33c31508c4fc3c9e49a57209f6 Bug: 1028830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237930 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#783871}
-
Sylvain Defresne authored
It is sometime useful to have different build directories (e.g. to allow switching the version of the SDK used). Add a way to customize the build directory to setup-gn.py Bug: 619921 Change-Id: I4cd07a2978bfdee46fbce63d3257076c5e86a885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270324 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#783870}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a805a6702fe6..40ecf2e45a09 2020-06-30 alexrudenko@chromium.org Fix stylelint-config-standard issues in elements/stylesSidebarPane.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I883f7c63ac71cfbe061ba9a903ec8c23918bc1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783869}
-
Yutaka Hirano authored
The flakiness has been fixed by https://github.com/web-platform-tests/wpt/commit/30252c8f1cc8f2a440d99d9388f871b3ae75297a. Bug: 1013523 Change-Id: I08bd3e7b6ba19eeade1af685838b59d6237f2405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274499 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783868}
-
Illia Klimov authored
This patch fixes a bug that adds an empty space instead of notifications permission in site settings. Reproducible only on Android 7.1 and less. Bug: 1099645 Change-Id: I8d283b186ce562a1598ce72ff431863d45c77197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273103 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783867}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1163749fd80..722e769803e8 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 80ff4391..2c0b70ba (783693:783820) 2020-06-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 51d47a5b..80ff4391 (783422:783693) 2020-06-29 philipp.hancke@googlemail.com sdp: remove old workaround 2020-06-29 sprang@webrtc.org Removes locking in TransportFeedbackProxy. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I07a5d1cb283cc06183efd5c5e367d96f7100caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274690Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 1100774, 1100783, 1100786 Change-Id: I0836d580d0668c45844c7630a769658ec81b6286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274971 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#783865}
-
Aya ElAttar authored
Added browsertests to test that the login screen warnings for the managed-guest sessions are controlled via ManagedGuestSessionPrivacyWarningsEnabled policy, which was added by this CL crrev.com/c/2254605. Bug: 1099648 Change-Id: I18b7d0b15ca13182ff62b3bc23d3378aa59ced3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270458 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#783864}
-
wutao authored
This patch adds a ChromeOS Settings subpage to select the personal albums of Google Photos and categories of Art gallery. A list of checkboxes of available albums and Art categories is shown in this Settings page. If no album or Art category is selected, server will return default photos. ss: https://screenshot.googleplex.com/HDEeiGq1xmb Bug: b/158630641 Test: manual Change-Id: Ia520f090d42d0caa8956c88e2cef07b6b31eec6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246218 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#783863}
-
Miyoung Shin authored
This CL converts PrerenderHostMsg_PrefetchFinished to FrameHost Mojo message and removes the unused PrerenderMessageFilter. Bug: 798712 Change-Id: I72721a011ebfb9951f4e7c01a96e09139f3c5e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256116 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#783862}
-
Noel Gordon authored
Dispatch drag test events in different phases (like a browser) - simulate using an idle callback request Check the event dispatch result in each event phase - fail if any of these dispatch calls fail Use source and target for variables and concepts - drag drop is spec-ed in terms of sources and targets Don't send a dragEnd event if we are skipping the drop event - this to match what a browser would do in this case Update the Closure markup and comments - skipDrop is no longer optional (so we can go async) No change in behavior: existing transfer tests transferDragAndDrop and transferDragAndHover should work as before. Bug: 1062902 Change-Id: Ia65b517ae5854f8abd92fe908a457ec72497b156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274125Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783861}
-
sauski authored
Connected the previously created Safe Browsing generated preference to the production settings code. The settings-radio-group element is also extended to allow for not immediately setting the associated pref to support the Safe Browsing disabled dialog. This change also obviates the Safe Browsing proxy/handler, as well as some logic to support the previous Safe Browsing use of the collapse-radio-button element. These have been removed as part of this CL. Bug: 1096471 Change-Id: Iccd24602c4a7bf020ba6a78ed0bb00f2021dba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270137 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#783860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03ad609d3178..c783abd3776d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: peria@google.com Change-Id: I082ca231d46adb7b36478c364530e8edb591d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275626Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783859}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eb1a9106b40b..359d16da1108 2020-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 20768107 to 277fb4f3 (412 revisions) 2020-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 69c011ef35f1 to 06462adde69b (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091259,chromium:1094869 Tbr: ethannicholas@google.com Test: Test: Test: CQ Change-Id: Ie05c83b6abcb82906f99aa11944019662a4b63de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275627Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593475028-63728bbaf9d72e013a403087ba2956d3e5f5a26b.profdata to chrome-mac-master-1593496775-686b801b00e226d40d93326669dcabc4de9f2009.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I845719fe6f2db7b38d39ce749374d8f9afd42d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275629Reviewed-by:
-
Colin Blundell authored
This class will be reused by WebLayer. The componentization is straightforward. Bug: 1099169 Change-Id: I1da79b401d9dcb87e3048f35b37eccd5c6880f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272321 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#783856}
-
Colin Blundell authored
In preparation for componentization of this class for sharing with WebLayer, this CL cleans it of //chrome dependencies. We do so by introducing a simple ChromeConfirmInfoBar convenience subclass that glues ConfirmInfobar to //chrome, which will then enable ConfirmInfobar itself to be componentized and reused by WebLayer. Note that any //chrome-level subclasses of ChromeConfirmInfoBar could still easily be componentized if desired in the future by simply changing them to subclass from ConfirmInfoBar directly and take in the needed additional parameters in *their* constructors for supplying by the embedder. Bug: 1099169 Change-Id: I20b57b37eec57ed9932c6a3610f64e3860ac2900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272323 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
David Jean authored
Bug: 1096035,1076852 Change-Id: I386b8127fd0aed588226b6068553e086a7bba18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273158Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#783854}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd4435373db6..a805a6702fe6 2020-06-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34fb1337668d30a0d6b187d43edc2908037519d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275628Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0c55cdde36c8..6bd8e303c90e 2020-06-30 tsepez@chromium.org Pass cppgc::Heap into xfa layout layer. 2020-06-29 thestig@chromium.org Initialize CFWL_WidgetMgr::Item in the header. 2020-06-29 thestig@chromium.org Initialize CXFA_Graphics::TInfo in the header. 2020-06-29 thestig@chromium.org Initialize various nullptrs where declared. 2020-06-29 thestig@chromium.org Clean up Gouraud / Mesh shading code. 2020-06-29 thestig@chromium.org Add a pixel test with a free-form Gouraud-shaded triangle mesh. 2020-06-29 thestig@chromium.org Fix regression in CFX_SkiaDeviceDriver::PaintStroke(). 2020-06-29 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 91fa1462a88f to a2a7e05eb765 (74 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099990 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1e5200fd31c987155d975d6583a265a14b445246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275150Reviewed-by:
-
Trent Apted authored
There's a strict set of flags that aren't yet applied across test code. This extends the flags to utility files used in tests (but not yet the browsertest.js files themselves). Fixes the problems. And makes those flags readily available to other system apps. Bug: 1100755 Change-Id: Ib1dbb094bbfc5d3f42fe7d7dab19f9200449c09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275364Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#783851}
-
Rahul Singh authored
based system This CL adds code to migrate shortcuts menu data (shortcut_infos, downloaded_shortcuts_menu_icons_sizes, and on-disk shortcuts menu icons) from the old Extensions based system to the new WebApps based system. In web_app_migration_manager.cc this CL adds code that reads shortcuts menu data from bookmark_app_registrar and writes it to a WebApp object. Using new structures added in web_app.proto and code added in WebAppDatabase the WebApp is then written to the local LevelDB. We then read WebApp entries from the LevelDB store and add them to the WebAppRegistrar to conclude the migration. Testing: Added tests in web_app_migration_manager_browsertest.cc to exercise the shortcuts menu migration code. Bug: 1069316, 1069312 Change-Id: I9d642495d655828d23b08116b63560aa273d0500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269550 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#783850}
-
Koji Ishii authored
crbug.com/1100070 says this is needed to enable FragmentItem on test bots. Bug: 1100070 Change-Id: If0aa58bcc95fd4fbb6338f89c207cbfc31da3251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274620Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#783849}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ia87cc42876a65e7bdc72a3dc5a9663e310197444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274966Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783848}
-
GioVAX authored
Calls to StartArc are wrapped in a timeout check for all managed users, except Kiosk and demo sessions. Correct initialization of the error reporting infrastructure for MGS interactive sessions. BUG=b:156271583 TEST=Tested manually by forcing ARC to fail. Change-Id: I2d914e73d2a08f6514eae90dce3566d5256f73e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230497 Commit-Queue: Giovanni Pezzino <giovax@google.com> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783847}
-
Francois Beaufort authored
This CL makes sure video track capabilities and settings are available after getUserMedia promise resolves. This was not the case and web developers had to introduce an arbitrary timeout before accessing track capabilities and settings. Bug: 711524, 934063 Change-Id: I3063cc66c52189a34c58e465385be82c8cff955b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270142Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#783846}
-
Simon Zünd authored
COEP issues were already sent by the browser-side, but did not utilize the new issue storage yet. This CL changes that. R=sigurds@chromium.org Bug: chromium:1063007 Change-Id: Ie956a4c847a2c029057d55da75dc80146b2132ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252340 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#783845}
-
Hesen Zhang authored
Change-Id: If317deecc81f259bcf6bf6c44c10a65cf3f1ddac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271015Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#783844}
-
Mikel Astiz authored
This cleans up a few minor leftovers that continue to reference the legacy Sync Directory, about to be deleted from the codebase. Change-Id: I583b07038f13f648d5c47e8aea2ed0a36edbe93e Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267037 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#783843}
-
Jeevan Shikaram authored
Add the ARC app ID of Youtube Music so that the promise icon will be placed correctly. Update the order of the Youtube Music web app order. Bug: 1099140 Change-Id: Icd52e96de333a3582fac6f528440360ce4dde42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275367 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/27e915ed4f20..dca47063ccd2 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2295 from ben-clayton/rm-old-kokoro-cfgs 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2292 from proydakov/gcc-unused-parameter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Idf18ad63fc8457b25c8078aeee9e44f5614fd2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275579Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2278e39a67ce96be7a2ab33088fb9365e6630b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274682Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/10b7541a1edc..eb1a9106b40b 2020-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from ff90599cdf60 to b231c7fb717d (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Id7cb589ba28808d85a8bd4836bf99ae7a92abf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275622Reviewed-by:
-
Alex Danilo authored
CL:2265701 enables sub-menus hanging off the file list context menu, however the menu reference for the 'More Actions' option referenced the wrong menu. Changes the 'More Actions' sub menu to refer to 'share-menu' instead of 'share-sub-menu'. Bug: 1100161 Change-Id: Ifa730a1abef42a4833485fc38258e667848b50a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275363Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#783838}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2de2c1c5473..7993f34db4ae 2020-06-30 timvp@google.com Vulkan: Store transformed SPIR-V in ProgramExecutableVk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Test: Test: CQ Change-Id: Id9ab51b3696cb46dfc7af86b11237d8244d00478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275427Reviewed-by:
-
Lei Zhang authored
Let it fix whatever nits it finds. Change-Id: I910cebded2ad8b6b2eae786ad191a64d1980b901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274467Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783836}
-
Fergal Daly authored
Change-Id: If16c72133f32025757928223b1f0157acfad63fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273257 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#783835}
-
Francois Beaufort authored
Now that all video capture device factories populate the pan_tilt_zoom_supported field, there is no need for the unknown status. Bug: 934063 Change-Id: I4811515b9584da60744e85f6dde146d3b46efb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241119 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#783834}
-
Zufeng Wang authored
This is added to loadtimedata to be read in by the untrusted app code. Bug: b/159957772 Change-Id: Id593248b30821404c3d319d7268704a879c8ae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275078Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f437404b0ed..03ad609d3178 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: peria@google.com Change-Id: Ib4f40e55b9fc8b29f9ffcd005ab44bb0bc8270e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275425Reviewed-by:
-
