GitLab

These have recently been retired from Valgrind, and are also being retired from Dr Memory:

bug_101125a
bug_101125b
bug_101125c
bug_106183a
bug_106183b
bug_106183c
bug_106552

BUG=101125,106183,106552
R=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/588103002

Cr-Commit-Position: refs/heads/master@{#296047}

These have recently been retired from Valgrind, and are also being retired from Dr Memory:

bug_32623
bug_75127a
bug_75127b
bug_75127c
bug_79933a
bug_87232

BUG=32623,75127,79933,87232
R=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/587113002

Cr-Commit-Position: refs/heads/master@{#296046}

This is a cleanup-only/documentation change, no behavior changes.

Add comments explaining how Directory locking works.

Move protected methods to private (there was no reason for them to be
protected).

Move private data members below private method declarations.

For methods that take a ScopedKernelLock, always pass by const reference
before non-const pointer parameters.

Give ClearDirtyMetahandles a ScopedKernelLock parameter so it's clear
that the caller must be holding a lock.

BUG=

Review URL: https://codereview.chromium.org/585663002

Cr-Commit-Position: refs/heads/master@{#296045}

BUG=415944

Review URL: https://codereview.chromium.org/585953003

Cr-Commit-Position: refs/heads/master@{#296044}

BUG=none

Review URL: https://codereview.chromium.org/594623002

Cr-Commit-Position: refs/heads/master@{#296043}

Review URL: https://codereview.chromium.org/593833002

Cr-Commit-Position: refs/heads/master@{#296042}

BUG=

Review URL: https://codereview.chromium.org/588803002

Cr-Commit-Position: refs/heads/master@{#296041}

In this CL, we avoid leaking the void* pointer of profile outside of
web_request_api.cc. The main idea behind is void* is used in webrequest API to
avoid accidently access to profile on IO thread. When we are certain that a
function is called on UI thread, we can cast the void* to BrowserContext*.

A refactor is made to
WebRequestEventRouterDelegate::LogExtensionActivity(...):
-Change its first parameter from void* to BrowserContext*; So we won't leak void* pointer outside of web_request_api.cc.
-This function only keeps the logic that is run on UI thread, the logic for IO thread is moved back to web_request_api.cc.

BUG=352293

Review URL: https://codereview.chromium.org/589153002

Cr-Commit-Position: refs/heads/master@{#296040}

BUG=397754
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/584433002

Cr-Commit-Position: refs/heads/master@{#296039}

This patch re-enables a patch that was timing out on windows. This
code has changed significantly since it was disabled, and it's worth
seeing if the problem went away.

NOTE TO SHERIFFS
================

In case of a cc_unittest timeout (one of TileManager tests with
occlusion), please revert this. I'll monitor how it goes, but I might
miss it in the build.

R=danakj
BUG=401527

Review URL: https://codereview.chromium.org/588143006

Cr-Commit-Position: refs/heads/master@{#296038}

Right now it's adding a lot of other files that aren't needed to run the tests, which slows down the uploading and downloading steps when using component builds. Since this preprocessing step is only meant to add extra binaries that are the result of the component build, just whitelist .dll/.so/.dylib.

BUG=414808

Review URL: https://codereview.chromium.org/592143002

Cr-Commit-Position: refs/heads/master@{#296037}

render_pass->transform_to_root_target should've been
delegated_render_pass->transform_to_root_target.

BUG=406274

Review URL: https://codereview.chromium.org/546993002

Cr-Commit-Position: refs/heads/master@{#296036}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8b5f7b4..fc8dcfc

TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/589203002

Cr-Commit-Position: refs/heads/master@{#296035}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4401a1f..baae2f1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/587303003

Cr-Commit-Position: refs/heads/master@{#296034}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/588723002

Cr-Commit-Position: refs/heads/master@{#296033}

This script attempts to automate a lot of the waterfall-staring
that pixel wranglers need to do. A version is already published
and documented at
http://www.chromium.org/developers/how-tos/gpu-wrangling/check_gpu_bots-script.
This script is intended to be a temporary measure to help out
pixel wranglers until such functionality (or better) is
incorporated into tools like the sheriff-o-matic.

BUG=

Review URL: https://codereview.chromium.org/588603003

Cr-Commit-Position: refs/heads/master@{#296032}

BUG=None
R=cmasone@chromium.org
TBR=jamescook@chromium.org
TEST=gn gen

Review URL: https://codereview.chromium.org/586213002

Cr-Commit-Position: refs/heads/master@{#296031}

BUG=416326

Review URL: https://codereview.chromium.org/590223002

Cr-Commit-Position: refs/heads/master@{#296030}

The documentation for WebView#destroy() reads "This method should be called
after this WebView has been removed from the view system. No other methods
may be called on this WebView after destroy". However, some apps do not
respect that restriction so this change ensures that we fail gracefully
in that case and do not crash.

BUG=415666

Review URL: https://codereview.chromium.org/581423002

Cr-Commit-Position: refs/heads/master@{#296029}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/594503003

Cr-Commit-Position: refs/heads/master@{#296028}

BUG=354261
R=brettw@chromium.org, brettw

Review URL: https://codereview.chromium.org/589753005

Cr-Commit-Position: refs/heads/master@{#296027}

Move data_reduction_proxy_* field declarations from profile_impl_io_data.h
to profile_io_data.h, before chrome_network_delegate. This guarantees
that chrome_network_delegate is destroyed before the data reduction
proxy objects.

BUG=414806

Committed: https://chromium.googlesource.com/chromium/src/+/d463f6b84e8a56d44904ec1418c99d7b47ea26dc

Review URL: https://codereview.chromium.org/575143003

Cr-Commit-Position: refs/heads/master@{#296026}

BUG=400927

Review URL: https://codereview.chromium.org/511623002

Cr-Commit-Position: refs/heads/master@{#296025}

BUG=384870
R=jochen@chromium.org
TEST=build succeeds

Review URL: https://codereview.chromium.org/584753003

Cr-Commit-Position: refs/heads/master@{#296024}

Remove 'feature' where the animations get slowed down when a user clicks one of
the window controls (minimize, maximize, close) while holding shift. This is
intended for debugging only but affects behavior in stable too

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/586813004

Cr-Commit-Position: refs/heads/master@{#296023}

Contains fixes for depth texture detection in D3D9.

BUG=416053,angle:750

Review URL: https://codereview.chromium.org/593793002

Cr-Commit-Position: refs/heads/master@{#296022}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/78324b1..8b5f7b4

TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/594493004

Cr-Commit-Position: refs/heads/master@{#296021}

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/587823003

Cr-Commit-Position: refs/heads/master@{#296020}

BUG=352293

Review URL: https://codereview.chromium.org/584143002

Cr-Commit-Position: refs/heads/master@{#296019}

This forces the Display containing it to redraw and satisfy the request.

BUG=

Review URL: https://codereview.chromium.org/582173003

Cr-Commit-Position: refs/heads/master@{#296018}

Copy edit Learn Basics section. Includes first group of new illustrations to make overall site images look googly and at the same time part of a single design process.

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/581643004

Cr-Commit-Position: refs/heads/master@{#296017}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default | grep WARNING

Review URL: https://codereview.chromium.org/574193002

Cr-Commit-Position: refs/heads/master@{#296016}

This is 10/11 tests from upstream. All uses of setTimeout were removed to hopefully eliminate any flakiness.

Fixes bug where live region removals weren't spoken.

BUG=371692

Review URL: https://codereview.chromium.org/582123002

Cr-Commit-Position: refs/heads/master@{#296015}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a29b5d8..4401a1f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/587263003

Cr-Commit-Position: refs/heads/master@{#296014}

Review URL: https://codereview.chromium.org/572373002

Cr-Commit-Position: refs/heads/master@{#296013}

Recent changes caused the Android Debug GPU bot to fail this test.
This could possibly be due to anti-aliasing changes.

BUG=416450

Review URL: https://codereview.chromium.org/592743003

Cr-Commit-Position: refs/heads/master@{#296012}

Two cases are now improved:
1. Errors during model loading. Previously this would trigger a reconfiguration
despite being in the middle of an existing configuration.

2. Errors after model loading but before association. Previously these would do
nothing.

BUG=415757

Review URL: https://codereview.chromium.org/585643003

Cr-Commit-Position: refs/heads/master@{#296011}

Introduce WebRequestEventRouterDelegate to resolve the dependency of chrome in web_request_api.cc(.h).

BUG=352293

Review URL: https://codereview.chromium.org/568583002

Cr-Commit-Position: refs/heads/master@{#296010}

Unregister BookmarkImageService observer from BookmarkModel in the
Shutdown method instead of the destructor to follow the two step
shutdown of the profile.

Fix a typo in the EnhancedBookmarkModel override of KeyedService
Shutdown method (could have been caught by using the OVERRIDE keyword).

BUG=None

Review URL: https://codereview.chromium.org/588233002

Cr-Commit-Position: refs/heads/master@{#296009}

Just use RenderText's cap-height vertical centering.
Do not use one-off naive font-height vertical centering.

BUG=411908
TEST=views::Label and gfx::Canvas::DrawString* text baselines look good and match Textfields.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/585053002

Cr-Commit-Position: refs/heads/master@{#296008}