- 09 Sep, 2020 40 commits
-
-
Aaron Colwell authored
Renamed the single param version of GetSiteInfoForURL() to ComputeSiteInfoForURL() to make it a little more clear that these functions behave differently in subtle ways. The new name reflects that this method behaves like SiteInstanceImpl::ComputeSiteInfo(). This change also updates a few pieces of code to go through this renamed method so that it is clear that each of these places expect the same behavior. There are no behavior changes. Bug: 1085275 Change-Id: Ie1a1911c5d92ba620789f456f10cdc732ee95244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399450 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805320}
-
Clark DuVall authored
This allows using Process.getStartUptimeMillis() for startup metrics, which will include the time spent loading java code. Bug: 1126301 Change-Id: Ia5b050ba268b3445a7dd934fab409298ce9b3c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399918Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805319}
-
Hajime Hoshi authored
This CL adds a new UKM event * BackForwardCacheDisabledForRenderFrameHostReason and a new UKM to HistoryNavigation * BackForwardCache.DisabledForRenderFrameHostReasonCount for further analysis. The UKM privacy doc is: https://docs.google.com/document/d/1GDsehNwMEHXef_o2XqNbsXk2F0pdhXt1khVVE4cRcLw/edit?usp=sharing Bug: 1122491 Change-Id: I21fd6c9ef122b8b84d231cddea6e68fd9592bad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392188 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805318}
-
ckitagawa authored
This CL adds the ability to pre-warm a compositor process for use by paint preview show-on-startup. 1. The compositor is started when native is initialized if the experiment is enabled. 2. Depending on the situation the compositor is then used or killed. a. Compositor is used: disconnect handler is updated and it is used as if there was a compositor already. b. Compositor is not used: the process is killed immediately. This moves initialization of the compositor service up to O(100 ms) earlier (in local tests). Bug: 1126180 Change-Id: I1e6f627403e8c020b6551c510ad908bba0fc24a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398562Reviewed-by:Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805317}
-
Adithya Srinivasan authored
Bug: 1124352 Change-Id: I272834d52b0373334f741596e497e465c09ea712 Tbr: mmoskvitin@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401320Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805316}
-
Maciej Malinowski authored
The Chrome Graph Processor is a wrapper for a graph processor implementation from Perfetto. This class takes care of all required input and output parameters conversion. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: I3c6a320fe354bcd4bbd93388dfc013244bc9f261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299348 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#805315}
-
Egor Pasko authored
The stories we use for getting memory usage results (as "browse_news@@NativeCodeResidentMemory_avg") got removed from Telemetry. Instead there are new stories with very similar names. Let's try them. I checked locally that the new stories are picked up and run successfully on Pixel 2/P. Bug: 1117184 Change-Id: If82ba747ea04df3a644f11d415d07525a51a7dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401100Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805314}
-
Matt Falkenhagen authored
Change-Id: I0d6671c150f81df315f63972e757f35a389f8532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397038Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805313}
-
Jan Wilken Dörrie authored
This change makes use of absl::variant in PasswordFormManager, which can only observe one of a form or digest at a given time. Bug: 943045 Change-Id: If81d636f0388c4730dfd585d6c68d28afba3b8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341123 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805312}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I17d2840c67574adeb0e474a26d0c17f36a6d88b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805311}
-
Alice Wang authored
This CL disables the web sign-in bottom sheet when there are no accounts on device. Bug: 1120334 Change-Id: I0ac3be7022540bd2aed42ce638be69ce6c9ca515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397893 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805310}
-
David Roger authored
The color for the new profile is now created earlier (before the bubble is shown), and passed to the bubble in the BubbleParameters structure. This required moving the color out of loadTimeData. Fixed: 1126238 Change-Id: Ia544b51370011addebd1ec1ba786db23cdfe6ce3 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398511Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805309}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: Ib74ab98c7f04208b2206f8fe0988a79ee0aa87e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375286 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805308}
-
Alice Wang authored
This CL sets the selected account before collapsing the bottom sheet. It is a minor improvement to avoid showing empty collapsed account list. Bug: 1124737 Change-Id: I5f69cfe2a209ed0ef7bb9c17078b84452e743078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400279Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805307}
-
Michael Lippautz authored
- Allow downcast construction; - Disallow conversion to T* directly; - Disallow Get(); This CL concludes hardening as all uses left go through an intermediate CTP handle which retains the object as long as the thread does not terminate. Bug: 1125495 Change-Id: I4ab837127745378a57513d11ffbdea3fd961b20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396140 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#805306}
-
danakj authored
While unable to reproduce the exact failure, it is the case that if the renderer does not respond in time to previous IPCs sent through SynchronizeVisualProperties(), by submiting a new compositor frame, then a new request from the test will be dropped due to waiting for an ack. We do not need to wait for a compositor frame, but we do need the SynchronizeVisualProperties() call to send an IPC to the renderer, so we can use SynchronizeVisualPropertiesIgnoringPendingAck() instead to ensure progress. We also note that the test failed to set up an in-process child widget previously, and adjust it to have one. R=avi@chromium.org Bug: 1126153 Change-Id: I38d6f738696abf428defed966200b2c1dd6f0f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399313 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805305}
-
Jan Wilken Dörrie authored
Bug: 791541, 1126051 Change-Id: I545bf52bb42864e5ea8e3a900ef30bce20180297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400420Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f163ad2. With Chromium commits locally applied on WPT: de03f74d "WPT: Refactor contacts tests to use test-only-api.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I7ed51e9e0ceae873cb066e5af21ac7849d9715b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401058Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805303}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca9406bac452..b7310899f126 2020-09-09 hjd@google.com Merge "Revert "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3""" 2020-09-09 treehugger-gerrit@google.com Merge "Ensure that our join key doesn't contain "NoJank"." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1b18f384e8535efadfc1fba80f513cc7fffe4d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400883Reviewed-by:
-
Adithya Srinivasan authored
This reverts commit 74b8ec6f. Reason for revert: Suspect that its causing ios test failures in bots, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/11779 Original change's description: > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805136} TBR=holte@chromium.org,sebsg@chromium.org,sczs@chromium.org Change-Id: I5a1aa3987b4591a1a5b511df4d3834c1455ea643 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401300Reviewed-by:
-
Miguel Casas authored
Decoding a bitstream in VA has two steps: one, submitting the parsed parameters and encoded chunk, and two, executing the decode. For the first part, ToT VaapiWrapper submits every piece of data individually, acquiring and releasing |va_lock_| every time. This is unnecessary, so this CL refactors the SubmitBuffer() method into a new SubmitBuffer_Locked() and adds a SubmitBuffers() to bundle a couple of submissions together. This is verified via chrome:tracing and codepen.io/full/RwarYvG that plays 4 1280x572 VP9 videos at the same time. Tracing is captured for a few seconds, results are summarised in [1,2], basically: The total decode CPU time doesn't change much on neither kohaku nor Braswell(reks) but batch-submitting takes less time, specially on BSW from ~3x0.089ms= ~0.267ms to ~0.236ms [3], so about 10%. Having less contention in the Lock makes for an ancillary reduction in Execute_Locked() from 3.295 to 3.165ms. Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). Later CLs will migrate the other decoders, and possibly avoid the call to vaCreateBuffer() that takes a good 50% of the SubmitBuffer/s() time. [1] Kohaku w/o patch https://imgur.com/a/nVuE0Nk, [2] Kohaku with patch https://imgur.com/a/xhdbqHn [3] VP9 ToT calls SubmitBuffer 3 times per incoming encoded buffer. Bug: b/166646505 Change-Id: I1b8e36bb1d7107b5367b0b41137e2dc6625e1569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393629 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805300}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599609504-d5a4da8648bee9c45af68f0bedc0e876fcbf0d82.profdata to chrome-mac-master-1599651808-76687bf9821b87304e86bb785c30a5b3566b2da2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I91fe8486bd7bc100144bf9ce19a4e34587d45996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400277Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b820513f2f27..88a5d76f5f62 2020-09-09 tvanderlippe@chromium.org Fix auto-unittest compile target 2020-09-09 mathias@chromium.org Force accessible link color for invalid network requests 2020-09-09 tvanderlippe@chromium.org [globals] More cleanup 2020-09-09 alexrudenko@chromium.org Remove unnecessary file pattern in karma.conf.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I774842637aaa5376c8ba79601cb942029e8c2969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400882Reviewed-by:
-
kylechar authored
The tests no longer fail under msan/tsan. Bug: 974283 Change-Id: I61c6ab9711fc9e40837d5e79e59058ae5262b827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399445 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#805297}
-
Francois Doray authored
Normally, Intensive JS Timer Throttling is enabled when a tab has been hidden for 5 minutes. To facilitate testing, about:flags provides an option to enable the intervention immediately when a tab is hidden. Unfortunately, this affects timers set with a short timeout from the visibilitychange event and leads to unrealistic test condition. To provide more realistic test conditions, this CL changes the about:flags entry to enable the intervention when a tab has been hidden for 10 seconds. Bug: 1075553 Change-Id: I4594e920c3214d7e335851b941acb9bbe85aac65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399305Reviewed-by:
-
Peter Boström authored
The specific UAF happens as a views::Checkbox callback deletes the dialog in which it was hosted. Because the client pointer is cached in InputMethodAuraLinux::ProcessKeyEventDone there's UAF after that point. The fix checks if GetTextInputClient() has changed after InsertChar() or InsertText() and returns early, stopping event propagation. Bug: 1125187 Change-Id: Id6a277858adf69011d56627893a98b5603eee503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399245Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805295}
-
Josh Nohle authored
Use an expiration scheduler to notify the certificate manager when a public certificate has expired. Then, remove all expired public certificates from storage. Fixed: b/166117022 Change-Id: I28b019d805518e9f9520ccd427840f75bd5bee1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377070 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805294}
-
Josh Nohle authored
Call GetDeviceState RPC in contact downloader to check in the user's contact list has changed since the last upload to the Nearby Share server. While waiting for the GetDeviceState RPC to be implemented, we assumed contacts always changed; now, we invoke the RPC. Fixed: b/166115703 Change-Id: I4954673d3ba55c335311c782ded6bc5d6360daf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399899Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805293}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7598f4b003ea..48df087f8a86 2020-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 10121443c16d to ce08265ba5b7 (3 revisions) 2020-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1ab52e54abfd to a715b1b40535 (2 revisions) 2020-09-09 syoussefi@chromium.org Vulkan: Free 8 bits in RenderPassDesc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I6492177b62fb30bc171ad4a70c1156cc3479577d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400274Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for BoundsAnimationMode. enum class is more type safety. Bug: 940736 Change-Id: Idc09b7b7f3beec8b179a989e1f5a7e02d7d4734f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400581 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#805291}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9d5940fef55..81c6d6eeb4cf 2020-09-09 herb@google.com move canReuse to sub runs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ib56349bfca12c9812cf3fe563253c773579b449c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400881Reviewed-by:
-
Kramer Ge authored
TestSubsurface has a ptr to MockSurface wl_resource which may incur use-after-free if MockSurface is destroyed first. Do the same thing we do for MockXdgSurface in MockSurface dtor to avoid it. Change-Id: Ia63c187485c39033f715f446cc724fcc4043b46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391388Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#805289}
-
Marc Treib authored
These constants used to be defined in the factory and passed into the service. However, they're always the same, so might just as well be defined directly in the service. This avoids having to duplicate them in other factories (for iOS). Bug: 1102314 Change-Id: I518dcd04524f5a7e7e9399d66a4adc775df2aaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400419 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805288}
-
Ali Juma authored
This CL uses TaskShutdownBehavior::BLOCK_SHUTDOWN for the background task runner associated with an SQLLitePersistentCookieStore, matching the behavior in content/. This ensures that when an SQLLitePersistentCookieStore is destroyed, the call to SQLitePersistentStoreBackendBase::DoCloseInBackground posted to the background thread gets executed before the SQLitePersistentStoreBackendBase is destroyed, fixing an assertion failure. Bug: 1121986 Change-Id: I77c7fad335b07508fb316fc6b1a88b822692893d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398510Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805287}
-
Antonio Sartori authored
The previous implementation returned `true` for `*.example.com` subsumes `example.com`. However, since `*.example.com` does not match `example.com`, this should not be the case. And indeed according to 2.3.3 in https://w3c.github.io/webappsec-cspee/#subsume-source-expressions in this case the subsume algorithm should return `false`. Bug: 1086857 Change-Id: I449f72d2db0a918478fc1ba4250335ae57a4ae2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210463Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#805286}
-
Henrique Ferreiro authored
Replace NullableString16 with Optional<string16> from blink::Manifest and blink::PlatformNotificationAction, the last two usages of NullableString16 in Blink. Also, remove the exception to use this type from audit_non_blink_usage.py. Bug: 604860 Change-Id: I3cbed115d887b6e17d61220d24a15a38026d263a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233060 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#805285}
-
Swapnil authored
Extensions.ForceInstalledFailureUpdateCheckStatus always returns "no update" status in case of CRX_FETCH_URL_EMPTY error. This was verified by the statistics we gathered. This histogram is no longer required. Bug: 1109934 Change-Id: I7656a40de99d83b8acfdd0b29dd202cbb64371c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380271 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805284}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc89f636b89f..ca9406bac452 2020-09-09 hjd@google.com Merge "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3"" 2020-09-09 ssid@google.com Merge "Remove log that spams tests" 2020-09-09 taylori@google.com Merge "perfetto-ui: New version of marking" 2020-09-09 fmayer@google.com Merge "Heap Profiling quickstart for Windows." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1fe29b00b3fe8d5e35d90a71290a6d978301ad1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400273Reviewed-by:
-
Jose Dapena Paz authored
GCC: make begin/end/empty methods of StringPiece constexpr to allow them to be called from base::ConsumeDurationNumber Compilation fails in GCC in base::ConsumeDurationNumber, as it is a constexpr but it calls methods begin/end/empty in StringPiece that are not constexpr. This change makes them constexpr. ../../base/time/time.cc: In function ‘constexpr base::Optional<base::{anonymous}::ParsedDecimal> base::{anonymous}::ConsumeDurationNumber(base::StringPiece&)’: ../../base/time/time.cc:67:63: error: call to non-‘constexpr’ function ‘const value_type* base::BasicStringPiece<STRING_TYPE>::begin() const [with STRING_TYPE = std::__cxx11::basic_string<char>; base::BasicStringPiece<STRING_TYPE>::const_iterator = const char*; base::BasicStringPiece<STRING_TYPE>::value_type = char]’ 67 | StringPiece::const_iterator orig_start = number_string.begin(); | ~~~~~~~~~~~~~~~~~~~^~ Bug: 819294, 1049498 Change-Id: If8813ac2651ac444cde7b874a1540c98c256c5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394159Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#805282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6c5e5870e09f..b820513f2f27 2020-09-09 sigurds@chromium.org Rewrite heap snapshot test as e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91dfa280b949527ad7089776b56d852990c9c6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400880Reviewed-by:
-
