- 15 Mar, 2018 40 commits
-
-
Ian Vollick authored
Minor change to get the colors to match the spec. Bug: None Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9b16ca657ed0a4dcfd4fe28108997ef005e9e52f Reviewed-on: https://chromium-review.googlesource.com/963687Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543288}
-
Chris Harrelson authored
Previously, it did not update update them during layout, which could result in failure to update composited scroll offset after situations like scroll clamping during synchronous forced layouts. Bug: 820839 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I129e7db4c5f4bc7b862b38de84ff174e7950fd5c Reviewed-on: https://chromium-review.googlesource.com/963517 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#543287}
-
Hwanseung Lee authored
caption-side[1], isolation[2], unicode-bidi[3], writing-mode[4] are added to support in whitelist. and test file are also added. [1]https://drafts.csswg.org/css-tables-3/#propdef-caption-side [2]https://drafts.fxtf.org/compositing-2/#propdef-isolation [3]https://drafts.csswg.org/css-writing-modes-4/#propdef-unicode-bidi [4]https://drafts.csswg.org/css-writing-modes-4/#propdef-writing-mode Bug: 820299 Change-Id: Ic0395565e77363b27ed7f93c861c4258396d766e Reviewed-on: https://chromium-review.googlesource.com/962562Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#543286}
-
James Hawkins authored
components/proximity_auth: Make this component CrOS-only. This is true in practice. R=khorimoto@chromium.org, sky@chromium.org Bug: none Test: none Change-Id: Ibc90d3d78fc6e7829a8fc282d1fd8bd9763d6fc1 Reviewed-on: https://chromium-review.googlesource.com/963696Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#543285}
-
Kenneth Russell authored
These are needed with the LUCI configurations. On Buildbot these were silently ignored. TBR=iannucci@chromium.org, geofflang@chromium.org NOTRY=true Bug: 815092, 819899 Change-Id: I97f62b802e76b2d925590603e90f2d8bb4bab072 Reviewed-on: https://chromium-review.googlesource.com/963799Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543284}
-
Eric Karl authored
This change addresses banding issues by using the newly added glUnpremultiplyAndDitherCopyCHROMIUM. In cases where we previously rasterized into a RGBA4444 target, we instead rasterize into a temporary RGBA8888 target, then do an unpremultiply/dither copy into the RGBA4444 target. This means that tiles may be either unpremultiplied or premultiplied, so we need a way to pipe this information to the GLRenderer, so it can blend correctly. This change introduces a is_premultiplied property to ContentDrawQuadBase to handle this. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I769a51e6a5f37dd5b9bede42577dbfade17e27e2 Reviewed-on: https://chromium-review.googlesource.com/937991Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#543283}
-
Steven Bennetts authored
This CL: * Supports setting any valid property in internet-detail-page. * Correctly provides the VPN type when setting VPN properties. * Replaces 'VPN-{Username|Password}' with OpenVPN and L2TP specific entries so that fields are properly localized in network-property-list. * Adds OpenVPN.ExtraHosts to the detail page. Bug: 742666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I278576c18dfdc45e4b5151a08fd4ded0b0efeda0 Reviewed-on: https://chromium-review.googlesource.com/954342 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543282}
-
Erik Luo authored
Bug: 810176 Change-Id: Iccad1213fbaabb465f42dbdf75273c0c2fa8913e Reviewed-on: https://chromium-review.googlesource.com/941001 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543281}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c9c003404cd..a3a80b69082f $ git log 1c9c00340..a3a80b690 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 cwallez presubmit_unittest.py: use LUCI for the optional GPU tests on Linux Created with: roll-dep src/third_party/depot_tools BUG=815092 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifd2cc8663685b1bcd49e56954d04c50139f1f65b Reviewed-on: https://chromium-review.googlesource.com/963225Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543280}
-
Kimberly Hunter authored
This change applies the existing gpu bug workaround, init_gl_position_in_vertex_shader, to devices with PowerVR GPUs. By initializing gl_postion to a known value, a vertex shader can be created. This allows the following gl_tests to pass on PowerVR devices: GLOOBAttribTest.DrawUsingOOBMatrixAttrib R=piman@chromium.org TEST=Existing tests pass Bug: 286468, 416670 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iecb91777d093cdd0eb8079dc56aca92f6e4ad93d Reviewed-on: https://chromium-review.googlesource.com/956531Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543279}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddd9b6c95806..563a73429ee0 $ git log ddd9b6c95..563a73429 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b2034cdcc96b6dea62b499ba8508e031969b25c Reviewed-on: https://chromium-review.googlesource.com/963748 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543278}
-
Mike Frysinger authored
Change-Id: I2076b1659198a70dd2e0ceec7cad34d61727f446 Reviewed-on: https://chromium-review.googlesource.com/963789Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#543277}
-
Conley Owens authored
This change adds a boolean `was_cached` to the SubresourceLoadInfo struct. This lets consumers know whether or not the response was fetched from the network cache. Notably, this is important for recording page load metrics when the Network Service is enabled. BUG=816684 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I28d60ff7286feca5d333203405ee9c351f43c0ab Reviewed-on: https://chromium-review.googlesource.com/938650Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#543276}
-
Scott Chen authored
This CL fixes a few things that broke during a merge: - ID name change messed up by merge - paper-icon-button-light new syntax Bug: 819862 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I072a4e6127ca87ba9035a6a83f87bfa4cf4290af Reviewed-on: https://chromium-review.googlesource.com/961535 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#543275}
-
Dmitry Gozman authored
This token is globally-unqiue and has the same value between browser and renderer. By using it in trace events, one can match frame attribution for browser and renderer trace events. This will be used to at least support OOPIFs in DevTools Performance panel in the future. Bug: 820250 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I932be92154220731dfdc5998614c281b419dc1aa Reviewed-on: https://chromium-review.googlesource.com/956522 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543274}
-
Alice Boxhall authored
TBR=spqchan Bug: 822022 Change-Id: I68245d38a79fc9698f9528261f910c8eba822d48 Reviewed-on: https://chromium-review.googlesource.com/963151 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543273}
-
John Chen authored
Change-Id: Ia49dbb7244b3697601ac5704a218af25e9a6b05f Reviewed-on: https://chromium-review.googlesource.com/963731Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543272}
-
chaopeng authored
In this patch, we remove the rails configuration on Direct Manipulation. The rails configuration would restrict scroll events on X or Y rails. After this changes, user able to scroll to any direction by touchpad as touch screen on Windows, Android and touchpad on Edge. Bug: 779372 Change-Id: Idf1da1eb85c2a73f432b78b0002fde28609a4cfe Reviewed-on: https://chromium-review.googlesource.com/963043Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543271}
-
Daniel Cheng authored
Change-Id: I8327f38e0cb1c96bb92b0b19a291d21b1a8b36b1 Reviewed-on: https://chromium-review.googlesource.com/961736Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543270}
-
Bill Orr authored
VrInputConnection stores a callback to call when a request completes. If another request comes in, the callback is overwritten, and the new callback will be called. The second request will not have a callback to call, breaking assumptions and crashing. The fix is to queue callbacks to handle multiple outstanding requests. Bug: 821990 Change-Id: I937136bc5291805b5a421f162c4ec175d511867b Reviewed-on: https://chromium-review.googlesource.com/963695Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543269}
-
Josh Horwich authored
Update the logic to decide if ARC OptIn dialog is shown for managed users to only skip it if both ArcBackupRestoreEnabled and ArcLocationServiceEnabled are managed and false. BUG=b:73339871 TEST=unit_tests, Opt in to ARC++ with Managed User Change-Id: Ibf5a513f0559f511ef386042da7a227af9d4af89 Reviewed-on: https://chromium-review.googlesource.com/963003 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543268}
-
Ned Nguyen authored
Change-Id: I5d39a8e928695164a18179f9a907c8af3fc1f6f0 Reviewed-on: https://chromium-review.googlesource.com/962985 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#543267}
-
Dmitry Gozman authored
When the frame has already been detached, Client() will be nullptr. Since we can call LocalWindowProxy methods even when detached, e.g. through ToV8ContextEvenIfDetached(), we should null-check the client. This is a band-aid fix, because we actually should not initialize context on a detached frame and change ToV8ContextEvenIfDetached to never force context. However, the proper solution has many risks and needs additional investigation. Bug: 805882 Change-Id: Idcd6bbc0e6eec9b2de53acfb646b30bd9636d797 Reviewed-on: https://chromium-review.googlesource.com/949603 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#543266}
-
edchin authored
This CL also renames some other assets for naming consistency. Bug: 818198 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1b603f16740e5ac5279533ea39db6f9d3ab1088a Reviewed-on: https://chromium-review.googlesource.com/962832Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543265}
-
Xianzhu Wang authored
Use ClampSub on integer values instead of clampTo<int> on float values. This can improve record time by 3% on Android (https://pinpoint-dot-chromeperf.appspot.com/job/14d64d9e440000 click "Analyze benchmark results). Change-Id: I8521a93caf821c551f342c551b5de84b6e35e092 Bug: 820467 Reviewed-on: https://chromium-review.googlesource.com/958292Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543264}
-
Fredrik Hubinette authored
Avoid calling pow() on negative numbers as that causes undefined behavior in the shader. Bug: 821967 Change-Id: Iab3dc9840c17d90aa5952adf17b8b24e2890d055 Reviewed-on: https://chromium-review.googlesource.com/962969Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#543263}
-
Mike Klein authored
We used to build the .S files with -ffp-contract=fast for this, and adding it here to the HSW opts will have the equivalent effect. None of the other x86 targets support FMAs. In many key places we do call _mm256_fmadd_ps explicitly, but in several other stages we have been relying on Clang to sniff out opportunities, especially for fused-multiply-subtracts, which we're just not very good at seeing in our heads. Bug: 821012 Change-Id: I2767cbdb7151d60ea7553e83f51b28ff9340eb94 Reviewed-on: https://chromium-review.googlesource.com/963141Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#543262}
-
Alice Boxhall authored
Bug: 820761 Change-Id: I910fede13345b2159aca28a418887d75e5c2b201 Reviewed-on: https://chromium-review.googlesource.com/958643Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#543261}
-
Alexander Alekseev authored
Bug: 794371 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I89faadd5eeda922bcd8f7aad3180e47a65400d59 Reviewed-on: https://chromium-review.googlesource.com/963683 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#543260}
-
Kouhei Ueno authored
We have planned to implement streaming CBOR parser, but the plan changed. Bug: 803774 Change-Id: I281d6ad20e213d786a48e0cf6171c2dea403393b Reviewed-on: https://chromium-review.googlesource.com/963150Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#543259}
-
Becky Zhou authored
+ Make expand icon right aligned for the expandable header with 16dp right padding Bug: 821462 Change-Id: I17f24f891013479c3297e062e5e72f04c1257115 Reviewed-on: https://chromium-review.googlesource.com/960925Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543258}
-
rbpotter authored
Since the final PDF from print preview is now sent directly to the printer in all cases, the PDF should be regenerated in all cases where the user changes a setting that should modify the final PDF, including "Print as Image". Bug: 813267 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I49202c782c35209d319f146b272dd49c2d0cfd07 Reviewed-on: https://chromium-review.googlesource.com/963282Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#543257}
-
Alice Boxhall authored
TBR=sammiequon@chromium.org Bug: 822049 Change-Id: I25c7cf6bd7d4f1641c37afaaa176d7b24f674c39 Reviewed-on: https://chromium-review.googlesource.com/963153Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543256}
-
Donn Denman authored
Fixes the recent regression with tap gesture recognition in Reader mode tabs. Converting a tab to show the simplified view is one of the rare times when we get a new CVC or WebContents for the same tab. With this change we check if the tab is connected to a different WebContents and create a new observer when it is. BUG=821676 Change-Id: I8ba56ffba42a6ca9c138c2cd1c387e398cc27591 Reviewed-on: https://chromium-review.googlesource.com/962992Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543255}
-
Qiang Xu authored
changes: Declare methods in AccessibilityFocusRingController that chrome needs in mojo interface. Bug: 594887 Change-Id: I5d8b47eb91301e848e2a2d3d13ad60b946db8a65 Reviewed-on: https://chromium-review.googlesource.com/957524 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543254}
-
edchin authored
Removes dead and unnecessary code. Bug: 818198 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I468a5018ec794b4c921f569362d37f1da3d1d6a5 Reviewed-on: https://chromium-review.googlesource.com/963319Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543253}
-
Jay Civelli authored
This CL fixes the SecurityIndicatorTest.CheckIndicatorText with the network service by using a URLLoaderInterceptor. Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I25cecf5301b2b963a8c64cb515c45d6cdd74cf31 Reviewed-on: https://chromium-review.googlesource.com/961449Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543252}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 20ce9b76. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13844 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts jfernandez@igalia.com: external/wpt/css/css-align jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jsbell@chromium.org: external/wpt/IndexedDB jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mek@chromium.org: external/wpt/webmessaging TBR=leon.han@intel.com No-Export: true Change-Id: I54188d8fa4d3b434ea6f8b3ea067f34c2bd98a65 Reviewed-on: https://chromium-review.googlesource.com/963500 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543251}
-
Nicholas Verne authored
Bug: 814626 Change-Id: I8d4622c78b6e2404c7012f28319cbe8ca37690d9 Reviewed-on: https://chromium-review.googlesource.com/938543Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#543250}
-
Jinsuk Kim authored
It is possible that a few android.view.View APIs are called after WebContents gets destroyed. This CL keeps them from accessing the destroyed instance by safeguarding it at ContentView where they pass through. Alternatively this could be done at embedder level (i.e. parent view of ContentView), but this approach reduces duplicated code. And re-enabled the disabled test. Bug: 821750 Change-Id: Ied55e7d36c589e6e7e324d081204c9a1294da7b2 Reviewed-on: https://chromium-review.googlesource.com/963149Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#543249}
-