- 09 Dec, 2016 40 commits
-
-
ahest authored
Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset #4 id:20002 of https://codereview.chromium.org/2537893002/ )" Reverted in https://codereview.chromium.org/2548883002/ Reason for relanding: turns out something else was causing these failures. See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17 TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org BUG=668707 Review-Url: https://codereview.chromium.org/2564943002 Cr-Commit-Position: refs/heads/master@{#437632}
-
lgrey authored
This is almost the same exact code, so it might be worthwhile to find a way to abstract it out, but I think it's probably not in scope for this CL. BUG=648557 Review-Url: https://codereview.chromium.org/2563593003 Cr-Commit-Position: refs/heads/master@{#437631}
-
bnc authored
This lands server change 127437330 by jamessynge. BUG=488484 Review-Url: https://codereview.chromium.org/2558243002 Cr-Commit-Position: refs/heads/master@{#437630}
-
rsesek authored
BUG=none R=anthonyvd@chromium.org Review-Url: https://codereview.chromium.org/2561163004 Cr-Commit-Position: refs/heads/master@{#437629}
-
mbjorge authored
arm devices require the OPUS_FIXED_POINT. This define got lost at some point. Add a public_dep so the media_unittests gets the necessary config. BUG=672352 TEST=gn desc out/ //media:media_unittests Review-Url: https://codereview.chromium.org/2562513003 Cr-Commit-Position: refs/heads/master@{#437628}
-
jamescook authored
Original CL http://crrev.com/2558083003 was reverted for use-after-free caused by my test network detailed view registering observers that were not properly cleaned up. Switched to using the real system menu network detailed view. Eventually extension-controlled network information will come out of a mojo service. This provides test coverage to make sure the icon shows up in the system tray menu. BUG=651157 TEST=chrome browser_tests Review-Url: https://codereview.chromium.org/2565823002 Cr-Commit-Position: refs/heads/master@{#437627}
-
lgrey authored
BUG=648557 Review-Url: https://codereview.chromium.org/2559243002 Cr-Commit-Position: refs/heads/master@{#437626}
-
lukasza authored
Before this CL, blink::Resource class would define 2 almost identical methods: - Same const-ness - Same return type - Same body - Different name and access: public |getDataBufferingPolicy| and protected |dataBufferingPolicy|. This CL removes the redundant dataBufferingPolicy() and tweaks the only caller of the removed method to call getDataBufferingPolicy() instead. This CL helps with rewrite_to_chrome_style which would have renamed dataBufferingPolicy to getDataBufferingPolicy to avoid type-vs-method name conflict (see r414550 and r417471). Such rename would mean two definitions of the same method and so would mean a build error. BUG=582312 Review-Url: https://codereview.chromium.org/2561403003 Cr-Commit-Position: refs/heads/master@{#437625}
-
qiankun.miao authored
BUG=634519 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2564813002 Cr-Commit-Position: refs/heads/master@{#437624}
-
lawrencewu authored
BUG=672859 Review-Url: https://codereview.chromium.org/2568533002 Cr-Commit-Position: refs/heads/master@{#437623}
-
amp authored
BUG=671349 Review-Url: https://codereview.chromium.org/2559873002 Cr-Commit-Position: refs/heads/master@{#437622}
-
estade authored
BUG=671718 Review-Url: https://codereview.chromium.org/2550413004 Cr-Commit-Position: refs/heads/master@{#437621}
-
mbrunson authored
When a large number of rows are present in the device table, scrolling performance drops considerably. This is due to the table recalculating its size due to button elements being in each row of the table. Replaces buttons in device table with action links to speed up rendering of the device table. BUG=651282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2558493004 Cr-Commit-Position: refs/heads/master@{#437620}
-
lpy authored
Document::themeColor() only looks for meta-theme-color inside <head>, however, the spec for meta-theme-color does not restrict it to <head>. BUG=671823 Review-Url: https://codereview.chromium.org/2566523003 Cr-Commit-Position: refs/heads/master@{#437619}
-
jmadill authored
Revert of Run dEQP ES3 tests on Windows AMD bots. (patchset #2 id:20001 of https://codereview.chromium.org/2510153002/ ) Reason for revert: Looks like the generated json didn't get updated properly. Original issue's description: > Run dEQP ES3 tests on Windows AMD bots. > > It's important for ANGLE to be able to test both NVIDIA and AMD (our > Windows WebGL 2 conformance targets) standalone with dEQP > for correctness on ANGLE rolls and ANGLE try bots. This change will > add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, > and the ANGLE CQ. The Optional tester is not included for now. > > BUG=641080 > R=kbr@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > NOTRY=true > > Committed: https://crrev.com/597826c59589969bc904e9287adcf2bc9cdcfccf > Cr-Commit-Position: refs/heads/master@{#437354} TBR=kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641080 Review-Url: https://codereview.chromium.org/2567793002 Cr-Commit-Position: refs/heads/master@{#437618}
-
skyostil authored
When a 0x0 element is in view, its intersection ratio is defined[1] to be 1. BUG=662826 [1] https://wicg.github.io/IntersectionObserver/#update-intersection-observations-algo Review-Url: https://codereview.chromium.org/2556243003 Cr-Commit-Position: refs/heads/master@{#437617}
-
dewittj authored
Recently OfflinePageModelChanged was renamed to OfflinePageAdded to reflect the reality of when that function was being called. As a result, the OfflinePageAdded function now receives as a parameter the OfflinePageItem that was added. This allows for a much simpler observer function that directly operates on the new page in the download cache. BUG=638276 Review-Url: https://codereview.chromium.org/2555013003 Cr-Commit-Position: refs/heads/master@{#437616}
-
nick authored
BUG=560438 Review-Url: https://codereview.chromium.org/2558673003 Cr-Commit-Position: refs/heads/master@{#437615}
-
rtoy authored
setTargetAtTime should allow a time constant of 0. This means the output value jumps instantaneously to the target value at the start time. Spec: https://webaudio.github.io/web-audio-api/#widl-AudioParam-setTargetAtTime-AudioParam-float-target-double-startTime-float-timeConstant BUG=630869 TEST=audioparam-setTarget-timeConstant-0.html, audiparam-exceptional-values.html Remove test for timeConstant=0. Review-Url: https://codereview.chromium.org/2426893003 Cr-Commit-Position: refs/heads/master@{#437614}
-
jmadill authored
https://chromium.googlesource.com/angle/angle.git/+log/dceacf5..023c2b1 BUG= TBR=geofflang@chromium.org TEST=bots NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2557743009 Cr-Commit-Position: refs/heads/master@{#437613}
-
pfeldman authored
Review-Url: https://codereview.chromium.org/2567573002 Cr-Commit-Position: refs/heads/master@{#437612}
-
halcanary authored
upcoming CL: https://review.skia.org/5461 Review-Url: https://codereview.chromium.org/2564103002 Cr-Commit-Position: refs/heads/master@{#437611}
-
takumif authored
Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 Review-Url: https://codereview.chromium.org/2554753002 Cr-Commit-Position: refs/heads/master@{#437610}
-
reillyg authored
This calls out the targets generated by mojom.gni that other targets should be depending on. BUG=None Review-Url: https://codereview.chromium.org/2560953004 Cr-Commit-Position: refs/heads/master@{#437609}
-
gurchetansingh authored
crrev.com/2533163002 changed the internal format representation of the GbmBuffer class. The function used to convert back to the gfx::BufferFormat type, GetBufferFormatFromFourCCFormat, is missing NV12. This format gets passed from the ARC++ container to Chrome, so video playback isn't working on some platforms. Let's fix this by adding the format. BUG=b:33011213 TEST=Play Youtube App video on minnie R=dnicoara@chromium.org, dcastagna@chromium.org, tfiga@chromium.org, posciak@chromium.org Review-Url: https://codereview.chromium.org/2562903002 Cr-Commit-Position: refs/heads/master@{#437608}
-
caseq authored
Review-Url: https://codereview.chromium.org/2564613003 Cr-Commit-Position: refs/heads/master@{#437607}
-
sadrul authored
. GpuServiceProxy -> GpuHost . GpuServiceProxyDelegate -> GpuHostDelegate . GpuServiceHost -> GpuHost . GpuServiceImpl -> GpuClient . GpuServiceInternal -> GpuService BUG=none Review-Url: https://codereview.chromium.org/2559183003 Cr-Commit-Position: refs/heads/master@{#437606}
-
phulce authored
Adjust CookiesTable comparator to get the correct property for string comparisons. BUG=671251 Review-Url: https://codereview.chromium.org/2550213002 Cr-Commit-Position: refs/heads/master@{#437605}
-
zea authored
Fixes a flaky issue introduced in the recent tabs submenu tests due to inspecting possibly unset timestamp values. Also fixes a pre-existing issue where sync ids for tabs were not being set, which the refactor brought to light. BUG=671902, 671902 TBR=msw Review-Url: https://codereview.chromium.org/2562853002 Cr-Commit-Position: refs/heads/master@{#437604}
-
dbeam authored
* up contrast to 4.5:1 for small text * fix some aria roles * update header colors (and make settings match while I'm at it) R=calamity@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2555693006 Cr-Commit-Position: refs/heads/master@{#437603}
-
rohitrao authored
The net stack will not send HTTP requests to a specific set of blacklisted ports, but the OS may assign one of those ports to the EmbeddedTestServer. This was causing spurious net_unittests failures on iOS when it happened. This CL modifies the EmbeddedTestServer to retry until it is assigned a non-blacklisted port. BUG=607630 Review-Url: https://codereview.chromium.org/2562893002 Cr-Commit-Position: refs/heads/master@{#437602}
-
lilyhoughton authored
building the URLRequestContext manually. This change is entirely internal, so it does not yet actually take a config object as an argument. BUG=523858 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2502683003 Cr-Commit-Position: refs/heads/master@{#437601}
-
Pavel Feldman authored
R=alph@chromium.org Review-Url: https://codereview.chromium.org/2563763003 . Cr-Commit-Position: refs/heads/master@{#437600}
-
dglazkov authored
Turns out, typ treats the absence of the unit tests as failure, and we don't have any tests at the moment. R=peria,bashi,haraken BUG=672738 Review-Url: https://codereview.chromium.org/2557403003 Cr-Commit-Position: refs/heads/master@{#437599}
-
zhaobin authored
We would like to ensure following execution order when calling PresentationRequest.start(): 1. resolve start() promise 2. fire PresentationRequest onconnectionavailable event 3. fire PresentationConnection onconnect event To fire event after resolving promise, we need to dispatch events asynchronously BUG=669213 Review-Url: https://codereview.chromium.org/2547143002 Cr-Commit-Position: refs/heads/master@{#437598}
-
scottchen authored
BUG=621903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2563443005 Cr-Commit-Position: refs/heads/master@{#437597}
-
shrike authored
The AutocompleteTextFieldEditor draws a background, apparently even when you call setDrawsBackground:NO (at least during editing). Because of the 1pt spacing set by UX between the security decoration border and the start of omnibox text, this background started drawing into the decoration's hover rect. On the right edge it drew into the edge of the focus ring. This cl prevents the AutocompleteTetFieldEditor from drawing a background, relying instead on the background drawn by the textfield's cell. It also changes decorations to be drawn after the cell's interior, to prevent the background overlap when not editing. R=avi@chromium.org BUG=669870,672518 Review-Url: https://codereview.chromium.org/2562863002 Cr-Commit-Position: refs/heads/master@{#437596}
-
yoshiki authored
BUG=672392 TEST=trybots pass Review-Url: https://codereview.chromium.org/2558083005 Cr-Commit-Position: refs/heads/master@{#437595}
-
emircan authored
This is follow-up for CL[0] that moved passing of WebRTC rendering frames off of main thread. That CL caused a regression in test[1] where the number of unique frames encoded is less, suggesting that we are dropping frames. Traces showed that compositor thread may be blocked by long texture upload calls and frames get accumulated in the meantime. We might be dropping frames due to the limit of having only 3 frames in flight. This CL addresses this issue by moving these calls to IO thread directly. In order to do it: - FrameDeliverer classes in MediaStreamVideoRendererSink and WebMediaPlayerMS are moved to IO thread. - WebMediaPlayerMSCompositor::EnqueueFrame gets called on IO thread. - Since WebMediaPlayerMSCompositor operates on three threads, I made it a ref counted object. This way, we do not need to create multiple WeakPtr factories or synchronize/block destruction on multiple threads. [0] https://codereview.chromium.org/2472273002/ [1] crbug.com/667262 BUG=667262,652923 TEST=Tested running JS alert() in console during an AppRTC loopback. Review-Url: https://codereview.chromium.org/2529263004 Cr-Commit-Position: refs/heads/master@{#437594}
-
dgn authored
Java tests that involve building dex files can reach the dex method limit when their dependencies pull at lot of content. This CL enables multidexing for a few targets that fail building when we stop pre-proguarding the play services library BUG=668211 Review-Url: https://codereview.chromium.org/2563663002 Cr-Commit-Position: refs/heads/master@{#437593}
-
