GitLab

Renames enable-new-qp-input-view to enable-new-md-input-view. Because QP is a internal code name, we should use md instead.

BUG=422869

Review URL: https://codereview.chromium.org/863093006

Cr-Commit-Position: refs/heads/master@{#314763}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/600d716..4b9569f

TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/897093003

Cr-Commit-Position: refs/heads/master@{#314762}

This change is picked from https://github.com/libevent/libevent/commit/ea6b1df

BUG=455089

Review URL: https://codereview.chromium.org/895323002

Cr-Commit-Position: refs/heads/master@{#314761}

Revert of Clean up V4L2 codec-related flags and defines (patchset #3 id:40001 of https://codereview.chromium.org/828063009/)

Reason for revert:
x86 Chrome compile failure due to https://code.google.com/p/chromium/issues/detail?id=455545.

Original issue's description:
> Clean up V4L2 codec-related flags and defines
>
> All arm platforms support V4L2 SVDA by default and use_v4l2_codec also governs V4L2 VDA/VEA now.
> Generates libv4l2 stub in GN file.
>
> BUG=449883
> TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks,
> and panther_freon
>
> Committed: https://crrev.com/d5eeecc577f274bb8ed9d1954f263d83b5f00050
> Cr-Commit-Position: refs/heads/master@{#314536}

TBR=piman@chromium.org,wuchengli@chromium.org,henryhsu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449883

Review URL: https://codereview.chromium.org/902773003

Cr-Commit-Position: refs/heads/master@{#314760}

This is a cleanup change in preparation for [ http://crbug.com/450509 ], where
metrics will be logged in non-ChromeOS-only code.

BUG=450509
TEST=compiles
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/887093004

Cr-Commit-Position: refs/heads/master@{#314759}

Add an IsEnabled() method to the EasyUnlockService, and other minor cleanup.

BUG=none
TEST=none
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/889153004

Cr-Commit-Position: refs/heads/master@{#314758}

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/884003003

Cr-Commit-Position: refs/heads/master@{#314757}

Revert of Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test". (patchset #1 id:1 of https://codereview.chromium.org/899103002/)

Reason for revert:
Speculatively reverting to try to fix broken Mac 10.8 retina and Nexus 4 layout tests.

Original issue's description:
> Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test".
>
> At this point, "--run-layout-test" is the flag that is actually functional, and using "--dump-render-tree" simply causes the "--run-layout-test" to be appended to the command line.
>
> A subsequent Blink patch will change the scripts in Blink to use "--run-layout-test" instead of "--dump-render-tree".
>
> BUG=453252
>
> Committed: https://crrev.com/7066b52aa7103b402dea27c64ec17d45c373a838
> Cr-Commit-Position: refs/heads/master@{#314664}

TBR=avi@chromium.org,paulmeyer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453252

Review URL: https://codereview.chromium.org/896403002

Cr-Commit-Position: refs/heads/master@{#314756}

Revert of Throttle resource message requests during user interaction (patchset #14 id:300001 of https://codereview.chromium.org/847883002/)

Reason for revert:
The new DCHECKs for CalledOnValidThread are breaking tests everywhere:
https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/6021

Original issue's description:
> Throttle resource message requests during user interaction
>
> Resource message requests can be relatively expensive, particularly in
> the induced work on the browser IO thread. Currently, there is no bound
> on the rate with which such requests are dispatched from the renderer.
> This leads to situations where the browser IO thread is flooded with
> requests, potentially causing scroll jank and otherwise undesirable
> stalls in the browser pipeline.
>
> Introduce a ResourceMessageThrottler which intercepts and defers a given
> resource message stream, depending on the state of the RendererScheduler.
> When the RendererScheduler indicates that high priority work is
> imminent/likely, requests will be throttled according to a configurable
> dispatch rate.
>
> Hook this throttling mechanism up to the ResourceDispatcher, limiting
> the number of resource message requests/second during user interaction
> to 180 (3 per frame at 60 fps) on Android, and 480 on desktop.
>
> See goo.gl/H42AgQ for more design details.
>
> BUG=440037,402136
>
> Committed: https://crrev.com/acfb4199abf841a1577c3968579c43b0232a53b7
> Cr-Commit-Position: refs/heads/master@{#314739}

TBR=alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org,rmcilroy@chromium.org,davidben@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440037,402136

Review URL: https://codereview.chromium.org/897223002

Cr-Commit-Position: refs/heads/master@{#314755}

We should investigate why the binaries generated by gold are bigger.

BUG=396333

Review URL: https://codereview.chromium.org/869043007

Cr-Commit-Position: refs/heads/master@{#314754}

TBR=rvargas@chromium.org
BUG=455536
NOTRY=true

Review URL: https://codereview.chromium.org/876473005

Cr-Commit-Position: refs/heads/master@{#314753}

Non-blocking IO has higher throughput than the previous implementation
that used overlapped IO. 15% increase in throughput for sending to
localhost is observed. There could be additional performance advantage
in WiFi network.

All existing UDP socket tests passed. I added a unit test to do
benchmarking. Also tested this manually with WebRTC and verified that
all UDP send and receive activities are logged correctly.

BUG=442392

Review URL: https://codereview.chromium.org/861963002

Cr-Commit-Position: refs/heads/master@{#314752}

This function used to be used to support multiple backends, and is no
longer used.

BUG=

Review URL: https://codereview.chromium.org/900133003

Cr-Commit-Position: refs/heads/master@{#314751}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fc49b4d..600d716

TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/894093005

Cr-Commit-Position: refs/heads/master@{#314750}

TBR=rsleevi@chromium.org
BUG=455533
NOTRY=true

Review URL: https://codereview.chromium.org/896323004

Cr-Commit-Position: refs/heads/master@{#314749}

Revert of Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (patchset #1 id:1 of https://codereview.chromium.org/900133002/)

Reason for revert:
These aren't the changes you're looking for.

Original issue's description:
> Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (patchset #1 id:1 of https://codereview.chromium.org/899073003/)
>
> Reason for revert:
> Reason for revert:
> Speculatively reverting to try to fix broken Mac 10.8 retina layout tests in Blink:
> compositing/iframes/iframe-composited-scrolling-hide-and-show.html
> compositing/iframes/overlapped-iframe-iframe.html
> svg/as-border-image/svg-as-border-image-2.html
> and more.
>
> Original issue's description:
> > Make Reflector Use Main Thread MessageLoop when in SingleThread
> >
> > When in using single thread with browser compositor, make reflector use
> > main thread MessageLoop instead.
> >
> > Test with forced SW mirrored display on both Linux-cros build and Pixel.
> > BUG=453732
> >
> > Committed: https://crrev.com/0b88b2372f1ad82c12656a4b9a17098470e576a1
> > Cr-Commit-Position: refs/heads/master@{#314665}
>
> TBR=danakj@chromium.org,weiliangc@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=453732
>
> Committed: https://crrev.com/6cb534f690545ebda6751d153a6e72f50d4003cc
> Cr-Commit-Position: refs/heads/master@{#314732}

TBR=danakj@chromium.org,weiliangc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453732

Review URL: https://codereview.chromium.org/896393002

Cr-Commit-Position: refs/heads/master@{#314748}

Revert of Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (patchset #1 id:1 of https://codereview.chromium.org/897173003/)

Reason for revert:
These aren't the changes you're looking for.

Original issue's description:
> Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (patchset #2 id:20001 of https://codereview.chromium.org/860283005/)
>
> Reason for revert:
> Speculatively reverting to try to fix broken layout tests in Blink:
> compositing/iframes/iframe-composited-scrolling-hide-and-show.html
> compositing/iframes/overlapped-iframe-iframe.html
> svg/as-border-image/svg-as-border-image-2.html
> and more.
>
> Original issue's description:
> > Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits
> >
> > setIgnoreViewportTagScaleLimits copies the default limits into the UA
> > constraints. This was happening before the defualt limits were set during
> > initialization so it was clamping page scale at [1,1].
> >
> > BUG=453377
> >
> > Committed: https://crrev.com/ebbcc53e21fbfe15a76fa7fbf6d14c84095880ee
> > Cr-Commit-Position: refs/heads/master@{#314668}
>
> TBR=aelias@chromium.org,sievers@chromium.org,bokan@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=453377
>
> Committed: https://crrev.com/910b93d89932cc75fcce36f4dbc5f3bef7c2f064
> Cr-Commit-Position: refs/heads/master@{#314723}

TBR=aelias@chromium.org,bokan@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453377

Review URL: https://codereview.chromium.org/900153002

Cr-Commit-Position: refs/heads/master@{#314747}

This CL ignores updates to and disables the Most Likely apps when the page is
animating away from the start page. This prevents the apps from disappearing
due to a search being initiated.

BUG=454667

Review URL: https://codereview.chromium.org/897583002

Cr-Commit-Position: refs/heads/master@{#314746}

[gcc] Fix build failure caused by error: multi-line comment [-Werror=comment] in focus_traversal_unittest.cc

gcc toolchain throws a warning for using a trailing '\' in a comment which begins with '//'.

clang toolchain doesn't throw any warning for this hence its not captured by our bots.

Compiler option -Wno-comment appended after -Wall fixes the above issue but results in having inconsistent
comments.

The code snippet at [1] cleverly avoids these warnings as shown.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser/content_hash_tree.h&l=23

R=mgiuca@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/874663003

Cr-Commit-Position: refs/heads/master@{#314745}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/12753cc..a9d9de4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/893233005

Cr-Commit-Position: refs/heads/master@{#314744}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/895083003

Cr-Commit-Position: refs/heads/master@{#314743}

There are two changes to make this work:
-Set the plugins width/height to 100%. We will soon be using this for the material layout as well.
-Allow MimeHandlerViewGuests to handle pinch gestures when they are full-page plugins.

BUG=453729

Review URL: https://codereview.chromium.org/904553002

Cr-Commit-Position: refs/heads/master@{#314742}

Also ship the LTO plugin header so we can build LLVM against it.

BUG=453195
R=thakis@chromium.org
CC=thestig@chromium.org

Review URL: https://codereview.chromium.org/899783003

Cr-Commit-Position: refs/heads/master@{#314741}

Revert of Move tracing namespace from base::debug to base::trace_event. (patchset #7 id:120001 of https://codereview.chromium.org/882673002/)

Reason for revert:
broken Memory.FYI TSan bot.
crbug.com/455530

Original issue's description:
> Move tracing namespace from base::debug to base::trace_event.
>
> After having transitioned all the tracing headers from base/debug/ to
> base/trace_event, this CL addresses the namespace move.
> In principle, this CL should only change the namespace of the
> base/trace_event files but the namespace used by the tracing clients.
> In order to achieve this, namespace aliases are appended to the
> trace_event headers, to make it so that clients can still refer to
> base::debug::TraceFoo, with that being aliased to
> base::trace_event::TraceFoo.
> The upcoming CLs will gradually migrate the clients to use the
> base::trace_event namespace and will remove the ns aliases.
> Unfortunately, this CL has also to update few tracing clients,
> in particular the ones having forward declarations. Forward
> declarations, in fact, cannot be aliased as the compiler sees them
> before the alias itself.
>
> See crrev.com/837303004 and the related bug for motivations and design doc.
>
> BUG=451032
> TBR=skyostil@chromium.org,jam@chromium.org
>
> Committed: https://crrev.com/97c5abba36f5ce473cd996fab74fbf5aa9bb5464
> Cr-Commit-Position: refs/heads/master@{#314657}

TBR=dsinclair@chromium.org,picksi@chromium.org,primiano@chromium.org,skyostil@chromium.org,ssid@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451032

Review URL: https://codereview.chromium.org/904573002

Cr-Commit-Position: refs/heads/master@{#314740}

Resource message requests can be relatively expensive, particularly in
the induced work on the browser IO thread. Currently, there is no bound
on the rate with which such requests are dispatched from the renderer.
This leads to situations where the browser IO thread is flooded with
requests, potentially causing scroll jank and otherwise undesirable
stalls in the browser pipeline.

Introduce a ResourceMessageThrottler which intercepts and defers a given
resource message stream, depending on the state of the RendererScheduler.
When the RendererScheduler indicates that high priority work is
imminent/likely, requests will be throttled according to a configurable
dispatch rate.

Hook this throttling mechanism up to the ResourceDispatcher, limiting
the number of resource message requests/second during user interaction
to 180 (3 per frame at 60 fps) on Android, and 480 on desktop.

See goo.gl/H42AgQ for more design details.

BUG=440037,402136

Review URL: https://codereview.chromium.org/847883002

Cr-Commit-Position: refs/heads/master@{#314739}

r314575 removed a default `files` array on the `Internet Plug-Ins` Mac
bundle subfolder, so it was only added with disable_nacl=0

This adds an empty default array to match the targets below.

Review URL: https://codereview.chromium.org/877553010

Cr-Commit-Position: refs/heads/master@{#314738}

BUG=chromium:448415
TEST=validate_format, pretty_print

Review URL: https://codereview.chromium.org/901783002

Cr-Commit-Position: refs/heads/master@{#314737}

 - InputMethod.PkCommit.Index
 - InputMethod.PkCommit.Type

BUG=367631
TEST=None

Review URL: https://codereview.chromium.org/893313003

Cr-Commit-Position: refs/heads/master@{#314736}

Reverting back to using BGRA_8888 format to fix the following errors:
[0204/075331:ERROR:gl_image_linux_dma_buffer.cc(79)] Invalid format:
6408
[0204/075331:ERROR:vaapi_drm_picture.cc(110)] Failed to create GLImage

BUG=447798
TEST=Ran ./video_decode_accelerator_test and verified that the above
error isn't present anymore

Review URL: https://codereview.chromium.org/886353005

Cr-Commit-Position: refs/heads/master@{#314735}

This separates the code used to "host" the setuid sandbox binary from
the code used to run underneath it (i.e., the client).  The primary
motivation for this is so that lightweight clients (e.g., the BMM
non-SFI sandbox) can avoid all of the additional dependencies required
only for hosting the setuid sandbox.

TBR=mseaborn@chromium.org,nasko@chromium.org
BUG=455087

Review URL: https://codereview.chromium.org/877153005

Cr-Commit-Position: refs/heads/master@{#314734}

This removes some unused code and simplifies some dependencies. I'm planning to pull the audio code out into its own component, and it'll be clearer if I do minimal refactoring along the way.

Review URL: https://codereview.chromium.org/901753002

Cr-Commit-Position: refs/heads/master@{#314733}

Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (patchset #1 id:1 of https://codereview.chromium.org/899073003/)

Reason for revert:
Reason for revert:
Speculatively reverting to try to fix broken Mac 10.8 retina layout tests in Blink:
compositing/iframes/iframe-composited-scrolling-hide-and-show.html
compositing/iframes/overlapped-iframe-iframe.html
svg/as-border-image/svg-as-border-image-2.html
and more.

Original issue's description:
> Make Reflector Use Main Thread MessageLoop when in SingleThread
>
> When in using single thread with browser compositor, make reflector use
> main thread MessageLoop instead.
>
> Test with forced SW mirrored display on both Linux-cros build and Pixel.
> BUG=453732
>
> Committed: https://crrev.com/0b88b2372f1ad82c12656a4b9a17098470e576a1
> Cr-Commit-Position: refs/heads/master@{#314665}

TBR=danakj@chromium.org,weiliangc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453732

Review URL: https://codereview.chromium.org/900133002

Cr-Commit-Position: refs/heads/master@{#314732}

Previously: when multiple permissions were requested, they could only
be toggled individually if the user clicked on "Customize."

Now: the bubble will always allow for customization if there are
multiple permissions in the request. it will be the default state.

BUG=440563

Review URL: https://codereview.chromium.org/885373004

Cr-Commit-Position: refs/heads/master@{#314731}

Recent changes (merging PDFium) have pushed some binaries over the limit.

BUG=453844
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/897163002

Cr-Commit-Position: refs/heads/master@{#314730}

7061d1a  Update GN files from previous commit as well.
1be2034  Initialize V8 outside of PDFium.
62120b7  Prevent base::CheckedNumeric from leaking outside of pdfium.
c32dac1  Replace CFX_SmartPointer cast operator with Get() method.
0c01ad0  Fix stack exhaustion in CPDF_DataAvail::HaveResourceAncestor()

BUG=455399
TBR=tsepez

Review URL: https://codereview.chromium.org/904513006

Cr-Commit-Position: refs/heads/master@{#314729}

This allows callers to pass a char* (string literal) or StringPiece
(lightweight substring) without having to explicitly construct a string
object.

Refactored the implementation to avoid an ugly const_cast and Boolean to
avoid mutating a const pointer. Updated tests to use char* literals, and
added some new tests to test the new edge cases.

BUG=455068

Review URL: https://codereview.chromium.org/895913004

Cr-Commit-Position: refs/heads/master@{#314728}

BUG=351501
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/875073004

Cr-Commit-Position: refs/heads/master@{#314727}

This CL makes StartPageView subclass View instead of
SearchResultContainerView. A new SearchResultContainerView has been
added as a child of StartPageView instead. This change will facilitate
further refactoring.

BUG=455059

Review URL: https://codereview.chromium.org/896063002

Cr-Commit-Position: refs/heads/master@{#314726}

Added max_transform_feedback_separate_attribs, max_uniform_buffer_bindings,
and uniform_buffer_offset_alignment to Capabilities.
These were introducted in GLES 3.0.

BUG=429053
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/885013002

Cr-Commit-Position: refs/heads/master@{#314725}

This patch enables the following flow for throttled plugins:
1. Place real plugin on page, preroll for a few seconds until a keyframe is extracted.
2. On throttle, replace the plugin with a PluginPlaceholder. Set the extracted keyframe as the poster. Meanwhile, the real plugin is hidden, throttled, but still alive.
3. On clicking the placeholder, replace the placeholder with the original throttled plugin.

BUG=443810,403800

Review URL: https://codereview.chromium.org/866173002

Cr-Commit-Position: refs/heads/master@{#314724}