GitLab

We used to do so, and the resulting data doesn't make sense.

BUG=224262
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13119014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192526 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly a copy of https://chromiumcodereview.appspot.com/12395010 which was reverted due to a regression (https://code.google.com/p/chromium/issues/detail?id=189100). I have attempted to fix that regression here.

BUG=189100,179381

Review URL: https://chromiumcodereview.appspot.com/12529012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192525 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the new methods in GDataWapiService. Because the GData WAPI
will be deprecated, so instead of splitting GetResourceListOperation, keeping
it as is but set some default parameters in GDataWapiService.
The new methods are not used yet, but will be soon used.

BUG=160932
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/13429004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192523 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192522 0039d316-1c4b-4281-b951-d872f2087c98

Second attempt at this change.  The required a native_client change:
https://codereview.chromium.org/12499011/

Thus this change also brings in NaCl changes from
11084:11126 inclusive.

BUG=196627
TEST=run nacl brower tests one ARM linux


Review URL: https://chromiumcodereview.appspot.com/13652003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225536


Review URL: https://chromiumcodereview.appspot.com/13472020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192520 0039d316-1c4b-4281-b951-d872f2087c98

Make LabelButton focusable on set_style(STYLE_NATIVE_TEXTBUTTON).
(this matches NativeTextButton::Init behavior)

Change NativeTextButton to LabelButton in FocusTraversalTest like:
https://codereview.chromium.org/13584010 Patch Set 4.

Update MessageLoopForUI...RunWithDispatcher() test comments.

BUG=155363,226814
TEST=native style LabelButtons are focusable by default. Tests pass.
R=tfarina@chromium.org,sky@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13639003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192519 0039d316-1c4b-4281-b951-d872f2087c98

This won't be allowed by unique_ptr<T> or scoped_ptr<T>.

BUG=171118

Review URL: https://codereview.chromium.org/13710002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192518 0039d316-1c4b-4281-b951-d872f2087c98

TEST=browser_tests --gtest_filter=\*DirectoryReader\*

Review URL: https://chromiumcodereview.appspot.com/13643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192517 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=japhet@chromium.org

Review URL: https://codereview.chromium.org/13517005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192515 0039d316-1c4b-4281-b951-d872f2087c98

Commands are updated when focus is updated. This makes sense, when executing commands by pressing an ui element. However, when executing a command via a shortcut, we may execute it while it shouldn't be allowed to be executed. This patch fixes it by updating the command's state (disabled/enabled) just before executing it via a shortcut.

TEST=Enter Files.app, select a file, then deselect a file, hit Delete button. A delete command should not be invoked.
BUG=174554


Review URL: https://chromiumcodereview.appspot.com/13532006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222218
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/13434005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192513 0039d316-1c4b-4281-b951-d872f2087c98

Fixed IsCapturingUserMedia() and IsBeingMirrored() to use WebContents pointer
to identify tabs.


Review URL: https://chromiumcodereview.appspot.com/13355003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192512 0039d316-1c4b-4281-b951-d872f2087c98

When the browser cache for a given profile is cleared
we will now clear out any shaders stored in the
shader disk cache for that profile.

BUG=176289


Review URL: https://chromiumcodereview.appspot.com/12500009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192511 0039d316-1c4b-4281-b951-d872f2087c98

> Re-apply 192420: Move login switches to src/chromeos
> Includes fix for GOOGLE_CHROME_BUILD
> 
> BUG=192420
> TBR=ben@chromium.org, nkostylev@google.com
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13671005

TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/13590004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180591
TEST=misc audio clients in Chrome using the new --force-wave-audio flag on Win7
Review URL: https://codereview.chromium.org/13639002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192509 0039d316-1c4b-4281-b951-d872f2087c98

Add ContentViewCore#udpateFrameInfo trace event.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13688003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192508 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192507 0039d316-1c4b-4281-b951-d872f2087c98

scoped_ptr<T[]>, which will replace scoped_array<T>, does not support
passing NULL as an explicit argument to reset().

BUG=171118

Review URL: https://codereview.chromium.org/13692002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192506 0039d316-1c4b-4281-b951-d872f2087c98

Includes fix for GOOGLE_CHROME_BUILD

BUG=192420
TBR=ben@chromium.org, nkostylev@google.com


Review URL: https://chromiumcodereview.appspot.com/13671005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192504 0039d316-1c4b-4281-b951-d872f2087c98

Image and tracking updates are now tracked separately, so that we properly
distinguish between adds/updates.

BUG=226539


Review URL: https://chromiumcodereview.appspot.com/13666003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192503 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192502 0039d316-1c4b-4281-b951-d872f2087c98

-Track frame info for newly inserted nodes via DOM.childNodeInserted.
-Update subframe execution context IDs.
-Return NoSuchFrame if the frame doesn't have a execution context
BUG=chromedriver:279


Review URL: https://chromiumcodereview.appspot.com/13651002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225857


Review URL: https://chromiumcodereview.appspot.com/13650008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192500 0039d316-1c4b-4281-b951-d872f2087c98

Previously, there were two code paths in BrowserPluginGuest to request a new window (new <webview>) from the embedder: one for suppressed openers and one for unsuppressed openers. This CL unifies the two code paths.

BUG=none
Test=WebViewTest.Shim, WebViewTest.NewWindow


Review URL: https://chromiumcodereview.appspot.com/13649007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226642
TEST=AACTest_TestImplicitSBR_ChannelConfig0,AACTest_TestImplicitSBR_ChannelConfig1


Review URL: https://chromiumcodereview.appspot.com/13648007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192498 0039d316-1c4b-4281-b951-d872f2087c98

- we want to check a data block of a specific tag and enough length,
  which doesn't mean && here.
- data_block skipping length is different between two continue

BUG=226318
TEST=ui_unittests passed


Review URL: https://chromiumcodereview.appspot.com/13648004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192497 0039d316-1c4b-4281-b951-d872f2087c98

These are only used downstream, so the failure was invisible upstream.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13691002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172584


Review URL: https://chromiumcodereview.appspot.com/13620002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192495 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that users don't lose any saved settings when upgrading to M27.

BUG=226488


Review URL: https://chromiumcodereview.appspot.com/13619010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192494 0039d316-1c4b-4281-b951-d872f2087c98

Remove NativeWidgetWin::RestoreFocusOnActivate's built-in hack.
Always use kReasonFocusRestore in FocusManager::RestoreFocusedView().
Always run FocusManager::SetFocusedViewWithReason with kReasonFocusRestore.
(this clears and resets child HWND focus, needed for the hack)

Fixes initial omnibox focus on Win with --enable-views-textfield; plus:
interactive_ui_tests.exe --gtest_filter=BrowserFocusTest.ClickingMovesFocus --enable-views-textfield
views_unittests.exe --gtest_filter=BubbleDelegateTest.InitiallyFocusedView --enable-views-textfield
(test updated to have the proper expectation, removing a non-Aura Win hack)
Doesn't regress child HWND focus like the previous attempt: http://crrev.com/186235

Remove SearchTextfieldView Textfield subclass; make RequestFocus non-virtual.
TODO(followup): Polish find-bar focus behavior as needed in followups.

BUG=125976,131660,224591,225963
TEST=View and web-contents focus restoration on minimize/restore; repro steps in bugs. Find bar works as expected (may need attention in followups). Tests pass with --enable-views-textfield.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13227002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192493 0039d316-1c4b-4281-b951-d872f2087c98

This is for working around the case when <input type="file"/> control is used
twice; CrOS file picker kindly resolves a remote file path to a local cache
and the type=file control tries to default to the path, but the cache path
itself is out of user-visible directory. In such a case, we just use the
last_selected_directory(), rather than going back to the very default directory.

BUG=178013

Review URL: https://chromiumcodereview.appspot.com/13614002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192492 0039d316-1c4b-4281-b951-d872f2087c98

A number of users have been reporting problems with the identity API. Gaia investigations reveal that these users have overflowed a limit on the number of login tokens they can have for Chrome. Revoking tokens we don't need any longer should mitigate the problem. 

This is identical to https://codereview.chromium.org/13249007/ but with a corrected base url.

BUG=224462

Review URL: https://chromiumcodereview.appspot.com/13599003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192491 0039d316-1c4b-4281-b951-d872f2087c98

In https://codereview.chromium.org/12983010/

reversed_root_transform is passed into event::UpdateForRootTransform.

Then for TouchEvent::UpdateForRootTransform(), the radius_x/y now
should times the inverted device scale factor instead of being
divided by it. The same in ScrollEvent::UpdateForRootTransform() for
scroll offset ordinal.

BUG=chromium:226169
TEST=On Link, visit http://www.rbyers.net/paint.html, make sure
     touch radius has normal range.

Review URL: https://chromiumcodereview.appspot.com/13594009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192490 0039d316-1c4b-4281-b951-d872f2087c98

The Menu Button ui control that the history action pop-ups employ
handle the resize event by hiding the menu.  This CL will similarly
hide the menu on a |scroll| event is triggered.

This resolves the scrolling problem in the referenced bug.

However, this change does not address the reported behavior that the
pop-up remains visible when changing tabs. I tend to agree with
sergiu@ that the existing behavior seems proper.

BUG=222313
TEST=The MenuButton ui element is used in several places; I tested the History, Bookmark Manager and NTP but I can see it also being used in ChromeOS login screen and File Manager which I am unable to test. The change involves hiding the menu pop-up when the document scroll event is triggered.

Review URL: https://chromiumcodereview.appspot.com/13532014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192489 0039d316-1c4b-4281-b951-d872f2087c98

- Remove the EndKeepALive work arounds;
- Manage app session lifetime explicitly by watching app
  window counts;

BUG=226103

Review URL: https://chromiumcodereview.appspot.com/13581008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192487 0039d316-1c4b-4281-b951-d872f2087c98

Due to weirdness with GPUs on trybots causing flakiness in tests, the initial implementation of CompositingIOSurfaceTransformer was committed with all unit tests disabled.  This change will enable the tests, but force the software-based OpenGL implementation to be used.

In a later change, we will allow the OpenGL implementation to auto-detect and utilize a GPU, where one is available.  However, first the tests should prove themselves as stable when not using GPU.

TBR=kbr


Review URL: https://chromiumcodereview.appspot.com/13573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192486 0039d316-1c4b-4281-b951-d872f2087c98

install-build-deps.sh runs "sudo /path/to/src/build/linux/install-chromeos-fonts.py".
If the repo is on a filer, sudo fails because root is not allowed to access files on
a filer. However, installing a Repo on a Filer is not recommended.
Solution:
install-build-deps.sh attempts to detect that the Repo is not on a Filer and
in that case prints a warning with instructions.

Note: install-build-deps.sh exits immediately on failure because it uses "bash -e".

BUG=225543
R=derat@chromium.org
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/13532003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192485 0039d316-1c4b-4281-b951-d872f2087c98