GitLab

When prompting the user for APP scanning, the "Discard" button is still
present in the download shelf. It hidden behind the "Scan" button,
but still accessible via Tab/Enter keys, leading to accidental discards
when operating via keyboard.

This CL makes no visible changes to the UX.

Bug: 1049748
Change-Id: Ie4cb9fbc42341cca76bc5479e4ca9f207f7e9226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042388Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739147}

Bug: 1046910
Change-Id: I71360304e19988a111a9364aa57eb401f70ed783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040621Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739146}

The rebaseline expectation from
https://chromium-review.googlesource.com/c/chromium/src/+/2031863 is missing
the border around the month picker.

Bug: 1049650
Change-Id: I8360d3c10547815196f080b2c4d5b6700977ac60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042521Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#739145}

ErrorOr<> makes it easier to return an arbitrary value or an error.
For example, one might:

ErrorOr<std::unique_ptr<int>> Foo() {
  // return a ptr, or a MediaError explaining why not.
}

Change-Id: I819b29c1dcc9ba2512ab709da2ae6b267a24d8b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040374
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739144}

The name AssistantWebView is now freed up in Ash and can be used by
the AssistantWebView2 interface.

Bug: b:146520500
Change-Id: I9ddb0e5e7fe9697a7cc3a350e8607c973d4f22bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040733
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739143}

To limit fetching for URL-keyed hints when no hint is returned, an
empty entry is added to the URL-keyed hint cache so the page navigation
fetch will not continuously re-fetch for the same URL.

This is important for limiting server load before any feature using
URL-keyed hints is enabled.

Bug: 1048717
Change-Id: Ic8250d1f463bde6c5bd71b18910a7f584c80fa6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042271
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739142}

The issue is that we don't reset the contents_changed_ flag to false at
the end of DrawingBuffer::FinishPrepareTransferableResourceSoftware.
Here's the problem:
1) We draw something into webgl canvas (DrawingBuffer) and export it as
   a software resource (FinishPrepareTransferableResourceSoftware).
2) Later we do a readPixels on the canvas (which is
   preserveDrawingBuffer: false).  The readPixels will clear the canvas
   to match spec behavior
   (WebGLRenderingContextBase::ClearIfComposited).
3) The next time blink document lifecycle happens (rAF, resize, etc.)
   DrawingBuffer thinks it needs to export the back buffer to compositor
   again because contents_changed_ is still true.
4) DrawingBuffer exports the cleared back buffer to compositor.

This CL includes a pixel test that simulates the above case by switching
tabs (and calling readPixels) to force a document lifecycle update. The
included test fails before this fix and passes afterwards.

Bug: 1047829
Change-Id: I1496919b974d84e975db28eafd9b8e6ffc71d91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040732Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739141}

Avoids a UAF by disconnecting the mojo::Receiver from the pre-finalizer.

Bug: 1043603
Change-Id: I1592a517bf74dd4fcb8e947e1122442864e0dacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042276Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739140}

Bug: 992823
Change-Id: Ib1fa7a548291426068b4ecc156b10a0c1241337a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040797Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739139}

Bug: 1042534
Change-Id: I90ebfa07d025bc668593aa8df08c8cbbe4ddb8a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031755
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739138}

File handling is a slightly different to other features which go into
origin trial: The underlying OS holds state to let it identify handlers
for different file types.

This CL cleans up that state when an origin trial expires, so that apps
which don't have a valid trial, don't show up as file handlers in the
operating system.

On navigation to a page inside an installed app with file handlers,
we store the time that the trial expires. If the trial has
already expired, we unregister the file handlers. If the trial is valid,
but the app's file handlers are not registered, we register them.

On Chrome start up, we unregister file handlers for all apps for
which the origin trial has past it's expiry date.

This ensures that apps without a valid origin trial token will show up
in the open with menu at most one Chrome restart, or until the user
visits the site again, whichever happens first.

Bug: 1028448
Change-Id: I6e2d19d7462d1f94955f1ca51abffd2a4c53096d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940001Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739137}

Phase 2 of ChromeVox custom annotations project.

This change adds a new file to the ChromeVox codebase called
user_annotation_handler.js. This file exposes methods to create
and get annotations for AutomationNodes. It also modifies the Output
module to check for annotations when outputting the node name, and
reports one to the user if found (and the feature is enabled). Lastly,
this change adds tests in the user_annotation_handler_test.js file,
which act as integration tests by asserting speech output.

This file is being added to support ChromeVox custom annotations.
For more details on that project, please see the following design

document: 
https: //docs.google.com/document/d/1K6Sg0wLOjUdz7ycJqxPnFWNvie7yaJ3enlss10cXKqM/edit
Change-Id: Ib35c77f8df295f9dbae5ba702ffef6af6668b269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992805
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739136}

This fixes an issue where clean up tasks are scheduled but not run until
later when another user has signed in.

Bug: 1048231
Change-Id: I0a453463117d10abcb2c9e9927e9ee3824443892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036392Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739135}

This also removes the "Experimental" from the API methods, as features
must make a breaking change when they leave origin trial.

Bug: 719176
Change-Id: I3daa6bbe82fda07a9f549672c7b94269904059f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037181Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739134}

This handles this switch and set ARC request param accordingly.

TEST=Locally, unit test
BUG=b:147978162

Change-Id: I739fb91481ce054ab6e175100ead6dade246a418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042375
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739133}

Bug: 1048119
Change-Id: I0ead8b2aaee34a27c030259829ad279a6261c92c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042314Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739132}

When the WebUIOmniboxPopup flag is on, this CL doesn't add the native
result views.

This CL is just meant to "hollow out" the OmniboxPopupContentsView
when the flag is on. The next step would be add an actual
views::WebView to take the place of all the child result views.

This CL was deliberately kept to just a bunch of stubs to illustrate
all the integration points we would need with a WebUI popup.

Even when the flag is on, we keep the actual OmniboxPopupContentsView,
because it's responsible for drawing the "beard" and transparent
poke-through that we need even if we render the popup contents in
WebUI.

Bug: 1046561
Change-Id: I01d7a77413b760a290dc823b2a142921121f81cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042218Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739131}

We are still interested in these histograms.
Extending their expiry by another year.

Fixed: 1048207
Change-Id: I573b2bb70ddda06bbc58e01583386169f6b94c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036356Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#739130}

Not reporting metrics below:
Scheduling.Renderer.BeginMainFrameQueueDurationCritical
Scheduling.Browser.BeginMainFrameQueueDurationCritical
As they are reported under:
CompositorLatency.SendBeginMainFrameToCommit.BeginMainSentToStarted


Bug: chromium:976030
Change-Id: I4a32b9234d267712d485188f1b1383c6a327fd58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024916Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739129}

This handler was little bit overcomplicated. This led to a bug in web
kiosk mode when we update network state, but do not update the handler.

Because of this convolution, in web kiosks, the network configure
screen did not update itself when connected to network(which is what
client will expect from the handler which observes network state).
Now it behaves more logically and predictably.

Bug: 1015383
Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739128}

Add support for CopyOutputRequest::result_selection when using
SkiaRenderer with the Skia readback API. Previously the field was
ignored in SkiaOutputSurfaceImplOnGpu. The skia readback API doesn't
support specifying a clip rect in the destination pixel space, so this
is a bit of a workaround with the potential for some rounding errors.

This CL also adds SkiaReadbackPixelTest. It draw a frame containing a
source image with a CopyOutputRequest. The pixels that are read back are
compared against reference PNGs. The test is based on
GLRendererCopierPixelTest and uses the same source and result PNGs.

Bug: 1047217
Change-Id: I9f97cacafff15833d6ce97d36c69c70b55d09479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033624
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739127}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/50984a64faec..816c2b3548fb

git log 50984a64faec..816c2b3548fb --date=short --first-parent --format='%ad %ae %s'
2020-02-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-02-06 ehmaldonado@google.com git-cl: Remove _add_codereview_[issue_]select_options and _CODEREVIEW_IMPLEMENTATIONS.

Created with:
  gclient setdep -r src/third_party/depot_tools@816c2b3548fb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I79128767d064067a3cdaad50ed12712e0ff20c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042332Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739126}

I am removing the auto/legacy tests because the code does not do the
right thing for those and at any rate this is no longer supported.
I will remove them in a later CL.

Bug: 991096

Change-Id: I3d4722074b8c3f4f97d5129f54d3795a41cfce78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039591
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739125}

Relying on tabProvider.get() as an iterator causes an infinite loop on
tablets. As an alternative, I aggregate all Tabs under each TabModel
and iterate over them explicitly.

Bug: 1046308
Change-Id: I3f096a0549ef9a7d463acc4eebbed46f7c9aac99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033703
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739124}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/73f1b60756e3..7457e5e4ba27

git log 73f1b60756e3..7457e5e4ba27 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 michael.liao@microsoft.com [Common - ConfirmDialog]: Placing initial focus on OK button and making dialog SR accessible

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@7457e5e4ba27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:963183
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If999c708798defbcdeb96b649089c41ba43e57ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042657Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739123}

This reverts commit 9e9a0e96.

Reason for reland: Closing file before moving it to appease windows

Change-Id: Iaa9b51861232c98ef4bf7210f868dbe20544c5c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040950
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739122}

https://chromium.googlesource.com/openscreen.git/+log/297e9f7db90b..39dda173e881

git log 297e9f7db90b..39dda173e881 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 mfoltz@chromium.org [Open Screen] Update documentation on threading, other fixes.

Created with:
  gclient setdep -r src/third_party/openscreen/src@39dda173e881

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I3abe87f0b1fa89c95613deca667c30a75828e8be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041807Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739121}

Updates the expires_after attribute for 48 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 30 days of 2020-08-17.

Change-Id: I8116b948f4bc5a8ca791a0d320d7b552cd242d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042255
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739120}

Show a chip on the tab card if that tab has search result page in its
navigation stack. The chip contains the search term. When clicked,
the tab would visit the search result page again.

This is behind a Finch parameter "enable_search_term_chip" under
TabGridLayoutAndroid.

The CL is split into two, and this is part one, which only contains the
diff that cannot be handled by the Formal Equivalence Checker in
http://crrev.com/c/1934235/4.

See also: part two (http://crrev.com/c/2036513).

Bug: 1048255
Change-Id: I6fa83d1179cb3700b65afde86327ecbb148ed92b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038458
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739119}

After app unexpectedly crashes in EG2 test, it is relaunched at -setUp
of next testMethod. Currently in this situation, |appNeedsLaunching| is
judged false and app is launched without TestCase +setUps at |activate|
method, which will cause DCHECK failures at +tearDown. This change makes
|appNeedsLaunching| judged true in this situation and run TestCase
+setUps after the relaunch to prevent DCHECK failures.

Bug: 1023911
Change-Id: I83bd06df7afdf2402fbb0593a6825910107534f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037852Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739118}

dom-breakpoints.js usually takes ~70 on some mac bots, but occasionally
exceeds 91s and runs into a timeout.

This CL splits the test into two, which hopefully makes it less likely
to trigger timeouts.

The test and, most importantly, the test expectations are just split;
they did not change.

Bug: chromium:1049444
Change-Id: Ie2288bafa5807726cfd1fddc5d91189bc2ad905a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042105
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739117}

Change-Id: I8b387723819d1fd138915b507eaac4624fd34917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042683
Auto-Submit: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#739116}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4d9391c167c..f5e5312d2154


Created with:
  gclient setdep -r src-internal@f5e5312d2154

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1044793
Tbr: jbudorick@google.com
Change-Id: I12401cbd0db5aa03004ed14d779f5464faa9988b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042654Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739115}

media/base/video_frame_pool.cc: remove an unnecessary test in a while
loop.

media/filters/dav1d_video_decoder.h: remove an unneeded #include.

Bug: N/A
Change-Id: I0014cee024c2321382f018bfbbe9065a9e135b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042675Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739114}

These files currently rely on getting these includes
transitively via inspector_protocol generated code.
Would like to make the dependency direct so it's easier
to change the generated code.

Change-Id: I84cb8889c6fd5c0d2245a91cb1b667f3e79f2a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037966Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739113}

Tbr: ender@google.com
Bug: None
Change-Id: Iba7a0e122310d7f7ba286dfd4c4296610a4f9bb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042296Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739112}

This fixes timeouts that were occurring when FlexNG was enabled:
https://test-results.appspot.com/data/layout_results/linux-rel/292466/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
(*/text-with-display-style.html)

These tests timeout if they don't receive all the expected performance
entries, causing the failure (the test never completes, waiting for the
performance entries).

The specific failure for FlexNG was occurring as we didn't have a
ScopedPaintTimingDetectorBlockPaintHook for the flexbox on the stack,
only one for the anonymous block-flow. This meant that the performance
entry was never recorded for the flexbox element.

Previously the ScopedPaintTimingDetectorBlockPaintHook would get
emplaced in two different places -
 1) Within BlockPainter
 2) Within the inline painter

This changes the EmplaceIfNeeded call to walk up the layout object
tree to the first non-anonymous object which has a DOM node associated
with it.

This walk up the layout object tree should be relatively cheap. Most of
the time it will be only walking up zero or one objects.

Additionally with the layout object walk we don't need to EmplaceIfNeeded
on nested <div>s, only when we actually encounter some text to be
painted.

Bug: 845235
Change-Id: I80e18539f70d2e1df56d3d85dd928dc10a35e28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032428
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739111}

The current test case for gfx::TransformBetweenRects only verifies
the function on the source rectangle whose origin is at (0,0).
This CL provides a more general test case.

Bug: 1046983
Change-Id: I06a451ce7bcbad1344139792d6265d5313fe782d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036272Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739110}

This change removes the watcher process.  The watcher process is
responsible for waiting for the browser process to exit and logs the exit
code to a known registry location. Subsequent launches read from the
registry location and log the value to a histogram.  The watcher process
was originally created prior to the creation of crashpad.  Since all the
watcher process is doing is waiting for the browser process to exit it
makes sense to move this functionality to the crashpad process and get
rid of the watcher process and code entirely.  Use of the registry is
now removed and the histogram is logged directly on shutdown.
This change removes the chrome_watcher.dll which gives back ~ 1MB of
disk space.

Bug: 1043844
Change-Id: I666819e64817197e8950a9c5749c921fcebdb964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035054
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739109}

This reverts commit c2f07278.

Reason for revert: This change is causing regression. Bounding box
calculation of a given element requires the |kScrollX| and |kScrollY|
positions. In case of PDF there is a scroll element which lives outside
the PDF node. The scroll element also reports scroll positions. During
calculation of bounding boxes in AXTree::RelativeToTreeBoundsInternal
|kScrollX| and |kScrollY| are applied twice.

Original change's description:
> Add viewport scroll information to PDFAccessibilityTree
>
> This CL adds following information to PDFAccessibilityTree
> - ax::mojom::IntAttribute::kScrollXMin
> - ax::mojom::IntAttribute::kScrollXMax
> - ax::mojom::IntAttribute::kScrollX
> - ax::mojom::IntAttribute::kScrollYMin
> - ax::mojom::IntAttribute::kScrollYMax
> - ax::mojom::IntAttribute::kScrollY
>
> It enables partial implementation of IScrollProvider, following methods
> will work with this change
> - IScrollProvider::get_HorizontallyScrollable
> - IScrollProvider::get_VerticallyScrollable
> - IScrollProvider::get_HorizontalScrollPercent
> - IScrollProvider::get_VerticalScrollPercent
>
> This information is required by Screen readers to announce the current
> scroll position and extent of scroll to the user.
>
> Tests: The best way to test this change will be through browser tests.
> However, it requires the second part of the change, detailed in the
> associated bug, to be completed.
>
> Bug: 1034521
> Change-Id: I629b2773c75f2b6b222d339cd0ae01799d695295
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985821
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Virender Singh <virens@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#728843}

TBR=dcheng@chromium.org,thestig@chromium.org,mohitb@microsoft.com,virens@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1034521
Change-Id: I15675f9ba604be96e9c50c9bea1dbe84ef8c9a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041714Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739108}