- 28 Jan, 2020 40 commits
-
-
Gabriel Charette authored
Migrates everything in base/task but post_job.h and lazy_task_runner.h which will be migrated in their own CLs. Bug: 1026641 Change-Id: If58acf8dd79ef848a16df210d4a283db10231a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996991 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#735733}
-
Yue Zhang authored
Bug: None Change-Id: I6712fb9a0c2df38a6c7a9612420f362258984ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024114 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735732}
-
Junbo Ke authored
Hit ERR_READ_IF_READY_NOT_IMPLEMENTED in SocketDataPump::ReceiveMore() when switching the Cast HTTP server to network::server::HttpServer. Add the implementation to unblock the migration. Bug: b/118771830 Merge-With: eureka-internal/342047 Test: CQ & manual Change-Id: I44666fa5b7f741d757c4382798b69f461a1e7fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018597 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#735731}
-
Jeremie Boulic authored
Initial tests for the StorageHandler, C++ side of the storage management page. Testing functions retrieving storage statistics of the local filesystem. Test: unit_tests --gtest_filter="*StorageHandlerTest*" Bug: 1044495 Change-Id: I8632f4607360deb4c0b4068d2db545e08a8db406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016767Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735730}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d1d9d35216b..086aded3cb74 git log 2d1d9d35216b..086aded3cb74 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 syoussefi@chromium.org Return the correct location count for matrices in structs 2020-01-27 courtneygo@google.com Vulkan: Allow user to specify preferred device Created with: gclient setdep -r src/third_party/angle@086aded3cb74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I83036211488fab82c887122d9488629831df7b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca7b3bf33052..9d635962bc78 git log ca7b3bf33052..9d635962bc78 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 ukai@google.com OWNERS: add ukai for cipd_manifest.* Created with: gclient setdep -r src/third_party/depot_tools@9d635962bc78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8067646c54fa0f6dc73e4a231751db45aa1217cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023878Reviewed-by:
-
Piotr Bialecki authored
- hit test subscription should fail when the session has ended - implement feature descriptor and feature policy for hit test - add WPTs to check whether subscription succeeds/fails appropriately Changes: Change-Id: Ib7735ca3c1015a4e3742c71d6d144e24a79c935e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019608 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735727}
-
Kei Nakashima authored
This change is for following the HTML standard. Accordingly, added willValidate check to validationMessage. It's for keeping the current behavior of validationMessage after this CL. Bug: 1038224 Change-Id: Ied5f6bcdc5eda495de6d3925435e73d856b23b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015912 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735726}
-
Joel Hockey authored
This feature is now always enabled Change-Id: Ie671537ca44eb834ad6d5aaae0b88212cbaa5b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024387 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#735725}
-
Regan Hsu authored
This CL moves a big chunk of mostly OS Settings strings (and one one shared string) out of browser settings string provider to os and shared setting string provider: * AddCrostiniStrings * AddPluginVmStrings * AddAndroidAppStrings * AddAppsStrings * AddAppManagementStrings * AddParentalControlStrings * AddBluetoothStrings * AddChromeOSUserStrings * AddDeviceStrings * AddEasyUnlockStrings * AddFilesStrings * AddInternetStrings * AddMultideviceStrings * AddUsersStrings * AddGoogleAssistantStrings Bug: 967888 Change-Id: I115a9e4817204d136edf7dea97d8cfabfefb56a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008365Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Robert Liao authored
Previously, the IncreasedContrastThemeSupplier bypassed most of the incognito colors. This worked fine as the colors it did specify worked with non-incognito colors in incognito. http://crrev.com/719713 removed this bypass, resulting in incognito colors applied to the IncreasedContrastThemeSupplier and white-on-white text as well as light-on-white controls. This change reintroduces this opt-out as a workaround. BUG=1045630 Change-Id: Ib83172fbd90559bc72e94e850591ee66cd4ad4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024468 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735723}
-
Yue Zhang authored
Bug: 1002678, 1004570 Change-Id: I4ab4ec1fb3fce3d8267357ec03805346b6d3ec35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023197Reviewed-by:
-
Alex Moshchuk authored
A few functions in RenderProcessHostImpl, such as IsSuitableHost, were passing both a BrowserContext and either an IsolationContext or SiteInstance. This isn't needed, as both IsolationContext and SiteInstance already include BrowserContext information, so this CL removes the unnecessary BrowserContext arguments. Bug: 1015882 Change-Id: I248b999736adf409bb694af7330af8dcf5161d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021337 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#735721}
-
Yuchen Liu authored
Bug: internal b/139027108 Test: Build Change-Id: If42783475bb8428116030dc1ad69e7825d59b41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023284 Auto-Submit: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735720}
-
Koji Ishii authored
This patch implements |LayoutInline::NodeAtPoint| by replacing |NGPaintFragment::InlineFragmentsFor| with |NGInlineCursor|. Fixes ~6 tests. Bug: 982194 Change-Id: Id327810033008499593e27553b225e4e3758e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022447Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735719}
-
Anupam Snigdha authored
There were few bugs related to how the composition and selection ranges were modified when SetComposition call was executed in EditContext. This patch fixes those and also added unit tests for it. Bug: 999184 Change-Id: If354e99b2f9ac0fd455a97a849062ced4c457759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023676Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3234ce1347c5..fd7fd960be69 git log 3234ce1347c5..fd7fd960be69 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 brianosman@google.com Revert "In GrSkSLFP, always use a coord transform" 2020-01-27 jlavrova@google.com Dealing with SkScalar values in cache 2020-01-27 fmalita@chromium.org [skottie] Switch SkMatrix44 -> SkM44 2020-01-27 reed@google.com don't need to include deprecated Sk3D.h 2020-01-27 herb@google.com Rename AtlasID to PlotLocator 2020-01-27 bsalomon@google.com Fix case of asyncRescaleAndReadPixelsYUV420 for case where SkSurface is 2020-01-27 robertphillips@google.com Revert "Add SkImage::MakeRasterFromCompressed and make MakeFromCompressed fall back to decompression for unsupported compression types" 2020-01-27 brianosman@google.com In GrSkSLFP, always use a coord transform Created with: gclient setdep -r src/third_party/skia@fd7fd960be69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040643 Tbr: reed@google.com Change-Id: Ic8707e7d93e50a40c599a388ebbfa6844ae9c8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024280Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1634ebc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id54a02d48d2c92b500adfd73b63aa6db392cea64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023740Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735716}
-
Stefan Zager authored
Approved intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6dOOw2vu1is BUG=1015183 Change-Id: I5231d4014e4ac260a78c3328df6a1b8171e5e598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015676Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#735715}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2def28bf1003..32d4291f7a61 git log 2def28bf1003..32d4291f7a61 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 thestig@chromium.org Change CFX_DIBBase::GetPaletteSize() to return size_t. 2020-01-27 tsepez@chromium.org Fix segv in CXFA_LayoutPageMgr::ProcessLastPageSet(). Created with: gclient setdep -r src/third_party/pdfium@32d4291f7a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I55d8fb2a6017e3efd30711d8e326d4e23696e120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024308Reviewed-by:
-
Mingjing Zhang authored
This CL adds DomainDiversityReporter to schedule domain metrics computation tasks and emit histograms. The reporting task is executed shortly after startup and then scheduled once per 24 hours thereafter. Bug: 1015424 Change-Id: Id4b8043c1a9b9ea0ee70d4be68e9c35017a82de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864522 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#735713}
-
Will Cassella authored
Several methods are declared in blink::HTMLMediaElement, but aren't actually defined anywhere. This CL removes their declarations. Change-Id: I111cbf564c78285f9a9698953ef97e99a80a640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018256Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#735712}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL uses mojom::ScrollIntoViewParams::Behavior and clean up ScrollBehavior enum in Blink. Bug: 1039285 Change-Id: Id9a6a03c9ff64b8d36bc76511ad5ac784f660576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021567 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Sophie Chang authored
This is the precursor to adding async support for CanApplyOptimization. The hook will be to check after the hints are stored, whether there are any callbacks registered and run through the current CanApplyOptimization by type. Bug: 1036490 Change-Id: Ia28887d324263a3778cacc848272c22d6cc186f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018703 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#735710}
-
Hugo Benichi authored
The feature has been shipping since 2017Q4 and is always enabled by default. Remove the flag. BUG=None TEST=Compiled Change-Id: I244a2c79ef3eb84d321a90658e64f2e7db4b14c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014204Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#735709}
-
Shakti Sahu authored
Sometimes we incorrectly create two Just Now sections in download home. This leads to a crash in RecyclerView as stable IDs should be unique. This happens especially when there are two downloads very close to midnight, one before midnight and one after midnight. This CL fixes this issue and places both of them in one Just Now section. Change-Id: I5af6560c29a7413f86a6245719859197d72268dd Bug: 1020079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024068Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735708}
-
Wei-Yin Chen (陳威尹) authored
When the last tab is closed outside of the Grid tab switcher UI, for example, after tapping "close all incognito tabs" from Android notification, exit clank to avoid staying in a broken state. Bug: 1028893 Change-Id: Id8a289f578430f330c0af44916d10c52e51404ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024275Reviewed-by:
-
Yuchen Liu authored
Chromecast will use MediaDrmStorage to support persistent usage record. Bug: internal b/142677685 Test: Build Change-Id: Ie0ac3c962662004e0af9440046ccf3905d2c286b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006969Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735706}
-
Steve Becker authored
Exposes setExperimentalAppBadge() and clearExperimentalAppBadge() on the navigator for service workers. When a service worker uses the badging API, the badge update affects all web apps within the scope of the service worker's registration. Future changes can expose the badging API to dedicated workers and shared workers. The WICG draft spec (https://wicg.github.io/badging/) states that dedicated workers and shared workers may set a badge when they are a service worker client. To expose badging on WorkerNavigator, this change updates the existing badging code under /blink/renderer/modules/badging/. The change adds a new IDL file, worker_navigator_badge.idl. The new IDL defines a partial WorkerNavigator interface to add the set and clear badging functions. The change updates the existing NavigatorBadge class to include the new WorkerNavigator IDL bindings, which are identical to the existing Navigator IDL bindings except they pass a WorkerNavigator& parameter instead of Navigator&. The change moves the core implementation from the existing Navigator IDL bindings into SetAppBadgeHelper() and ClearAppBadgeHelper(). These helpers enable both the Navigator IDL bindings and the WorkerNavigator IDL bindings to use the same implementation. The next part of the change registers a blink::mojom::BadgeService binder in the ServiceWorkerGlobalScope's browser interface binders. The ServiceWorkerGlobalScope needs this registration to connect the NavigatorBadge class to the badging::BadgeManager class in chrome/browser. Without this registration, the JavaScript badging APIs do not trigger any badge updates for service workers. For the Window, the binder registration occurs through ContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(). Unfortunately, RegisterBrowserInterfaceBindersForServiceWorker() does not exist. Additionally, the Window binder registration provides the RenderFrameHost as context when creating a new mojo binding. The BadgeManager uses the RenderFrameHost as a binding context to find the URL to use when setting a badge. ServiceWorkerProviderHost is like RenderFrameHost, but for service workers. ServiceWorkerProviderHost can provide the service worker registration scope URL to use when setting a badge. Unfortunately, ServiceWorkerProviderHost is not publicly exposed to chrome/browser. This makes creating a RegisterBrowserInterfaceBindersForServiceWorker() problematic since the service worker cannot provide the same amount of context as the Window/Frame. Instead of using something like ContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(), this change registers the badging binder in the content layer in browser_interface_binder.cc. Keeping the binder in the content layer allows it to use the ServiceWorkerProviderHost to get the context it needs and then pass that context to the BadgeManager in chrome/browser. The change adds the ContentBrowserClient::BindBadgeServiceReceiverFromServiceWorker(), which allows the content badging binder to pass the service worker's Render Process Host and its scope URL to the BadgeManager, which the BadgeManager uses as the binding context. The change updates the BadgeManager class to work with both service workers and documents. There are two differences between service worker and document badge updates: 1) A service worker badge update may affect multiple apps. A document badge update may affect up to one app. 2) Service workers and documents provide different mojo binding contexts. Service workers provide a RenderProcessHost and a scope URL. Documents provide a RenderFrameHost and a frame ID. To deal with these differences, this change updates the pre-existing BadgeManager::BindingContext struct to be an abstract interface base class. The class has one method to override: GetAppIdsForBadging(), which returns the list of AppIDs to update after a badge change. The change adds two derived classes FrameBindingContext and ServiceWorkerBindingContext. Each class handles the differences described above. For testing, this change updates WebAppBadgingBrowserTest to include service worker test cases. The change added new test data to chrome/test/data/web_app_badging/ to facilitate service worker testing. The new browser tests use the main frame to post a message to the service worker. Depending on the message content, the service worker responds by either calling setExperimentalAppBadge() or clearExperimentalAppBadge(). The change also generalizes WebAppBadgingBrowserTest to handle when a service worker badge change affects multiple apps. Before this change, WebAppBadgingBrowserTest expected exactly 1 badge update. After this change, the test can expect multiple badge changes with at most 1 badge change per app. The change also updates the badging origin trial API web_tests to include service workers. I attempted to update the existing badging web_tests to include workers, but since these tests run as file://, all workers failed to run due to null origin errors. I was also unsuccessful moving these tests to run as https:// since the https:// server did not have the required resources to mock mojo. Bug: 1036202 Change-Id: I66b2bf66b787965d6aa4ac35b663e522ffc4bd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009376 Commit-Queue: Steve Becker <stevebe@microsoft.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#735705}
-
David Bokan authored
This reverts commit b746c948. Reason for revert: Still failing on Mac web tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16983 Original change's description: > [Reland#2] Make programmatic scrolls respect smooth scroll flag > > Programmatic smooth scrolls should also be instant if the smooth scroll > flag is explicitly disabled. > > Previously landed in https://crrev.com/c/1536759 and in > https://crrev.com/c/2009842 > > To reland, this CL force enables the scroll animator in Blink web > tests. Without this, the usual flow for determining if the animator is > enabled is followed, which leads to inconsistencies. On Mac, the > animator is enabled in Chrome but not in content shell. This leads to > inconsistencies with other platforms (Mac tests ran without smooth > scroll while Linux/Windows ran with) and ensuring we test what we ship. > > This change required some minor fixes to tests that assumed instant > scroll on Mac (and uncovered one real bug). > > Second reland fixes a few more tests on Mac. See diff from original > patchset for changes. > > TBR=flackr@chromium.org,nasko@chromium.org > > Bug: 944583 > Change-Id: Ib91c417f1fcc2b27601f2c7039b02da72b9d5420 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022356 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735480} TBR=flackr@chromium.org,nasko@chromium.org,bokan@chromium.org Change-Id: Ifad1c0b6a19f222391c2361e80c699d27da7576b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024412Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735704}
-
Mario Sanchez Prada authored
Add a new method to blink::mojom::LocalFrameHost interface, to be implemented right from RFHI, which will allow us to remove the WebLocalFrameClient::DidChangeLoadProgress() API plus the related bits under //content/renderer. Bug: 1008432, 1041076 Change-Id: Ic5e19292b8c8cce75b519fb516e311fb8d029f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003309Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#735703}
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer 3. Bug: 1026426 Change-Id: Ia950fecef1b3a13af65d5e1505d2cd37d1e1b5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024150Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735702}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f437869d4107..ca7b3bf33052 git log f437869d4107..ca7b3bf33052 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 ukai@google.com roll out new goma client binary (VERSION=188) Created with: gclient setdep -r src/third_party/depot_tools@ca7b3bf33052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib658d3675bf89294b653a574320adc45bca50f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024126Reviewed-by:
-
John Budorick authored
Bug: 1037892, 1046174 No-Try: true Change-Id: I427a0cd77e79c5cda66e92c931697eb16b28a511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024160 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#735700}
-
Kent Tamura authored
After crrev.com/735492, LayoutTextControlInnerContainer is unnecessary. TextControlInnerContainer exists only to apply LayoutTextControlInnerContainer, so we can remove TextControlInnerContainer too. This CL should have no behavior changes. Bug: 1040828 Change-Id: I091de82bc35f9c0e481edd06cf348205558aa378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024127Reviewed-by:
-
Xinghui Lu authored
Bug: 1036042 Change-Id: I1db72655a60ac12b3d88f3c41ccc80cb0725a3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015661 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735698}
-
Mohsen Izadi authored
A bool is set in CompositorFrameReporter indicating whether the frame was missed or not. Then it is converted to a MissedFrameReportType enum and passed around. First, we can use the enum from the beginning to keep frame miss status. We also don't need to pass it around inside CompositorFrameReporter as everywhere that needs it can query the member variable. The 's' was also removed from the end of the enum name to make it more consistent with the rest of the code base. The unnecessary, deprecated value kDeprecatedMissedFrameLatencyIncrease is also removed. Bug: None Change-Id: Ic65e872aa260c5b6cfbbef030c26ea7203ae6f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020511Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735697}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/17a6381c1c98..11b66cf1103c git log 17a6381c1c98..11b66cf1103c --date=short --first-parent --format='%ad %ae %s' 2020-01-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5a8e8ca5..01683979 (735421:735581) Created with: gclient setdep -r src/third_party/webrtc@11b66cf1103c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib8350634d693f4381e1af292a25d37b4e59ddc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024273Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 1043145 Change-Id: I0b66bb21fbcc8216289445e3826f746c4df22805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009597 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735695}
-
rbpotter authored
- Add rules to autogenerate Polymer3 versions of cr_policy_pref_behavior and cr_policy_pref_indicator at build time - Autogenerate tests for the Polymer 3 version of cr_policy_pref_indicator. This will be used to migrate the chrome://settings page in future. Bug: 1042558 Change-Id: I4721c7c4ae9d898135fea09111dcc6c79b529888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021335Reviewed-by:
-
