- 04 Feb, 2020 40 commits
-
-
Etienne Bergeron authored
Since Skia is used for rendering in the BrowserTest, a font should be backed by a SkTypeface. That was not the case previously since the class RenderTextMac was still used. RenderTextMac got removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1902193 Bug: 1026735 Change-Id: I23a3c4b6b0d5a36304e81e0251dc0e55f6836f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028213 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738239}
-
Jiaqi Han authored
In line with the removal of ENABLE_CAST_WAYLAND_SERVER buildflag. This reverts commit 663bb259. Bug: 1043215 Test: CQ Change-Id: I6840eaf5423d49c7d5c96f275b3461d367702146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006470Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#738238}
-
Shimi Zhang authored
The usage of sResourceCache had been removed in https://codereview.chromium.org/1270793002 long time ago, but the member variable is still there, it should be removed as well. Since now there is only one ID in this class, modify the comments accordingly. Bug: None Change-Id: I58443bb6d9200ce8970d0745a110cb80a707a12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036810Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#738237}
-
Marc Treib authored
TBR=ccameron@chromium.org Bug: 1048149 Change-Id: I3f2e4cde50d8786f55dbad776216deac4f4c5106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036102Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738236}
-
Ilia Samsonov authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/306f3754a71d..10b1902d893e $ git log 306f3754a..10b1902d8 --date=short --no-merges --format='%ad %ae %s' 2020-01-21 absl-team Googletest export 2020-01-17 absl-team Googletest export 2020-01-16 absl-team Googletest export 2020-01-15 absl-team Googletest export 2020-01-15 absl-team Googletest export 2020-01-14 absl-team Googletest export 2020-01-14 absl-team Googletest export 2020-01-14 absl-team Googletest export 2020-01-10 absl-team Googletest export 2020-01-15 36923279+ivan1993br Remove exclusion of *-main and*-all targets 2020-01-12 hilmanbeyri Use IsReadableTypeName IsReadableTypeName in OfType function in gmock-matchers_test.cc 2020-01-12 hilmanbeyri fix unit test failure on NoShortCircuitOnFailure and DetectsFlakyShortCircuit when GTEST_HAS_RTTI is 1 2020-01-09 absl-team Googletest export 2020-01-09 absl-team Googletest export 2020-01-07 absl-team Googletest export 2020-01-07 absl-team Googletest export Created with: roll-dep src/third_party/googletest/src This CL uses the internal placeholder GTEST_CUSTOM_TEMPDIR_FUNCTION_ to use an available path for temp directory. Change-Id: I9ca9bd1d599d9737a228b43e50b5caadfff5229c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel Change-Id: I9ca9bd1d599d9737a228b43e50b5caadfff5229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023674Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#738235}
-
Maksim Ivanov authored
This relands the test from the commit 8fd76b23 that got reverted for the second time due to flakiness. The test is relanded as DISABLED, in order to land all the lgtm'ed plumbing that would anyway be necessary even after fixing all possible flakiness. Original change's description: > Add browser tests for smart card SAML login > > Provide test coverage for the scenario where a new user authenticates > via SAML using a smart card (or, generally speaking, using a security > token via an extension using the chrome.certificateProvider API). > > This also provides some test coverage for the <security-token-pin> > Polymer element used on the Login Screen. > > Bug: 1033936 > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734510} Bug: 1033936 Tbr: alemate@chromium.org, hendrich@chromium.org Test: run the test locally with is_chrome_branded=true Change-Id: Ie3431acfdb589bd7d9ed443d283de996af18a266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032116 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#738234}
-
Jose Lopes authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I7bc713213889d35e0868821a41c0ea9c8e0c16d1 Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030953Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#738233}
-
Wez authored
ServiceDirectoryClient has been deprecated in favour of the Fuchsia- provided sys::ServiceDirectory, so remove it. Bug: 974072 Change-Id: I5fba438b946b05213a3686110cf733bb43ecb179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033154Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738232}
-
Joshua Bell authored
An -expected.txt file was expecting a failure, but the test is passing now. A TestExpectations entry was added. Remove the -expected.txt and the entry instead. See also: https://chromium-review.googlesource.com/c/chromium/src/+/2018565 https://chromium-review.googlesource.com/c/chromium/src/+/2017123 TBR=ioanap Bug: 1047126 Change-Id: Icbec35915d21878ec260ee2fff3fcaf7d6818fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036367Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738231}
-
Ehimare Okoyomon authored
Fix the cookie-controls-changed listener to update the correct element for the incognito ntp. Bug: 1046352 Change-Id: I301f63304f15a81a4ac029d6d6445e3848d39b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035963Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#738230}
-
Dale Curtis authored
This reverts commit a276a7a2. Reason for revert: Didn't stop the flake. Original change's description: > Allow autospawn for pulse deamon to attempt to fix flaky tests. > > Locally if I run "pactl exit" and log the start time, up to 3 seconds > may elapse before the pa_context reaches the PA_CONTEXT_READY state. On > my local machine, something is restarting the pulse daemon > automatically within a few seconds. It's possible the bots are running > in some state where the pulsedaemon will not respawn, so we end up > hanging forever. > > There's no easy way to timeout the wait for PA_CONTEXT_READY since on > the call into pa_threaded_mainloop_wait() just hangs and there's no way > to pump the mainloop otherwise it looks like. If we want to make the > loop timeout, we need to switch away from wait() to a spin/sleep loop. > > Lets see if this fixes the issue first, if not then we can try a timeout > based approach. > > R=guidou > > Bug: 1047655 > Change-Id: If81ef546c04aa33df8e35368102fd890016db76f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036901 > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738151} TBR=dalecurtis@chromium.org,guidou@chromium.org Change-Id: I8695d34184abdd1eaa4e1c0d19e8e93ac7fbe9c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037347Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738229}
-
Johannes Henkel authored
"Remove the JSON parser and revamp Value::parseBinary." Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2026351 "Add JsonEncoder tests for lone surrogates" https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2017303 In addition to the upstream changes, this PR includes the necessary tweaks to the blink inspector (now taking the detour via CBOR to parse Javascript). New Revision: 0e0a1995497511008864546c094e885f3f1e13a3 Change-Id: I1449d3a76c6a946a8bc321dd8d0cb111ce1bf303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021290Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738228}
-
Robert Liao authored
ScopedBstr::Get provides a migration pathway away from operator BSTR() const, a violation of the implicit conversion rule in the C++ style guide. https://google.github.io/styleguide/cppguide.html#Implicit_Conversions BUG=1034666 Change-Id: Idacb984b3c97b6deafbd91b3dd0d8928a12f932b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036522 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738227}
-
David Benjamin authored
Note this is a behavior change. Previously, these requests would send cookies, although not save them. This isn't a particularly coherent notion privacy-wise, and the discussion thread at [0] suggests the fetches do not require cookies. If this fetch does indeed require cookies, do not approve this CL. [0] https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4/edit#heading=h.d3td7t6q4ppy Bug: 799935 Change-Id: I314f9fa1cf7bd7ae64c58651f8071e0e8bea776b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965866Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Rob Schonberger <robsc@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#738226}
-
Nikita Podguzov authored
This is shown to the users if a non-whitelisted extension calls chrome.printing.submitJob(). If user clicks "Accept" button, the print job is sent to the printer. If they click "Deny" button, the dialog is closed and nothing happens, extension receives REJECTED status. Bug: 996785 Change-Id: Idf9cbc5af4ae740252ac32d2a64f6928c61eb955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007277 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#738225}
-
Roman Aleksandrov authored
Animate the ripple to deactivated state if the backspace button becomes disabled. This speeds up the fading away of the ripple. Bug: 1021834 Change-Id: I1285a4644a81e62b2b5bf371574bb1eccd350e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036059Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5d877847fae..2fca97168bfe git log f5d877847fae..2fca97168bfe --date=short --first-parent --format='%ad %ae %s' 2020-02-04 nisse@webrtc.org Delete header file mock_vcm_callbacks.h Created with: gclient setdep -r src/third_party/webrtc@2fca97168bfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idadda601e5301de6b00e59db0d48d8f2af88e6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738223}
-
Wez authored
Some tests need to run the message loop until a particular condition becomes true, but have no direct signal from the code under test to use to trigger the check & terminate the run. RunUntilConditionForTest() runs the loop and repeatedly calls a supplied callback until it returns true, or the Run()-timeout expires. The helper returns true if the condition was met before the timeout. Bug: 1021777, 976740 Change-Id: I18f887431a68cb73cc77a445f3b915284b111cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033162 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#738222}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/842c4bc2..4460b2d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic8e7c63a6e78dd4eabdb679114e627ebe664ef55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037385 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738221}
-
Tibor Goldschwendt authored
Also, do the same if clicking mic button in retry state. Bug: 1042534 Change-Id: I00b846fda24d263bd0c9493fd865fc3300541482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036384Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738220}
-
Olivier Li authored
Change-Id: I79e1153db46c9d12b6bf774914a46b095eeb3ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025947Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#738219}
-
Yann Dago authored
Create a snapshot manager that takes snapshot of some files and directories from the user data directory on browser update, and restores it on version rollback. All this happens when the browser is in an enterprise environment. Change-Id: If8373dd4c41edbf41ce9d6271300f7cd7a5ce575 Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992265 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#738218}
-
Maggie Chen authored
Some content unit tests create GpuDataManagerImpl in the IO thread. PeakGpuMemoryTrackerImpl needs GpuDataManagerImpl and GpuDataManagerImpl is created it when PeakGpuMemoryTrackerImpl is running on the IO thread. This will cause a crash (sequence checker) if the DisplayChange observer is added. This CL makes sure GpuDataManagerImpl is created first in the test setup so GpuDataManagerImpl will run on the main thread later. Bug:1042989 Change-Id: I825937f800dfeeddf2d25b03e5e50bf418e6942e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019882 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738217}
-
Joanmarie Diggs authored
BrowserAccessibility::GetTargetNodesForRelation was converting the correctly-ordered vector of AxIds into a set, causing the target order to be based on when the accessible object was created. This order does not necessarily correspond to the position in the accessibility tree, let alone to the author-provided order. This situation wasn't problematic because of the few ARIA properties whose value is an ID reference list, none were likely being used for assistive technology navigation. Because aria-details is changing to support multiple targets for which ATs will be expected to provide navigation, we need to start preserving the author-specified reference order. There are only a few properties for which there are multiple targets, and the list of referenced IDs for those properties is expected to be quite small. Thus converting the vector to a set doesn't buy us much. Therefore, return the target nodes as a vector, checking for duplicate AxIds. Bug: 1047988 Change-Id: I8352a073b71cc1863cbd25326d0cd48a4abd3d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034690Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#738216}
-
Maria Kazinova authored
The FormData extraction code was racing against new page load even though FormData was already passed into a function in string format. Now the FormData is extracted from a passed in string. This is a fix for a reverted change. Bug: 418827 Change-Id: Ic2d65d40a34183302a200ccf07a3d0070fdc2bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033517 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#738215}
-
Vadym Doroshenko authored
Bug: 1042196, 1045431 Change-Id: I0648dacaa8396ff167ea2b189a00d64fdbf04389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012031 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738214}
-
Paul Moy authored
Add the first interactive routine, AC power, to cros_healthd. This routine checks the power supply's status and type against the routine inputs. --gtest_filter=CrosHealthdServiceConnectionTest.* Bug: chromium:1046452 Test: chromeos_unittests Change-Id: I26a317c681781bed096513502240ba4663253fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033809 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738213}
-
Becca Hughes authored
Remove timestamp_ms field from playbacks table since we have moved it to the sessions table. BUG=1024368 Change-Id: Ie7de911bc6b728fbea633a433b40f4584d9bee2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036812Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738212}
-
Jeremy Roman authored
This is intended to mitigate concerns about data:, chrome://, or other surprising URLs being loaded. While there are existing mitigations for many of these cases, this provides with more confidence that these restrictions apply specifically to portals. See security review comments on crbug.com/1040212. Since this means that the throttle has some enforcing functions even when cross-origin portals are enabled, PortalNavigationThrottle is refactored slightly to exist whenever Portals are enabled, but to limit the origin checking to kPortalsCrossOrigin disabled. Bug: 1008989 Change-Id: Ia66723867731e88995b7e7d03ef72c78bcb96fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036776Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738211}
-
Ewann authored
A new page info is going to be implemented. Bug: 1038919 Change-Id: I4cba76a06144784cee46ebd637b7281f7107e5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036177Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#738210}
-
Tarun Bansal authored
No longer needed with NoStatePrefetch. Also, verified using the histograms dashboard that this enum is not getting populated. Bug: 1038057 Change-Id: I4fede4f1d10bf9723d6adf65f6b58a042f708794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995995 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738209}
-
Marc Treib authored
This reverts commit 897d08bf. Reason for revert: Still breaks ARC boot, see crbug.com/1048710 and crbug.com/1046881 Original change's description: > Reland "[PM] Add support for dedicated workers" > > This is a reland of dec0aa0b > > The fix for the failure is in this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2036479 > > Original change's description: > > [PM] Add support for dedicated workers > > > > The WorkerWatcher observes dedicated workers through the > > DedicatedWorkerService interface. > > > > Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208 > > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#736411} > > Change-Id: I40b86ea7de8fa4b252ffe805ec5992020dffc515 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028214 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738160} TBR=pmonette@chromium.org,siggi@chromium.org Change-Id: Ibc5ac277917d191b1033d45e2201e11b653e754e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035965Reviewed-by:
-
Anthony Vallee-Dubois authored
This CL moves EnrollmentStatus to a platform agnostic location so that it can be used on non-ChromeOS desktop platforms as support for device accounts is added on those platforms as well. Bug: 1026261 Change-Id: I47d60c8a033fb45730565b95bf6f5030b1d99fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998746Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#738207}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I3cc65cb4105cfc8caf0f98f5cd42cec5dacca4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035864Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#738206}
-
Marc Treib authored
This reverts commit df3250dd. Reason for revert: Suspected of causing crashes, see crbug.com/1047879 Original change's description: > Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType > > It has been deprecated and unused for a while. > The specifics proto itself can't be removed yet because it's still used > on the server. > > Bug: 1009361 > Change-Id: Ic183a6e244435cfce60ccdda34bff3e22a032ff3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022670 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736397} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009361, 1047879 Change-Id: I762fbf6f1b4b752a47b34e6a101a066d0c78aebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036005Reviewed-by:
-
Matt Menke authored
This was only used by an (unused) URLRequestContextBuilder method, some URLRequest LoadTimingInfo tests, and in the Cronet test fixture. This CL removes the first two uses, and moves the class over to Cronet. This CL also removes two other unused methods from URLRequestContextBuilder. Bug: none Change-Id: Id850440993e5b69b1ac5412a23243ece1200333a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033693 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738204}
-
Takumi Fujimoto authored
A tab mirroring source from a Cast SDK enabled website (e.g. Google Slides) uses the mirroring app ID rather than the tab mirroring URN. We need to set the tab ID in CreateRoute() for those cases. An alternative way to do this would be making IsTabMirroringSource() return true for those cases, but there's code that assumes support for the audio mirroring app (separate ID from the mirroring app) if IsTabMirroringSource() is true, which wouldn't make sense given the app ID would not be the same as one specified. Bug: 1047788 Change-Id: I100ccbd881854ddbae33b94474761a816061573c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033926Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#738203}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2543c5cbffca..11cc3e8ebc7e git log 2543c5cbffca..11cc3e8ebc7e --date=short --first-parent --format='%ad %ae %s' 2020-02-04 aerotwist@chromium.org [e2e] Implements waitFor helper 2020-02-04 tvanderlippe@chromium.org Migrate snippets/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@11cc3e8ebc7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1047671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I263c3e3b7d618737481d3d9cfc9c1fd8e89ef129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036829Reviewed-by:
-
Mark Yacoub authored
BUG=987274 TEST=DrmOverlayValidatorTest, HardwareDisplayControllerTest, HardwareDisplayManagerTest Change-Id: I693464b560384bf42cc9bed9fbe2e68cea5474ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036641 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
-
Jeremy Roman authored
These are guaranteed to be valid, non-null strings. Getting a null string here indicates that UTF-8 decode failed, in which case propagating a null string is not the right thing to do. Test included. This test would trigger the DCHECK in the linked bug without this fix. Bug: 1047753 Change-Id: I9e31d50176563d339b07883bbc2e5b52c4ff7641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033568 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738200}
-
