- 11 May, 2018 40 commits
-
-
Felix Ekblom authored
BUG=b:78171027 CQ-DEPEND=cl:1042575 Change-Id: I7886f3ac5483f381b677630dd966cdfacd483aaa Reviewed-on: https://chromium-review.googlesource.com/1044366Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#557808}
-
Zinovy Nis authored
- Get rid of redundant .c_str() for std::string, - Get rid of redundant .get() for std::unique_ptr, - Get rid of redundant member initializations - Replace NULL -> nullptr. R=blundell@chromium.org, caitkp@chromium.org, jochen@chromium.org, meacer@chromium.org, sdefresne@chromium.org Change-Id: Ibcd0f6ad0ab6610a334fb4a5309caa6ad00b5766 Reviewed-on: https://chromium-review.googlesource.com/1046085 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557807}
-
Matt Falkenhagen authored
When a new registration is made, it attempts to notify all ServiceWorkerProviderHosts for an in-scope clients. This way navigator.serviceWorker.ready and Clients#claim etc work correctly, as the ServiceWorkerProviderHost is aware of the best matching registration. Before this CL, new registrations would miss reserved clients. So if a page was still undergoing navigation while a registration was created, the page would never be aware of the registration. So if a SW from that registration called clients.claim(), the page would not be claimed. Bug: 841070 Change-Id: I615f416ac27cadb88dcae0bde368226a92a6c481 Reviewed-on: https://chromium-review.googlesource.com/1053928Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557806}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c77a6a1be7d..0cc01b753ac6 $ git log 8c77a6a1b..0cc01b753 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 fmalita [skottie] Guard against asset cycles Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Id55c4847c1916a9f30fe5a539ba4a3d96f42b2d9 Reviewed-on: https://chromium-review.googlesource.com/1055210 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557805}
-
Makoto Shimazu authored
This change is to create EmbeddedWorkerInstanceClient from the Renderer interface. It used to be created from the InterfaceRegistry, but we didn't have guarantee of IPC message orderings between StartWorker and messages onto the Renderer interface. StartWorker needs to be run after initialization of the renderer (crrev.com/c/1031693 will introduce SetUserAgent message), so this CL is to put the very first IPC for the service worker, which is establishing the Mojo connection, on the Renderer interface. Bug: 818450 Change-Id: I5a5d64fa9aef73ca602633b2b3664110d0a761c9 Reviewed-on: https://chromium-review.googlesource.com/1053042 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557804}
-
Matt Falkenhagen authored
These still seem to pass locally. I suspect a merge caused them to be accidentally added in https://chromium-review.googlesource.com/c/chromium/src/+/1041126 PlatformAppBrowserTest.AppWindowAdjustBoundsToBeVisibleOnScreen PlatformAppBrowserTest.CreateAndCloseAppWindow MimeHandlerViewTests/MimeHandlerViewTest.SingleRequest/0 Bug: 752372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id2713b0196ed1cfa666a2d62c37da8600b02fbd0 TBR: jam NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1055129Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557803}
-
Kenichi Ishibashi authored
Store client_id supplied via ServiceWorkerContainer::SetController() in ServiceWorkerProviderContext::ProviderStateForClient so that we can pass the client_id to WorkerFetchContextImpl. This enables us to set FetchEvent#clientId accordingly in shared workers. Bug: 840668 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie03290b9d70c3fd0d2a74e83d7881057ec3e1b51 Reviewed-on: https://chromium-review.googlesource.com/1049210 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557802}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0db9f061b85f..394f1c63d58a $ git log 0db9f061b..394f1c63d --date=short --no-merges --format='%ad %ae %s' 2018-05-11 manojgupta > > Revert "generic_stages: temporarily ignore all target prebuilts." > > > > This reverts commit 887fe7d05033cd814d9390b2f3ebcd9262330d7b. > > > > Original change's description: > > > generic_stages: temporarily ignore all target prebuilts. > > > > > > Ignore the target prebuilts and rebuild packages from source. > > > > > > This is a temporary CL. Revert this CL once in has participated in > > > a green CQ run. This process is documented at: > > > > > > https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries > > > > > > BUG=chromium:826418 > > > TEST='./cbuildbot/run_tests' passed. > > > > > > Change-Id: Id80097c2721001598efa294ea0a7cfc69eac038d > > > Reviewed-on: https://chromium-review.googlesource.com/1044745 > > > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > > > Tested-by: Yunlian Jiang <yunlian@chromium.org> > > > Reviewed-by: Manoj Gupta <manojgupta@chromium.org> > > > Reviewed-by: Lann Martin <lannm@chromium.org> > > > > Bug: chromium:826418 > > Change-Id: Ibc01cf44e64d921088ab48d65eac624f5aeb463d > > Reviewed-on: https://chromium-review.googlesource.com/1054268 > > Reviewed-by: Lann Martin <lannm@chromium.org> > > Tested-by: Lann Martin <lannm@chromium.org> > > Bug: chromium:826418 > Change-Id: Ib85d9b279c8d6738aa893492529c64da6fa0456c > Reviewed-on: https://chromium-review.googlesource.com/1054269 > Reviewed-by: Lann Martin <lannm@chromium.org> > Tested-by: Lann Martin <lannm@chromium.org> Created with: roll-dep src/third_party/chromite BUG=chromium:826418 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4025fa965c9f5b1e2846a282317e52cd8d5a236f Reviewed-on: https://chromium-review.googlesource.com/1055209Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557801}
-
Satoru Takabayashi authored
The metrics were added long time ago crrev.com/99811 without the corresponding changes to histograms.xml. The metrics still look interesting hence this change is to update histograms.xml. BUG=797623 Change-Id: I2445387d21a5ff51519638e0c4efce74108fe747 Reviewed-on: https://chromium-review.googlesource.com/844008 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557800}
-
Shakti Sahu authored
Fixed an accidental change to the feature list which was introduced in the CL https://chromium-review.googlesource.com/c/chromium/src/+/1003754 Change-Id: I4b1261a50f4e637453ea6b273d063f4af3a7dce9 Reviewed-on: https://chromium-review.googlesource.com/1054780Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557799}
-
Satoru Takabayashi authored
The metrics were added long time ago crrev.com/64367 without the corresponding changes to histograms.xml. The metrics still look interesting hence this change is to update histograms.xml. BUG=643563 Change-Id: I0ea55648b27b938dc5780932ac9dde31f4e1ff09 Reviewed-on: https://chromium-review.googlesource.com/842427 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#557798}
-
Scott Violet authored
When a client is notified of events it's told if the event matches a pointer observer. If the event does match a pointer observer, a single event is sent to the client. This implies I need a post event processing hook to determine if the client was notified already and not send if appropriate. This is why I added WindowEventDispatcherObserver as a way to deal with this. I'll be more obvious in a following patch. BUG=837692 TEST=covered by test Change-Id: Ifb3e332466b3e6a6ee09c625020d6dbf9ed1a54e Reviewed-on: https://chromium-review.googlesource.com/1054413 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#557797}
-
spqchan authored
Bug: 838873 Change-Id: I22e5a8a54d372abc84993ef1cd33e4325856cb6b Reviewed-on: https://chromium-review.googlesource.com/1042726Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557796}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d894aa45e08..e7273d25017a $ git log 3d894aa45..e7273d250 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado Reland "gclient: Get rid of parsed_url." Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic0e6386f9d2f7b62b49ddc3e69dce7f4f20dcd76 Reviewed-on: https://chromium-review.googlesource.com/1055050 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557795}
-
Yoshisato Yanagisawa authored
Since runtest.py depends on modules listed in build/third_party, we need to set --with-third-party-lib when we execute runtest.py via runit.py. Bug: 825290 Change-Id: Ic780388a9b9086364c1e4dcbd4a70a2cd2ed2425 Reviewed-on: https://chromium-review.googlesource.com/1053674Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#557794}
-
tzik authored
This grabs f8925d027884dde9, that fixes a compile failure of crc32c on C++17 mode. https://chromium.googlesource.com/external/github.com/google/crc32c.git/+log/0f771ed5ef83..f8925d027884 $ git log 0f771ed5e..f8925d027 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 tzik Move string_view inclusion out of crc32c namespace (#19) 2018-04-23 costan Bump third-party dependencies and fix MSVC compile warning. (#18) 2018-03-15 costan Improved configuration for YouCompleteMe, Travis and AppVeyor. (#16) 2018-03-15 costan Disable exceptions on Visual Studio. (#17) 2018-02-23 costan Replace preprocessor macros with Google Test's Type-Parameterized Tests. (#15) 2017-11-30 costan Update dependencies. (#14) 2017-11-27 costan Remove unofficial product notice from README. (#13) 2017-10-05 costan CMake: fix include install path. (#12) Created with: roll-dep src/third_party/crc32c/src BUG=752720 Change-Id: I6b5b7f101b830fa0c7c5df6bfd6d201e01a9a358 Reviewed-on: https://chromium-review.googlesource.com/1053848 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#557793}
-
Andrew Grieve authored
Bug: 702625 Change-Id: I0e11b7f8d8490e92b8e6440b5363bb0b2f45d51a Reviewed-on: https://chromium-review.googlesource.com/1025067Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557792}
-
Sunny Sachanandani authored
This reverts commit 3e2200fa. Reason for revert: Caused some regressions. piman@ and I have been rethinking how throttling works. Might make sense to hold this off until we have a solid plan. Original change's description: > Do not throttle BeginMainFrame on SubmitCompositorFrameAck > > The original motivation for this code was to workaround early swap ack > on freon, but since freon isn't a thing anymore and we have a display > compositor that actually performs the swap, it should be ok to get rid > of it. This should improve throughput similar to main frame before > activation. > > R=brianderson > BUG=311213 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I5108c74a57ba201d25999989de8da4c7f81a5176 > Reviewed-on: https://chromium-review.googlesource.com/1031892 > Reviewed-by: Brian Anderson <brianderson@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554547} TBR=brianderson@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 311213,838469,838462,838461,838460,838458 Change-Id: I600b48b3b24a213954b563347dc3dc87dd143ad2 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1054987 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#557791}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e70d1621. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17271 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing TBR=markdittmer No-Export: true Change-Id: I512b92a5b8f073c4d4d768493b2e1a500caa2cb6 Reviewed-on: https://chromium-review.googlesource.com/1055087 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557790}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c6ea2dabfc8..8c77a6a1be7d $ git log 6c6ea2dab..8c77a6a1b --date=short --no-merges --format='%ad %ae %s' 2018-05-11 angle-skia-autoroll Roll third_party/externals/angle2/ 6110763fe..2fc0806f5 (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4028b2b06396ca0e2125dcc207a1716e3c2d2ca0 Reviewed-on: https://chromium-review.googlesource.com/1054359 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557789}
-
Alex Moshchuk authored
Bug: 728219, 805705 Change-Id: Ia9a6d81a00376e2437b14357b1db4b97dd7dc8ef Reviewed-on: https://chromium-review.googlesource.com/1054833 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557788}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d1262780b26..0db9f061b85f $ git log 5d1262780..0db9f061b --date=short --no-merges --format='%ad %ae %s' 2018-05-04 cmtice cros_fuzz_test_env: Copy libs for llvm-symbolizer to sysroot. Created with: roll-dep src/third_party/chromite BUG=chromium:839939 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0fe7472ccb0e8c6074468661c314b6b224aedafa Reviewed-on: https://chromium-review.googlesource.com/1055108Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557787}
-
Yuichiro Hanada authored
Bug: 841694 Test: Manual testing on device. Change-Id: Ic9fe8a6dcf6c4063838070fb5cccfadfbf355f55 Reviewed-on: https://chromium-review.googlesource.com/1053622Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#557786}
-
Xiaochu Liu authored
Add a table to track cross-profile component usage. The table is a protobuf that has entries recording component usage for each component installed. When a user signs in: Component updater adds component usage entry when Load is called AND a component is loaded(succeed or fail). Component updater deletes component usage entry when Unload is called. When no user signs in: No entry is added or deleted. BUG=chromium:811431 TEST=unittest platform_AddPrinter.epson e2e test: Load/Unload when multiple users sign in/sign out. Manually check persistent metadata/component existence is corrrect after each operation. TODO: have an autotest to cover the e2e test. crbug.com/839542 Change-Id: I5e72ee8734adf6c6f1d8e885f4a41ebd33822af2 Reviewed-on: https://chromium-review.googlesource.com/946559 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#557785}
-
Theresa authored
Add a new TextViewCompoundDrawables widget that supports explicitly sizing and tinting compound drawables. Update the "Simplified NTP" bookmarks and downloads buttons to use the new widget. BUG=836308 Change-Id: I7705135153cee9b053fb031bb69b6dbc636caee4 Reviewed-on: https://chromium-review.googlesource.com/1054556Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557784}
-
dpapad authored
Specifically: - iron-a11y-announcer - 2.1.0 - iron-a11y-keys-behavior - 2.1.1 - iron-validatable-behavior - 2.1.0 Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iad7ccbf1022cdc394d01272bd9cb75c8f41265e3 Reviewed-on: https://chromium-review.googlesource.com/1052911 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#557783}
-
Kyle Horimoto authored
This class performs the low-level work to bootstrap a connection to a remote device; each specific connection type (e.g., BLE listener) must implement its own derived type. Bug: 824568, 752273 Change-Id: I74d5244ac3ad79aac6fa89c6e1f39513d72431de Reviewed-on: https://chromium-review.googlesource.com/1053392 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#557782}
-
rodmartin authored
Change-Id: I6d3f41c71f1e481da5bc0a67964e22828eca70dd Reviewed-on: https://chromium-review.googlesource.com/1050972 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557781}
-
Xiaocheng Hu authored
The above two functions are the same if the RenderedPosition is always located in the InlineBox with a higher bidi level. With crrev.com/c/1052988, the condition is already satisfied. Hence, this patch merges the two functions into one. Bug: 811502 Change-Id: I0040af1d33d5105cb4504cbbdab2723041505d66 Reviewed-on: https://chromium-review.googlesource.com/1054583Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557780}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I42b52ed7b128fa4ab7fcced81b32804e7438d5ed Reviewed-on: https://chromium-review.googlesource.com/1054049Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557779}
-
Trent Apted authored
When scrolling with layers, flip the viewport with layer transforms under RTL. This is necessary because the layer-backed scrolling machinery is not privy to the automatic UI flipping done in toolkit-views. ScrollOffsets must be positive, so scrolling horizontally in RTL currently moves the contents to the left. Flipping the viewport layer resolves this and scrolls to the right but reverses the text, so flip the contents to compensate. Testing exposed a quirk of View::ScrollRectToVisible() under RTL on all platforms. It seems only Views::TreeView uses ScrollRectToVisible() to affect horizontal scrolling, but it's currently broken (see http://crbug.com/840236). Fix it so we can use it in the test. Bug: 840236, 828361 Change-Id: Ib16724ff73829a6383be82e7bd11893b3a7e2ffc Reviewed-on: https://chromium-review.googlesource.com/999076Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#557778}
-
https://pdfium.googlesource.com/pdfium.git/+log/5ad45e2f68bb..5e0b271b6935 $ git log 5ad45e2f6..5e0b271b6 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 dsinclair Fixup ASSERT in Bidi handling; Add bidi fuzzer. Created with: roll-dep src/third_party/pdfium BUG=chromium:839695 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8dd271c6d77f96e369f68a2be87e978a7211f9c4 Reviewed-on: https://chromium-review.googlesource.com/1054623Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557777}
-
John Abd-El-Malek authored
Instead use a NetworkContext, which runs in the network process when network service is enabled. Bug: 825242, 789640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1f1244fbc71968a78bbb8ad1235e69f9935658fa Reviewed-on: https://chromium-review.googlesource.com/1008839Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557776}
-
Timothy Loh authored
This reverts commit f1c154fd. Reason for revert: "org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest#testSavePageNoOrigin" is flaky https://bugs.chromium.org/p/chromium/issues/detail?id=842035 Original change's description: > Finch code for OfflinePagesSharing > > Ensures that test bots cover OfflinePagesSharing flag scenarios. > > Bug: 758733 > Change-Id: Id73eebc0e9592318ed4d33b95dc169574bc0efc3 > Reviewed-on: https://chromium-review.googlesource.com/1043349 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Peter Williamson <petewil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557636} TBR=petewil@chromium.org,asvitkine@chromium.org,dtrainor@chromium.org,jianli@chromium.org Change-Id: Ib44d68b435936b2e0f943073fc458c5c7a6a44a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758733, 842035 Reviewed-on: https://chromium-review.googlesource.com/1055167Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557775}
-
Xiaohan Wang authored
- Fix GpuVideoDecoder::Initialize() so that even if the stream is clear we still pass down the CDM ID. This is needed for handling future encrypted streams since GpuVideoDecoder doesn't do full-fledged reinitialization. - Fix AndroidVideoDecodeAccelerator so that even if the stream is clear we still requrest MediaCrypto, for the same reason. Bug: 840586 Test: Manually tested Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I99c4a86001aa75924f93d8ee634fd5136a85e2c1 Reviewed-on: https://chromium-review.googlesource.com/1050434 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#557774}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3c311c15709b..5d1262780b26 $ git log 3c311c157..5d1262780 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 lannm Reland "generic_stages: temporarily ignore all target prebuilts." 2018-05-10 lannm Revert "generic_stages: temporarily ignore all target prebuilts." Created with: roll-dep src/third_party/chromite BUG=chromium:826418,chromium:826418 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifce9ea2a650b6955231efa2bda325b4eb2f11357 Reviewed-on: https://chromium-review.googlesource.com/1054856Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557773}
-
Fergal Daly authored
Nothing reads this field. Change-Id: I8b4af3655bf9fc89827ef992d0dc3fc0fc5be3fe Reviewed-on: https://chromium-review.googlesource.com/1053673Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557772}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b6297b2b. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17270 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes TBR=markdittmer No-Export: true Change-Id: I870de391d8ec9e311bcd82dd386b176f27b369a1 Reviewed-on: https://chromium-review.googlesource.com/1054927 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557771}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2191308678e4..3d894aa45e08 $ git log 219130867..3d894aa45 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado bot_update: Fix manifest creation. Created with: roll-dep src/third_party/depot_tools BUG=chromium:841936 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iacfd5922774e48e10d9829e21f2b75138803b6d2 Reviewed-on: https://chromium-review.googlesource.com/1054853 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557770}
-
Bo Liu authored
and use the implementation type directly. Bug: 813232 Change-Id: I53aaaf47a9f05a29930430c764bf87118c8c940e Reviewed-on: https://chromium-review.googlesource.com/1054640Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557769}
-