GitLab

This results in some code duplication right now but this will be mitigated once all platforms use WidgetImpl.

http://crbug.com/72040
TEST=existing tests

Review URL: http://codereview.chromium.org/6507028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75431 0039d316-1c4b-4281-b951-d872f2087c98

their CPU consumption.

The new interval is 1000 ms, or once per second. We can easily adjust
this value up or down, but this seems like a reasonable value to judge
the compatibility impact of this change.

BUG=66078
TEST=none (tested manually with minimal test case)

Review URL: http://codereview.chromium.org/6546021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73357
TEST=Get an infobar to show. Open Tab Overview/Tabpose. Everything looks correct.

Review URL: http://codereview.chromium.org/6543012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75429 0039d316-1c4b-4281-b951-d872f2087c98

The bookmark folder menus look bad when squeezed up against the bottom of a screen. 
Detect this case and automatically switch to showing the menu above the button in this case. 
BUG=69996
TEST=bookmark_bar_folder_controller_unittest.mm

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75342
Review URL: http://codereview.chromium.org/6469044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75428 0039d316-1c4b-4281-b951-d872f2087c98

fixes parts of bug http://code.google.com/p/chromium/issues/detail?id=55764

On IE9 a border is still drawn around all mshtml windows, which does not happen with ChromeFrame.
This needs more investigation.

BUG=55764
TEST=Launch IE9 and navigate to a ChromeFrame enabled page. The ChromeFrame page should not
     have a client edge border.

Review URL: http://codereview.chromium.org/6531022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75427 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75421 0039d316-1c4b-4281-b951-d872f2087c98

This allows JAWS to fully support text editing.

BUG=none
TEST=manual testing with JAWS screenreader

Review URL: http://codereview.chromium.org/6469037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=chromoting UI manual tests

Review URL: http://codereview.chromium.org/6518013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75417 0039d316-1c4b-4281-b951-d872f2087c98

children of text fields from the renderer to the browser. The child containing
the text appeared to be redundant anyway.

BUG=none
TEST=updated unit test, manual testing with screen readers

Review URL: http://codereview.chromium.org/6469038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75416 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6544016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75415 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/6286092/

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6349101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75414 0039d316-1c4b-4281-b951-d872f2087c98

Disabling Autofill test, autofill.AutoFillTest.testFilterMalformedEmailAddresses, as it's failing on Windows pyauto bots. 

BUG=73439
TEST=none

Review URL: http://codereview.chromium.org/6469058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75413 0039d316-1c4b-4281-b951-d872f2087c98

Add product-specific flags to the rename command in the registry.  This fixes a regression that prevented in-place upgrades of Chrome Frame from working.

BUG=73329
TEST=Follow the steps in the bug.  Between steps 4 and 5, check that the "cmd" registry value in HKLM\Software\Google\Update\Clients\{8BA986DA-5100-405E-AA35-86F34A02ACBF} contains "--chrome-frame".

Review URL: http://codereview.chromium.org/6541029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75412 0039d316-1c4b-4281-b951-d872f2087c98

Fix breakpad compilation on ubuntu 10.10.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6546023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75411 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75405 - Register Application Restart with Windows Restart Manager on browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.

BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.

Review URL: http://codereview.chromium.org/6462024

TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/6538059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75410 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75399 - Revert 75371 - Try to fix the Win Builder (dbg)(shared) build break by adding a dependency from content_browser to WebKit.gyp (TabContents uses WebView's zoom constants and helper functions).

TBR=avi
Review URL: http://codereview.chromium.org/6546013

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6538058

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6541028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75406 0039d316-1c4b-4281-b951-d872f2087c98

Register Application Restart with Windows Restart Manager on browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.

BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.

Review URL: http://codereview.chromium.org/6462024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75405 0039d316-1c4b-4281-b951-d872f2087c98

tabs are brought to the foreground and sent to the background.

This CL does not actually increase the background timer interval. That
will be done separately, so that it can easily be reverted without
removing all of the associated code.

BUG=66078
TEST=none (tested manually with minimal test case)

Review URL: http://codereview.chromium.org/6532012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75404 0039d316-1c4b-4281-b951-d872f2087c98

Refactor WebResourceService class, making it more generic.  Move all the promo-related code into a new PromoResourceService class that inherits WebResourceService.

This refactoring will allow us to re-use WebResourceService class for GPU Blacklist updates purpose.

This CL tries to minimize the code change and adds no new logic.

BUG=68802
TEST=unittest,promo functions working fine as before.

Review URL: http://codereview.chromium.org/6542003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75403 0039d316-1c4b-4281-b951-d872f2087c98

Enable two histograms for measurement:
    - measure PLT differences
    - measure SSL_Connect_Latency conditioned on the test.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6544004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75402 0039d316-1c4b-4281-b951-d872f2087c98

Fix a regression when switching the options pane to use Dom UI: when a user clicks the "Make Chrome my default browser" button, we should reset the browser.check_default_browser to true.

BUG=73208
TEST=Follow steps listed in bug, observe that the infobar again shows up.

Review URL: http://codereview.chromium.org/6542018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75401 0039d316-1c4b-4281-b951-d872f2087c98

Instead, DownloadFileManager puts the DownloadFile in a new map when it has the final name.

This is a step towards moving the 'final rename' determination happen in the UI thread.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6480079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75400 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75371 - Try to fix the Win Builder (dbg)(shared) build break by adding a dependency from content_browser to WebKit.gyp (TabContents uses WebView's zoom constants and helper functions).

TBR=avi
Review URL: http://codereview.chromium.org/6546013

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6538058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75399 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6469055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72579
TEST=manual testing, trybots

Review URL: http://codereview.chromium.org/6487001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72486
TEST=added new unit_tests and browser_tests
Manual Test: With preendering enabled, do a search for "yahoo mail". Prerendering should be canceled
due to https.

Review URL: http://codereview.chromium.org/6523062

TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/6543010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75395 0039d316-1c4b-4281-b951-d872f2087c98

Show doesn't necessarily get called when a window is opened directly to a
url (as opposed to a new tab page).

BUG=70657
TEST=manual testing

Review URL: http://codereview.chromium.org/6538038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72486
TEST=added new unit_tests and browser_tests
Manual Test: With preendering enabled, do a search for "yahoo mail". Prerendering should be canceled
due to https.

Review URL: http://codereview.chromium.org/6523062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75393 0039d316-1c4b-4281-b951-d872f2087c98

- use ScopedTempDir in work items that need backup space for rollback
- all work items that need backup space take a parent dir in which they create temp dirs
- use ScopedTempDir in a few other places
- renamed some parameters in certain functions so that the same name is used everywhere

While I was at it, I couldn't help but replace Append(UTF8ToWide(version.GetString())) with the more pleasing AppendASCII(version.GetString())

BUG=70368
TEST=existing tests in installer_util_unittests cover the changes

Review URL: http://codereview.chromium.org/6538025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73415
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/6538056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75391 0039d316-1c4b-4281-b951-d872f2087c98

Check and invalidate cached credentials if they were used for preemptive authentication and were rejected by the server.

BUG=72589
TEST=net_unittests --gtest_filter=HttpAuthHandler*.HandleAnotherChallenge

Review URL: http://codereview.chromium.org/6525035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75390 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75347 - Revert 75306 - Force native frames to repaint when OnNCActivate is called. With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated.

DesktopNotification tests failing on win full - speculative revert since this is the only CL in the range that seems possibly related.

BUG=none
TEST=frames behave normally in Aero mode, when activated and deactivated.

Review URL: http://codereview.chromium.org/6507044

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6546006

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/6541023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75389 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6541022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75388 0039d316-1c4b-4281-b951-d872f2087c98

Rather than have a couple of nasty #if defined blocks, push the code down into the platform specific RenderWidgetHostView layer.  Added support for releasing surfaces:

- if renderer crashes, RenderWidgetHostView releases the surfaces (no change from previous code)

- if gpu process crashes, the GpuProcessHostUIShim releases the surfaces (introduced in this patch)

- if the channel between the renderer and gpu process falls, the gpu process asks the GpuProcessHostUIShim to release the surface

BUG=none
TEST=by hand 3D css and WebGL on win, max, linux, and linux views

Review URL: http://codereview.chromium.org/6462034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75387 0039d316-1c4b-4281-b951-d872f2087c98

After opening a new tab, the tab may not be ready to read the title. The method CheckTitle checks title within the certain timeout.
It may not a good solution but workable and existing code already uses it, so I think we use it to fix this bug.


BUG=46781
TEST=UnloadTest.BrowserCloseBeforeUnloadOK.

Review URL: http://codereview.chromium.org/6544015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75386 0039d316-1c4b-4281-b951-d872f2087c98

Initialize INPUT struct. The dwFlags member of INPUT struct is not properly
initialized so sometimes the key event is interpreted as a key up and thus
keys are missed.

BUG=70167
TEST=keyboard input is fine on windows

Review URL: http://codereview.chromium.org/6542015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72633
TEST=none
Review URL: http://codereview.chromium.org/6538022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75384 0039d316-1c4b-4281-b951-d872f2087c98

When set this policy overrides the user settings for that pref.

No UI changes have been made to ContentSettings.xib only wired the enabled flag to the managed property of the underlaying pref.

BUG=59775
TEST=Manually set the policy and check if the corresponding UI element is disabled and correspond to the policy state.

Review URL: http://codereview.chromium.org/6534021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73358
TEST=waterfall.sh match no longer shows stack

Review URL: http://codereview.chromium.org/6469051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75382 0039d316-1c4b-4281-b951-d872f2087c98

When Chromoting is enabled via Chrome, the service process is started
if necessary and notified that the Chromoting service has become enabled.
When the service process is later auto-started (or run manually) it will
initialize Chromoting, which detects that it is enabled and starts up, but
fails to inform the service process that it's enabled, so the process waits
a while and then exits.

BUG=73168
TEST=Enable Chromoting in Chrome.  Kill the existing service process and start a new one manually.  Ensure that the new one runs for at least two minutes without quitting.

Review URL: http://codereview.chromium.org/6532023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75381 0039d316-1c4b-4281-b951-d872f2087c98