- 14 Aug, 2019 40 commits
-
-
Tetsui Ohkubo authored
Because of CustomTab, it is possible for ARC IME to lose IME focus even though window focus does not change. To prevent that, we should ensure the IME focus is set again when the custom tab child window is removed. TEST=manual(Open a custom tab in Gmail, type something in web contents, close the tab, and type again in Gmail search box in the app.) BUG=b:135281220 Change-Id: I7ee383cdf952c349264725e5691323ce0ee609fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752272Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#686710}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1cd23288. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor kojii@chromium.org: external/wpt/css/css-rhythm NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5e3a88bbd97fee5a683c2db4c3db39f2a92f887a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752885Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f75996469d02..1db609ad72d7 git log f75996469d02..1db609ad72d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 34c59c9b88b7..5e4e8b0af5fa (2 commits) 2019-08-13 bsalomon@google.com Remove GrRenderable param from GrProxyProvider::createTextureProxy() Created with: gclient setdep -r src/third_party/skia@1db609ad72d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:None Change-Id: Ia6e9ce6ea4079d15fd88103309a650bd05f7da3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686708}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2fb628da46f1..40618d0b93aa git log 2fb628da46f1..40618d0b93aa --date=short --no-merges --format='%ad %ae %s' 2019-08-14 enga@chromium.org Implement RenderBundle in the backend 2019-08-13 hob@chromium.org Update BUILD flags to support Chrome OS 2019-08-13 rharrison@chromium.org Rolling 2 dependencies 2019-08-13 enga@chromium.org Implement RenderBundle in the frontend Created with: gclient setdep -r src/third_party/dawn@40618d0b93aa The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:993457 Change-Id: I9d83d3c039b59a888e70ec56ff3e5a718fa02c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686707}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/565082dac784..d74e2c39cff9 git log 565082dac784..d74e2c39cff9 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 treehugger-gerrit@google.com Merge "Fix start stop buttons visibility" Created with: gclient setdep -r src/third_party/perfetto@d74e2c39cff9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibddcc6aa49d52faa651d7eb772aff31fa2b04ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686706}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f20959283711..60044886a393 git log f20959283711..60044886a393 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 nigi@chromium.org [SkiaPaths] Fix issue that non-Windows cannot load font correctly. Created with: gclient setdep -r src/third_party/pdfium@60044886a393 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia9431e800430865300b584c30676d1f03a1a0199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752336Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686705}
-
James Hollyer authored
This is the second part to a BluetoothDiscoverySession refactoring. The intention of this refactor is to properly keep track of all discovery session inside the parent bluetooth adapter class. The OS specific children should now only be used for OS specific stops, starts, and filter updates and will have no knowledge of the individual sessions. This will more easily allow for filters to be pushed to the OS level filtering. This CL deals with the removing of discovery sessions and the queueing of multiple discovery requests at the same time. Bug: 490401 Change-Id: I80648a76b2dedffe6b1466a06172f99f29c25011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699214 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ovidio de Jesús Ruíz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#686704}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14ef7d57c13d..d6195b651b19 git log 14ef7d57c13d..d6195b651b19 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 saklein@chromium.org uprev_lib: create and move the overlay uprev manager. Created with: gclient setdep -r src/third_party/chromite@d6195b651b19 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I912a5beec025e67f2d7a1d99f1b04bfbbc466a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686703}
-
Kouhei Ueno authored
This CL prevents the pages capturing audio from entering BFCache. We now taint RenderFrameHost which has granted MediaStream [1] access, and BackForwardCache::CanStoreDocument will return false for those RFHs. I *think* the change should be enough to block other media playing/recording pages from entering the BFCache, but to be confirmed by subsequent CLs which adds the browser tests. [1] MediaStream as in https://w3c.github.io/mediacapture-main/#mediastream which includes microphone/camera/tab/desktop capture. Bug: 989379 Change-Id: I1be4b64d6947058c0e37da7685eeb699a01b1ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729581Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#686702}
-
Hiroshige Hayashizaki authored
This CL imports more tests from upstream: - Test files from https://github.com/WICG/import-maps/tree/master/reference-implementation/__tests__ are imported to import-maps/imported/resources/. - Generated test HTMLs are placed in import-maps/imported/. - To support more tests, the glue code in resolving.tentative.html is moved into `jest-test-helper.js` and extended to support new tests. The current test failures are added as -expected.txt, and will be fixed in the future when import map functionalities are implemented or fixed. Bug: 990561 Change-Id: I087df82355513584a0cf1891da648dd2155f53c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686701}
-
edchin authored
Previously, simultaneously tapping on a recent tab and "enable sync" in tab grid's recent tab panel would leave the UI in an unusable state. The cause of the bug is that both touches are processed, and then both actions attempt to present view controllers. Simultaneous touch is a grey area, in which the user's intent is unclear and therefore, the best approach to handling the touches is also unclear. One approach is to disable one UI element when another UI element is tapped first. I think that should be a last resort because it makes the UI feel less responsive, and it is difficult to keep track of all the UI states of each button and tappable region. Instead, this CL takes the approach of allowing the taps, processing the first tap, then the second. Then the second tap attempts to present a view controller. It is reasonable to ignore this second tap's attempt because another view controller has already been presented. This CL fixes these simultaneous touches from recent tabs: 1) a recently closed tab and "enable sync" 2) a tab from another device and "enable sync" 3) "show full history" and "enable sync" Note that this CL only applies to the sync settings being shown first, because in practice it seems that the sync settings button tap registers first before a table view tap. If the other way also happens in practice, we can add further code in the future. Also note that I thought about adding tests. But it is not possible to add an egtest that tests simultaneous taps. And a unittest is too contrived in this scenario. TEST: from recent tabs (in tab grid or from menu), simultaneously tap a recently closed tab, a tab from another device, or "show full history" with "enable sync". Bug: 961050 Change-Id: Id388eaeb80173e3ba2f9800a571e990b9d75181b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750190 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686700}
-
Yoshisato Yanagisawa authored
The CL also removes unnecessary mb_config.pyl. Bug: b/137246264 Change-Id: Ib241089a5c6c1a0c67e5effe6ef9efb1f7d30db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732095Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#686699}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b3eeb2a40354..7e48c9eb9993 git log b3eeb2a40354..7e48c9eb9993 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 jdarpinian@chromium.org Add explicit integer casts Created with: gclient setdep -r src/third_party/angle@7e48c9eb9993 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:3439 Change-Id: Ia15361caeed91b8a5c87e30237a5b2230f939ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686698}
-
Vikas Soni authored
Skip 2 pixel tests for android webview : 1. Pixel_OffscreenCanvasTransferToImageBitmapWorker 2. Pixel_OffscreenCanvasTransferToImageBitmap Also update tags on existing tests to prevent pattern conflict asserts. Bug: 992599 Change-Id: Ieba42b646719d039a36f36c8551cd2585a344e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753115Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#686697}
-
Cliff Smolinsky authored
If a delayloaded function is patched using IATPatchFunction and then later there are method calls to the same DLL, the delayloadhelper will fully realize the IAT for that DLL, overwriting the patch. This change forces all of the imports to get loaded before the patch is created. The primary scenario for this is the GDI patch for GetFontData done in InitializePDF(). This presents a problem, however, because this method is currently called during startup for every child process, thus negating the work done to make GDI delayloaded in the first place. As such, this change also makes two optimizations to prevent losing the delayload perf benefits: 1. For PDF (ppapi) processes, ensures InitializePDF's patches only run on Win7 and Win8. This is done because Win10 uses different font retrieval mechanisms because of win32k process mitigations. 2a. Ensures InitializePDF runs for ppapi processes. Since this code is only actually needed for PDF rendering, there's no reason to do it for every child process. The LoadAllImports + patching then becomes pay-for-play when a PDF is being viewed. 2b. Ensures InitializePDF runs for printing utility processes which use the GDI-based font information on all Windows versions. Bug: 988164 Change-Id: I4d3c560a7c022c09251773c2a0d1cb4585da2145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731175 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#686696}
-
Yun Liu authored
Java coverage is working now on release build. We need to change the configs of android-kitkat-arm-coverage-dbg(rel) the same as current android-kitkat-arm-rel, except with coverage on, to further merge android-kitkat-arm-coverage-rel in android-kitkat-arm-rel later. Bug: 988116 Change-Id: I0cdee70745896f6e291cf172aa2f641ccf254c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746080 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686695}
-
May Lippert authored
Fix: CrSettingsLanguagesPageTest.InputMethods CrSettingsPeoplePageAccountManagerTest.All CrSettingsRouteTest.All SettingsAccessibilityTest.MANAGE_ACCESSIBILITY_* BUG=950007 TEST=Ran browser tests with and without flag Change-Id: I3c23ffc7bbc1fae7946b1c816f67f70b9a309492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748067Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#686694}
-
Peter Kasting authored
Verified that reverting the patch on that bug causes the test to fail. Bug: 969099, 980496 Change-Id: Ie6a26d0a18e1e6533989b776ae24575ffc4a8fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752878 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#686693}
-
Kazuki Takise authored
Some Tast Tests need to know whether Chrome animation is running or not because, for example, Chrome animation is applied to PIP windows when they are moved or resized, but currently there's no way to tell if when it's done completely. In case we need more information in the future, this CL adds an API that queries "window information", instead of adding more specific APIs such as getWindowAnimationState or getWindowBounds. BUG=b:131248000 BUG=b:135956156 BUG=b:135160409 TEST=tast -verbose dut my_crbook arc.PIP Change-Id: Idb0cdba9110127c3b24736d18b326963b929f25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728513 Auto-Submit: Kazuki Takise <takise@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#686692}
-
Gyuyoung Kim authored
This CL converts implementations of idle_manager.mojom both the browser process(IdleMonitor) and the renderer process (IdleDetector) in idle_manager.mojom. - Change mojo::Binding with mojo::Receiver - Change IdleManagerPtr with mojo::Remote<IdleManager> Bug: 955171 Change-Id: I5e5b33cef0ee01b86e44e0778dbb2cd5ab9ac45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750508 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#686691}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/979fa780ce2f..9185e4495d6d git log 979fa780ce2f..9185e4495d6d --date=short --no-merges --format='%ad %ae %s' 2019-08-13 ehmaldonado@chromium.org depot_tools: Make scm Python 3 compatible. Created with: gclient setdep -r src/third_party/depot_tools@9185e4495d6d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I3ded0e71c4bd7105874556e8b74b8138cc72761b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686690}
-
Sunny Sachanandani authored
The internal finch analysis checks that the field trial config exactly matches the beta/stable experimental group including disabled features. Bug: 892874 Change-Id: I46bba1b6eb75dd741e0bdcc299e6073ae092e912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752111 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686689}
-
Rakina Zata Amni authored
Adds "contain: style layout size" presentational hint (https://html.spec.whatwg.org/multipage/rendering.html#the-css-user-agent-style-sheet-and-presentational-hints) when the rendersubtree attribute is present on an element. This means any element with the rendersubtree attribute will get style, layout, and size containment, unless it's overridden by author style. This CL also removes "contain: style layout;" from display locking WPTs as they're not needed anymore. Not implemented in this CL: - Handling of elements whose containment is overridden and thus not efficiently lockable. Non-contained locking will be implemented in another CL. See discussion: https://github.com/WICG/display-locking/issues/62#issuecomment-516631887 Bug: 991095 Change-Id: I14e1fa2fe45d072ec7b251423014d7ec6ab06f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746112 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#686688}
-
ssid authored
The library uses some static variables and singleton classes. Since this is included by a lot of other components, this should be a shared library. BUG=942761 Change-Id: I3a94b31fad3f3b8e4784651b34757d83af141b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752872 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#686687}
-
Alan Cutter authored
Failing on Mac waterfall, suspecting: https://chromium-review.googlesource.com/c/chromium/src/+/1749135 This test uses setTimeout(..., 500) which should be fixed. TBR: tonikitoo@igalia.com Bug: 993328 Change-Id: I1909991c4e7df4ca75c4b02ef1fc9b917b27b4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752566Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#686686}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e82443a8. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4d941ab165d94d5b30bd277b5a71478940ae02ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752746Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686685}
-
Chris Cunningham authored
This CL adds a switch to use libvpx for opaque (no alpha transparency) VP8. There is no change to the default behavior (using ffmpeg). The switch will be toggled via finch to compare the performance libvpx and ffvp8. Switching to libvpx would workaround a bug we're hitting decoding vp8 streams from intel hw encoders (bug believed to be in ffmpeg, filed https://trac.ffmpeg.org/ticket/8069). FFvp8 has better performance than libvpx, but these gains may not matter on modern systems. Vp8 is also very uncommon and generally low-resolution on today's web. FFmpeg and libVPX have different behaviors around mid-stream frame-size changes. LibVPX simply trusts the container metadata and we scale any deviation from that is simply scaled. This is also true for hardware decoders (for other codecs) and VP9 (which already uses libvpx). In contrast, FFmpeg trusts the frames themselves and changes the size of the video dynamically. This motivated a re-write of the video-frame-size-change.html, which is focused on rendered size changes rather than nuance of a specific codec. Folks desiring a size change should use MSE to append a new init segment to explicitly signal the new size. Given very limited use of VP8 today, we expect this does not break folks (and hope the finch experiment will confirm that). (https://simpl.info/videoalpha/) Bug: 992235, 963740, b:138840822 Test: media_unittests and manually verified alpha still works with vpx Change-Id: I48cec468946eb5a769fb2966da6b92ba28b43d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745711 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#686684}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Id6210ee797928b79e6fd3a64b94f6e48fa00b37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753582Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686683}
-
John Emau authored
This change will make it easier for screen reader users to select the JavaScript Context in the Console and the audio context in the Web Audio tool by moving focus to the menu on activation and reading the selected position of the item. Summary of changes: - Decorated markup with appropriate ARIA properties. - Moved focus from button to menu following active-descendant pattern [1]. - Dropdown selection is now only finalized by clicking an item, or pressing Enter, Space, or Tab. Scope of impact: The SoftDropDown is currently used as the JavaScript context selector in the Console tool and audio context in the Web Audio tool. [1] https://w3c.github.io/aria-practices/examples/menu-button/menu-button-actions-active-descendant.html [2] https://cs.chromium.org/search/?q=UI.SoftDropDown+-f:out+f:.js+f:front_end&sq=package:chromium&type=cs Screenshot: https://i.imgur.com/jIpsRYP.png Gif: https://i.imgur.com/V4FoqKn.gifv Bug: 963183 Change-Id: Iaf44f50639626fe22ef55862ae3a8b93962a4efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626643 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#686682}
-
Antonio Gomes authored
All users have been switched to using the variant of PostCrossThreadTask and PostDelayedCrossThreadTask that operate on WTF's once-callbacks (aka CrossThreadOnceFunction). BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: I2ff3732924192f910ae26b810353efa84eafaf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626489 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#686681}
-
David Staessens authored
The new video_decode_accelerator_perf_tests collect various performance metrics while decoding a video. To give an idea of the relative amount of frames dropped the 'frame drop rate' is calculated, which is the ratio between frames dropped and frames not-dropped. This metric is unfortunately rather confusing to interpret (e.g. 50% of frames dropped is a frame drop rate of 1). The drop rate was initially used rather than drop percentage to keep in sync with the old video_decode_accelerator_unittest. This CL changes the 'frame drop rate' metric to the more readable 'frame drop percentage', which is also the metric collected by various other tests such as the Tast playback_perf_* tests. TEST=new vda performance tests on eve BUG=None Change-Id: I674e47b9d540df0348ee53f4cf71f5cc19fb5db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750534Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#686680}
-
Gyuyoung Kim authored
This CL replaces all remained uses of GetDataResourceAsASCIIString as well as the implementation of GetDataResourceAsASCIIString in data_resource_helper. Bug: 983396 Change-Id: Ic388ac0c72162ae6c081797d23245b5b1f3d41e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746213 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#686679}
-
Gyuyoung Kim authored
This CL converts implementations of nfc.mojom in the renderer process. Major changes are as below, - Change the argument of SetClient from NFCClient to pending_remote<NFCClient> in nfc.mojom - Change mojo::Binding with mojo::Receiver - Change NFCClientPtr with mojo::Remote<NFCClient> Bug: 955171 Change-Id: Ibfc900f35dc22736e8af3753705e55fadd5ac76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750517 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#686678}
-
David Staessens authored
When the video_decode_accelerator_(perf_)tests are build for ChromeOS the video test code expects at least the 'use_v4l2_codec' or 'use_vaapi' flag to be set. This CL ensures the build works if none of these flags are set. The test won't work, but the build will not be broken. BUG=993467 TEST=Built for ChromeOS without 'use_v4l2_codec' or 'use_vaapi' set Change-Id: Ic7b543907ed1b37bcac2b9f2bc3dc006109a8166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752268Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#686677}
-
Nate Fischer authored
We allow downgrades by default when installing APKs. We should apply the same setting for App Bundles. There's no good reason to not allow downgrades by default for local development, since it's just annoying when installation fails because a previous install had a higher version. Note: this does not allow downgrades on user builds, but "allow_downgrade" is otherwise harmless to pass (the install acts as if allow_downgrade was not specified). This is a follow-up to https://crrev.com/c/1383575. Bug: 915431 Test: manual Change-Id: I7392d9a4656f702266f5790bee9a7fec395190f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746642Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686676}
-
Rohit Rao authored
Disabling to unblock the CQ. BUG=993604 Change-Id: I6a129e8ae3d8b48b155bfec3ce3bff0ff7657f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753204 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686675}
-
Antonio Gomes authored
... when posting tasks. A task posted runs once, so CrossThreadBindRepeating is not strictly correct. This is now possible, after [1]. [1] crrev.com/c/1750043 BUG=964922 R=jbroman@chromium.org Change-Id: Ic1937f017ec6cd5a532b99a1f270f2ce2a99b8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752078 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686674}
-
Yutaka Hirano authored
Implement https://github.com/whatwg/xhr/issues/248. We haven't sorted the headers, so there is no compatibility issue. Bug: 993271, 651750 Change-Id: Ie69fb45a90795ea303324358312b16b7e6e227aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750476Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#686673}
-
Brandon Wylie authored
This color samples the edges of the dse logo and creates a background that the logo is then laid on top of. Bug: 993416 Change-Id: I64ccd7358165334914eff54563f71f141dd4d4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737331 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#686672}
-
Michael Giuffrida authored
Removes remaining KioskNext code and references. Bug: 977019 Change-Id: Ic1d554d9771996f87e85ee2d335cbf82da2ec19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750264 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686671}
-