- 30 Apr, 2009 19 commits
-
-
sgk@google.com authored
* Fix action execution with no specified target output files. * Handle duplicate --mode= values. Review URL: http://codereview.chromium.org/99210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14946 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use scoped pointers to manage memory. Review URL: http://codereview.chromium.org/100206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14945 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
This is used for Linux, where we're currently not doing inverse selection. Review URL: http://codereview.chromium.org/100207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14944 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
This wasn't actually a bug in that everything worked fine. It just meant we were calling the default handler twice, and returning from what should have been a void function. Review URL: http://codereview.chromium.org/99218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14943 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
Review URL: http://codereview.chromium.org/100200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14942 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
This ended up being implemented as a toplevel instead of a popup, to handle things like virtual desktop switching. I imagine there are some other problems we might hit, like the window getting decorated, etc. Although I think the shape mask might prevent decorations from being visible. This is not pixel perfect with Windows, since we're not anti-aliasing the frame border. Review URL: http://codereview.chromium.org/100203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14941 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
does resolve the location bar not being focused bug on the mac build. Patch by Sean Bryant (sean@cyberwang.net). BUG=9419 Review URL: http://codereview.chromium.org/100140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14939 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
This is a cherry-pick of the following change: http://code.google.com/p/skia/source/detail?r=159 We introduce this change for the 'lighter' composite operation. We need kAdd_Mode, which is introduced in this change for the operation. Patch by Shinichiro Hamaji. BUG=1619 Review URL: http://codereview.chromium.org/93093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14938 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/100199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14936 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
2. Function actual parameters are not shown in the call stack panel because they are alredy displayed in the scopes panel. Review URL: http://codereview.chromium.org/99185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14935 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=Make sure that the task manager isn't obviously broken on Windows. Review URL: http://codereview.chromium.org/93067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14934 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
It seems the AutocompleteResultView::DrawString() function calls the AutocompleteResultView::DrawStringFragment() function even when |text_start| is greater than |text_end|, i.e. there are not matching characters. This change filters out the above case and fixes a couple of lint errors. Review URL: http://codereview.chromium.org/100196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14933 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
On Windows, "Alt" key will set both alt and meta is on (issue 2215). But Alt-Gr is used to insert alternate character. BUG=10846 Review URL: http://codereview.chromium.org/99216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14932 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Review URL: http://codereview.chromium.org/99081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14927 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
BUG=10863 Review URL: http://codereview.chromium.org/100178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14926 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
On translate.google.com, it fails to show balloon, because of JavaScript exception in following code: p=a.getClientRects(); ... p[0].top // p[0] is undefined! Current v8 binding misses indexed access method in ClientRectList. CSSOM View Module draft says http://dev.w3.org/csswg/cssom-view/#clientrectlist In ECMAScript implimentations, objects that implement the ClientRectList interface must also have a [[GET]] method that, when invoked with a number, acts like the item() method would when invoked with that argument. BUG=10697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14925 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
BUG=11200 R=aa Review URL: http://codereview.chromium.org/100164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14924 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
Review URL: http://codereview.chromium.org/99117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14922 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
On Gtk/Linux, it emits key events with ASCII text and ctrl on for ctrl-<x>. In WebKit, EditorClient::handleKeyboardEvent in WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp drops such events. On Mac, it emits key events with ASCII text and meta is on for Command-<x>. These key events should not emit text insert event. Alt key would be used to insert alternative character, so we should let through. Ctrl-Alt combination may equal to AltGr key, which is also used to insert alternative character. In summary, we can't think of a scenario where you'd use control(w/o alt) or meta to do insertion of a ASCII character. BUG=10846,11070,11165 Review URL: http://codereview.chromium.org/99209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14921 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Apr, 2009 21 commits
-
-
aa@chromium.org authored
think this was happening because we were injecting from the the browser at load_start, but the document might not be established in the renderer by the time this message is received. Since we are now not even showing the toolstrip until load_complete, it is no big deal to delay the CSS injection until then. Review URL: http://codereview.chromium.org/100182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14914 0039d316-1c4b-4281-b951-d872f2087c98
-
http://crbug.com/11132dkegel@google.com authored
when tab->GetActiveEntry() is NULL. Review URL: http://codereview.chromium.org/100172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14913 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Parts of the code are from ermilov.maxim@gmail.com. Thanks! BUG=8405 Review URL: http://codereview.chromium.org/100106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14912 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Make "Reopen closed tab" be "Reopen closed window" when a window is the top item on the closed tabs stack. Original patch by Miranda Callahan (see http://codereview.chromium.org/100054 ), r=me. BUG=11183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14910 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
Review URL: http://codereview.chromium.org/100144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14909 0039d316-1c4b-4281-b951-d872f2087c98
-
playmobil@google.com authored
Also rebaseline another SVG test since eseidel says our result looks ok. Review URL: http://codereview.chromium.org/100187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14907 0039d316-1c4b-4281-b951-d872f2087c98
-
gwilson@google.com authored
This only works with post-1.0 Chrome, as it refers to the new Window names. R=kuchhal Review URL: http://codereview.chromium.org/101008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14906 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
TBR=evan Review URL: http://codereview.chromium.org/100185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14904 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@google.com authored
- Introduce ExtensionHost, which is the guy that talks to the RenderViewHost. - ExtensionView holds an ExtensionHost, and also renders its contents in an HWND. - Added code to load a page optionally specified in the manifest as a background process whenever it exists. Review URL: http://codereview.chromium.org/92043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14902 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
Reenabling all of them. Hopefully it'll help with flakiness. Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux. BUG=6584,2136 TEST=Run the browser tests. Review URL: http://codereview.chromium.org/101013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98
-
playmobil@google.com authored
Review URL: http://codereview.chromium.org/100181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14899 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
Review URL: http://codereview.chromium.org/99206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14898 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
BUG=None TEST=make sure all tests (unit-tests, ui-tests...) still work. Review URL: http://codereview.chromium.org/100032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14897 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Review URL: http://codereview.chromium.org/99201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14896 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
Review URL: http://codereview.chromium.org/100170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14894 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
We weren't sizing the GtkFixed widget because the animation delegate callbacks weren't being called. Now we artificially call AnimationProgressed() once we know what size the GtkFixed should be. TEST=switching back to a tab that has an infobar open should properly display that infobar. Review URL: http://codereview.chromium.org/99110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14893 0039d316-1c4b-4281-b951-d872f2087c98
-
playmobil@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14892 0039d316-1c4b-4281-b951-d872f2087c98
-
http://www.crbug.com/2044senorblanco@chromium.org authored
on large <canvas> elements. We disable the __debugbreak only when skia tells us it is prepared to correctly handle a failed (NULL) malloc(). It does this by calling sk_malloc_flags() without SK_MALLOC_THROW. Note that, since the switch to tcmalloc, the new_handler was not getting called at all (since tcmalloc doesn't support it yet), so this crash is currently unreproducible in trunk. In order to test this change, I reverted the tcmalloc change in my client. This is not the case in the stable branch, since it doesn't use tcmalloc, so this change is still needed there. (It will also be needed in trunk again once mbelshe's re-implementation of the new_handler is in). BUG=http://www.crbug.com/2044 Review URL: http://codereview.chromium.org/100163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14891 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14890 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14889 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
Review URL: http://codereview.chromium.org/100177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14888 0039d316-1c4b-4281-b951-d872f2087c98
-