1. 31 Jan, 2010 2 commits
  2. 30 Jan, 2010 21 commits
    • kov@webkit.org's avatar
      2010-01-30 Gustavo Noronha Silva <gns@gnome.org> · a117719b
      kov@webkit.org authored
              Build fixes needed for make distcheck.
      
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a117719b
    • mrowe@apple.com's avatar
      Stop copying an IDL file in to the framework wrapper. · 924363ac
      mrowe@apple.com authored
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      924363ac
    • mrowe@apple.com's avatar
      Sort Xcode projects. · 81042bbc
      mrowe@apple.com authored
      JavaScriptCore:
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      WebCore:
      
      * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      81042bbc
    • mrowe@apple.com's avatar
      Roll over a few oversized ChangeLogs. · 8dd4df87
      mrowe@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@54101 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8dd4df87
    • mrowe@apple.com's avatar
      Roll out r54073 as it introduced many thousands of leaks. · a2228964
      mrowe@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@54100 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a2228964
    • mrowe@apple.com's avatar
      Fix run-leaks with newer versions of the leaks tool. · 7a09b2a0
      mrowe@apple.com authored
      Rubber-stamped by Stephanie Lewis.
      
      * Scripts/run-leaks:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54099 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a09b2a0
    • mrowe@apple.com's avatar
      Keep the Windows feature defines in sync with FeatureDefines.xcconfig. · 88086c4f
      mrowe@apple.com authored
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      88086c4f
    • mrowe@apple.com's avatar
      Fix the Mac build. · ce975940
      mrowe@apple.com authored
      Disable ENABLE_INDEXED_DATABASE since it is "completely non-functional".
      
      As the comment in FeatureDefines.xcconfig notes, the list of feature defines
      needs to be kept in sync across the various files.  The default values also
      need to be kept in sync between these files and build-webkit.
      
      JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54097 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ce975940
    • sfalken@apple.com's avatar
      2010-01-29 Steve Falkenburg <sfalken@apple.com> · 2dd8f82e
      sfalken@apple.com authored
              Reviewed by Darin Adler.
      
              Timeout for client-based Geolocation shouldn't start until user gives consent
              https://bugs.webkit.org/show_bug.cgi?id=34352
      
              * page/Geolocation.cpp:
              (WebCore::Geolocation::startRequest): Don't start timer if we're blocked on user consent.
              (WebCore::Geolocation::setIsAllowed): Start timer after user gives consent.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54096 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2dd8f82e
    • cmarrin@apple.com's avatar
      Fixed changed virtual function in GraphicsLayerCACF and call order issues · fd3fca5b
      cmarrin@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=34348
              
              The correct virtual function in GraphicsLayerCACF is now being
              called. We also fixed an issue in QTMovieWin where the size
              of the movie was not being set correctly because the call order
              was changed.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54095 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fd3fca5b
    • dpranke@chromium.org's avatar
      2010-01-29 Dirk Pranke <dpranke@chromium.org> · 675f761a
      dpranke@chromium.org authored
              Reviewed by Eric Siedel.
      
              Top-level test drivers for running the Chromium port of run-webkit-tests
              and being able to rebaseline test results from the test bots.  The
              files in the Scripts directory are simply wrappers around the files
              in webkitpy/layout_tests for convenience.
       
              https://bugs.webkit.org/show_bug.cgi?id=31498
      
              * Scripts/rebaseline-chromium-webkit-tests: Added.
              * Scripts/run-chromium-webkit-tests: Added.
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
              * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54094 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      675f761a
    • dpranke@chromium.org's avatar
      2010-01-29 Dirk Pranke <dpranke@chromium.org> · c2ca4503
      dpranke@chromium.org authored
              Reviewed by Eric Siedel.
      
              Add in the second block of python code for the Chromium port
              of run-webkit-tests. These files execute different diffs to classify
              the various types of failures from a test.
      
              * Scripts/webkitpy/layout_tests/test_types: Added.
              * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
              * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
              * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
              * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c2ca4503
    • dpranke@chromium.org's avatar
      2010-01-29 Dirk Pranke <dpranke@chromium.org> · 95237f5a
      dpranke@chromium.org authored
              Reviewed by Eric Siedel.
      
              Check in the first part of the Chromium Python port of the 
              run-webkit-tests test driver. The files under 
              layout_tests/layout_layout constitute most of the implementation;
              they can be roughly divided into code that parses the 
              "test_expectations.txt" file that describes how we expect tests to
              pass or fail, platform-specific hooks for the different Chromium 
              ports (in platform_utils*), code for parsing the output of the
              tests and generating results files and HTML and JSON for the
              dashboards, auxiliary scripts for starting and stopping HTTP and
              Web Socket servers, and then one of the actual driver files 
              (test_shell_thread). Code for actually parsing test output for 
              failures and the top-level driver scripts will follow shortly.
      
              https://bugs.webkit.org/show_bug.cgi?id=31498
      
              * Scripts/webkitpy/layout_tests: Added.
              * Scripts/webkitpy/layout_tests/layout_package: Added.
              * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
                - scripts to start and stop apache. Note that the apache file
                  generates a conf file dynamically, and we should switch to 
                  using the same static conf file that the regular run-webkit-tests
                  uses, and we can also use the same httpd2.pem file.
      
              * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
                - scripts to generate the JSON layout test dashboard and the
                  flakiness dashboard
              * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
                - default configuration for LigHTTPd (used on Windows)
              * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
                - utility class that implements progress bars on the console to
                  be displayed while the tests are running
              * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
                - various routines for manipulating paths and URIs
              * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
                - platform-specific aspects of the drivers (binary names, paths,
                  process control, etc.)
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
                - code for parsing the 'test_expectations.txt' file to determine
                  which tests are expected to fail (and how) on which platforms
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
                - code for handling different kinds of failures (generating output
                  in the results, etc.)
              * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
                - code to gather the lists of tests
              * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
                - code to actually execute tests via TestShell and process
                  the output
              * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
                - scripts to start and stop the pywebsocket server
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54091 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      95237f5a
    • bweinstein@apple.com's avatar
      Roll out r54088 because the functions were already in · a32a5024
      bweinstein@apple.com authored
      IWebPreferencesPrivate, so they should stay there.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54090 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a32a5024
    • jpetsovits@rim.com's avatar
      2010-01-29 Jakob Petsovits <jpetsovits@rim.com> · c79091e6
      jpetsovits@rim.com authored
              Reviewed by Nikolas Zimmermann.
      
              [OpenVG] Implement more graphics primitives
              https://bugs.webkit.org/show_bug.cgi?id=34339
      
              Adds lines, arcs, ellipses, polygons and rounded
              rectangles to PainterOpenVG and GraphicsContext.
      
              Rounded rects support by Eli Fidler <efidler@rim.com>.
      
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::drawLine):
              (WebCore::GraphicsContext::drawEllipse):
              (WebCore::GraphicsContext::strokeArc):
              (WebCore::GraphicsContext::drawConvexPolygon):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              (WebCore::GraphicsContext::drawFocusRing):
              (WebCore::GraphicsContext::drawLineForText):
              (WebCore::GraphicsContext::clearRect):
              (WebCore::GraphicsContext::strokeRect):
              * platform/graphics/openvg/PainterOpenVG.cpp:
              (WebCore::PainterOpenVG::drawRect):
              (WebCore::PainterOpenVG::drawRoundedRect):
              (WebCore::PainterOpenVG::drawLine):
              (WebCore::PainterOpenVG::drawArc):
              (WebCore::PainterOpenVG::drawEllipse):
              (WebCore::PainterOpenVG::drawPolygon):
              * platform/graphics/openvg/PainterOpenVG.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54089 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c79091e6
    • bweinstein@apple.com's avatar
      Rubber-stamped by Adam Roben. · fc2bca7f
      bweinstein@apple.com authored
      Move customDragCursorEnabled preference functions from 
      IWebPreferences to IWebPreferencesPrivate.
      
      * Interfaces/IWebPreferences.idl: Moved customDragFunctions from here...
      * Interfaces/IWebPreferencesPrivate.idl: To here.
      * Interfaces/WebKit.idl: Touched to make sure we rebuild.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54088 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fc2bca7f
    • dpranke@chromium.org's avatar
      2010-01-29 Dirk Pranke <dpranke@chromium.org> · 5f3304c5
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              Check in a copy of the simplejson library; it will be used by
              the Chromium port of run-webkit-tests.
              
              https://bugs.webkit.org/show_bug.cgi?id=31498
      
              * simplejson: Added.
              * simplejson/LICENSE.txt: Added.
              * simplejson/README.txt: Added.
              * simplejson/__init__.py: Added. 
              * simplejson/_speedups.c: Added.
              (ascii_escape_char):
              (ascii_escape_unicode):
              (ascii_escape_str):
              (py_encode_basestring_ascii):
              (init_speedups):
              * simplejson/decoder.py: Added.
              * simplejson/encoder.py: Added.
              * simplejson/jsonfilter.py: Added.
              * simplejson/scanner.py: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54087 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5f3304c5
    • dpranke@chromium.org's avatar
      2010-01-29 Dirk Pranke <dpranke@chromium.org> · 85ffb3bd
      dpranke@chromium.org authored
              No review
      
              Add myself to the committers list
      
              * Scripts/webkitpy/committers.py:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      85ffb3bd
    • jorlow@chromium.org's avatar
      2010-01-29 Jeremy Orlow <jorlow@chromium.org> · 261f6353
      jorlow@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              A first step towards the Indexed Database API
              https://bugs.webkit.org/show_bug.cgi?id=34342
      
              Add runtime enable support for Indexed Database API.
      
              * features.gypi:
              * public/WebRuntimeFeatures.h:
              * src/WebRuntimeFeatures.cpp:
              (WebKit::WebRuntimeFeatures::enableIndexedDatabase):
              (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
      2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              A first step towards the Indexed Database API
              https://bugs.webkit.org/show_bug.cgi?id=34342
      
              Flesh out the first part of Indexed Database API.
              Currently only compiles with v8 + chromium for now.
              Completely non-functional, but it seems best to do
              this in chunks.
      
              No tests because nothing works yet.
      
              * Configurations/FeatureDefines.xcconfig:
              * WebCore.gypi:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/DOMObjectsInclude.h:
              * bindings/v8/DerivedSourcesAllInOne.cpp:
              * bindings/v8/RuntimeEnabledFeatures.cpp:
              * bindings/v8/RuntimeEnabledFeatures.h:
              (WebCore::RuntimeEnabledFeatures::setIndexedDatabaseEnabled):
              (WebCore::RuntimeEnabledFeatures::indexedDatabaseEnabled):
              * bindings/v8/V8Index.cpp:
              * bindings/v8/V8Index.h:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::V8DOMWindow::IndexedDBEnabled):
              * bindings/v8/custom/V8IDBRequestCustom.cpp: Added.
              (WebCore::V8IDBRequest::resultAccessorGetter):
              * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Added.
              (WebCore::V8IndexedDatabaseRequest::openCallback):
              * dom/EventNames.h:
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::indexedDB):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * storage/IDBDatabaseError.h: Added.
              (WebCore::IDBDatabaseError::create):
              (WebCore::IDBDatabaseError::~IDBDatabaseError):
              (WebCore::IDBDatabaseError::code):
              (WebCore::IDBDatabaseError::setCode):
              (WebCore::IDBDatabaseError::message):
              (WebCore::IDBDatabaseError::setMessage):
              (WebCore::IDBDatabaseError::IDBDatabaseError):
              * storage/IDBDatabaseError.idl: Added.
              * storage/IDBDatabaseException.h: Added.
              (WebCore::IDBDatabaseException::create):
              (WebCore::IDBDatabaseException::~IDBDatabaseException):
              (WebCore::IDBDatabaseException::code):
              (WebCore::IDBDatabaseException::setCode):
              (WebCore::IDBDatabaseException::message):
              (WebCore::IDBDatabaseException::setMessage):
              (WebCore::IDBDatabaseException::IDBDatabaseException):
              * storage/IDBDatabaseException.idl: Added.
              * storage/IDBRequest.cpp: Added.
              (WebCore::IDBRequest::IDBRequest):
              (WebCore::IDBRequest::~IDBRequest):
              (WebCore::IDBRequest::abort):
              (WebCore::IDBRequest::eventTargetData):
              (WebCore::IDBRequest::ensureEventTargetData):
              * storage/IDBRequest.h: Added.
              (WebCore::IDBRequest::create):
              (WebCore::IDBRequest::readyState):
              (WebCore::IDBRequest::error):
              (WebCore::IDBRequest::result):
              (WebCore::IDBRequest::scriptExecutionContext):
              (WebCore::IDBRequest::toIDBRequest):
              (WebCore::IDBRequest::refEventTarget):
              (WebCore::IDBRequest::derefEventTarget):
              * storage/IDBRequest.idl: Added.
              * storage/IndexedDatabaseRequest.cpp: Added.
              (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
              (WebCore::IndexedDatabaseRequest::~IndexedDatabaseRequest):
              (WebCore::IndexedDatabaseRequest::open):
              * storage/IndexedDatabaseRequest.h: Added.
              (WebCore::IndexedDatabaseRequest::create):
              (WebCore::IndexedDatabaseRequest::request):
              * storage/IndexedDatabaseRequest.idl: Added.
      2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              A first step towards the Indexed Database API
              https://bugs.webkit.org/show_bug.cgi?id=34342
      
              Add Indexed Database API
      
              * configure.ac:
      2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              A first step towards the Indexed Database API
              https://bugs.webkit.org/show_bug.cgi?id=34342
      
              Add indexed database API.
      
              * Scripts/build-webkit:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54085 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      261f6353
    • abecsi@webkit.org's avatar
      Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used. · 8dd7eb4d
      abecsi@webkit.org authored
      This fixes a regression introduced in r53559.
      
      Reviewed by Alexey Proskuryakov.
      
      https://bugs.webkit.org/show_bug.cgi?id=34336
      
      * Scripts/webkitperl/httpd.pm:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54084 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8dd7eb4d
    • bweinstein@apple.com's avatar
      WebCore: Drag and Drop: Windows uses "stop" sign as cursor when dragging · 28e89396
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34305
      <rdar://problem/7589672>
      
      Reviewed by Adam Roben.
      
      Add a FIXME for the code that needs to be changed to support full
      custom cursors.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleDrag):
      
      WebKit/win: Drag and Drop: Windows uses "stop" sign as cursor when dragging
      https://bugs.webkit.org/show_bug.cgi?id=34305
      <rdar://problem/7589672>
              
      Reviewed by Adam Roben.
      
      Add a preference in WebKit (that defaults to false), for whether or not
      we should show the custom cursors during drag and drop. However, this is
      currently only used on Windows, and only used to hide the "drop not allowed"
      icon inside the WebView is the preference is set to true.
      
      This will be off by default, so no change in behavior.
      
      * Interfaces/IWebPreferencesPrivate.idl: Added new functions.
      * Interfaces/WebKit.idl: Touched to force Interfaces build.
      * WebDropSource.cpp:
      (WebDropSource::GiveFeedback): Implementation of conditional showing cursor
          logic.
      * WebPreferenceKeysPrivate.h: Added new preference key.
      * WebPreferences.cpp: Added new functions.
      (WebPreferences::setCustomDragCursorsEnabled):
      (WebPreferences::customDragCursorsEnabled):
      * WebPreferences.h: Added new functions.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54083 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      28e89396
  3. 29 Jan, 2010 17 commits
    • victorw@chromium.org's avatar
      · 7df37d74
      victorw@chromium.org authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@54082 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7df37d74
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · 81f2de85
      ap@apple.com authored
              <rdar://problem/7441982> REGRESSION (TOT): Adobe CS4: Installer alerts are displayed as
              blank windows
      
              We probably shouldn't be deferring loads below modal dialogs and alerts, because that's not
              what being modal means. But making such a change for general Web content would require fixes
              in other parts of code, which I'm not ready to implement right now, so making it application
              specific.
      
      WebCore:
              * page/Page.cpp: (WebCore::Page::setDefersLoading): Do nothing if load deferring is not
              enabled in page settings.
      
              * WebCore.base.exp:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setLoadDeferringEnabled):
              * page/Settings.h: (WebCore::Settings::loadDeferringEnabled):
              Add the ability for client to disable page deferring (still enabled by default).
      
              * platform/mac/RuntimeApplicationChecks.h:
              * platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAdobeInstaller):
              Added a bundle ID test for Adobe installer.
      
      WebKit/mac:
              * WebView/WebView.mm:
              (shouldEnableLoadDeferring): Load deferring is enabled unless the application is Adobe
              Installer.
              (-[WebView _preferencesChangedNotification:]): Call setLoadDeferringEnabled().
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54081 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      81f2de85
    • sfalken@apple.com's avatar
      Build fix. · c9f11aea
      sfalken@apple.com authored
      * page/Geolocation.cpp:
      (WebCore::Geolocation::startUpdating):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54080 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c9f11aea
    • sfalken@apple.com's avatar
      2010-01-29 Steve Falkenburg <sfalken@apple.com> · fb757738
      sfalken@apple.com authored
              Reviewed by Darin Adler.
      
              Client-based Geolocation starts updating before getting consent from the user
              https://bugs.webkit.org/show_bug.cgi?id=34343
      
              * page/Geolocation.cpp:
              (WebCore::Geolocation::startRequest): Pass notifier instead of options to startUpdating.
              (WebCore::Geolocation::setIsAllowed): Add the observer or notify of error for deferred startUpdating.
              (WebCore::Geolocation::startUpdating): Pass notifier instead of options, since we may need to call it if we fail to get user consent.
              Defer adding the observer if we don't yet have user consent, since this could kick off
              server-based wifi Geolocation requests.
              * page/Geolocation.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54079 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fb757738
    • jhoneycutt@apple.com's avatar
      MSAA: Crash when posting a notification for a detached object · 21c98ab4
      jhoneycutt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34309
      <rdar://problem/7409759>
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      Test: platform/win/accessibility/detached-object-notification-crash.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (AccessibilityRenderObject::document):
      Null check m_renderer. This is the bug fix; the other changes in the
      patch are for the test.
      
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      Map AXValueChanged to EVENT_OBJECT_VALUECHANGED, so we'll post a
      notification when AXValueChanged is posted. Receiving an event of this
      type tells us that the test passed.
      
      WebKit/win:
      
      * AccessibleBase.cpp:
      (AccessibleBase::QueryService):
      If an unrecognized service ID is passed, return early. Otherwise, return
      the result of QueryInterface.
      (AccessibleBase::QueryInterface):
      Add static_casts. Check for new UUIDs.
      (AccessibleBase::isSameObject):
      Query the object for AccessibleBase. Return whether the pointers or the
      wrapped objects match.
      
      * AccessibleBase.h:
      Give the class a UUID so we can query for it in isSameObject(). Inherit
      from IAccessibleComparable; inherit from IServiceProvider so clients can
      use QueryService to query for a custom interface.
      
      * Interfaces/AccessibleComparable.idl: Added. Declares a function that
      can be called to compare to accessible objects.
      
      * Interfaces/WebKit.idl:
      Include the new IDL.
      
      * WebKit.vcproj/Interfaces.vcproj:
      Add the new IDL to the project.
      
      WebKitTools:
      
      * DumpRenderTree/AccessibilityController.h:
      Declare new functions. Add new members to store the event hook and the
      mapping of accessibility elements to their JS callbacks.
      
      * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
      (AccessibilityController::notificationReceived):
      Stubbed.
      (AccessibilityController::addNotificationListener):
      Stubbed.
      
      * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      (AccessibilityController::notificationReceived):
      Stubbed.
      (AccessibilityController::addNotificationListener):
      Stubbed.
      
      * DumpRenderTree/win/AccessibilityControllerWin.cpp:
      (AccessibilityController::AccessibilityController):
      Initialize the event hook.
      (AccessibilityController::~AccessibilityController):
      Remove the event hook. Unprotect all of the JS functions that are stored
      in the map.
      (logEventProc):
      Clean-up a variable.
      (stringEvent):
      Return a string description of the MSAA event code.
      (notificationListenerProc):
      Get the accessible object from the event, and query it for IAccessible.
      Call the AccessibilityController's notificationReceived().
      (comparableObject):
      Use QueryService to obtain the IAccessibleComparable for the
      IServiceProvider.
      (AccessibilityController::notificationReceived):
      Iterate the map of objects that have registered for notification
      callbacks. Query each for IServiceProvider, then use comparableObject()
      to get an IAccessibleComparable. If we find an object matching the
      notified object, call its callback, passing the event that was received.
      (AccessibilityController::addNotificationListener):
      If we have not created the event hook, create it. Protect the JS
      callback function object, and add the object and its callback to our
      map.
      
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::addNotificationListener):
      Call through to the AccessibilityController's addNotificationListener().
      
      * DumpRenderTree/win/DumpRenderTreeWin.h:
      Add an extern declaration for the shared FrameLoadDelegate extern, so we
      can access it from AccessibilityController.
      
      * DumpRenderTree/win/FrameLoadDelegate.h:
      (FrameLoadDelegate::accessibilityController):
      Return the AccessibilityController.
      
      LayoutTests:
      
      * platform/win/accessibility/detached-object-notification-crash-expected.txt: Added.
      * platform/win/accessibility/detached-object-notification-crash.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54078 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      21c98ab4
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · c4ea075e
      kenneth@webkit.org authored
      [Qt] Separate implementation from class definition.
      
      * QtLauncher/main.cpp:
      (LauncherWindow::webView):
      (LauncherWindow::LauncherWindow):
      (LauncherWindow::~LauncherWindow):
      (LauncherWindow::keyPressEvent):
      (LauncherWindow::grabZoomKeys):
      (LauncherWindow::sendTouchEvent):
      (LauncherWindow::eventFilter):
      (LauncherWindow::loadStarted):
      (LauncherWindow::loadFinished):
      (LauncherWindow::showLinkHover):
      (LauncherWindow::zoomIn):
      (LauncherWindow::zoomOut):
      (LauncherWindow::resetZoom):
      (LauncherWindow::toggleZoomTextOnly):
      (LauncherWindow::print):
      (LauncherWindow::screenshot):
      (LauncherWindow::setEditable):
      (LauncherWindow::dumpHtml):
      (LauncherWindow::selectElements):
      (LauncherWindow::setTouchMocking):
      (LauncherWindow::newWindow):
      (LauncherWindow::setupUI):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54077 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c4ea075e
    • eric@webkit.org's avatar
      2010-01-29 Shinichiro Hamaji <hamaji@chromium.org> · 03061356
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              prepare-ChangeLog outputs useless messages for a nonexistent bug ID
              https://bugs.webkit.org/show_bug.cgi?id=34313
      
              * Scripts/prepare-ChangeLog:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54076 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      03061356
    • darin@chromium.org's avatar
      2010-01-29 Darin Fisher <darin@chromium.org> · 974213eb
      darin@chromium.org authored
              Okayed by Oliver Hunt.
      
              Rollout r53949, r53951 and r54013 due to a Chromium regression that it
              causes.  Somehow this code change is triggering an endless repaint loop.
      
              https://bugs.webkit.org/show_bug.cgi?id=33808
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawTiledImage):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/transforms/TransformationMatrix.h:
              (WebCore::TransformationMatrix::isIdentityOrTranslation):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              * rendering/RenderBoxModelObject.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54075 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      974213eb
    • kenneth@webkit.org's avatar
      [Qt] On Maemo5, a click/touch in the location bar (when unfocused) · 3c80a539
      kenneth@webkit.org authored
      should result in all text selected.
      
      Reviewed by Ariya Hidayat.
      
      * QtLauncher/locationedit.cpp:
      (LocationEdit::focusInEvent):
      * QtLauncher/locationedit.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54074 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c80a539
    • oliver@apple.com's avatar
      2010-01-29 Oliver Hunt <oliver@apple.com> · 732be1c8
      oliver@apple.com authored
              Reviewed by Darin Adler.
      
              JSC is failing to propagate anonymous slot count on some transitions
              https://bugs.webkit.org/show_bug.cgi?id=34321
      
              Remove the unsafe two argument Structure::create method, and correct
              the uses of it to propagate the anonymous slot count.
      
              * runtime/JSObject.h:
              (JSC::JSObject::setStructure):
              * runtime/Structure.cpp:
              (JSC::Structure::addPropertyTransition):
              (JSC::Structure::changePrototypeTransition):
              (JSC::Structure::despecifyFunctionTransition):
              (JSC::Structure::getterSetterTransition):
              (JSC::Structure::toDictionaryTransition):
              * runtime/Structure.h:
      2010-01-29  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Darin Adler.
      
              JSC is failing to propagate anonymous slot count on some transitions
              https://bugs.webkit.org/show_bug.cgi?id=34321
      
              Add a test for modification of a type with anonymous slots.
      
              * fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
              * fast/dom/Window/anonymous-slot-with-changes.html: Added.
      2010-01-29  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Darin Adler.
      
              JSC is failing to propagate anonymous slot count on some transitions
              https://bugs.webkit.org/show_bug.cgi?id=34321
      
              Make code generator add assertions for anonymous slot count.
      
              Test: fast/dom/Window/anonymous-slot-with-changes.html
      
              * bindings/scripts/CodeGeneratorJS.pm:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54073 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      732be1c8
    • kenneth@webkit.org's avatar
      [Qt] Show progress reaching 100% for loads. · 281ff844
      kenneth@webkit.org authored
      Reviewed by Ariya Hidayat.
      
      * QtLauncher/locationedit.cpp:
      (LocationEdit::LocationEdit):
      (LocationEdit::setProgress):
      (LocationEdit::reset):
      (LocationEdit::paintEvent):
      * QtLauncher/locationedit.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54072 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      281ff844
    • eric@webkit.org's avatar
      2010-01-29 Tony Chang <tony@chromium.org> · c1eb43d7
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Add gdb helper methods for Ranges like we have for VisibleSelections.
              https://bugs.webkit.org/show_bug.cgi?id=34308
      
              No new tests, these are only for debugging.
      
              * dom/Position.cpp:
              (WebCore::Position::showTreeForThis):
              * dom/Range.cpp:
              (showTree):
              * dom/Range.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54071 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c1eb43d7
    • eric@webkit.org's avatar
      2010-01-29 Drew Wilson <atwilson@chromium.org> · 75bab15e
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
              https://bugs.webkit.org/show_bug.cgi?id=34292
      
              Test: fast/events/init-events.html will pass in Chrome now.
      
              * bindings/v8/custom/V8MessageEventCustom.cpp:
              (WebCore::V8MessageEvent::initMessageEventCallback):
              Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54070 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      75bab15e
    • eric@webkit.org's avatar
      2010-01-29 Ben Murdoch <benm@google.com> · f157f0a0
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
              https://bugs.webkit.org/show_bug.cgi?id=34215
      
              Add a function on the ChromeClient that WebCore can use to inform the platform when it needs touch events. This way the platform can optimise by not forwarding the events if they are not required.
      
              No new tests as the only implementation is specific to Android.
      
              * dom/Document.cpp:
              (WebCore::Document::detach): Check if this is the top level document and if so, stop forwarding touch events.
              (WebCore::Document::addListenerTypeIfNeeded): Inform the ChromeClient it should start forwarding touch events and guard touch event code properly.
              * history/CachedFrame.cpp:
              (WebCore::CachedFrameBase::restore): If the document uses touch events, inform the ChromeClient to start forwarding them.
              (WebCore::CachedFrame::CachedFrame): If the document uses touch events, inform the ChromeClient to stop forwarding them, as the document is being put into the page cache.
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::needTouchEvents): Add an empty implementation.
              * page/ChromeClient.h: Add the needTouchEvents() function.
      2010-01-29  Ben Murdoch  <benm@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              [Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
              https://bugs.webkit.org/show_bug.cgi?id=34215
      
              Add needTouchEvents() to the ChromeClient which is called when the page decides it needs or no longer needs to be informed of touch events.
      
              * WebCoreSupport/ChromeClientQt.h:
              (WebCore::ChromeClientQt::needTouchEvents): Add an empty implementation.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f157f0a0
    • eric@webkit.org's avatar
      2010-01-29 Alexander Pavlov <apavlov@chromium.org> · 617657b5
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Fix toolbar gradient to match the window's titlebar on Snow Leopard
              https://bugs.webkit.org/show_bug.cgi?id=34320
      
              * inspector/front-end/inspector.css:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54068 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      617657b5
    • eric@webkit.org's avatar
      2010-01-29 Alexander Pavlov <apavlov@chromium.org> · b0869d68
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Fix MacOS X version detection
      
              MacOS X version can have 2 or 3 segments.
              https://bugs.webkit.org/show_bug.cgi?id=34322
      
              * inspector/front-end/inspector.js:
              (WebInspector._detectPlatform):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54067 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b0869d68
    • eric@webkit.org's avatar
      2010-01-29 Andreas Kling <andreas.kling@nokia.com> · 718b624f
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Disable the QtLauncher statusbar on Maemo
      
              https://bugs.webkit.org/show_bug.cgi?id=34330
      
              * QtLauncher/main.cpp:
              (LauncherWindow::showLinkHover):
              (LauncherWindow::selectElements):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54066 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      718b624f