- 16 Oct, 2019 40 commits
-
-
ckitagawa authored
The current code is too lax. It doesn't enforce bounds checks strongly enough. It claims to be for RVAs, but allows all sections through. This results in downstream code being unable to trust that the regions created are safely within the image resulting in issues when Fuzzing if the data is ill formed. To fix the fuzzers we should be remove this forgiveness. However, long term a better check for RVA forgiveness should maybe be investigated. Bug: 1013823, 1013842, 1013871, 1014124 Change-Id: Ic164fc76d687711c496f57b3bfe33ced6b8ad838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863070Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#706511}
-
Hiroshige Hayashizaki authored
This CL splits some WPT tests into - wpt/import-maps/core/ that tests the core features after https://github.com/WICG/import-maps/pull/176, and - wpt/import-maps/builtin-support.tentative/ that requires pre-#176 built-in module and fallback support, in order to test builtin- and non-builtin- versions easier. Bug: 1010751 Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706510}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the viz::mojom::FrameSinkManagerClient interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ice2d034ac1b5eed866c7296046cf031eb0f00f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859987 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#706509}
-
Robbie McElrath authored
See https://crbug.com/1010625 for background. This CL does the following: * Whitelist prefs needed to record the SeedFreshness metric * Change the SeedInfo.date field to use the device's current time rather than the server's time from the Date header * Copy the seed that VariationsSeedLoader finds to the pref that VariationsSeedStore uses so its metrics recording code will work Test: Manually verified SeedFreshness was being recorded Bug: 1010625 Change-Id: I8b3eda5967672b4fd4218bab288157dfd06ce38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828235 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706508}
-
Amr Aboelkher authored
Add ChromeVox support to indicate for each accessibility feature, whether its forced on, and is being controlled by a policy, in the tray accessibility menu. Bug: 552439 Change-Id: Ia6066725deeaa4587192c6b309de7dfdfc4b10fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863020Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#706507}
-
rbpotter authored
Update extensions.html to use relative paths like the rest of the page. This reduces the differences in the generated output file when updating to Polymer bundler v4. Update print preview's icons.html file to not rely on "xlink:href", which is deprecated and no longer necessary. This link also breaks when passed through Polymer bundler v4. Bug: 921285 Change-Id: I8b68c4e91db141065cce8a1cc83a86a9e8e051b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862085Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706506}
-
Cliff Smolinsky authored
The test was incorrectly expecting >1 dll to be enumerated for the case when a target module is specified. Bug: 1014527 Change-Id: I1e8fd5474411f5e4286a171e0353e24e46e668b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863450Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706505}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba97f6065ed1..a0568178808d git log ba97f6065ed1..a0568178808d --date=short --no-merges --format='%ad %ae %s' 2019-10-16 ehmaldonado@chromium.org depot-tools: Remove support for --auth-refresh-token-json. Created with: gclient setdep -r src/third_party/depot_tools@a0568178808d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: I554e1bee3eec2c1f055509132b974249ea735488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706504}
-
Brian Sheedy authored
Removes the LUCI config and test spec entries for the GPU Mac 10.14 testers, as the build-side bot configs were removed in crrev.com/c/1860147. Bug: 1005378 Change-Id: Ie1b54734874723cbd993ffc02ef7952154e97572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863740 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706503}
-
Sebastien Marchand authored
This database isn't needed anymore now that sites can opt out from freezing via an Origin Trial. Change-Id: I91608ecc2e1bc77ddf3da762ff332674f403f1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862723Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#706502}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..e180b591d166 $ git log 1093c4de2..e180b591d --date=short --no-merges --format='%ad %ae %s' 2019-10-16 cwallez Fix compilation with shared_library components on Windows 2019-10-16 cwallez Add missing header for MSVC 2019-10-16 enga Split generation of dawncpp headers from libdawncpp 2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling 2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests 2019-10-15 senorblanco clang-win compile files for skia-dawn. 2019-10-15 cwallez Add dawnGetProcAddress. 2019-10-15 cwallez Split the libdawn target in components with a single purpose. Created with: roll-dep src/third_party/dawn TBR=kbr@chromium.org BUG=dawn:22 Change-Id: I03fdfed640f8a1c6747e369f34e9be26903de27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865168Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#706501}
-
John Budorick authored
Bug: 1014952 Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694 Tbr: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706500}
-
Alex Ilin authored
The test removes the sole profile, waits for the browser removal from the BrowserList and then expects that the new browser is already added. This seems not to be always true, since the new profile/browser is created asynchronously. This CL modifies ProfileHelperTest.DeleteSoleProfile to wait for BrowserListObserver::OnBrowserAdded() event before checking that the BrowserList isn't empty. Bug: 1008238 Change-Id: Ie7b6a705d7cba5a03e943ed6ec0ab4c3ea08c36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863294 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Koji Ishii authored
Bug: 988015 Change-Id: I9a070297c2b3f0422e94f555d2637d15cd498002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719913Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706498}
-
Parastoo Geranmayeh authored
This reverts commit 1901912d. Reason for revert: potential cause for flaky tests. Please see bug. Bug: 1014966 Original change's description: > Composited Worklet Animations: Fixed updating local time on main thread. > > This CL changes how local time of composited worklet animations is updated on main thread: > instead of polling local time on main thread, the local time is posted via animation events > by the composited thread to the main thread. > > Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing > > Changes made: > - Expanded AnimationEvent to support worklet animation time update event type. > - Reused existing mechanism of posting animation events to the main thread to support new > event type. > - Removed "peek" logic. > - Enabled tests that previously failed. > > > Bug: 943787 > Change-Id: I2d285506739ea623e292927d21e54910fb7e24bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826872 > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#706078} TBR=flackr@chromium.org,majidvp@chromium.org,gerchiko@microsoft.com Change-Id: Ic5bfd6532578276fe9e0de80f96f343a863e4f0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865350Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706497}
-
Livvie Lin authored
Don't downgrade to DANGEROUS on form edits when kMarkHttpAsParameterDangerWarning is enabled. This also means that DevTools will no longer show the form field edited warning in these cases. Bug: 1008218 Change-Id: Ie3b94406824494f1fb8e2b8d6edf9208ff08a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860396Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706496}
-
Ionel Popescu authored
According to https://w3c.github.io/html-aam/#el-datalist the aria role for datalist should be listbox (currently it is menu). For datalist options according to https://w3c.github.io/html-aam/#el-option the aria role should be option (currently it is menuitem). The unit test is also updated to use the new aria roles. Bug: 1011133 Change-Id: Ia3541067e3d8ada622c5c3776f3b1b0ce0a26c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838997Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706495}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59e72b71b5cf..36446f281ca2 git log 59e72b71b5cf..36446f281ca2 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 senorblanco@chromium.org Reformat BUILD files. 2019-10-16 senorblanco@chromium.org Roll Dawn to ToT. 2019-10-16 robertphillips@google.com Start disentangling tessellation from pipeline creation in GrTextureOp 2019-10-16 halcanary@google.com canvaskit: add helpful message to compile.sh Created with: gclient setdep -r src/third_party/skia@36446f281ca2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I1b5590ce88ef6512b1922f5a489963d041bb42d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865197Reviewed-by:
-
Istiaque Ahmed authored
On windows, filename with (.| )+ suffix is ignored, i.e. "foo.html." and "foo.html" are treated the same. VerifiedContents is already aware of this and it stores a canonicalized version of filename for filenames containing (.| )+ suffix. This CL makes ComputedHashes aware of the change too, so that searching for hashes will consider canonicalized version of the filename as candidate. This makes ComputedHashes::Reader and VerifiedContents treat this suffix behavior consistently. This CL also adds unittest and browsertest for the fix. Bug: 696208 Test: See bug for test repro. Change-Id: I7c59add5c035815673259ef1f995c7b9ed01a75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772643 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706493}
-
Eric Karl authored
Currently, when Display is destroyed, it tears down DisplayScheduler midway through destruction. This is problematic as DisplayScheduler can call back into Display in a partially destroyed state. We could force DisplayScheduler to be destroyed earlier, but this is still somewhat brittle. Instead we allow DisplayScheduler to have a null DisplaySchedulerClient and null this before destroying Display. Bug: 1012943 Change-Id: I5892ed2746ba29ef5c3c027e9564e52ee6c659ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863674 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706492}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1c80a64. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5d8180308c7bf43416d51e0e2bf042910475cc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864874Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706491}
-
sczs authored
- Creates InfobarSaveCardCoordinator and implements stop and infobarWasDismissed which is common between all InfobarCoordinators. - Creates kInfobarTypeSaveCard and expands infobar_metrics_recorder to handle this case. (The Histogram suffix is being updated on https://crrev.com/c/1862867) Bug: 1014652 Change-Id: I86e70ce67f01e63622d83834094fb4bd4fded68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862863Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706490}
-
Christian Fremerey authored
Bug: None Change-Id: Id480b5ff4951b72408bf26765bff53fb4e447901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811279Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706489}
-
Annie Sullivan authored
We need to re-enable to check if bug 839470 is fixed, and bug 953371 is marked fixed. Bug: 839470,953371 Change-Id: I9c1c06b731c7d9049ed88cf758796dd31a35f9ee TBR: crouleau@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864380Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706488}
-
Matt Menke authored
There's a method in net/ which does the exact same check: net::HttpUtil::IsSafeHeader(). We shouldn't duplicate logic. Bug: None Change-Id: I70a68db14c4cdb1962e0980594485e8a41be1308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862864Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#706487}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/692ad2ff20be..a737564bd5b5 git log 692ad2ff20be..a737564bd5b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jclinton@chromium.org cbuildbot: Always use `--groups all` when repo init Created with: gclient setdep -r src/third_party/chromite@a737564bd5b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I61e1a1e796610f0a38f8dc345afc79c6f238cc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865196Reviewed-by:
-
Robert Liao authored
BUG=1014283 Change-Id: Ieb4762c3c6b59cba40a55d60c980d76c0330180f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860979Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706485}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bedeb781e8ca..a14555a7928f git log bedeb781e8ca..a14555a7928f --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jmadill@chromium.org Vulkan: Refactor RenderTargetVk ImageViews. 2019-10-16 tobine@google.com Revert "Vulkan: Define VK_USE_PLATFORM_XLIB_KHR" Created with: gclient setdep -r src/third_party/angle@a14555a7928f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1011068 Change-Id: I94b146ac594828006ecc7fc0d1df910f0e4cd6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864373Reviewed-by:
-
Andrew Grieve authored
Rather than whatever version of java is available in PATH. For desugar and errorprone, some java warnings started to show up from this: "WARNING: An illegal reflective access operation has occurred" I've just silenced them with a stderr filter, and figure they will go away next time we roll these deps. I've checked the effect on d8 & r8 for this: * On my local machine, they run much faster. * On the trybot, they ran a bit slower. Bug: 693079 Change-Id: I4001bbcb5bdcc2a9afa062c35633dc397b0ef9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857702 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706483}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad531032..fedca194 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id2be91e07431d38b508fc198e601865d2ad07ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864875Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706482}
-
Mark Cogan authored
This is the first CL of several breaking crrev.com/c/1860025 into smaller chunks. This updates most of the SettingsNavigationController class inits to take a Browser instead of a BrowserState. One of the inits (the import data one) is called from AuthenticationFlowPerformer, which doesn't yet have a Browser, so it's initialized with a BrowserState instead. Because of this, SettingsNavigationController itself is initialized with a BrowserState. There's also some cleanup of these init names. Prior to this change, none of the class methods (for example: "newAccountsController:delegate:") properly identified the first parameter. Some of the method signatures were also impossible for clang-format to wrap to 80 characters. So: - The return type of all of these methods is now 'instancetype'. - The 'new' prefix is dropped from all of them, matching current style. - Methods that had 'WithBrowserState:' now have 'ForBrowser:', aside from -importDataControllerForBrowserState:delegate:importDataDelegate: fromEmail:toEmail:isSignedIn:. - Methods that didn't have a keyword for the BrowserState parameter also now have "ForBrowser:". - "syncEncryptionPassphrase" is shortened to "syncPassphrase", since "Encryption" doesn't add any useful information. The full method name is now +syncPassphraseControllerForBrowser:delegate:. - "autofillProfille" is corrected to "autofillProfile" (one "l" in "profile", The full method name is now +autofillProfileControllerForBrowser:delegate: - "settingsMainController" is reordered to "mainSettings". The full method name is now +mainSettingsControllerForBrowser:delegate: BrowserInterface didn't have a 'browser' property, which it clearly needed. This CL adds one. Change-Id: I6b0a8c8583dc69485a0f65ac1d069de7b417d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862915 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#706481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48014ea23a48..79f2a7ff7c3b Created with: gclient setdep -r src-internal@79f2a7ff7c3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I00e877980c0f4e0a3eaa0a5e970fc96c1a55353e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706480}
-
Rodney Ding authored
- Consolidate baseFeature checks together and use enums to denote 3 common use patterns Design docs: https://docs.google.com/document/d/1d6_NBVPXh7B2XMk3H9b_qIxeuSXq6MblVSJldN7bTBY/edit?usp=sharing Bug: 832393 Change-Id: If3b4e4d80c61ab810014550c6aedf873768d1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826862 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#706479}
-
Alexander Rezepkin authored
Before this patch, the maximum number of suggestions within Hunspell was 15, although Chrome uses only 5 suggestions. See: https://cs.chromium.org/chromium/src/components/spellcheck/common/spellcheck_common.h?l=22&rcl=a88c5fe6e641bdc9cb84b64ddb90ead67e0d0bcc So when a misspelled word has more than 5 suggestions, Hunspell does a useless job and searches for suggestions that will never be used. This patch reduces from 15 to 5 the maximum number of searched suggestions within Hunspell. Bug: NONE Change-Id: I68054cfc161ec509c99a620de2b0e5252576853c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863298 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706478}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9097eeb5359b..520ed2286b88 git log 9097eeb5359b..520ed2286b88 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 srisser@google.com Fix how we calculate potential overflows with PBOs Created with: gclient setdep -r src/third_party/swiftshader@520ed2286b88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:140881221 Change-Id: Ib7a9f1f683bdffb975ddc61d69baa81957e98f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865191Reviewed-by:
-
Sebastien Marchand authored
Change-Id: I17ccf902883095ba5e2f7356672e6c3d3b5dfd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864612 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#706476}
-
dpapad authored
registerMessageCallback is not encouraged, when a TestBrowserProxy already exists. Note that registerMessageCallback is fairly old infrastructure, and couples our tests to test_api.js which is unwanted. Bug: None Change-Id: I97c480fbb44547e3dbb6dad32d96d96174051559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863074Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706475}
-
Paul Lewis authored
If a user right clicks on an element in the console and chooses to reveal it in the elements panel, and the element is not in the document, the operation fails but it is not communicated to the user. This patch adds a warning if the node appears to be detached from the document; it is done through checking the parentNode property, which is the most suitable means in lieu of having the isConnected property available in the Node object. Bug: 967156 Change-Id: I58228facb54e9afc87215d68176f473121121db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681891 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#706474}
-
Thomas Tangl authored
Bug: 995720 Change-Id: Ib8863788082efb13f38831813e86dff5289d810b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865247 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706473}
-
Peter Boström authored
This reverts commit 5bb16cdd. Reason for revert: Relanding without CreateInkDropMask removal. Original change's description: > Revert "Add HighlightPathGenerator to TabCloseButton" > > This reverts commit b25e7445. > > Reason for revert: The ink drop path here was not the same as the highlight path; in particular, the ink drop path is manually mirrored, while the highlight path is auto-mirrored. Reverting since this results in the wrong appearance in RTL. > > Original change's description: > > Add HighlightPathGenerator to TabCloseButton > > > > Replaces OnBoundsChanged override which resulted in a lot of path > > generation (per-tab + frame) while opening new tabs or resizing the > > window. > > > > Also removes a ::GetInkDropMask() override which just generated the same > > path. > > > > Bug: chromium:1007546 > > Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 > > Auto-Submit: Peter Boström <pbos@chromium.org> > > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#705972} > > TBR=ellyjones@chromium.org,pbos@chromium.org > > Change-Id: Ic7bd1312d452c828877669db89af45ac59160455 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1007546 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864393 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706348} TBR=ellyjones@chromium.org,pkasting@chromium.org,pbos@chromium.org Change-Id: I219552ebc8ec2dfe0504f5d1234d01fdc7e1232d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864376 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706472}
-
