GitLab

The other layout files will be moved later.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6374011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72507 0039d316-1c4b-4281-b951-d872f2087c98

Some Mac OS Leopard versions were affected by a bug caused by trying to close a speech UI bubble that was being already closed.
It has been checked in all platforms that the bubble is closed before calling the focus lose event, making it unnecesary to close it again.

BUG=70251
TEST=none

Review URL: http://codereview.chromium.org/6264015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68682
TEST=compiles

Review URL: http://codereview.chromium.org/6385003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72505 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70773
TEST=

Review URL: http://codereview.chromium.org/6395001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70750
TEST=content_settings_provider_unittest.cc

Review URL: http://codereview.chromium.org/6300015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72503 0039d316-1c4b-4281-b951-d872f2087c98

Improve blacklist logic: use more fields (driver_vendor, gl_renderer, ect) for blacklist logic; add blacklist logic and blacklist entry id; also improves the histogram to record occurance of each entry blocking gpu.

BUG=none
TEST=unittest

Review URL: http://codereview.chromium.org/6352011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72502 0039d316-1c4b-4281-b951-d872f2087c98

The visibility of the speech input bubble was not being checked when a image was requested to be set. Consequently, this could lead to invalid image objects in some cases producing glib and GTK errors.

BUG=70223
TEST=none

Review URL: http://codereview.chromium.org/6272018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72501 0039d316-1c4b-4281-b951-d872f2087c98

In DOMUI pref mode, Mac menu items should open prefs via a browser window. Also fixes OpenSyncMyBookmarksDialog on all platforms.

BUG=67670
TEST=Choosing a pref-opening menu item from the Chrome menu on Mac should open DOMUI prefs.

Review URL: http://codereview.chromium.org/6293018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72500 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70771
TEST=none

Review URL: http://codereview.chromium.org/6267013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72499 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6094004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72498 0039d316-1c4b-4281-b951-d872f2087c98

- Introduced ProductOperations: an interface implemented for each product that takes care of product-specific functions. Each Product owns an instance and delegates certain operations to it.
- Removed the use of MasterPreferences by BrowserDistribution so that the former isn't needed outside of the installer.
- Replaced PackageProperties with a new BrowserDistribution type (CHROME_BINARIES)
- Plumbed the concept of InstallerState more thoroughly through installer
- Removed ProductPackageMapping and Package
- Moved more registry read ops into ProductState
- Validation of products to be installed is now done in CheckPreInstallConditions
- Ignore --chrome-frame --ready-mode if chrome is also being installed/updated and a SxS GCF is found (chrome is updated).
- Migrates existing single-install Chrome to multi-install where appropriate.
- Fixes update to Chrome's uninstallation arguments when Chrome Frame is uninstalled.
- Removed dead code from install.cc.
- Added code to update products' "ap" values when ready-mode is accepted.
- Skip post-install things such as launching the browser when Chrome was implicitly added to the install/upgrade process by virtue of being part of a multi-install.

BUG=61609
TEST=run the installer, see it work.  existing tests in installer_util_unittests have been updated; new tests are included for ProductState, ChannelInfo, etc.

Review URL: http://codereview.chromium.org/6288009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72497 0039d316-1c4b-4281-b951-d872f2087c98

Replace one unfortunate hack with a somewhat better one. The included atlctrlx.h relies on min and max macros, which are generally bad and especially so in combination with STL.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6298014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:6923
TEST=manual

Review URL: http://codereview.chromium.org/6245010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72495 0039d316-1c4b-4281-b951-d872f2087c98

The suppresion in the test list is way too general and will mask
almost anything V8 related.

Review URL: http://codereview.chromium.org/6271020

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/6295016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72494 0039d316-1c4b-4281-b951-d872f2087c98

This allows for cases where the request complete callback is invoked outside a message loop,
for e.g. in TestPostChunkedDataAfterStart(). Quit() can only be invoked inside a message
loop whereas posting a QuitTask to the message loop can be done from anywhere.

BUG=none
TEST=TestPostChunkedDataAfterStart passes through the tsan bots and net_unittests in general runs fine.

Review URL: http://codereview.chromium.org/6329019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72493 0039d316-1c4b-4281-b951-d872f2087c98

Recommit of r72380.

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6306011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70665, 70643
TEST=none, these are tests themselves.

Review URL: http://codereview.chromium.org/6309015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=compile failure with touchui=1
TEST=fix compile with touchui=1
TBR=rjkroege@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72490 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces preference settings for incognito windows. The semantics are the following:

- An extension can set regular preferences as before. These affect regular and incognito windows.

- An extension can set regular preferences *and* incognito preferences. In this case, the incognito preferences affect only incognito windows.

- If extension A sets reg+incognito, extension B sets reg but no incognito, extension B has higher precedence than A --> B's preferences hold for all regular and incognito windows.

- Incognito preferences are never persisted to disk.

In order to realize this, the ExtensionPrefs class allows setting regular and incognito extension controlled preferences. It allows creating an incognito version of the PrefService with an independent PrefValueStore. This (incognito) PrefValueStore and the original PrefValueStore share several of their PrefStores (i.e. DefaultPrefStore, CommandLinePrefStore, Configuration PrefStores) but differ in two pref stores:

- We maintain two separate ExtensionPrefStores containing the effective preferences for regular and incognito windows.

- We maintain two separate user pref stores. The regular JsonPrefStore is expanded by an OverlayPersistentPrefStore that maintains all write-operations in an in-memory overlay. Therefore, incognito changes are not visible in the file-backed JsonPrefStore.

The two ExtensionPrefStores retrieve their effective values from a shared ExtensionPrefValueMap.

The OffTheRecordProfileImpl provides a request_context_ that uses the new PrefService already.

BUG=66027,69057
TEST=unit tests, will be fully testable once the Proxy Settings API allows incognito settings.

Review URL: http://codereview.chromium.org/5915004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72489 0039d316-1c4b-4281-b951-d872f2087c98

The suppresion in the test list is way too general and will mask
almost anything V8 related.

Review URL: http://codereview.chromium.org/6271020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72488 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60211
TEST=bots

Review URL: http://codereview.chromium.org/6265024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72487 0039d316-1c4b-4281-b951-d872f2087c98

In CL http://codereview.chromium.org/6134003 I did a find/replace for all places in testserver.py
that read the request body and incorrectly replaced this one as well. The intention was only to
make the change to methods of TestPageHandler and not SyncPageHandler.

BUG=none
TEST=sync_integration_tests builds fine in the buildbots.

Review URL: http://codereview.chromium.org/6391003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:70608
TEST=None

Review URL: http://codereview.chromium.org/6377006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72485 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72481 0039d316-1c4b-4281-b951-d872f2087c98

Landing the patch from http://codereview.chromium.org/6265020/ written by
Evgeniy Stepanov (eugenis@chromium.org), who doesn't have committer access yet.

BUG=70379
TBR=erg

Review URL: http://codereview.chromium.org/6304020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromiumos:7214
TEST=Run desktopui_ChromeFirstRender autotest and verify that it passes.

Review URL: http://codereview.chromium.org/6353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72478 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70569
TEST=manually

Review URL: http://codereview.chromium.org/6282014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:11244
TEST=manually

Review URL: http://codereview.chromium.org/6374012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6923
TEST=manual

Review URL: http://codereview.chromium.org/5758002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72473 0039d316-1c4b-4281-b951-d872f2087c98

For the record, the layout was broken due to the two changes:

http://src.chromium.org/viewvc/chrome?view=rev&revision=71836
caused each language name to have a weird button-like shadow.

http://src.chromium.org/viewvc/chrome?view=rev&revision=72085
broke the two-column layout.

BUG=crosbug.com/11241
TEST=on chrome os, open the language selection overlay. confirm that the layout is nice.

Review URL: http://codereview.chromium.org/6393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6134003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6371012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72470 0039d316-1c4b-4281-b951-d872f2087c98

Pass user agent to InvalidationClientImpl as client_info.

Pick up fix for bug that was causing increased server traffic.

BUG=70674
TEST=none

Review URL: http://codereview.chromium.org/6310015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72468 0039d316-1c4b-4281-b951-d872f2087c98

Currently chromeos::InputMethodMenuButton is derived from both StatusAreaButton and InputMethodMenu, which violates the Chrome coding guideline. This change removes the multiple inheritance by adding InputMethodMenu object to InputMethodMenuButton as a member variable.

BUG=chromium-os:7572
TEST=manually & try bot

Review URL: http://codereview.chromium.org/6262012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6248018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6268013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none



Review URL: http://codereview.chromium.org/6321019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72464 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony,yuzo

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67101

Review URL: http://codereview.chromium.org/6327017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72459 0039d316-1c4b-4281-b951-d872f2087c98