GitLab

This CL adds a PersistentReportingStore* to the constructor of
ReportingService. This pointer is plumbed down to the ReportingCache,
which will eventually use the store to persist its data to disk.
The store must outlive the ReportingService. If null, the
ReportingCache will be in-memory only. The ReportingService is
instantiated with a nullptr placeholder as the store for now.

Bug: 895821
Change-Id: I3a3234653707d2dd87f475413c6318ee7b43121a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575079
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656973}

Update AddVSyncObserver -> AddVSyncParameterObserver

Bug: internal b/131929340
Test: None
Change-Id: I9b8c9f7763626e306a862c32387462a94d8611af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595544Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656972}

Bug: 923711
Change-Id: I81509ec2c46bc91958831d4ebdb25db8c45c07f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596912
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656971}

This CL makes most of the WebRequestInfo data members const. To achieve this, a
new helper struct called WebRequestInfoInitParams is introduced. This will help
with guarantees around WebRequestInfo's immutability.

BUG=696822
TBR=mmenke@chromium.org

Change-Id: I36bd8284aca9e68e115fba94b579456902f968ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594066
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656970}

This patch adds a privacy info row in Launcher to indicate the search is
powered by Assistant.
Specs can be found in the comment 7 in the bug.

Bug: 939944
Test: manual
Change-Id: I5c048c9153057997a3e532ced75403d2504a0c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584728
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656969}

This also now returns a NGPhysicalContainerFragment. The accessor method
now DCHECKS it is non-null, and that the status of the NGLayoutResult
is success.

There should be no behaviour change.

Bug: 635619
Change-Id: Ieff951a4fd9c923ad2664d6ad21fcd7a0269441b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594165Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656968}

Detach HeadlessShell from HeadlessWebContents when the latter is being closed.

Bug: 958755
Change-Id: Ief08c630bb3b558265be31e7ff9e6a2566b594f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593829
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656967}

- remove now-unused `import re` in update.py
- remove code to not check out LLD, we always pull it nowadays
- remove code to remove libcxxabi on macOS, we haven't downloaded that in years
- fix todo to use `clang-cl --version` on Windows now that clang-cl
  accepts --version

Bug: none
Change-Id: I31b0f071b7ea5adad492576543917accbf0b3f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595176
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656966}

This CL is a prerequiste work for extracting navigation related code
out of CRWWebController.

Bug: 956522
Change-Id: I1e365b11fa58b87e0710c70ae49d57984c83b0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596569
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656965}

Change-Id: I7facada0aafe1d16ab1b4b97840e6453781ea64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497218
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656964}

It's doing more harm than good at this point.

R=jbudorick, martiniss
NOTRY=true

Bug: 960100
Change-Id: If6b234a5eacf922ad7ef698da704667775fc8439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597750Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656963}

https://chromium.googlesource.com/catapult.git/+log/f48ed7d31e47..bade8578ee5a


git log f48ed7d31e47..bade8578ee5a --date=short --no-merges --format='%ad %ae %s'
2019-05-06 svenzheng@chromium.org Add a README.md for a new bin folder.


Created with:
  gclient setdep -r src/third_party/catapult@bade8578ee5a

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:958876
TBR=sadrul@chromium.org

Change-Id: I9aa757968024f0123bd297f6b3c9088ae99f24af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597335Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656962}

BUG=453796
TBR=sky

Change-Id: I92e382cc04e25d710d54aa521df5adb14cce29de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596846
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656961}

Image Element Timing requires FCP++ to report ImageResourceContent* as
a property of ImageRecord. Originally, FCP++ reports url as part of it.
If we add ImageResourceContent*, url wouldn't need to be be in
ImageRecord any more because ImageResourceContent already contains it.

Bug: 957448
Change-Id: I66f858ddf962a079bb56e5ed7dc3814787f0c5ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595654Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656960}

Fixes a regression in typing when there's a selection due to a
recent CL for longpress-resolve feature.

BUG=959742

Change-Id: I333698c60e950fb26976c02a589bc34464660e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596853
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656959}

Android has unique requirements that make it very different from Linux,
so give it its own Crashpad file.

Also remove OS guards for that file and stop building Crashpad files
on Linux (returning soon).

Change-Id: I2d017be3013355e4148ed0bb626e45962cbe1578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595243Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656958}

hint_cache_store is now initializing its leveldb_proto database with the
new GetDB API, which enables migrating to a shared leveldb database.

Bug: 943166
Change-Id: I071b31a474e2872ca440cb89375c04c6bc27a251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578067
Commit-Queue: Salvador Guerrero <salg@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656957}

Lineboxes do not have a LayoutObject. This caused
LocalToAncestorRects to compute outlines for element with layers
with offset from BODY.

The fix is to pass containing_block to AddOutlineRectsForDescendant.

Bug: 892526
Change-Id: I84bbc3ca6bac58574627adbd7efb7007faa5f4d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597025
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656956}

E.g.:
[15501/41336] ACTION //third_party/ow2_asm:asm_tree_java(//build/toolchain/android:android_clang_arm)
Unknown constant: 13. Passing class through.

Bug: 958897
Change-Id: I8ef570018c2505aa1341ddc36817a2a2c27bfafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597529
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656955}

This CL maps cookies with an unspecified SameSite attribute to the
string "unspecified" when getting a CookieListItem.

Bug: 953306, 856364
Change-Id: I47ae28be2f73bfc8bb112678f2003087298c3ebd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582328
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656954}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c467474e3a7a..3735847e6deb


git log c467474e3a7a..3735847e6deb --date=short --no-merges --format='%ad %ae %s'
2019-05-06 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@3735847e6deb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I1e9c15a3fe1a43da662b65a59180d874fbf82ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597336Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656953}

In the render frame, get the shared UKM source id from Document::UkmSourceId() and pass the source id down to the compositor where cc/trees/ukm_manager uses it to record metrics.

Bug: 892361
Change-Id: I54badadf9480f103573aefcbee1a9ef153381e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583129Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656952}

http://crrev.com/c/1592473 moved the IDs directly into non-generated
Java code.

Bug: 957618
Change-Id: I3c8f7177bbe7cae76e3a7fb82c3f3e7dc6865f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593846Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656951}

Use a boolean to track whether NavigationBarColorController is
initialized rather than trying to duplicate the logic in
setOverviewModeBehavior.

BUG=959744

Change-Id: I2e85c3a80308fa7b9d9ceca4e185c20dddcc47a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597090Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656950}

Bug: 958468

Change-Id: Ieb8bbc0e14ae9bb688227e5f576a9832bdef2b63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591887
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656949}

pdf_unittests depends on both //ppapi/cpp and
//ppapi/cpp/private:internal_module, which should not be used together:
Both provide pp::Module::Get(), which would be an ODR violation (except
//ppapi/cpp is provided as a static library which doesn't end up getting
linked into pdf_unittests).

Since //ppapi/cpp isn't linked in anyway, this should be a no-op.

Note that only //ppapi/cpp requires a pp::CreateModule() definition, so
there's no need for a custom run_all_unittests.cc anymore.

Change-Id: I896ca1c50a4c57b87672882d75e040ea6713ba1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597469
Auto-Submit: K Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656948}

SmsReceiver allows browsers to retrieve the contents of an incoming SMS to
perform SMS-based user verification without requiring the user to manually
type verification codes. Before launching this feature, we want to add a
kill switch that can be set from the server side that lets us turn off
the feature in case there is a security or privacy problem.

Explainer:
https://github.com/sso-google/sms-otp-retrieval

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Drmmb_t4eE8

Design Doc:
https://docs.google.com/document/d/1TG7BzAPdt2DWNOmephxNf09kdzDKYq8l6Z126oSif8I/edit

Bug: 955747
Change-Id: Iaf43946ba66f658f6b80a68dab2464db311fb28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589499Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656947}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ccd2b4da9a7e..ad1c8b22e23d


git log ccd2b4da9a7e..ad1c8b22e23d --date=short --no-merges --format='%ad %ae %s'
2019-05-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@ad1c8b22e23d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I2d913d910cb30ad1c23e906c689568d1c4dfb41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597330Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656946}

CheckedObserver allows for safer observation as well as allowing the
check_empty=true setting for ObserverList.

Bug: none
Change-Id: I8c74958723254a4fb07fba05206eaa0363a8caaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593929
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656945}

Standard python prefers test_*.py but Chromium uses *_test.py.

Bug: 958163
Change-Id: I98d2fbe2b71d936f2a819e07c64c008ee71a9547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597254Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656944}

https://android.googlesource.com/platform/external/perfetto.git/+log/4d8300d86dec..b63f61e88635

$ git log 4d8300d86..b63f61e88 --date=short --no-merges --format='%ad %ae %s'
2019-05-03 ssid Add config to disable perfetto's default data sources

Created with:
  roll-dep src/third_party/perfetto

Update to use new config proto.

TBR=oysteine@chromium.org

Change-Id: Id8aba6657be76a7eabd361a7ceed0cb2ed178eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595221Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656943}

There was a bug crbug.com/767924 which allowed invalid
PpdReferences to be created.  This prevented users from assigning
a PPD to a printer configured as driverless.  This will record
if any users are still affected to determine if they need to be
migrated.

Bug: 81374
Change-Id: If2c533a10ce445500abbdd69fe74d46955b74852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507200
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656942}

MenuController::CalculateBubbleMenuBounds currently returns incorrect
results if the display has non-zero origin (which is common when
using external displays on ChromeOS).

This is fixed by using monitor_bounds.right() instead of .width()
when the right edge of the display is required in computations.

Unit tests adjusted to cover non-zero display origins.

Bug: 959460
Test: MenuControllerTest.TestMenuFitsOnScreen*
Change-Id: I1fd301c766d62bbc0c2b4916d9be90ceeb9bccdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596183
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656941}

This reverts commit 963bfd6e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 656911 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTYzYmZkNmVjM2ZhZGRmYmQyYWVmNjA0OWFlMmEwMTlhZjVjZTYwNww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/23961

Sample Failed Step: interactive_ui_tests

Sample Flaky Test: TabletModeTransitionTest.EnterExit

Original change's description:
> cros: Add tablet <-> clamshell performance test.
> 
> Test: interactive_ui_tests TabletModeTransitionTest.EnterExit
> Bug: 953896
> Change-Id: Ie2332df2bea2f7d2a63b39d8b390fcf4b28999f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580583
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656911}


Change-Id: Ia7e36dccc229f463bbf89a837b24ddac2079a35f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 953896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597539
Cr-Commit-Position: refs/heads/master@{#656940}

BUG=955128
TBR=etienneb

Change-Id: I66bef1156c363f807dbc5bca4165ed272ef469e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597273Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656939}

Bug: 930746
Change-Id: I0c8cba84b3b77fac15e61c8f6e22a25d114a9153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592046
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656938}

BUG=959435
TBR=qinmin

Change-Id: Ia32a5e3d645904c2133fa55421be36ff14877ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597127Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656937}

Added fault test cases, unsuccessful HTTP response and
malformed response, to HintsFetcher browsertests according to
the OnePlatform test plan.

Bug: 932707
Change-Id: Ic4d62970e25c12aa8384465d7f56353f85eb9e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592848
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656936}

To do that, split ComputeSameSite between get and set, and turn the
existing distinction in ComputeSameSite* into a scripts vs. network one.

While doing that, I noticed that the devtools interceptors weren't actually
setting same_site_context when they were handling Set-Cookie, so fixed them.

This matches proposed spec update:

https://github.com/httpwg/http-extensions/commit/49bcb4fddb8a8c294749ec9d81a236cde4df94b0

should bring us closer to Firefox, and should stop causing trouble for
OAuth implementation that use Same-Site cookies (e.g. Microsoft's --- hurray
to their auth folks for deploying it!)

Bug: 958331
Change-Id: Ied64233b6401bab629ca0a9212da520af2c166ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594115
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656935}

There is a bug that the payment sheet UI falls into an infinite spinning
loop when users re-select another item (e.g. shipping address, payer
detail info) since retry() is called.

This problem has been occured since http://crrev.com/c/1512594. In the
patch, the logic was changed so that updateWith() calls were forwarded
to the invoked payment app. The change is very reasonable and important,
but in the case of the autofilll payment app provided by the UA itself,
the change might not be appropriate. Therefore, this CL applies an
exception to the autofill payment app for the logic.

Test:
  chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRetryTest.java

Manual Test:
  https://w3c-test.org/payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html

Bug: 861704, 941837
Change-Id: Idf5ab1a45795490c7ee0e0e8e313e8f6213b0adf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589680
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656934}