- 06 Jun, 2016 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6aed5443..f8c7729d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2039963002 Cr-Commit-Position: refs/heads/master@{#398135}
-
dskiba authored
TraceStackFramePointers() function, which unwinds stack using frame pointers, sometimes crashes on Android when it dives deep into JVM internals and finds bad stack pointer there. See details here: crbug.com/602701#c18 This CL adds checks to make sure only valid stack pointers are dereferenced. BUG=602701 Review-Url: https://codereview.chromium.org/1975393002 Cr-Commit-Position: refs/heads/master@{#398134}
-
hcarmona authored
Tests included for dialog. Screenshots in bug. BUG=607348 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2015463003 Cr-Commit-Position: refs/heads/master@{#398133}
-
xunjieli authored
This CL uses WeakPtrFactory to post task in net::BidirectionalStream. BUG=606394 Review-Url: https://codereview.chromium.org/2043863002 Cr-Commit-Position: refs/heads/master@{#398132}
-
svaldez authored
R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2047483002 Cr-Commit-Position: refs/heads/master@{#398131}
-
penghuang authored
BUG=586390 Review-Url: https://codereview.chromium.org/2020293003 Cr-Commit-Position: refs/heads/master@{#398130}
-
halcanary authored
Review-Url: https://codereview.chromium.org/2041113002 Cr-Commit-Position: refs/heads/master@{#398129}
-
mushan authored
Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit BUG=612422 Review-Url: https://codereview.chromium.org/1984173002 Cr-Commit-Position: refs/heads/master@{#398128}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/09f5cd44ae30..dc27a648d2ff $ git log 09f5cd44a..dc27a648d --date=short --no-merges --format='%ad %ae %s' 2016-06-06 msarett Add SkDefaultXform as a catch-all to handle color conversions 2016-06-06 scroggo Use Options object passed to startScanlineDecode 2016-06-06 scroggo Revert of Make SkPngCodec decode progressively. (patchset #26 id:520001 of https://codereview.chromium.org/1997703003/ ) 2016-06-06 msarett Gamma sanity checks CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=mtklein@google.com Review-Url: https://codereview.chromium.org/2043873002 Cr-Commit-Position: refs/heads/master@{#398127}
-
jbroman authored
GetOutsets provided imprecise -- or possibly incorrect -- outsets for certain reference filters, such as <feOffset>. Instead RenderSurfaceImpl should explicitly specify that it wants forward mapping here. Also fix this to incorporate scale factors in the filter rect calculations (e.g. due to a high DPI display), and add unit tests. BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2018983003 Cr-Commit-Position: refs/heads/master@{#398126}
-
markdittmer authored
R=sky@chromium.org BUG=617315 Review-Url: https://codereview.chromium.org/2040783002 Cr-Commit-Position: refs/heads/master@{#398125}
-
reillyg authored
The original author can't remember why this post was necessary. Since the actual result callback is posted immediately afterwards any side-effects (such as synchronizing with another message loop) should already be achieved. Review-Url: https://codereview.chromium.org/2044603002 Cr-Commit-Position: refs/heads/master@{#398124}
-
fdoray authored
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop(ForUI|ForIO)::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=reillyg@chromium.org Review-Url: https://codereview.chromium.org/2031743005 Cr-Commit-Position: refs/heads/master@{#398123}
-
xdai authored
BUG=b/27776147 Review-Url: https://codereview.chromium.org/2033373003 Cr-Commit-Position: refs/heads/master@{#398122}
-
davidben authored
Although Chromium wisely disables this ancient UNIX bug, the net stack is part of Cronet which may be used in other consumers. Rather than modify the global signal dispositions (bad manners for a library) or propagate this requirement to the callers (also bad manners, if sound), make an attempt to suppress the signal on a per-socket basis. Unfortunately, iOS/OSX and Linux kindly have different APIs for this, so we need to touch two places. BUG=467132 Review-Url: https://codereview.chromium.org/2034433002 Cr-Commit-Position: refs/heads/master@{#398121}
-
mattreynolds authored
The HTTP request headers normally used by Chrome for Android are generated in the native layer. We do not want to load native when the Physical Web is resolving URLs in the background, so we cannot access these values directly. Instead, they are reconstructed from values accessible from the Java layer. BUG=607660 Review-Url: https://codereview.chromium.org/1989963003 Cr-Commit-Position: refs/heads/master@{#398120}
-
rajendrant authored
Only the network prediction enabled preference should be used to schedule or cancel periodic GCM task. The GCM task itself will run only when suitable for precaching. BUG=616956 Review-Url: https://codereview.chromium.org/2037913002 Cr-Commit-Position: refs/heads/master@{#398119}
-
kylixrd authored
BUG=584342 Review-Url: https://codereview.chromium.org/1966643002 Cr-Commit-Position: refs/heads/master@{#398118}
-
mcasas authored
Reverted after its own LayoutTests timed out in WebKit Win7 bot. This is due to media/mojo/interfaces not being in the generated bindings path, and that's being addressed in https://codereview.chromium.org/2045573002/. Original landed as https://crrev.com/2027023002 Original description --------------------------------------------------- ImageCapture: move mojom from WebKit/public to media/ This CL moves image_capture.mojom from {third_party/WebKit/public/platform/modules => media/mojo/interfaces} so the generated data types (e.g. PhotoCapabilities{Ptr}) can be used from both Blink and media/capture locations. Also capture.gypi is trivially relocated to capture/ folder. Note that gyp files are -yay!- close to being finally removed. BUG=518807 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel TBR=rockot@chromium.org, avi@chromium.org, dcheng@chromium.org, haraken@chromium.org, xhwang@chromium.org (no code changes). Review-Url: https://codereview.chromium.org/2040963004 Cr-Commit-Position: refs/heads/master@{#398117}
-
gayane authored
BUG=612828 Review-Url: https://codereview.chromium.org/2014463003 Cr-Commit-Position: refs/heads/master@{#398116}
-
wychen authored
BUG=617701 Review-Url: https://codereview.chromium.org/2011213002 Cr-Commit-Position: refs/heads/master@{#398115}
-
dglazkov authored
RenderFrame no longer knows about WebElement or WebNode, yay! R=esprehn BUG= Review-Url: https://codereview.chromium.org/2002683002 Cr-Commit-Position: refs/heads/master@{#398114}
-
stip authored
BUG=589168 Review-Url: https://codereview.chromium.org/2041973002 Cr-Commit-Position: refs/heads/master@{#398113}
-
sebmarchand authored
A change to enable WPO for the x64 Win official builds caused content_browserto expand beyond 2 GB which caused these errors: obj\content\content_browser.lib : fatal error LNK1107: invalid or corrupt file: cannot read at 0xEAE7739 msvs_shard is a way of breaking up a library to avoid this limitation. This issue doesn't affect the GN builds (because they use a sourceset concept instead of these huge static libraries). TBR=creis@chromium.org BUG=616946 Review-Url: https://codereview.chromium.org/2046573003 Cr-Commit-Position: refs/heads/master@{#398112}
-
thakis authored
MAC_OS_X_VERSION_MIN_REQUIRED corresponds to -mmacosx-version-min, which we currently set to 10.7 (and plan to set to 10.9 eventually, after fixing deprecation warnings). MAC_OS_X_VERSION_MAX_ALLOWED corresponds to the SDK used to compile chrome. We currently require the 10.10 SDK. Remove all code in sdk_forward_declarations that's no longer necessary. No behavior change. BUG=579255 Review-Url: https://codereview.chromium.org/2046693002 Cr-Commit-Position: refs/heads/master@{#398111}
-
pdr authored
Flipped writing modes cause an object's offset to be flipped relative to its parent. This patch switches from using locationOffset to topLeftLocation which includes writing mode handling. This matches similar logic in PaintLayer::updateLayerPosition. A comment has been added about removing unnecessary craws back up the tree for calculating containing blocks. With this patch, all fast/block/positioning tests pass, modulo our lack of multicolumn fragment painting. BUG=614257 Review-Url: https://codereview.chromium.org/2031873005 Cr-Commit-Position: refs/heads/master@{#398110}
-
juliatuttle authored
Once the HostCache exposes stale results, plumb them through the HostResolverImpl for callers who want them. BUG=605138 Review-Url: https://codereview.chromium.org/1903263002 Cr-Commit-Position: refs/heads/master@{#398109}
-
fdoray authored
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop(ForUI|ForIO)::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=ben@chromium.org Review-Url: https://codereview.chromium.org/2029413004 Cr-Commit-Position: refs/heads/master@{#398108}
-
moshayedi authored
This CL defines StructTraits<mus::mojom::Event, unique_ptr<ui::Event>>. With this mojo automatically uses unique_ptr<ui::Event> instead of mus::mojom::Event when generating C++ header files for mojom interfaces, and events are automatically serializied/deserialized and validated when sending/receiving over mojo IPC. BUG=578206 Review-Url: https://codereview.chromium.org/1939133002 Cr-Commit-Position: refs/heads/master@{#398107}
-
Reilly Grant authored
BUG=617740 TBR=miu@chromium.org,mcasas@chromium.org Review URL: https://codereview.chromium.org/2040963006 . Cr-Commit-Position: refs/heads/master@{#398106}
-
jamescook authored
This will allow it to be used in status tray initialization code. In particular: * It can wrap actions handled by ShelfWidget and ShelfLayoutManager (e.g. GetAutoHideState) * It can have observers similar to ShelfLayoutManagerObserver (OnAutoHideStateChanged) It's also more similar to how ash::mus::RootWindowController owns WmShelfMus. BUG=615155 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2041583004 Cr-Commit-Position: refs/heads/master@{#398105}
-
kozyatinskiy authored
R=pfeldman@chromium.org Review-Url: https://codereview.chromium.org/2044563002 Cr-Commit-Position: refs/heads/master@{#398104}
-
zmo authored
BUG= TEST=gpu bots TBR=kbr@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2044593002 Cr-Commit-Position: refs/heads/master@{#398103}
-
mboc authored
BUG=617055 https://codereview.chromium.org/1819753003/ accidentally removed UNDERLINE style support on Linux. This CL fixes the issue. Review-Url: https://codereview.chromium.org/2031223003 Cr-Commit-Position: refs/heads/master@{#398102}
-
Reilly Grant authored
VibrationTest.CancelVibrationFromMainFrameWhenMainFrameIsReloaded BUG=617727 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/2047503002 . Cr-Commit-Position: refs/heads/master@{#398101}
-
jaydasika authored
Right now, we do a layer tree walk for iteration over all layers on impl-side (LayerListIterator). Once we start pushing layer list instead of layer tree during commit/activation, we will use layer_list instead(layers will be added to layer_list in stacking order during commit/activation). A lot of tests build layer tree on the impl-side and don't go through commit/activation. So, we need to explicitly build the layer_list for these tests. BUG=617366 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2032303004 Cr-Commit-Position: refs/heads/master@{#398100}
-
fdoray authored
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop(ForUI|ForIO)::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2035943002 Cr-Commit-Position: refs/heads/master@{#398099}
-
pauljensen authored
Rename it to purgeActiveNetworkList which better reflects its actual function. It only purges the list of inactive networks, and does not add to the list. R=xunjieli Review-Url: https://codereview.chromium.org/1967373003 Cr-Commit-Position: refs/heads/master@{#398098}
-
gogerald authored
This CL is a strength of https://codereview.chromium.org/1952853005/. BUG=607695 Review-Url: https://codereview.chromium.org/2032043002 Cr-Commit-Position: refs/heads/master@{#398097}
-
erikchen authored
Revert of Re-enable WebGL Image Chromium. (patchset #3 id:40001 of https://codereview.chromium.org/2025973002/ ) Reason for revert: I'm observing a behavior difference between the Image CHROMIUM and non-Image CHROMIUM path. Turning off Image CHROMIUM while I investigate. https://bugs.chromium.org/p/chromium/issues/detail?id=617249#c5 Original issue's description: > Re-enable WebGL Image Chromium. > > This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, > and turns on IOSurface backed WebGL by default. > > BUG=581777 > > Committed: https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86 > Cr-Commit-Position: refs/heads/master@{#397603} TBR=kbr@chromium.org,avi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581777 Review-Url: https://codereview.chromium.org/2041053002 Cr-Commit-Position: refs/heads/master@{#398096}
-