- 21 Nov, 2019 40 commits
-
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1023677 Change-Id: Ie508e6499be964b52ee1567967f4fc7a5ca4a1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926809 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#717713}
-
Jonathan Ross authored
On Pixel 2 this test has begun consistently failing. Suppressing it while the root cause is analyzed. TBR=ynovikov@chromium.org TEST= webgl2_conformance_tests deqp/functional/gles3/negativetextureapi.html Bug: 1027125 Change-Id: Ie727ed406c10b42cfab5fb8f999068de32c19810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928145Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#717712}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kbabbitt@microsoft.com Bug: 1023677 Change-Id: I432d207b93c1146c24c36d08062b1ffa033caad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926803 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717711}
-
Ayu Ishii authored
This change allows developers to use the SMS Receiver API with the Abort Controller to cancel once the API is called. This will help developers with flows for retrying and sending a new code and they want to abort the previous call they made to the API. If the InfoBar is up during abort, it will leave the InfoBar open while returning an AbortError to the website. If another request is made while the InfoBar for 1st request is still open (after abort), upon clicking 'Verify' the SMS retrieved for the 1st request will return to the 2nd request. Bug: 976401 Change-Id: I132800f2954fdc370172dcd03789d3f08bcc4040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866914Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#717710}
-
Peter Wen authored
The android_clang_arm subdirectory is used during the build for 64-bit builds. These generated resources need a similar alias to be accessible in chrome pages like chrome://offline-internals. This is a temporary fix to add the missing alias. A long-term fix should resolve @out_dir@ to include android_clang_arm or something similar. Bug: 1020284 Change-Id: Ibf5f422dc38d77ea984ad576f9e36ddf5fe868d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928556 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717709}
-
Elly Fong-Jones authored
This change makes cbui (actually all of //chrome) unaware of DCV. Most of these changes are straightforward but there are a few wrinkles: * IntentPickerBubbleView does an explicit Layout immediately after its widget is created, which should be needless; * PasswordPendingView does an explicit Layout when changing its content, which should be needless because it calls DialogModelChanged immediately beforehand; * EnterpriseStartupDialogView sets button text directly rather than using set_button_label() but does not notify the dialog model about this, which probably causes visual glitches; * UserManagerView was reaching inside DialogClientView to unregister its default Esc key accelerator (!). As of this change, instead UserManagerView registers the same accelerator and discards it first; All of these now have TODOs to clean them up in subsequent CLs, since each of them might cause regressions when I fix them. Bug: 1011446 Change-Id: If5256329af1f9f649ec0e010dbe573479199e5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924960 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#717708}
-
Dominic Farolino authored
Now that BrowserAccessibilityManager implements WebContentsObserver (crrev.com/c/1672135), DidStopLoading is automatically called as a result of `navigator()->GetDelegate()->DidStopLoading();`. Bug: 981271 Change-Id: I081f0d9a2c54c9a99742c2aa4eb680c11c1b3bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924719Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#717707}
-
Devlin Cronin authored
Remove, expire, and obsolete-ify Extensions.LoadAllTime, since it is replaced by Extensions.LoadAllTime2. Mark Extensions.LoadAllTime2 as never expiring, since it is monitoring core extensions system performance. Bug: 1025837 Change-Id: Iedf225716607b2f827027ca501b2c327b609c48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927217Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717706}
-
Sharon Yang authored
Remove the use of a do while loop in AccessibilityBridgeTests so tests don't have the opportunity to run indefinitely. Also remove special handling of the case where this is no root node as this is now supported by the Semantics Manager. Testing: CQ Bug: 973095 Change-Id: I014506bf77fa11b7f33e115b601b9bfaa781b8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924714Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#717705}
-
Francois Doray authored
BatteryMetrics did not connect to a remote BatteryMonitor due to a shutdown crash (https://crbug.com/794105). This shutdown issue was fixed by using SequenceLocalStorageSlot to tear down the BatteryStatusService on thread thread termination (https://crrev.com/665919). This CL can therefore safely change the code to connect to a remote BatteryMonitor on Windows. The immediate impact is that Power.BatteryPercentDrop will be properly recorded on Windows. In upcoming CLs, we plan to record more battery metrics on all platforms. Bug: 794105, 1026678 Change-Id: Iebd3f32beda2ae487c5b23263ec95e350390b237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925130Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#717704}
-
Ionel Popescu authored
When the date/time doesn't have "date-time-edit" in its shadow subtree, the is_ampm_first, has_ampm, has_second, has_millisecond fields are going to be uninitialized. This CL ensures that the fields are always initialized. Bug: 1026906 Change-Id: Ibfa8dd9993cf291402407e3592de82387c3d68b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927574Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#717703}
-
Jasper Chapman-Black authored
This is the first step in adding canned queries to Caspian. Refactored TreeBuilder to replace group_by_component with a more arbitrary Symbol -> parent path transformation. Leaving generated file classification to a future CL. Change-Id: Ia142df715ba911d9629ad89aa5fa0d714394410a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924604Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#717702}
-
Ovidio Henriquez authored
This change converts all of the base::Bind and base::Callback to their Once counterparts for bluetooth_socket_mac.{h,mm}. This change also affects any files that interact with this class. Bug: 1007780 Change-Id: If3c6b2e24ecd3cac18a9a726fa7b5e78d00b05e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904529Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#717701}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6c7a793d. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I60d98d0fc65e51f4ffa1800fa205f9feb62041c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929152Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717700}
-
Archana Malhotra authored
Bug: 1026675 Change-Id: Ic72d4c618e6287429ec01978d2d2d0e414f73f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925184Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Archana Malhotra <armalhotra@google.com> Cr-Commit-Position: refs/heads/master@{#717699}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/091a11f81dce..6dadd812f4d9 git log 091a11f81dce..6dadd812f4d9 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 9856269+sarahM0@users.noreply.github.com Add spvc parser support for OpGroupDecorate, OpGroupMemberGecorate, OpDecorateStringGOOGLE, and OpMemberDecorateStringGOOGLE (#899) Created with: gclient setdep -r src/third_party/shaderc/src@6dadd812f4d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I6b74b378e84e76bba42a5b5dc53a3d6401f19599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928146Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717698}
-
Renato Silva authored
Creates a new test class for testing the offline fallback mechanism used in Chrome OS EULA terms. The behaviour the embedded server used for EULA tests is now determined during construction and cannot be changed in the tests themselves. Tested locally. Bug: 1015948 Change-Id: I87c7196968234ebde2573d604beee132564df899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926589 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717697}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1023677 Change-Id: Id20e94399700bb14d990b625f7703636035f2a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925460 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717696}
-
Olivier Li authored
Bug: 546640 Change-Id: I524066ce81a422938eca2c80523b60c4f9f670c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929094Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#717695}
-
Matt Jones authored
Since text selection is no longer the responsibility of the BottomSheet, the dependency on tab and tab provider have been removed as well. Bug: 986310 Change-Id: I827607ee610bf994a1205ad5b89c81b7bbff1813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927222Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#717694}
-
Wanchang Ryu authored
With --disable-in-process-stack-traces command-line flag, service process doesn't set signal handler for SIGPIPE. This causes crash when write() failed. This patch set SIGPIPE to SIG_IGN regardless --disable-in-process-stack-traces to get return value of write() Bug: 1026188 Change-Id: I11fcde7b38b7e6fa522cf17a50ebee6e62673177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924094Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#717693}
-
Jonathan Ross authored
MediaSourceTest.Playback_VideoOnly_WebM has begun flaking, up to 10% now. I'm disabling it on vulkan_content_browsertests until the root cause can be addressed. Also updating the bug id in the filter file to the unified bug covering this form of failure. TBR=ynovikov@chromium.org TEST=MediaSourceTest.Playback_VideoOnly_WebM vulkan_content_browsertests Bug: 985387 Change-Id: Ibac1705e890aeeccac01fbf671346567d562483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928058Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#717692}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b184e9654d26..2dad99092c8c git log b184e9654d26..2dad99092c8c --date=short --no-merges --format='%ad %ae %s' 2019-11-21 halcanary@google.com Replace third_party/gif: Preflight changes 2019-11-21 ethannicholas@google.com Revert "Fixed some GrSkSLFP limitations." Created with: gclient setdep -r src/third_party/skia@2dad99092c8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: Ie7990d5000a6f992c9ec8e5c8bf55c0ff74acc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717691}
-
Michael Ershov authored
The test failed because sometimes RemoteCommandsService generated an additional request that was not expected by a mock object. Fixed by reordering AllowUninterestingRemoteCommandFetches function calls and EXPECT_CALL(..., StartJob(_)) calls. It looks like the latter one overrode the former one. Bug: 1014318 Test: DeviceCloudPolicyManagerChromeOSEnrollmentTest.Success Change-Id: I9cd8f13c9346623faaabb3c850b292ec10bdd5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924431Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#717690}
-
Michael Thiessen authored
This reverts commit 1c0ecd5d. Reason for revert: Increases crash rate due to large bundles. Original change's description: > Save WebappActivity tab state to bundle, remove old stale file deletion > > Simplifies tab restore by copying from NoTouchActivity, which has the > same persistence model (currently) as WebappActivity. > > This also simplifies the stale directory cleanup to only clean up more > recent sources of stale directories. This could lead stale directories > to stick around when updating from very old versions of Chrome, but > these directories should be small regardless. > > Also deletes some unused webApk UMA constants, and deletes the unused > histogram generation code in NoTouchActivity for tab restore. > > Bug: 525785 > Change-Id: I615542e2f28a147ecd5403b04b61b749f3e737ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769313 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690834} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 525785 Change-Id: I47afd77f54e7c11574a5814fbdec50a1a3cf3d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926573 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#717689}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kcwu@chromium.org Bug: 1023677 Change-Id: I32c8ed6a484a6eafb0aa0e67cb393b9cae6c6275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926796 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717688}
-
bttk authored
This dependency breaks the refactoring of java metrics. The refactoring is a work in progress: https://chromium-review.googlesource.com/c/chromium/src/+/1915193 Change-Id: I3ae2cacb86d49611a4e1f4311fe227c462c965d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926509Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#717687}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/235c2525d2c0..3692dd5f3f67 git log 235c2525d2c0..3692dd5f3f67 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 lalitm@google.com Merge "gn: ensure that highest proto visibility is preserved when merging" 2019-11-21 hjd@google.com Merge "perfetto-cmd: Remove 10mb upload limit on user" 2019-11-21 treehugger-gerrit@google.com Merge "ui: Link to public version of extension page" 2019-11-21 lalitm@google.com trace_processor: fix userspace Android slice tracking Created with: gclient setdep -r src/third_party/perfetto@3692dd5f3f67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:144598382 Change-Id: Icc4404d52103c3e8c5c70ab075c048f2e606edd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717686}
-
Friedrich Horschig authored
With this CL, the PasswordPendingView shows an additional checkbox in test and debug builds. When the checkbox is selected/unselected, it changes the store inside the pending_form_ of the ManagePasswordsBubbleModel. So far, this field is unused (since pending_form_ is a copy and only username and password are passed to the delegate). To see the checkbox: * Build with is_debug=true or check_always_on=true * set the flag \#passwords-account-storage-saving-ui (or check out the screenshots in the linked bug) Bug: 1018701 Change-Id: Ie26931fb375677cffb5de3c0b5dff3b0a1544375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926587Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#717685}
-
Anastasiia Nikolaienko authored
The stub account on ChromeOS is treated specially for test purposes. Remove this special-casing since we have unified the interface for setting the primary account on ChromeOS with that on other platforms. Update tests: remove expectations that "the stub user is signed in by default on browsertests". Bug: 1014074 Change-Id: I37a812e060631c101d1b2d7d897c785c4c200f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872066 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#717684}
-
Wei-Yin Chen (陳威尹) authored
The first meaningful paint of Grid Tab Switcher (GTS) is defined as having all the thumbnails shown. When the tab switcher is shown due to feature "TabSwitcherOnReturn", this CL records the elapsed time from Activity OnCreate to the event as a performance metric. Bug: 1016952 Change-Id: I7c018823d19461a2cacf4496aa628beaefcbc7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892557Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717683}
-
Xianzhu Wang authored
These flags were used just for a few tests for checking internal data of composited layers. We should check them with unit tests. Removed tests: - compositing/layer-tree.html: just tested LAYER_TREE_INCLUDES_ROOT_LAYER which is not important. - compositing/overflow/composited-scrolling-paint-phases and compositing/update-paint-phases.html: The tested functionality is already tested by unit test CompositedLayerMappingTest.ScrollingContentsAndForegroundLayerPaintingPhase - compositing/animation/hidden-composited.html: now tested with unit test CompositedLayerMappingTest.CompositedHiddenAnimatingLayer. Change-Id: I148b4480020b41f241cd7ab854c31f96528cf89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927187Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#717682}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ae8320dd326..8adc98765133 Created with: gclient setdep -r src-internal@8adc98765133 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I746b61247f8d00334e723231dc066924e8805e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717681}
-
Anatoliy Potapchuk authored
Bug: 1006230 Change-Id: I1658e2ff0f2b7e91a74719e8eeeb26920273f54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926491 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717680}
-
Chris Lu authored
This change adds InfobarTranslateMediator to handle most InfobarDelegate model information retrieval. The InfobarTranslateTableViewController will use a data source protocol to retrieve it from the mediator. Bug: 1014959 Change-Id: I793f4bf5b3cb009b4a965aafb20e8ad045809af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921339 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#717679}
-
Richard Knoll authored
Removes these flags as they are enabled by default on stable already and we won't disable them anymore: - ClickToCallContextMenuForSelectedText - SharingDeviceRegistration - ClickToCallOpenDialerDirectly The ClickToCallReceiver feature is kept as a kill switch but the chrome flags entry for it is removed. Bug: None Change-Id: I05a5f10325176c56ecaaf6419d3c876675eced3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926627 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#717678}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e835fc01b1a9..b86a1770ee64 git log e835fc01b1a9..b86a1770ee64 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 sakal@webrtc.org Expose ABGRToI420 in YuvHelper. Created with: gclient setdep -r src/third_party/webrtc@b86a1770ee64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iaec7ae149c60bae4dd8ef2ab76a7c484cb35a718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717677}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f2c9ce1e08ed..72e68083f914 git log f2c9ce1e08ed..72e68083f914 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 kadam@inf.u-szeged.hu Add new relocation types. Created with: gclient setdep -r src/third_party/swiftshader@72e68083f914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:893460 Change-Id: I8f539e41ae0aaba518e060dd87f905194c538185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717676}
-
Joe Downing authored
This is the first step in removing the CRD Webapp code. First we need to make sure it's disappearance won't cause a problem for the official builders. After that we can continue cleaning up the various bits and bobs which build it and our pNaCl plugin. BUG= Change-Id: I7b30bc90e768505518046124ed887b23c09ddd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925353Reviewed-by:
Jason Kersey <kerz@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#717675}
-
Sebastien Marchand authored
The L41r GraphObserver has been added in https://crrev.com/c/1579363 but it has never been created, this fix this by calling LocalSiteCharacteristicsWebContentsObserver::MaybeCreateGraphObserver(); when starting TabManager. This CL also removes notifications from the list of features that are ignored during the first seconds after a tab has been backgrounded. This list is meant to be for features that needs to "stabilize" (e.g. the tab title can change while a tab is in background after a same-document navigation), but notifications are an explicit form of communication with the user. This also enable the corresponding test to avoid any regression on this. Change-Id: I34c1efb88e101337b9f9913b9796a4442a876487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925137Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#717674}
-