Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Nov, 2017 24 commits
  3. 19 Nov, 2017 14 commits
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ cbcb0a12a..f9ec4707e (1 commit) · a46b8b57
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/cbcb0a12ad00..f9ec4707ee13

$ git log cbcb0a12a..f9ec4707e --date=short --no-merges --format='%ad %ae %s'
2017-11-19 bsalomon Exclude tools/gpu/atlastext from public.bzl

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I1ebf18c0681b072194e610befade3ab920d4dabb
Reviewed-on: https://chromium-review.googlesource.com/777412Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517738}
      a46b8b57
    • Zhongyi Shi's avatar
      Add QuicConnectivityProbingManager which sends connectivity probing · 8fff75b5
      Zhongyi Shi authored 
      packet on new path. The manager will send out a new connectivity probing
packet if there is no response from the server on the probed path. The
manager will retry after a silent period from the previous sent event with
exponential backoff.
1 unit timeout is the smaller of 2 smoothed rtt from old path, or 600ms.


Bug: 774622
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I623b8a5aa8da6d553ca16d9f67655d4a32a4a1c9
Reviewed-on: https://chromium-review.googlesource.com/774299
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517737}
      8fff75b5
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ b07b06e14..cbcb0a12a (1 commit) · e9116824
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/b07b06e14819..cbcb0a12ad00

$ git log b07b06e14..cbcb0a12a --date=short --no-merges --format='%ad %ae %s'
2017-11-19 bsalomon Revert "Revert "Add Atlas Text interface for rendering SDF glyphs.""

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I891903e85c32119e0dae3218a40662db727fb616
Reviewed-on: https://chromium-review.googlesource.com/778114Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517736}
      e9116824
    • Mathieu Perreault's avatar
      [Autofill] Remove duplicate AutofillManager constructor · ebacf81e
      Mathieu Perreault authored 
      Move initialization of members to .h too.

Bug: None
Test: Existing
Change-Id: I76924652c98fecb97e04a3e5a51a97688a9ae5f5
Reviewed-on: https://chromium-review.googlesource.com/777507
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517735}
      ebacf81e
    • Mike West's avatar
      Add custom element event tests for CSP nonce hiding. · 537717e4
      Mike West authored 
      Basically copy-pasting from Anne's suggestions at
https://github.com/whatwg/html/pull/2373#issuecomment-332503536

Bug: 680419
Change-Id: I9fee18d46dc00ff3ec8ec90f3d8acd80ab015622
Reviewed-on: https://chromium-review.googlesource.com/771151Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517734}
      537717e4
    • Ian Vollick's avatar
      Revert "Enable OpenVR devices behind a runtime flag on Windows" · 3027032c
      Ian Vollick authored 
      This reverts commit 14d631ca.

Reason for revert: speculative revert to address launch issue on Windows

Original change's description:
> Enable OpenVR devices behind a runtime flag on Windows
> 
> BUG=782445
> 
> Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588
> Reviewed-on: https://chromium-review.googlesource.com/757859
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517684}

TBR=ddorwin@chromium.org,mthiesse@chromium.org,bajones@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 782445
Change-Id: Ib344cc9763d822ebe5ee47b33e751270b6a9e489
Reviewed-on: https://chromium-review.googlesource.com/777858Reviewed-by: default avatarIan Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517733}
      3027032c
    • v8-autoroll's avatar
      Update V8 to version 6.4.332. · 0a00265a
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/700d93e9..f4f2b219

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I2ca69d1ea94e462a46fcecf8633d5a8f84a14c77
Reviewed-on: https://chromium-review.googlesource.com/778144Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517732}
      0a00265a
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ df8408836..b07b06e14 (5 commits) · a9ee7436
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/df8408836be0..b07b06e14819

$ git log df8408836..b07b06e14 --date=short --no-merges --format='%ad %ae %s'
2017-11-18 egdaniel Fix assert in blink chromeos
2017-11-18 angle-deps-roller Roll skia/third_party/externals/angle2/ 90ed1e497..dc7bffd06 (1 commit)
2017-11-17 egdaniel Revert "Revert "Revert "Revert "Revert "Revert "Add private grpixelconfigs for alpha_8 and alpha_half""""""
2017-11-18 egdaniel Revert "Add Atlas Text interface for rendering SDF glyphs."
2017-11-18 angle-deps-roller Roll skia/third_party/externals/angle2/ c622833c5..90ed1e497 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I4d89aeb9a0161a690fe759f083d6c76ed57b09dd
Reviewed-on: https://chromium-review.googlesource.com/777810Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517731}
      a9ee7436
    • Peter K. Lee's avatar
      Calls decisionHandler asynchronously, part 2 · 2d1368a2
      Peter K. Lee authored 
      Only one of two calls to decisionHandler was converted to async in
http://crrev/c/773570. This changes the other call.

Bug: 774736
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie72c6efc42e5921eae8983d01f4be29fd3934d98
Reviewed-on: https://chromium-review.googlesource.com/777400Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517730}
      2d1368a2
    • chrome-release-bot's avatar
      Updating trunk VERSION from 3273.0 to 3274.0 · e3b1d1e5
      chrome-release-bot authored 
      TBR=govind@chromium.org

Change-Id: I3dfc18ff22d4cfcef352641c20fbcd0c46907cbf
Reviewed-on: https://chromium-review.googlesource.com/777928Reviewed-by: default avatarchrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517729}
      e3b1d1e5
    • v8-autoroll's avatar
      Update V8 to version 6.4.331. · 65b2e61d
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/49b87e46..700d93e9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I97fcd18d5363abda60c3d1e1c9525bf27d19f808
Reviewed-on: https://chromium-review.googlesource.com/778301Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517728}
      65b2e61d
    • Peter Lee's avatar
      Revert "Enable iOS Captive Portal feature by default." · 9991cd21
      Peter Lee authored 
      This reverts commit beecf799.

Reason for revert:

The following tests from ios_internal_chrome_external_url_egtests are broken:
ExternalURLSSLTestCase/testReloadInterstitial
ExternalURLSSLTestCase/testGoBackFromInterstitialUsingInterstitialButton
ExternalURLSSLTestCase/testLoadNTPAfterDontProceed
ExternalURLSSLTestCase/testAcceptingBadSSLCert
ExternalURLSSLTestCase/testRememberingAcceptUserDecision
ExternalURLSSLTestCase/testGoBackFromInterstitialUsingToolbarButton
ExternalURLSSLTestCase/testHostnameMismatchInterstitial

stdout from bot run here: https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-simulator-x64%2F1975%2F%2B%2Frecipes%2Fsteps%2Fios_internal_chrome_external_url_egtests__iPhone_5s_iOS_11.0__on_Mac%2F0%2Fstdout

Original change's description:
> Enable iOS Captive Portal feature by default.
> 
> Bug: 750228
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I0fa138e855d71ac256759d75f3e84d390cd2c896
> Reviewed-on: https://chromium-review.googlesource.com/777468
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517579}

TBR=eugenebut@chromium.org,michaeldo@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 750228
Change-Id: Ic15218338b16eede6572cbe157d982942de0a625
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/778283Reviewed-by: default avatarPeter Lee <pkl@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517727}
      9991cd21
    • John Budorick's avatar
      Revert "Add Android OOP HP end-to-end tests." · c94d1275
      John Budorick authored 
      This reverts commit e0b4355f.

Reason for revert: Breaks chrome_public_test_apk in debug builds. Will explain more in crbug.com/786743.

Original change's description:
> Add Android OOP HP end-to-end tests.
> 
> This CL has three components:
>   1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver.
>   2) Adds a java instrumentation test, along with a JNI shim that forwards into
>   ProfilingTestDriver.
>   3) Creates a new apk: chrome_public_apk_for_test that contains the same
>   content as chrome_public_apk, as well as native files needed for (2).
>   chrome_public_apk_test now targets chrome_public_apk_for_test instead of
>   chrome_public_apk.
> 
> Other ideas, discarded:
>   * Originally, I attempted to make the browser_tests target runnable on
>   Android. The primary problem is that native test harness cannot fork
>   or spawn processes. This is difficult to solve.
> 
> More details on each of the components:
> (1) ProfilingTestDriver
>   * The TracingController test was migrated to use ProfilingTestDriver, but the
>   write-to-file test was left as-is. The latter behavior will likely be phased
>   out, but I'll clean that up in a future CL.
>   * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver
>   has a single function RunTest that returns a 'bool' indicating success. On
>   failure, the class uses LOG(ERROR) to print the nature of the error. This will
>   cause the error to be printed out on browser_test error. On instrumentation
>   test failure, the error will be forwarded to logcat, which is available on all
>   infra bot test runs.
> (2) Instrumentation test
>   * For now, I only added a single test for the "browser" mode. Furthermore, I'm
>   only testing the start with command-line path.
> (3) New apk
>   * libchromefortest is a new shared library that contains all content from
>   libchrome, but also contains native sources for the JNI shim.
>   * chrome_public_apk_for_test is a new apk that contains all content from
>   chrome_public_apk, but uses a single shared library libchromefortest rather
>   than libchrome. This also contains java sources for the JNI shim.
>   * There is no way to just add a second shared library to chrome_public_apk
>   that just contains the native sources from the JNI shim without causing ODR
>   issues.
>   * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test.
>   * There is no way to add native JNI sources as a shared library to
>   chrome_public_test_apk without causing ODR issues.
> 
> Finally, this CL drastically increases the timeout to wait for native
> initialization. The previous timeout was 2 *
> CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test.
> This suggests that this step/timeout is generally flaky. I increased the timeout
> to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL.
> 
> Bug: 753218
> Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55
> Reviewed-on: https://chromium-review.googlesource.com/770148
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517541}

TBR=brettw@chromium.org,erikchen@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 753218
Change-Id: I0ce13ddac560fc685bce8798a59d2e1c784e08af
Reviewed-on: https://chromium-review.googlesource.com/778339Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517726}
      c94d1275
    • Aleks Totic's avatar
      Revert "[layout test results.html] Small UI tweaks and tiny bug fixes" · 3bb869bf
      Aleks Totic authored 
      This reverts commit 4e68cd40.

Reason for revert: Couple of outstanding bugs. Sorry I did not get
to code review this before landing.

Original change's description:
> [layout test results.html] Small UI tweaks and tiny bug fixes
> 
> - When click the toolbar to select a view during animation, show the
>   view for 1 second. This is convenient to briefly view a specific view
>   without stopping the animation. Previously the time showing the clicked
>   view was random.
> 
> - Let GUI.getExpectation(el) handle cases that the el is under
>   result-frame, so that keyboard navigation still works when the focus
>   is under result-frame (e.g. after the toolbar or the image result is
>   clicked).
> 
> - Let GUI.activeExpectation() return the open expectation if no
>   expectation line can be found from the focused element, so that keyboard
>   navigation can be based on the open expectation if the focus is neither
>   under the expectation line nor result-frame.
> 
> - Correct total count. Previously the total count didn't include expected
>   failures, skipped and wontfix tests, etc.
> 
> Change-Id: Ibc4b697c52a7b5d37f0ebbfb5c925cc478f15f06
> Reviewed-on: https://chromium-review.googlesource.com/777469
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517674}

TBR=wangxianzhu@chromium.org,qyearsley@chromium.org,atotic@chromium.org

Change-Id: I214a79799ab0c5744c00c0cbd85f1ecd7978159f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/777808Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517725}
      3bb869bf
  5. 18 Nov, 2017 2 commits