GitLab

Various WebGL-related tests started failing on XP and Vista:
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%282%29&number=31628
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%283%29&number=25055
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=41714
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%282%29&number=39756
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%283%29&number=35336

Example:

browser\extensions\requirements_checker_browsertest.cc(47): error: Value of: actual_errors
Actual: { "WebGL is not supported.", "CSS3d is not supported." }
Expected: expected_errors
Which is: {}

> Simplify GPU blacklist for WinAura
> 
> The gpu is completely blacklisted on all vista and XP machines with aura. All other blacklisting of them is redundant.
> 
> BUG=315199
> 
> Review URL: https://codereview.chromium.org/58343007

TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/60833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233210 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233208 0039d316-1c4b-4281-b951-d872f2087c98

Failing on check_deps
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/24263
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/45411
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%282%29/builds/19085
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/20133

> Clamp down various chrome/ DEPS files
> 
> R=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/52023003

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/61513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233205 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/52023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315397
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/60293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233200 0039d316-1c4b-4281-b951-d872f2087c98

 * Adding QuotaReservationManager.
 * Adding Reservation, ReservationPool, OpenFile, ActiveFile as its inner class.

TEST=content_unittests:QuotaReservationManagerTest.*
BUG=303443
TBR=avi
NOTRY=true

Review URL: https://codereview.chromium.org/43323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233199 0039d316-1c4b-4281-b951-d872f2087c98

This reduces command buffer flushes by allocating buffer ids in chunks of 64
just as texture ids.

BUG=314152
TEST=cc_unittests --gtest_filter=ResourceProviderTest.TextureAllocationChunk

Review URL: https://codereview.chromium.org/58603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233196 0039d316-1c4b-4281-b951-d872f2087c98

With underlying leak cause addressed, the suppression
is no longer needed.

R=thestig@chromium.org
BUG=291240
NOTRY=true

Review URL: https://codereview.chromium.org/56983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233195 0039d316-1c4b-4281-b951-d872f2087c98

from v2 to v3.

This CL only refactors the ping interceptor so that later on, update
checks can be intercepted and canned responses be served back.

Since v3 protocol uses http POST, a uniform way to intercept POST
requests is needed. The current interceptor works only for pings.
Support will be added later on to intercept update checks and
respond with specific XML.


BUG=314521

Review URL: https://codereview.chromium.org/56023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=294461

Review URL: https://codereview.chromium.org/45343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233193 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate the short period of time between the tap timeout and long
press causing onSingleTapConfirmed not to be dispatched when apps
expect.

Note: This is a cherry-pick of the upstream Android fix for b/8124095.

BUG=315124
NOTRY=true

Review URL: https://codereview.chromium.org/59173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233192 0039d316-1c4b-4281-b951-d872f2087c98

The gpu is completely blacklisted on all vista and XP machines with aura. All other blacklisting of them is redundant.

BUG=315199

Review URL: https://codereview.chromium.org/58343007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233191 0039d316-1c4b-4281-b951-d872f2087c98

Currently the AppShimMenuController is only instantiated if app shims
are enabled at startup. It's possible to enable app shims while Chrome
is running by enabling the app launcher. In this case v2 apps don't get
their own menu bar until Chrome is restarted.

This CL exposes InitAppShimMenuController in AppController, which is
called by AppListServiceMac when the app list is enabled.

BUG=314890
TEST=Start with app shims not enabled.
Enable app shims (e.g. enable the app launcher).
Start an app.
The app should have its own menu bar.

Review URL: https://codereview.chromium.org/55683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233190 0039d316-1c4b-4281-b951-d872f2087c98

These tests pass on my Nexus 7 v2. Occasionally I see a timeout in MediaSourceTest.ConfigChangeVideo test but the next retry passes. I'll check if the same thing happens on the test bots later.

BUG=304956
TEST=MediaSourceTest work on Nexus 7 v2.
R=qinmin@chromium.org

Review URL: https://codereview.chromium.org/60433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237681

Review URL: https://codereview.chromium.org/60273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233187 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233186 0039d316-1c4b-4281-b951-d872f2087c98

Pulls in:
d8b177c c99conv: Use a non-capturing group to shave off a couple seconds.
51449ec c99conv: Don't preprocess to file w/o GOMA. Use stdout. Remove lock.

BUG=172368
TEST=compilation is much faster.  try bots pass.
R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/61243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261451
TEST=On Chrome OS, rapidly enable/disable spoken feedback on user/lock/oobe screens.
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/60373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233180 0039d316-1c4b-4281-b951-d872f2087c98

Enable the test now that the problem with build bot is resolved.

BUG=314971

Review URL: https://codereview.chromium.org/61103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233179 0039d316-1c4b-4281-b951-d872f2087c98

Also:
* use username/password instead of hardcoded test@test.test and ''
* Improve logging.

BUG=308224
TEST=No longer see bad profile popup with this change.
NOTRY=True

Review URL: https://codereview.chromium.org/56533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233178 0039d316-1c4b-4281-b951-d872f2087c98

This keeps the feature as-is but shows a warning in the developer
console so the developers can fix their code before removing the
feature breaks it.

BUG=313986

TEST=When opening a new window with chrome.apps.window.create() if the
options parameter contain a 'singleton' option set to false and a 'id',
the developer console should show a warning.

Review URL: https://codereview.chromium.org/53973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233176 0039d316-1c4b-4281-b951-d872f2087c98

CFLog, which is overridden by content/renderer/renderer_main_platform_delegate_mac.mm, contains the following instruction in 64-bit form on 10.6.8 and 10.7.5:

4881ECD0000000                  sub        rsp, 0xd0

mach_override’s puny simplistic fake disassembler didn’t understand this instruction. This resulted in mach_override failing, which triggered a CHECK failure during renderer startup, with the result that everything would be a sad tab on 10.6 and 10.7 64-bit.

The latest version of mach_override replaces its weak old non-disassembler with libudis86, which should be much more capable in the area of understanding instructions, and which should improve mach_override’s ability to patch code without always having to retrain it.

In the mean time, the upstream change that was probably causing us to be unable to update to the current HEAD (https://github.com/rentzsch/mach_star/commit/498e0ba3)
has been backed out since then (https://github.com/rentzsch/mach_override/commit/1b3aa46f), so it should now be safe to update to HEAD.

Local patches https://codereview.chromium.org/21208002/ and https://codereview.chromium.org/22798004/ have been reapplied with minor fixes to work with the current version.

BUG=315218
R=avi@chromium.org

Review URL: https://codereview.chromium.org/61273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233175 0039d316-1c4b-4281-b951-d872f2087c98

Previously, items in autofill popup couldn't be selected using touch.
Now, gesture events are handled on autofill popup to enable touch.

BUG=290429

Review URL: https://codereview.chromium.org/44543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233172 0039d316-1c4b-4281-b951-d872f2087c98

command_buffer was historically included in nacl-compiled things, and base
wasn't.  These days, base is included in nacl-compiled things too, so the
duplication can be removed.

BUG=none
R=piman@chromium.org

Review URL: https://codereview.chromium.org/59383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314505
R=blundell@chromium.org
TBR=rsleevi

Review URL: https://codereview.chromium.org/58833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233169 0039d316-1c4b-4281-b951-d872f2087c98

Rewrite part of the test using plain C++ Fake pattern.

BUG=134675
TEST=ui_unittests --gtest_filter=AnimationContainerTest.*
R=ben@chromium.org

Review URL: https://codereview.chromium.org/56193006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233168 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/59973010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233164 0039d316-1c4b-4281-b951-d872f2087c98

1) Create a gcm subdir under browser/services and add some initial files.
2) Add GCMProfileService that is profile based and acts a bridge between
GCM API and GCM client. This does not contain the real implementation yet.
3) Add GCMProfileServiceFactory that owns and creates all GCMProfileService
and associate them with profiles

BUG=314924
TEST=none due to no real implementation has been added yet
R=fgorski@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/60673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315160

Review URL: https://codereview.chromium.org/60573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233162 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/50943002/ 

Since I changed everything to mirror aura, the comment becomes unnecessary.

BUG=312582

Review URL: https://codereview.chromium.org/59903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=No behavior change.

Review URL: https://codereview.chromium.org/59863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314532
TEST=chrome://settings/autofill shows card images next to credit card entries.
R=estade@chromium.org

Review URL: https://codereview.chromium.org/59173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233159 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233157 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=304839

Review URL: https://codereview.chromium.org/59773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233156 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161368&mode=html
TBR=
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/59623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233155 0039d316-1c4b-4281-b951-d872f2087c98

BUG=31473
TEST=manual

Review URL: https://codereview.chromium.org/59163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138629

Review URL: https://codereview.chromium.org/59093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233153 0039d316-1c4b-4281-b951-d872f2087c98

These docs refer to commands that are really out of date, and most likely don't even work anymore. Updating them to be more current.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/59043008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233151 0039d316-1c4b-4281-b951-d872f2087c98

Update content on Windows theme changes (Glass->Classic).
Implement BubbleFrameView::OnThemeChanged to fix title/close.
Called via NonClientView::UpdateFrame after being clobbered.

BUG=308262
TEST=Dialogs retain their title and close button after windows theme changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/58863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233150 0039d316-1c4b-4281-b951-d872f2087c98

Title is not displayed in the file select dialog, whereas Message is.

BUG=NONE

Review URL: https://codereview.chromium.org/54493010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233149 0039d316-1c4b-4281-b951-d872f2087c98