- 08 Jun, 2018 40 commits
-
-
Sadrul Habib Chowdhury authored
Only SCROLL_UPDATE and FIRST_SCROLL_UPDATE components currently have non-zero component ids. However, these component-ids are never used for any purpose. So use zero as the component-id for these components. This allows for the following cleanups: . RenderWidgetHostLatencyTracker no longer needs latency_component_id_. . Rename RenderWidgetHostImpl::GetLatencyComponentId() to a clearer name: GetFrameSinkIdForSnapshot(). BUG=849729 Change-Id: I7fea87d5cf1b06c580b6738816ffeb893063b1fb Reviewed-on: https://chromium-review.googlesource.com/1089715 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#565559}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ic4063923607a16b369741c1cb43fcdc1aad583d9 Reviewed-on: https://chromium-review.googlesource.com/1092430Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#565558}
-
Michael Lippautz authored
Bug: chromium:840789 Change-Id: Ic73ce15ac2057d4ed6fec89d3fc74c8bf32909ae Reviewed-on: https://chromium-review.googlesource.com/1092210 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565557}
-
Stefan Zager authored
Prior to this patch, a rect-based hit test took as parameters a center point and four padding values for top, right, bottom, and left padding. Theoretically, a rect-based hit test might have asymmetric padding, but in practice, this never happens in the code (i.e., it's always true that top-padding == bottom-padding and left-padding == right-padding). Additionally, point-based hit tests used the same call path as rect-based hit tests (with zero padding), which made the code hard to follow. Finally, there was a bug in the rect-based hit test implementation: point-based hit tests always create a one-pixel rect with the hit test point at top left and width=height=1. Because rect-based hit tests used the same code path, the hit test rect was always erroneously expanded by one pixel to the right and one pixel down. This patch makes an explicit distinction between point-based and rect-based hit tests; it gets rid of center-point-and-padding in favor of a simple rect; and it fixes the one-pixel-padding bug. BUG=827639 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I11e49da328080c03da2e1662cbcc0317ab409740 Reviewed-on: https://chromium-review.googlesource.com/1081331Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#565556}
-
Xiaohan Wang authored
This reverts commit 0c5ac919. The test has been fixed in http://crrev.com/c/1090113. Bug: 608541 Change-Id: I040328033921d8b24018761d19ecd923d44d75bf Reviewed-on: https://chromium-review.googlesource.com/1091883Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565555}
-
Lei Zhang authored
As is, it calls RenderProcessHost::SetMaxRendererProcessCount(), which overrides a global variable. Since it does not cleanup after itself, any other subsequent test cases are stuck with its override. RenderProcessHostUnitTest, which is sensitive to the override, has to call SetMaxRendererProcessCount(0) to compensate. BUG=850541 Change-Id: I0351d2bd709e2ba850ee47b5ed9a503903b3f5f8 Reviewed-on: https://chromium-review.googlesource.com/1088316Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565554}
-
Lei Zhang authored
Currently it takes an array of IDs, an offset into the array, and a count. This CL changes the method to just take a list of IDs, so its implementation is more straight forward. Callers that used to keep track of offsets into a fixed array now does the work of splitting the array into smaller chunks. BUG=769630 Change-Id: I7661bac4a965ce0734ebc5e89828b6b10b11572a Reviewed-on: https://chromium-review.googlesource.com/1080219 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565553}
-
Lei Zhang authored
Remove the |max_size| parameter, which is now always 0. BUG=769630 Change-Id: Id44b41f4c783119aa9069f474e47e567e5cda6a2 Reviewed-on: https://chromium-review.googlesource.com/1090222 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Katie D authored
Per UI review, we only want to show the relevant languages to the user by default to reduce page clutter. Tested by using a brand new profile and seeing that the English languages show up, and by adding "German" as another preferred language and seeing that both English and German show up in the preferred languages list. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I19b264b8b92921135acf0c2064e7a8bd9c8f881f Reviewed-on: https://chromium-review.googlesource.com/1074329 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#565551}
-
Jeremy Roman authored
Use base/sys_byteorder.h instead. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I904fec77fbf470f72287fb49a993de9013c9b758 Reviewed-on: https://chromium-review.googlesource.com/1090990 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#565550}
-
Pedro Amaral authored
This CL does 3 things: 1) Make BottomToolbarController be initialized in ToolbarManager instead of ChromeActivity. 2) Make an MVC component for the tab switcher button 3) Add the omnibox focus, tab switcher button, and menu buttons to the bottom toolbar. I opted to keep everything in one CL for now to give context. For example I moved the BottomToolbarController initialization because the ToolbarManager has the necessary information that is passed down to the TabSwitcherCoordinator. Let me know if you want this split up. A couple things are missing from this CL: 1) No incognito or theming. The bottom toolbar doesn't do these things yet so the buttons also won't. 2) Support for memex. The logic for triggering memex is spread in ToolbarPhone and I didn't want to have to move it to ToolbarManager or to have ToolbarPhone own BottomToolbarController. 3) There is currently no way of switching bottom buttons using the keyboard. 4) The top toolbar tab switcher button and menu button are still being shown. Eventually we'd probably need to do something with a cached feature. 5) When we enter tab switcher mode the omnibox focus button is still present even though it doesn't do anything. Not sure if we want to hide it. 6) Long-pressing the omnibox focus button doesn't show an accessibility toast. Not sure if we want this but the tab switcher button has it. 7) The app menu update badge is missing. Change-Id: I4aa6f6ca19d18cf32b8d6e4771e86971426fa2d7 Reviewed-on: https://chromium-review.googlesource.com/1068079 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565549}
-
Justin Cohen authored
Add -Wno-null-pointer-arithmetic and -Wno-unused-lambda-capture. Correct memory order argument to atomic operation error. Bug: 850333, 843234 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I34647764ebc03adfa865c32c298e24a0c1f60359 Reviewed-on: https://chromium-review.googlesource.com/1090151Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565548}
-
Hiroshige Hayashizaki authored
To match the behavior with the spec. Bug: 686281 Change-Id: I7aef8035083d1d5c12f91be597c580eb90833fdf Reviewed-on: https://chromium-review.googlesource.com/1091535Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#565547}
-
Richard authored
To enhance readability of code, put |version| in SWProviderHost:: GetOrCreateSWHandle() under management by scoped_refptr. Change-Id: I15c6a1d706a1b8176a077909b352726cb0813085 Reviewed-on: https://chromium-review.googlesource.com/1086724Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#565546}
-
Siddhartha authored
BUG=843419 Change-Id: I76862b50d57c845a4f4e0674dab579c45504488f Reviewed-on: https://chromium-review.googlesource.com/1087839 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565545}
-
Lei Zhang authored
This is what the information the caller really wants to know about directories on MTP devices before deleting them. By implementing this, the caller no longer have to use MTPDeviceTaskHelper::ReadDirectory(). As a result, ReadDirectory() can be simplified in a follow-up CL. BUG=769630 Change-Id: I29c1b40f7682cb68c271ea4817fbf32c776f33ab Reviewed-on: https://chromium-review.googlesource.com/1090221 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/09b82f4..c971895 git log 09b82f4..c971895 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 dtu@chromium.org [dashboard] Add mojo-linux-perf to Pinpoint. Created with: gclient setdep -r src/third_party/catapult@c971895 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:848551 TBR=sullivan@chromium.org Change-Id: Iaf08d38a02eb816bcc880cb602ed2592804fdc2d Reviewed-on: https://chromium-review.googlesource.com/1092250Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565543}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/798b832..1c06e11 git log 798b832..1c06e11 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 art-snake@yandex-team.ru Reland "Reland "Simplify CPDF_HintsTable."" Created with: gclient setdep -r src/third_party/pdfium@1c06e11 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb42683d703dd8a2864640eed0c743173d4f8c00 Reviewed-on: https://chromium-review.googlesource.com/1092190Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565542}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |NextBoundary()| and related things to reduce code size for improving code health. Change-Id: I644f444d2946908ea8f7e954bcd6dd31b42f8523 Reviewed-on: https://chromium-review.googlesource.com/1090692Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#565541}
-
Scott Violet authored
And makes work in ash. BUG=837715 TEST=covered by tests Change-Id: I65e5b3ee8a39f103c3ef1561a7de9ab27993aa86 Reviewed-on: https://chromium-review.googlesource.com/1090039 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565540}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f752aa..7a45dd1 git log 9f752aa..7a45dd1 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ea17575..81970bc (3 commits) Created with: gclient setdep -r src/third_party/skia@7a45dd1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ic2631e8c28b72cb81ae07a2ca2256ddcd04e863d Reviewed-on: https://chromium-review.googlesource.com/1092191Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565539}
-
Ahmed Fakhry authored
The MenuButton::PressedLock used to be always created with a null event from MenuController::Run() causing it to eventually call AnimateInkDrop() with a null event, which then used to clear the inkdrop host's `last_ripple_triggering_event_` which is used as the point from which the flood fill is generated. This CL passes the current located event (if any) to MenuButton::PressedLock. BUG=819878 Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8 Reviewed-on: https://chromium-review.googlesource.com/1089495Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#565538}
-
Matt Falkenhagen authored
Bug: 848786 Change-Id: Ie53fbf644afdd76d7c65649a05c939c63d89b4ec Reviewed-on: https://chromium-review.googlesource.com/1088335Reviewed-by:
-
Nigel Tao authored
It (chrome.fileManagerPrivate.installWebstoreItem) seems superseded by chrome.webstoreWidgetPrivate.installWebstoreItem (note the middle term changed from fMP to wWP), defined in ui/file_manager/externs/chrome_webstore_widget_private.js Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ca1049baef3a4cf7a66170092179bfef0af4c49 Reviewed-on: https://chromium-review.googlesource.com/1089593Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565536}
-
Yutaka Hirano authored
virtual/outofblink-cors/http/tests/xmlhttprequest/[workers/]upload-* crashes are fixed by https://crrev.com/a10c485c474fe0d212ed4d43ecc6f52712577823 . Bug: 836387 Change-Id: I179f52745effb1e66c5558f920bf08d71a4fca61 Reviewed-on: https://chromium-review.googlesource.com/1092213Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#565535}
-
Christopher Lam authored
This CL removes the old HistoryUI file and moves the icon retrieval functionality to the ChromeWebUIControllerFactory. Bug: 696821 Change-Id: I198c44bbfa86bd3b56cac01f3ecaa3f38254f285 Reviewed-on: https://chromium-review.googlesource.com/1069963Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/531d6f8..81db3d6 git log 531d6f8..81db3d6 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 derat@chromium.org cbuildbot: Stop building Tast infra packages. Created with: gclient setdep -r src/third_party/chromite@81db3d6 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845289,chromium:782515 TBR=chrome-os-gardeners@chromium.org Change-Id: Ie76c8995b11c83dfb3a61c796437a7a8207d4c13 Reviewed-on: https://chromium-review.googlesource.com/1092046Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565533}
-
Darren Shen authored
Part of several patches to remove KeyboardController::container_. When we remove KeyboardController::container_, |GetContainerWindow| will no longer make sense, so we need to remove all of its callers. A lot of calls to GetContainerWindow merely use it to get the root window. We can simply add a new method on KeyboardController to get the root window and change callers to directly call that. Bug: 849980 Change-Id: I505a3a8d6483eabaa571c3d5bedf07dc0902c320 Reviewed-on: https://chromium-review.googlesource.com/1088359 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#565532}
-
Lei Zhang authored
This reverts commit 11732507. Reason for revert: New browser_test is failing on linux-chromeos-rel. Original change's description: > Display confirmation dialog before proceeding to Demo Mode Setup flow. > > The dialog is not styled yet. > UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHKwkUMyliQOe9oB6rGBuYSwMSJbxAVNpw > > Test: Run DemoSetupTest. > Bug: 827376 > Change-Id: I58a051e3b9149472ff616aca791e7d8798f9b9fa > Reviewed-on: https://chromium-review.googlesource.com/1087594 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565518} TBR=xiyuan@chromium.org,jcivelli@chromium.org,agawronska@chromium.org Change-Id: I51160678e1952a3fbb0e0f048c00e2eda5a9f2c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827376 Reviewed-on: https://chromium-review.googlesource.com/1092330Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565531}
-
Lei Zhang authored
This reverts commit 83dadc4b. Reason for revert: Broke Linux CFI bot https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8420 Original change's description: > Update fontconfig > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > and [4] to fix a bug and clean up some log spam. > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > dependency since we statically link fontconfig. > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..7ad010e80bdf8e41303e322882ece908f5e04c74 > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > > BUG=831146 > > Change-Id: I5b9ae95e4b0ab03735a9adc5582eabeb45241ce8 > Reviewed-on: https://chromium-review.googlesource.com/1009071 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565514} TBR=thestig@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org Change-Id: Ieffcdeaeea22e5617adeac593d3df1127e3d1062 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831146 Reviewed-on: https://chromium-review.googlesource.com/1091478Reviewed-by:
-
Lei Zhang authored
This reverts commit edff5481. Reason for revert: This CL depends on r565449, but FindIt reverted r565449 because it caused MSAN errors. So revert this CL as well. Original change's description: > Display Cutout: Add controller and factory to Android > > Add a DisplayCutoutController that will decide when > to adjust the layout based on the cutout. This depends > on Android P APIs which are called by reflection. > > BUG=838400 > > Change-Id: Iaf808709ded2f3c1b3d7a060942ea8c65396ad9f > Reviewed-on: https://chromium-review.googlesource.com/1043248 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565494} TBR=mlamouri@chromium.org,tedchoc@chromium.org,beccahughes@chromium.org Change-Id: If626817c04b52541d486881b207a259eabf433fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838400 Reviewed-on: https://chromium-review.googlesource.com/1092047Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1a057e..81970bc git log e1a057e..81970bc --date=short --no-merges --format='%ad %ae %s' 2018-06-08 jiawei.shao@intel.com Use ShaderMap in DynamicHLSL and StateManager11 - Part I Created with: gclient setdep -r src/third_party/angle@81970bc The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic8244fe2b0ee70fd7b8cda79ea3d441e93c20af0 Reviewed-on: https://chromium-review.googlesource.com/1092131Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565528}
-
Tatsuhisa Yamaguchi authored
"Saved" also appears as IDS_DATA_REDUCTION_BREAKDOWN_SAVED_TITLE in src/chrome/android/java/strings/android_chrome_strings.grd. It has caused that Gallery app say "amount reduced" in Japanese whereas it should say "storing done". After this change we can put separate translations for those two phrases. Bug: 850385 Change-Id: Ie8204c023df771fcf22dac2fb9e177408097e880 Reviewed-on: https://chromium-review.googlesource.com/1090518Reviewed-by:
-
Hiroshige Hayashizaki authored
These tests are slow just because they set a long timeouts. Bug: 626703 Change-Id: Ia02beac96bf163b30df5c77eb05ec1038a5b346e Reviewed-on: https://chromium-review.googlesource.com/1091655 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 82f18579. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 565449 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgyZjE4NTc5MmI2MmY2MThkYWM0NGViZTExYzNiZjZlYTRmYWE3ZWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7501 Sample Failed Step: content_browsertests Original change's description: > Display Cutout: Track ViewportFit in WCO > > Adds a DisplayCutoutHost mojo interface that is implemented > by WebContentsImpl. When ViewportFitChanged is called by > the renderer we fire the ViewportFitChanged method on > WCO. This allows the browser to change the UI based on > the ViewportFit state. > > On the Blink side changes to ViewportFit bubble up through > Document which will call the DisplayCutoutHost Mojo > interface. > > BUG=838400 > > Change-Id: I701f8c367167c5d630800f9d41004b88d95f63f3 > Reviewed-on: https://chromium-review.googlesource.com/1038786 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565449} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=838400 Change-Id: I58be29b1a136e195f01af31dee27a06a9a997341 Reviewed-on: https://chromium-review.googlesource.com/1092270 Cr-Commit-Position: refs/heads/master@{#565525}
-
Scott Chen authored
Bug: 837177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84600d1e162db6994e56c99297645393aeab43d8 Reviewed-on: https://chromium-review.googlesource.com/1091652 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#565524}
-
Mathieu Perreault authored
As per mocks and new style, should be Google Blue 600. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: Ib9ee2112eb0efac2bbbd816dc7c9bd6f53e82471 Reviewed-on: https://chromium-review.googlesource.com/1089577Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565523}
-
Scott Chen authored
Tests were still testing for paper-input, which is why the tests were failing. Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70abd95c2da6c54f46a522c039ed28fda0c3b67c Reviewed-on: https://chromium-review.googlesource.com/1089863 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efe4f89..8e6f58c git log efe4f89..8e6f58c --date=short --no-merges --format='%ad %ae %s' 2018-06-08 sdy@chromium.org Add an `--ignore-current` flag to `git cl owners` to start from scratch. Created with: gclient setdep -r src/third_party/depot_tools@8e6f58c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib7a29c82a4978bf01beb6b8bf8a8f05c5d77c9fe Reviewed-on: https://chromium-review.googlesource.com/1092130Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565521}
-
Pedro Amaral authored
The bottom toolbar will need to be shown before native libraries are loaded so we cache the toolbar flag. Bug: 850804 Change-Id: I4699207e5d14cbaa2787479dec86dda9b4a51e79 Reviewed-on: https://chromium-review.googlesource.com/1091918Reviewed-by:
-
