GitLab

TBR=haraken
BUG=559300

Review URL: https://codereview.chromium.org/1468173002

Cr-Commit-Position: refs/heads/master@{#361165}

BUG=527856

Review URL: https://codereview.chromium.org/1434413002

Cr-Commit-Position: refs/heads/master@{#361164}

Revert of views/mus: Fix showing menu in chrome in mus. (patchset #2 id:20001 of https://codereview.chromium.org/1460003004/ )

Reason for revert:
Suspected in build failure. see crbug.com/560461

Original issue's description:
> views/mus: Fix showing menu in chrome in mus.
>
> For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
> window. For desktop builds, this means we attempt to host in a HWND or an
> X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
> NativeWidgetMus. To do this, use the native-widget factory first if it's
> available.
>
> BUG=none
>
> Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
> Cr-Commit-Position: refs/heads/master@{#361151}

TBR=sky@chromium.org,jam@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1472873003

Cr-Commit-Position: refs/heads/master@{#361163}

We'll need this for cursors and shadows.

BUG=548426
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1466483003

Cr-Commit-Position: refs/heads/master@{#361162}

BUG=557739

Review URL: https://codereview.chromium.org/1470613003

Cr-Commit-Position: refs/heads/master@{#361161}

1. Scrolls the page when navigating to a node, and updates the active indicator
location when a scroll event is received.

2. Update the active indicator location on every Output, rather than only
for speech or only for braille. (It was sometimes getting set and then
overwritten with nothing.)

3. Handle subranges within a node with a new boundsForRange API.

4. Automation API: implement boundsForRange, take frame offsets and
scroll offsets into account when returning a node's bounding box,
and use heuristics to avoid returning an empty bounding box.

BUG=537248
TBR=aboxhall

Review URL: https://codereview.chromium.org/1458723002

Cr-Commit-Position: refs/heads/master@{#361160}

TEST=conformance2/renderbuffers/framebuffer-test.html, gpu_unittests

BUG=429053

Review URL: https://codereview.chromium.org/1236053003

Cr-Commit-Position: refs/heads/master@{#361159}

Previously, the interface for URLRequestJob::ReadRawData was as follows:

  bool ReadRawData(IOBuffer*, int, int*)

Subclasses were expected to signal completion of the ReadRawData call by
calling NotifyDone, SetStatus, or maybe one of the other Notify* functions
on URLRequestJob, most of which do internal housekeeping and also drive the
URLRequest's state machine. This made it difficult to reason about the
URLRequestJob's state machine and needlessly complicated most of URLRequestJob.

The new interface is as follows:

  int ReadRawData(IOBuffer*, int)

Subclasses are required to either:

a) Return ERR_IO_PENDING, and call ReadRawDataComplete when the read completes in any way, or
b) Return a count of bytes read >= 0, indicating synchronous success, or
c) Return another error code < 0, indicating synchronous failure.

This substantially narrows the interface between URLRequestJob and its
subclasses and moves the logic for the URLRequest state machine largely into
URLRequestJob.

Also, the signature of URLRequestJob::ReadFilteredData and some other internal
URLRequestJob helpers changes to propagate detailed error codes instead of
coercing all errors to FAILED.

TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org,rdsmith@chromium.org
BUG=553300

Review URL: https://codereview.chromium.org/1467603002

Cr-Commit-Position: refs/heads/master@{#361158}

BUG=

Review URL: https://codereview.chromium.org/1468123002

Cr-Commit-Position: refs/heads/master@{#361157}

BUG=

Review URL: https://codereview.chromium.org/1467703003

Cr-Commit-Position: refs/heads/master@{#361156}

Previous change was not correct and lacked sufficient testing. Now testing with two forms to test for correct vector order.

BUG=555025
TEST=AutofillManagerTest

Review URL: https://codereview.chromium.org/1472723003

Cr-Commit-Position: refs/heads/master@{#361155}

BUG=560331

Review URL: https://codereview.chromium.org/1469873003

Cr-Commit-Position: refs/heads/master@{#361154}

BUG=536895,543405

Review URL: https://codereview.chromium.org/1458013003

Cr-Commit-Position: refs/heads/master@{#361153}

The following items are included in this CL.

1- Javascipt column for child processes that don't use V8 memory should always show "N/A".
2- Idle wakeups should show up only once per process.
3- NaCl debug ports column shows "Disabled" when the enable-nacl-debug flag is disabled.
4- NaCl modules should show the name of the app/extension instead of the URL.
5- Network usage can now be reported per process.

R=nick@chromium.org
BUG=551580

Review URL: https://codereview.chromium.org/1439213004

Cr-Commit-Position: refs/heads/master@{#361152}

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Review URL: https://codereview.chromium.org/1460003004

Cr-Commit-Position: refs/heads/master@{#361151}

I'm going to need more than one object to detect focus changes.

BUG=548424
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1465143004

Cr-Commit-Position: refs/heads/master@{#361150}

Fix the missing "data_store.pb.h" error when building extensions gn target on a clean output directory.

data_reduction_proxy_api.cc includes data_store.pb.h directly and indirectly (via data_reduction_proxy_compression_stats.h). This CL adds //components/data_reduction_proxy/proto:data_reduction_proxy_proto to the dependencies of extensions to solve this problem.

BUG=560321

Review URL: https://codereview.chromium.org/1460313004

Cr-Commit-Position: refs/heads/master@{#361149}

BUG=547246

Review URL: https://codereview.chromium.org/1460133002

Cr-Commit-Position: refs/heads/master@{#361148}

Improperly-formatted WAV data causes this class to attempt to divide by
zero in the constructor. Check for this condition, and invalidate
internal state if the WAV data does not parse properly. It should be able
to accept any data without crashing. Add unittests to verify.

Bug: b/21759728

BUG=
TEST=wav_audio_handler_unittest.cc

Review URL: https://codereview.chromium.org/1453233002

Cr-Commit-Position: refs/heads/master@{#361147}

1) Set the enable status of icon and label before it's being added as a
child of HoverHighlightView

2) Refuse SetHoverHightlight to true when disabled, and SetHoverHightlight
to false when OnEnabledChanged triggered and enabled() changed to false.

BUG=560013, 560027

Review URL: https://codereview.chromium.org/1470783002

Cr-Commit-Position: refs/heads/master@{#361146}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a40b4f5c..2280bfa0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1468093002

Cr-Commit-Position: refs/heads/master@{#361145}

BUG=208378

Review URL: https://codereview.chromium.org/1465133002

Cr-Commit-Position: refs/heads/master@{#361144}

Putative fix for crbug.com/545479. If WebUIManager is created but
navigation occurs before the WebUI URL starts loading, provisional
navigation for a non-WebUI URL could be observed by WebUIManager, and
WebUI should not be loaded in that case.

BUG=545479

Review URL: https://codereview.chromium.org/1464383002

Cr-Commit-Position: refs/heads/master@{#361143}

This used to work because the accessibility audit library pulls in parts
of the closure libray. Since it doesn't leak its internals in a newer
version, this dependency problem was exposed. The underlying issue is that
GEN_INCLUDES in the js test are included before closureModuleDeps, so
declarations from the latter are not available when evaluating the former.

Needed for https://codereview.chromium.org/1447693002/

BUG=555753
R=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/1472763002

Cr-Commit-Position: refs/heads/master@{#361142}

Cr-Commit-Position: refs/heads/master@{#361141}

BUG=295792, 483282, 559359, 559362, 559342
NOTRY=true

Review URL: https://codereview.chromium.org/1463983002

Cr-Commit-Position: refs/heads/master@{#361140}

IOSChromeIOThread initialises, holds and clean up data primarily used
on the IO thread. It is based on chrome/browser/io_thread.{cc,h} with
only the portion relevant to iOS kept.

BUG=556566

Review URL: https://codereview.chromium.org/1464083002

Cr-Commit-Position: refs/heads/master@{#361139}

This CL plumbs four QUIC experimental params (
quic_store_server_configs_in_properties,
quic_delay_tcp_race,
quic_max_number_of_lossy_connections,
quic_packet_loss_threshold) from Cronet's
setExperimentalOptions API to net::HttpNetworkSession.

This CL also adds a unittests target to run the unittests.
A followup CL will enable the unittests on the cronet bots.

BUG=545118

Committed: https://crrev.com/fde0b72c603cd111c36ca4cc416d82a7395bcf6c
Cr-Commit-Position: refs/heads/master@{#360454}

Committed: https://crrev.com/8ece3aa6845350c1971a3e824bf148f3e8de3253
Cr-Commit-Position: refs/heads/master@{#360875}

Review URL: https://codereview.chromium.org/1448583003

Cr-Commit-Position: refs/heads/master@{#361138}

https://chromium.googlesource.com/skia.git/+log/8e8eda9d4d2e..93c69fff5350

$ git log 8e8eda9d4..93c69fff5 --date=short --no-merges --format='%ad %ae %s'
2015-11-23 scroggo Revert of Add SkPngChunkReader. (patchset #9 id:160001 of https://codereview.chromium.org/1040453002/ )
2015-11-23 msarett Revert of Switch Skia's libjpeg-turbo to 1.4.2 (patchset #2 id:160001 of https://codereview.chromium.org/1469553002/ )
2015-11-23 scroggo Add SkPngChunkReader.
2015-11-23 bsalomon Review URL: https://codereview.chromium.org/1464593004

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1471803002

Cr-Commit-Position: refs/heads/master@{#361137}

BUG=477049

Review URL: https://codereview.chromium.org/1419083012

Cr-Commit-Position: refs/heads/master@{#361136}

The change was landed through the CL 1408923003

R=fmalita@chromium.org
BUG=546538

Review URL: https://codereview.chromium.org/1471003002

Cr-Commit-Position: refs/heads/master@{#361135}

The media playback test was recently added:
https://codereview.chromium.org/1431193005/

and requires specific switches:
* local file access required to load test media
* cma pipeline explicitly enabled in order to test that
* cast ozone platform enabled in order to test overlay frames

These tests have been failing on internal infrastructure (tot build)
because the switches were only configured in testing/buildbot (for
running on Chromium bots).

BUG=

Review URL: https://codereview.chromium.org/1466633004

Cr-Commit-Position: refs/heads/master@{#361134}

BUG=557285

Review URL: https://codereview.chromium.org/1465953003

Cr-Commit-Position: refs/heads/master@{#361133}

This CL:
- Removes weird OnFaviconAvailable() behavior if gfx::Image is empty.
- Merges: FaviconDriver::SetActiveFaviconValidity()
          FaviconDriver::SetActiveFaviconURL()
          FaviconDriver::SetActiveFaviconImage()
- Merges FaviconDriverObserver::OnFaviconAvailable() and
         FaviconDriverObserver::OnFaviconUpdated().

BUG=542057

Review URL: https://codereview.chromium.org/1407353012

Cr-Commit-Position: refs/heads/master@{#361132}

BUG=475442

Review URL: https://codereview.chromium.org/1471783002

Cr-Commit-Position: refs/heads/master@{#361131}

TEST=CronetUrlRequestTest.testMockClientCertificateRequested
BUG=558420

Review URL: https://codereview.chromium.org/1459993003

Cr-Commit-Position: refs/heads/master@{#361130}

This adds libffi-dev and libdrm-dev to the image
which were recently added with:
https://codereview.chromium.org/1464123002

R=thestig@chromium.org
BUG=559062

Review URL: https://codereview.chromium.org/1466383002

Cr-Commit-Position: refs/heads/master@{#361129}

Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
rename it to addPathByteStreams. Move the "regular" blending out into a
helper(blendPathByteStreams), and eliminate the redundant copy. Make the
functions more "functional" (return the result.)

Add a (private) setter for byte-stream data and use that to ensure
invalidation of the cached path. Also add an SVGPath::create(...)
accepting a SVGPathByteStream and use that in PathSVGInterpolation.

Inline mutableByteStream into the remaining user.

Review URL: https://codereview.chromium.org/1460253002

Cr-Commit-Position: refs/heads/master@{#361128}

BUG=559322

Review URL: https://codereview.chromium.org/1470503002

Cr-Commit-Position: refs/heads/master@{#361127}

crrev.com/1427963002 introduced a new memory-infra thread which runs
after all dump providers are finished. This measures the process total
memory usages. This was previously running at the start of a memory
dump. This means that the memory used while taking memory dump of other
providers will be included in the totals now and this metric has
regressed. This CL is a temporary change that reverts this behaviour so
that the perf bots are happy. Better fix for the problem will follow up
soon.

BUG=555584

Review URL: https://codereview.chromium.org/1466293002

Cr-Commit-Position: refs/heads/master@{#361126}