GitLab

Proper fix is in https://codereview.chromium.org/2983883002/, but I'd rather not
land that while on leave. I will land the proper fix when I come back if this is
still not replaced with the new UI.

BUG=668296

Review-Url: https://codereview.chromium.org/2985543002
Cr-Commit-Position: refs/heads/master@{#488328}

This change will allow for the detection of tasks running in
TaskScheduler that fail to post their task in a COM STA Task Runner
instead.

BUG=706512
TBR=gab@chromium.org
Previously Reviewed at https://chromium-review.googlesource.com/c/549223/

Review-Url: https://codereview.chromium.org/2978253002
Cr-Original-Commit-Position: refs/heads/master@{#487625}
Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f
Review-Url: https://codereview.chromium.org/2978253002
Cr-Commit-Position: refs/heads/master@{#488327}

Getting the whitespace removed will make SQLite patch management easier.

This CL was generated using the following commands.
cd third_party/sqlite
find src/ -type f -not -iname "*.db" -not -iname "*.eps" -not -iname "*.ico" \
    -not -iname "*.jpg" -not -iname "*.pfx" -not -iname "*.tiff" \
    -not -iname "*.vsix" -exec sed --in-place 's/[[:space:]]\+$//' {} \+
find patches/ -type f -exec sed --in-place 's/[[:space:]]\+$//' {} \+
./google_generate_amalgamation.sh

Bug: 746653
Change-Id: I933ab436d5a1be05074821d92e818dd6bf72009f
Reviewed-on: https://chromium-review.googlesource.com/578677Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488326}

BUG=

Change-Id: I71fd5ed6623499c55332e3ccc3372123768d37c8
Reviewed-on: https://chromium-review.googlesource.com/579689Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488325}

The KAV buttons should be aligned with the ones from GBoard.

Bug: 
Change-Id: I8ba048719326ed93890fa989092cc460d0071e29
Reviewed-on: https://chromium-review.googlesource.com/579971
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488324}

Bug: 746963
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I60bcffb65161c16521afc22b3aa1ed3d2bfe346d
Reviewed-on: https://chromium-review.googlesource.com/579528Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488323}

The issue was a general UBSan one, not a UBSan vptr issue. Also, we
didn't have to blacklist the false positive, but instead provided UBSan
wth the necessary type info.

BUG=737384

Change-Id: Ie6299e1edfc010ef976ab4fbefacba4d06e305b7
Reviewed-on: https://chromium-review.googlesource.com/579448Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Cr-Commit-Position: refs/heads/master@{#488322}

ExtractIntegerValueAtIndex's main piece of functionality was that it
would first try to read the number as a string, and if the failed, it
would fallback to reading it as a double/integer. However, the string
read is not needed, as the javascript side always passes a number.

Bug: 
Change-Id: I189e96865ec834bb8753f0d9f418cb3cd9925d17
Reviewed-on: https://chromium-review.googlesource.com/569848
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488321}

In the cases where a normal web page is not being displayed, the
browser controls are permanently shown (i.e. error page or
interstitial). Because of this, When the browser controls are at
the top of the screen, these views have a top margin applied to
them so the full page can be visible. This code was never updated
for bottom browser controls. This change adds logic to apply a
bottom margin when bottom browser controls exist.

BUG=738616

Change-Id: I155140d8341185b9cdb55f964d2491893732b4dc
Reviewed-on: https://chromium-review.googlesource.com/576268
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488320}

This CL is part of the Mojo Video Capture work.
Design doc for dev work [1].
Design doc for launch [2].

After this CL we differentiate in the UMA logging between
enumeration-only usages of the service and usages that include actual capture.

BUG:584797,721812

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://docs.google.com/document/d/1RLlgEdvqRA_NQfSPMJLn5KR-ygVzZ2MRgIy9yd6CdFA/edit?usp=sharing

Change-Id: If6fd5fd1480edf18cce861f6c880d811a2f9a58c
Reviewed-on: https://chromium-review.googlesource.com/572220
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488319}

Bug: none
Change-Id: I2014adfa408153e801a5c5b94423e63ecb08c48b
Reviewed-on: https://chromium-review.googlesource.com/579191Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488318}

ANGLE's shader translators hold a significant amount of memory for the
builtin symbols.  By lazily creating the shader translator, it may never
be intialized at all if all compiles hit the program binary cache.

BUG=695135

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I095dd2efa33e111726db893cd14c3c3574bdd6ce
Reviewed-on: https://chromium-review.googlesource.com/570540Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488317}

Added the missing return true and unit tests for both BufferFormat and
BufferUsage enum traits.

Bug: 732825
Change-Id: Idd41676f01a11f7666bf2c1c07621b4b9eae6b4a
Reviewed-on: https://chromium-review.googlesource.com/578211Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488316}

This reverts commit 0e0ca1fb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Android: Turn on UnusedResources lint check
> 
> Fixes current lint warnings and starts to remove obsolete old
> suppressions. Moving towards a world where we have as few suppressions
> as possible.
> 
> Bug: 731159
> Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89
> Reviewed-on: https://chromium-review.googlesource.com/578488
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Xi Han <hanxi@chromium.org>
> Reviewed-by: Yuwei Huang <yuweih@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488307}

TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org

Change-Id: I0347f22ffdf8ff7fa50a94a5d164dc4b790851f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731159
Reviewed-on: https://chromium-review.googlesource.com/580227Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488315}

This reverts commit 0e0ca1fb.

Reason for revert: Broke compile on Android Arm64 Builder (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29

Original change's description:
> Android: Turn on UnusedResources lint check
> 
> Fixes current lint warnings and starts to remove obsolete old
> suppressions. Moving towards a world where we have as few suppressions
> as possible.
> 
> Bug: 731159
> Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89
> Reviewed-on: https://chromium-review.googlesource.com/578488
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Xi Han <hanxi@chromium.org>
> Reviewed-by: Yuwei Huang <yuweih@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488307}

TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org

Change-Id: I7dc0c54b509fe2597a38bb6d660d9c4e7232321d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731159
Reviewed-on: https://chromium-review.googlesource.com/579749Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488314}

Because the original CL for this got reverted multiple times due to issues with working
with the build bots, the original CL has combined with a second CL (both described
below) such that the second CL moves the accessibility tests to a separate component.

From first CL:
- Adds html and js files for testing accessibility in Payment Request
- CL link: https://chromium-review.googlesource.com/c/578135
- Author: rayraymond

From second CL:
- Creates a new target, ios_chrome_payments_egtests, for Payment Request
  EG tests, in expectation of a dozen coming tests.
- Makes the target depend on the Payment Request test data in
  components/test/data/payments
- CL link: https://chromium-review.googlesource.com/c/575206
- Author: mahmadi

TBR=eugenebut@,lpromero@,michaeldo@,sdefresne@,eisinger@

Bug: 734571
Change-Id: I2a1213018dca57e14301b7188ac092ab9ff2ae56
Reviewed-on: https://chromium-review.googlesource.com/579647
Commit-Queue: Randall Raymond <rayraymond@google.com>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488313}

Bug: 330631
Change-Id: I762d739912102b324677baf2be9db9c91a13b6ac
Reviewed-on: https://chromium-review.googlesource.com/579938Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488312}

It is common to animate something away via a transform, bounds, or
opacity animation and want to flip a visibility bit upon completion of
that transition. Boolean animations are suited to this task. They act
as a step function returning the second value when the timing function
returns a fraction of 1.0 (and you can use this timing function to
adjust the position of the step).

This change also finishes the small bit of plumbing to tick bg
color animations.

Bug: None
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I18ab39570e2de63cbf103a36c10ea1766efc12e8
Reviewed-on: https://chromium-review.googlesource.com/579529
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488311}

Simulate Blink assigning an item and document sequence number to the
navigation. This is similar to what is done in
TestRenderFrameHost::SendNavigateWithParameters().

Bug: 728571
Change-Id: I6915d7e80154779c87294d71a1a395b862fc428b
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel
Reviewed-on: https://chromium-review.googlesource.com/579380
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488310}

- Move decision to show and close prompt to VrShell since it is a state
  change and shout not be part of UiSceneManager.
- Allow different content messages on the exit prompt.

Change-Id: I554948345638428fc48b763834619c40934498d9
Reviewed-on: https://chromium-review.googlesource.com/577674Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488309}

Previously, SensitiveInputVisibility events were reported to the
password manager. Chrome will soon introduce new states that trigger
the "Not Secure" warning in Chrome's omnibox (including edits of any
input type), meaning that the events are more naturally handled in
\chrome\browser\ssl instead. This CL extracts the handler from the
password manager to a new class. Future CLs will extend the mojo
interface with new events.

Bug: 720094
Change-Id: If7d2678dce2bda050fe488b69da0f754c7bb668b
Reviewed-on: https://chromium-review.googlesource.com/574759
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488308}

Fixes current lint warnings and starts to remove obsolete old
suppressions. Moving towards a world where we have as few suppressions
as possible.

Bug: 731159
Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89
Reviewed-on: https://chromium-review.googlesource.com/578488Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488307}

This is a remnant from long ago; I don't think anyone still uses this.
(If you do use this, please let me know, and feel free to revert this CL.)

Bug: 330631
Change-Id: I7870f0c9f3321931de1c1c3eff101f07762c8772
Reviewed-on: https://chromium-review.googlesource.com/579957Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488306}

Changes:
1. Enlarges the width of the AppsGridView to make 24px horizontal
padding for page switcher.
2. In the meanwhile, keeps the AppsGridView horizontally centered by
adding equal space to left and right side.

Specs: https://screenshot.googleplex.com/vdLmFvaJSdR
Screenshot: https://screenshot.googleplex.com/SWec2Jeqhon

BUG=741007

Change-Id: If74cc65099385580b8955825febcd39526a05992
Reviewed-on: https://chromium-review.googlesource.com/578723
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488305}

It looks like this was replaced with something else a while ago,
so remove the old thing.  It still references a script I'm hoping
to delete.

Bug: 330631
Change-Id: Ic0834dfab0a635d6926682299d9cdf49e4a24d89
Reviewed-on: https://chromium-review.googlesource.com/579937Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488304}

This reverts commit 4fb04a8a.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Snowflake] Unify infobar text styles
> 
> + Infobar secondary text from #646464 to 54% black
> + Infobar big icon control message to 20sp
> + Conneciton info url from bold to medium
> + Conneciton info description line height to 20
> + Page info secure scheme "https" text to medium
> + Page info and connection info link text to #3367D6
> + Bluetooth dialog link text to #3367D6
> + Bluetooth dialog bottom margin to match button right margin
> 
> BUG=723044,723054
> 
> Change-Id: I2646135c31d3328d0028b831275941ab00278382
> Reviewed-on: https://chromium-review.googlesource.com/572545
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Becky Zhou <huayinz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487534}

TBR=tedchoc@chromium.org,twellington@chromium.org,huayinz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 723044, 723054
Change-Id: I2c0593255aaa196ead26f6d34c9dc59d6672d195
Reviewed-on: https://chromium-review.googlesource.com/579788Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488303}

Add a 'debug_x64' and 'release_x64' build type for the Windows bots.

BUG=735483

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I71adf860a39fb14600c044dca9aeb8bd3bfb33fd
Reviewed-on: https://chromium-review.googlesource.com/579574
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488302}

This is a WIP for implementing the actions API
I am planning to break up my CLs into logical small chunks and this is
the start

Change-Id: I94bd3b0b7cbd7a727bbb6bd7e02f52651fe8d1d8
Reviewed-on: https://chromium-review.googlesource.com/578475Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488301}

Unfortunately we have to check focus twice before sending it to a VrDisplay,
once in the browser to do view-level focus, then again in the renderer to do
frame-level focus.

This CL ensures browser-side focus before sending displayactivate events
or head pose information to the WebVR page.

This CL adds an argument to OnWebContentsFocused to let observers know
which RenderWidgetHost gained/lost focus. It also implements GotFocus for
Android, meaning OnWebContentsFocused will now be called on Android where
it previously wasn't.

LostFocus will now be called significantly less, as I've made it symmetric
with GotFocus (which involved adding the fullscreen restriction to
WebContentsImpl::RenderWidgetLostFocus that's present in
WebContentsImpl::RenderWidgetGotFocus)

Bug: 687411, 738239
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ibeee427d602d7fef8ce533669b45d9cc5f8ffa03
Reviewed-on: https://chromium-review.googlesource.com/565760
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488300}

BUG=None

Review-Url: https://codereview.chromium.org/2973213002
Cr-Commit-Position: refs/heads/master@{#488299}

Difference from the reverted CL:
Renames JSONObject::GetObject to GetJSONObject to avoid a Windows build
issue.


Change-Id: I3ec8abedaa63b4d38fc9c9d3a53f7826de6b5392
Reviewed-on: https://chromium-review.googlesource.com/578633
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488298}

Move IconType class out of MediaSink class in media_sink.h and media_router.mojom

Bug: 694841
Change-Id: I710adea06557c63e061bb428dbaed7038eb8d956
Reviewed-on: https://chromium-review.googlesource.com/574900Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488297}

Added an UMA_HISTOGRAM_BOOLEAN to report how often a gesture event is
or is not dropped based on the current touch action state not
matching the gesture event.

Bug: 745718
Change-Id: Ib1c9f91cfcaa846f3e8bba9a7b1c87f698b2a962
Reviewed-on: https://chromium-review.googlesource.com/575071
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488296}

NOTRY=true

Bug: 710098, 623268, 623210, 680307
Change-Id: I3b086fb6310ba8216cbade6cae6de08e689d460d
Reviewed-on: https://chromium-review.googlesource.com/579891Reviewed-by: Lukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488295}

Bug: 734239
Change-Id: Ia815aa693ab6719a0a26d65231db1a04c26a2c4d
Reviewed-on: https://chromium-review.googlesource.com/578513
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488294}

To use the FeatureEngagementTracker to observe the New Tab and related
actions, the NewTabFeatureEngagementTracker class was created.

Things that were changed in this CL:
* Added the NewTabInProductHelp trial to the fieldtrial json
* Added a pref to track the user's total active session time
* Created a NewTabFeatureEngagementTracker class, which contains
methods to notify the IPH server when events happen and if the help
UI should be triggered.

Related CLs:
* The Observer for DesktopSessionDurationTracker
  http://crrev.com/d69292f
* Event constants that are used in NewTabFeatureEngagementTracker
  http://crrev.com/bdf5c97
* Using the NewTabFeatureEngagementTracker
  https://chromium-review.googlesource.com/c/549074/
* Addition to fieldtrial_testing.json
  https://chromium-review.googlesource.com/c/566335/

Bug: 734132
Change-Id: I8654ef001f3fb50fbd8bb8c4f215dffcfe403762
Reviewed-on: https://chromium-review.googlesource.com/549057
Commit-Queue: Catherine Chung <catherinechung@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Pam Greene <pam@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488293}

This is a reland of b650c38e
Original change's description:
> chromeos: fix DCHECK in ~WindowTreeHostManager
> 
> The DCHECK is because on observer is being added but not
> removed. Specifically exo's WmHelper installs an observer on
> WindowTreeHostManager but WmHelper never removes itself (because
> WindowTreeHostManager is deleted before WmHelper). This patch makes
> WmHelper be destroyed before WindowTreeHostManager by way of making
> ChromeBrowserMainExtraPartsAsh create exo related functionality.
> 
> BUG=none
> TEST=none
> 
> Change-Id: I84e7209c817e4687017edbc14db7f75cb1054fbb
> Reviewed-on: https://chromium-review.googlesource.com/572427
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487556}

Bug: none
Change-Id: I486d68e9a2af654facd50ccb0512bdca217520a8
Reviewed-on: https://chromium-review.googlesource.com/578287Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488292}

https://pdfium.googlesource.com/pdfium.git/+log/2c4a805ac3d6..dc11ec85ebf6

$ git log 2c4a805ac..dc11ec85e --date=short --no-merges --format='%ad %ae %s'
2017-07-20 dsinclair Cleanup CPWL_Icon AppStream generation
2017-07-20 dsinclair Consolidate Appearance Stream code in CPWL_AppStream.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ie3725d5399bcdedd7508c40cca545187daa0f6dc
Reviewed-on: https://chromium-review.googlesource.com/579577
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488291}

If navigation isn't possible when GestureNavSimple::OnOverscrollModeChange is
called, we don't show the affordance. In this case, we shouldn't attempt to
navigate again when GestureNavSimple::OnOverscrollComplete is called (even
if we can).

BUG=NONE

Review-Url: https://codereview.chromium.org/2983893002
Cr-Commit-Position: refs/heads/master@{#488290}

- Adds a request setter for the callback. Set to false by default.
- Starts sending the callback from bottom bar delegate only when
completely hidden or shown.
- If the bottom bar is not set, use the toolbar values to send the same
signal, so that bottom bar can be set as desired

BUG=746648

Change-Id: I6f60dde5e39354b33503ce9553b67cf953a9b533
Reviewed-on: https://chromium-review.googlesource.com/578392
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488289}