GitLab

This reverts commit 5d1496e0.

Reason for revert: https://bugs.llvm.org/show_bug.cgi?id=48048 got fixed.

Original change's description:
> Revert "[base] Use NO_UNIQUE_ADDRESS in flat_tree"
>
> This reverts commit f55e9981.
>
> Reason for revert: https://crbug.com/1144431
>
> Bug: 1144431
>
> Original change's description:
> > [base] Use NO_UNIQUE_ADDRESS in flat_tree
> >
> > This change makes use of NO_UNIQUE_ADDRESS in flat_tree, allowing the
> > removal of an internal class which just existed to make use of the empty
> > base optimization.
> >
> > Bug: 682254
> > Change-Id: Iabf91d4acee95c7ba4e929d23528d95b0ced1612
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509757
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#822948}
>
> TBR=dcheng@chromium.org,jdoerrie@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 682254
> Change-Id: If3b15e15241e8f8b5d99b80caadbb25153648f37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514147
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823192}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1144431
Bug: 682254
Change-Id: I70549a9fa09c05c1528a3df6f317fe2ac042b814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553429Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830482}

Randomly crashes on Win 7 Tests x64 (1)
https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/b8862779006945233296

TBR=rohitrao@chromium.org

No-Try: true
Bug: 1152289
Change-Id: I8007bb02997d230a66a78fda17b18c3c466f327b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557279
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Reviewed-by: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830481}

Fix the bug found by the "bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Ic33ba5a34435089eceda578014cd62b84350eef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555123
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Reviewed-by: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#830480}

As part of the OnionSoup project, this patch moves request_peer.h to
third_party/blink/public/platform/, which is needed when moving its
sub class content::SyncLoadContext into blink and removing
ResourceDispatcher finally.

Change-Id: I874307b49a68ed2ea931db1e48faf02539551d7a
Bug: 1110032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548648Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#830479}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with
is_chromeos_ash with some special cases (For those cases please
refer to http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: I86256d662153a26856323316978fa370a0cdc7ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550004
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830478}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with
is_chromeos_ash with some special cases (For those cases please
refer to http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: Ic46914d41965026956ec9adea34137fda5fdca16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550002
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830477}

Flakiness crash on Win 7 Tests x64 (1)
https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29

TBR=dpapad@chromium.org

No-Try: true
Bug: 1152287
Change-Id: Iff9b50f7cf759b481ae1cac94ae7848e4d29d050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556621Reviewed-by: Yuki Yamada <yukiy@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830476}

This replaces the usage of www2.127.0.0.1 with 127.0.0.1:8444.
(There're no tests that actually access this host.)

Bug: 1151384
Change-Id: I22d044943b40d8fffaea7dc7480e125c121dbe17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556739Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830475}

This was incorrectly removed in CL:2537450 because it appeared to have
no users. However, it was actually called directly by name (rather
then by the constant defined in system_api) in vmc.

Bug: 1151088
Change-Id: I95c4d10c8ab5656257bd72fd8d7fb47d07cef74c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551893Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#830474}

Bug: 1152214
Change-Id: I4d655c9f9103e560b5e8b5d3c4588601836ce344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556897
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#830473}

This reverts commit ea3a00e5.

Reason for revert: UIDevToolsServerTest.ConnectionToViewsServer crashes three builds in line: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29

Original change's description:
> Enable CertVerifierService by default
>
> This relands commit a79726df and
> commit aae065c3, which fix some
> incompatibilities between the CertVerifierService and some unit tests
> and enable the CertVerifierService feature by default.
>
> The Mac browser tests that caused the reverts are fixed by switching
> SetCertVerifierServiceFactoryForTesting to just set a global
> pointer rather than requiring SequenceLocalStorage which isn't
> available when we need it.
>
> Bug: 1015134, 1094483, 1146899
> Change-Id: I1f60b9a59d19da39b1da2d8f11cc71fb523091cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543199
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830404}

TBR=jam@chromium.org,mpdenton@chromium.org,caitlinfischer@google.com

Change-Id: Ie1da129bfe10c21178dfbab0427c96785a52930a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015134
Bug: 1094483
Bug: 1146899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557278Reviewed-by: Yuki Yamada <yukiy@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830472}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: I8a54ebb8aaf7257a13724fb41315abeef218680e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549022
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830471}

Right now, all generated event classes exist in the
metrics::structured::events namespace. If two events from different
projects have the same name (which is allowed), this will cause errors
in recording. This CL moves the events for each project into a
per-project namespace.

Bug: 1148168
Change-Id: I421fa684efab61096d1b097ddd4efbfb20ef3a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554250Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830470}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: Ie85cdc1829094da969ce7987bff738afe3b1ba96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546668
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830469}

 - Piexloader.load has a catch() to handle all errors: thus throw
   a module failure there, instead of returning a Promise.reject.
 - Add finally() clause: to handle calling imageBuffer.close() if
   needed to free the {?ImageBuffer} resources.
 - No change in behavior.

Bug: 1145029
Change-Id: Id6c50c447dc4ad31e34b7e6338f8c6b3c6a0a1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556885
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830468}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: I50d7dd90d7b7c88130cd0e08ae60b93d48e9237f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551856Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830467}

Roll Chrome Win64 PGO profile from chrome-win64-master-1606143477-736bd7cb1614be7da91ccc5efd0ee5b418913b13.profdata to chrome-win64-master-1606165050-a3d889677a06d0e206b82027c298bfd0cf0af279.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I76ea30d6a9af0cbf535916a5648175682e10c00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556577Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#830466}

The actual logic of getDisplayMode() is in the Java code, and therefore
it is more straightforward if you plumb it through Java WCDA instead of
individually plumbing it through native code.

Especially so since we are trying to implement this for one more
embedder, WebView.

Bug: 1094366
Change-Id: I3d0ae3095ba23a09ebc0f3360ddfc5cd79c32a6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542739
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830465}

This is a reland of 27401214

Test failures on Mac 10.14 don't appear to have anything to do with this change,
because all of the non-experimental Mac bots are passing.

Original change's description:
> Fixes erroneous focus placement on Mac
>
> When using VoiceOver, focus is often erroneously placed in Chrome's toolbar instead of the web contents
> as soon as the user navigates to a new page and after the page has loaded.
> If the page includes logic that moves the focus to a specific item as soon as it loads,
> that logic often has no effect on the location of the VoiceOver cursor.
> For example, after visiting a user's Gmail inbox, VoiceOver often
> neglects to automatically move to the list of emails, even though the page has logic to do that after load.
>
> The same problem often occurs when an iframe is inserted in the page and focus programmatically moves
> to somewhere inside it.
> For example if the user presses "h" and then "c" to focus the list of chat conversations in Gmail
> and then selects and opens one of the conversations, the VoiceOver cursor might not move to the edit field in that conversation.
>
> This patch:
> 1. Removes the logic that prevents the firing of a focus event if the page has not loaded, or has no content.
> A) The page is marked as loaded as soon as the HTML is parsed, i.e. extremely quickly, so in 99% of cases this condition has no effect.
> B) Even if the page is empty, user confusion does not occur, because everything happens too fast.
> I tested with Jaws and NVDA, which were the AT for which this second condition was added in the first place.
> C) This logic of preventing some focus events has caused bugs in the past, so I think simplifying it should
> improve the health of our codebase, given that it doesn't cause any regressions.
> 2. Adds accessibilityFocusedUIElement to BrowserAccessibilityCocoa.
> It was implemented in Views, but was missing from Web.
>
> I suspect that the reason that this patch seems to fix the bug is because
> VoiceOver monitors the load progress on the web contents, and expects a focus event to arrive as soon as the page has loaded.
>
> AX-Relnotes: VoiceOver focus should be in sync with browser focus, if the user has chosen this setting.
>
> R=dmazzoni@chromium.org, abigailbklein@chromium.org
>
> Change-Id: I9ae7b69fc3c7872bbbb39ffdd13562c97b8d1174
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551814
> Auto-Submit: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Abigail Klein <abigailbklein@google.com>
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830186}

Change-Id: I0238bcdd331ee610cc4dd52403699b13f4ba5091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555497Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830464}

This reverts commit 2f8a1a28.

Reason for revert: Causing compile failure with expand_owners.Error: The histogram WebCore.Document.execCommand must have a valid primary owner, i.e. a Googler with an @google.com or @chromium.org email address.

Original change's description:
> Extend expiry of WebCore.Editing.Commands* histogram
>
> This patch extends expiry of WebCore.Editing.Commands* histogram and
> updates owner of WebCore.Editing.* histograms
>
> Bug: 1149518
> Change-Id: I1924e8cf4ed51292a9fb6b940dc25b85f9acbcd8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550325
> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830461}

TBR=yosin@chromium.org,schenney@chromium.org

Change-Id: I0b276c4668d826eb728591b0715452bab645a6b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1149518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556745Reviewed-by: Yuki Yamada <yukiy@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830463}

This reverts commit 0bb526eb.

Reason for revert: DeviceComponentPolicyBrowserTest.ManagedStorage crashes linux-chromeos-rel:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel 

Original change's description:
> ExtensionForceInstallMixin in device_cloud_policy_browsertest
>
> Migrate the device_cloud_policy_browsertest.cc tests to
> ExtensionForceInstallMixin.
>
> Also fix the potential flakiness introduced with crbug.com/1012892: the
> test was relying on the fact that the sign-in screen force-installed
> extensions don't start without the network connectivity, meanwhile this
> behavior was changed and Chrome can now launch apps from the cache. This
> commit fixes this by making the ResultCatcher created early in the test
> setup, rather than in the test body.
>
> Bug: 1090941
> Change-Id: Ibad28e877470e79ae69f30725931d89277005a43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547584
> Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
> Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830317}

TBR=emaxx@chromium.org,hendrich@chromium.org

Change-Id: If1b6e9718074ede9009648fa79330f4ba3def785
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1090941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556889Reviewed-by: Yuki Yamada <yukiy@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830462}

This patch extends expiry of WebCore.Editing.Commands* histogram and
updates owner of WebCore.Editing.* histograms

Bug: 1149518
Change-Id: I1924e8cf4ed51292a9fb6b940dc25b85f9acbcd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550325
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830461}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: Iaf5de85add66159d989977ebd95b47181ffb484f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557260Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#830460}

https://skia.googlesource.com/skia.git/+log/ce0c876ce273..65fb101861ab

2020-11-24 reed@google.com Reland "Always tweak matrix for consistent opt"
2020-11-24 reed@google.com Revert "Always tweak matrix for consistent opt"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC adlai@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: adlai@google.com
Change-Id: I57abef65edddd701159074a0e4cabcb4907d7d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556616Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#830459}

This CL adds the per profile Singleton class FullRestoreService, to
implement the full restore notifications, the restore os settings, and
app launching, app windows restoration.

BUG=1146900

Change-Id: I73f0ffa8a9455ea2c082cf39aeca4652bcc5c135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554577
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830458}

This CL fixes flaky AccessibilityBoundsFixedScrolling test with
adding requestAnimationFrame() to get the update location after
kLayoutComplete.

Bug: 1136662
Change-Id: Idd0c8b3bad2b168ccdd0a90607300e76b13efa25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544323
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830457}

Bug: 1110772
Change-Id: I8ce5823e6a1d954f20ca2c691b7a88186dbe7a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550339
Commit-Queue: John Palmer <jopalmer@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830456}

This is a reland of fb01b080

Original change's description:
> Reland "desks: Enable enhanced desk animations by default."
>
> This is a reland of 3a6b8b82
>
> Original change's description:
> > desks: Enable enhanced desk animations by default.
> >
> > Enabling also exposed a DCHECK where the throughput tracker was being
> > Stopped when it was not started. This was previously missed, because
> > manual testing was all done on a device, where DCHECKs were disabled.
> >
> > Bug: 1148923
> > Test: none
> > Change-Id: I9c9236f04da072e0a63eb118db0969716a71ffdd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537131
> > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#828916}
>
> Bug: 1148923
> Change-Id: I999cdefe0685c0f086abe67dd6db76232817df96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551133
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830415}

Bug: 1148923
Change-Id: Icfa9c2b67d38aef6e513cd80f7f7dd59c858a1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556559Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830455}

This fixes more than 300 tests when LayoutNGFullPositionForPoint is
enabled. Such as:

  accessibility/menu-list-open.html
  editing/input/textcontrol-doubleclick-at-end.html
  editing/pasteboard/drag-drop-copy-text.html
  editing/selection/drag-drop-events.html
  editing/spelling/context_click_select_misspelling.html
  external/wpt/css/CSS2/normal-flow/blocks-026.xht
  external/wpt/css/css-flexbox/hittest-before-pseudo.html
  external/wpt/html/dom/elements/global-attributes/dir_auto-input-EN-L.html
  fast/css/hover-affects-ancestor.html
  fast/dom/focus-navigation-in-plugin.html

Bug: 1150362
Change-Id: I30028d682c40aceacc986cd40741a7a14c57810c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552799
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830454}

If none of the children of a fragment are hit-test candidates, we need
to lower the bar somewhat, and also consider other children, as long as
they are visible, and either have children on their own, or are block
containers. This logic is copied from LayoutBox::PositionForPoint().

This fixes editing/selection/selectstart-event-crash.html when
LayoutNGFullPositionForPoint is enabled.

Bug: 1150362
Change-Id: I1a8f38c2ebec2e39f07b2f0e4008bb6393ee6241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552591
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830453}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=pbommana@chromium.org

Change-Id: I322c004492050f415d8d11605ecdf0bd3f1ef4ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556660Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#830452}

Bug: None, dawn:424, dawn:431
Change-Id: Iece0d46de9cda041a628c4d8440fe8ed3119b653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552211Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830451}

We may end up here when called from
LayoutNGBlockFlowMixin::PositionForPoint() (when there are only
floated or out-of-flow positioned children, and no line boxes). But
allowing the new code to be executed when LayoutNGFullPositionForPoint
isn't enabled was a mistake. Revert to behaving the way we did prior to
CL:2485219.

Bug: 1150362
Change-Id: Ie13a064d86e9e84b5f53984456339ca74134054f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552594
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830450}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/432bf817a437..60b0ce5c4a44

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yukiy@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1149612
Tbr: yukiy@google.com
Change-Id: Id2ae4c51ec91699345be7f61ec4985e5d9f4b43d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556614Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#830449}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with
is_chromeos_ash with some special cases (For those cases please
refer to http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: I85995f356c2cd54a3911e39c96ba739f2988768f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550964Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830448}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with
is_chromeos_ash with some special cases (For those cases please
refer to http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: Id9ada579d9d6cf3cd6ddacedb3091adddaf7bd6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550148Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830447}

Fixes the issue where a glimpse of stale zero-prefix matches are shown
until fresh ones arrive.

Fixed: 1129368
Change-Id: I7d201314e418e7c3c71c59aed2ad831f3a772cc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556461Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830446}

The code would previously convert incoming GpuMemoryBuffer-based video
frames in NV12 format to I420. This CL changes the code to feed the
mapped NV12 image directly into the libvpx encoder, which now supports
NV12 natively.

Bug: 1126811
Change-Id: I39a7162beabdb12c6fbccd00000476f3e040e3ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545374
Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830445}

Following the recent mojofication of the CreateChildFrame message, the
only messages left in RenderFrameMessageFilter are plugin-related
messages.

This CL includes the following:
1. Removing unnecessary dependencies and state from
   RenderFrameMessageFilter (e.g.: ResourceContext).
2. Only build RenderFrameMessageFilter in plugin-enabled builds (and
   remove "#if ENABLE_PLUGINS" blocks).
3. RenderProcessHostImpl only instantiates the filter when plugins are
   enabled, and no longer keeps a reference to the filter.
4. Remove some declarations that were unused and have no definitions.
5. Remove some unused includes of render_frame_message_filter.h.

Change-Id: I3c8364bcdd102d811900b1929f771ff9779ea449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550149
Commit-Queue: Tal Pressman <talp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830444}

The only prod impl of InputMethodManager::GetSupportedInputMethods()
always returns an empty list which implies no-ops at callsites. The
existence of this method is thus completely unnecessary.

Some for-test impls of InputMethodManager::GetSupportedInputMethods()
do return stuff, but use allowlist::GetSupportedInputMethods() [1]
that's based on kInputMethods autogen'd from legacy deprecated
input_methods.txt [2] by gen_input_methods.py [3]. This CL replaces
such usage of input_methods.txt with test data, effectively making
related tests more hermetic.

This refactoring further reduces usage of legacy input_methods.txt
(remnant from before the migration to extension-based input methods
circa 2011), towards its full deprecation and removal. Nowadays the
canonical source-of-truth configs for 1P input methods on Chrome OS
is google_xkb_manifest.json [4].

[1] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/ime/chromeos/input_method_allowlist.cc;l=24;drc=0c6b25ab44b47df2e954ad588f5b518a53ac4c20
[2] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea
[3] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/gen_input_methods.py;drc=0303b222088853ce1c0af2bbc7f47937746eda97
[4] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json;drc=03ae97c2c311ac00d3e9a59203f4921c9e87e707

Bug: 1134526
Change-Id: Ie04e9b2140cd681bcb81fc166d4c184f7b490257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546204Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830443}