- 14 Dec, 2017 40 commits
-
-
danakj authored
This reverts commit 1050c3ac. Reason for revert: Did it's job. Original change's description: > Look for why ChromeOS bots are flakily using software compositing. > > This adds some NOTREACHED() on ChromeOS to figure out why tests are > disabling gpu compositing. > > R=zmo@chromium.org > > Bug: 793303 > Change-Id: I6ee99fc334c34c292bcb1e3568108e422d43da4c > Reviewed-on: https://chromium-review.googlesource.com/826382 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523958} TBR=danakj@chromium.org,zmo@chromium.org Change-Id: I439a4775e1dfa9329da9cbbd416a4bad11bd71e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 793303 Reviewed-on: https://chromium-review.googlesource.com/827142Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#524081}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c617901..327c9d94 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4680fca86bd30e7721b8de4dee8725e9797bb22a Reviewed-on: https://chromium-review.googlesource.com/827024Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524080}
-
Allen Bauer authored
Per this comment on linked bug: https://crbug.com/651643#c62 Bug: 651643 Change-Id: Ic90a7a83232d4c3eace025872ef839d68d68d45c Reviewed-on: https://chromium-review.googlesource.com/823083Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524079}
-
Shivani Sharma authored
This CL adds a browser test that tests that globally allowing ads should work as expected. We had a unit test for this earlier but not a browser test. Bug: Change-Id: Ieb43a5512eb5c54a94fee79f7d39fe8d51c6796f Reviewed-on: https://chromium-review.googlesource.com/826165 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#524078}
-
kylechar authored
These tests were failing because of a flag not being passed. Try enabling on FYI. TBR: jonross@chromium.org Bug: 793302 Change-Id: Ic780a2545199c7c7d81014f3650c95de1b19f57c Reviewed-on: https://chromium-review.googlesource.com/827027Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524077}
-
Justin Novosad authored
BUG=793667 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifc75e2d1545346cf618a6a2303dc659369040674 Reviewed-on: https://chromium-review.googlesource.com/824983Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524076}
-
Mike West authored
Bug: 794098 Change-Id: I7f2e05edcf08b67b09a00a6707857d38a0d2028e Reviewed-on: https://chromium-review.googlesource.com/827007 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#524075}
-
Morten Stenshorne authored
This is a reland of 4e246b2e Original change's description: > [LayoutNG] Don't let legacy layout re-enter layout of a scrollable block node. > > We'd end up re-entering NGBlockNode::CopyFragmentDataToLayoutBox() for > the same node. > > After layout of a fragment, NGBlockNode::CopyFragmentDataToLayoutBox() would > call LayoutBlock::UpdateAfterLayout(), which would call > scrollbar was toggled, it'd go ahead and call UpdateLayout() on the object, > which would take us back into the NG layout machinery, on the same node, via > Finally we'd re-enter NGBlockNode::CopyFragmentDataToLayoutBox(), causing misc > kinds of misery, such as not being able to paint the block at all. For > multicol, there'd even be a DCHECK failure "Variable fragment inline size not > supported", because the code got confused as to whether a fragment was a first > fragment or not. > > LayoutBox: :UpdateAfterLayout(), which would call > PaintLayer: :UpdateSizeAndScrollingAfterLayout(), which would call > PaintLayerScrollableArea: :UpdateAfterLayout(). If this code detected that a > LayoutNGBlockFlow: :UpdateBlockLayout(), further to NGBlockNode::Layout(). > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I832372223e324682bb4e38b3177dce30093df2e1 > Reviewed-on: https://chromium-review.googlesource.com/824265 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524039} TBR=eae@chromium.org Change-Id: I5aceb5c45c8fa60b20fa481318f05c609ca2b46b Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/826985Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#524074}
-
Miguel Casas-Sanchez authored
Our code search doesn't linkify crbug[.com] if they are not prefixed with http[s]:// (e.g. [1]). This CL adds a warning on upload that this is happening and suggests prefixing https://, since it seems like we are not going to be able to linkify them automatically in CS anytime soon (see bug). It looks a bit like: ** Presubmit Warnings ** Found unprefixed crbug.com URL(s), consider prepending https:// ui/ozone/platform/drm/gpu/gbm_buffer.h:107 // TODO(mcasas): crbug.com ui/ozone/platform/drm/gpu/gbm_buffer.h:108 // TODO(mcasas): crbug/123 [1] https://cs.chromium.org/chromium/src/BUILD.gn?type=cs&q=crbug.com&sq=package:chromium&l=65 Bug: 762061 Change-Id: Ib58bc6b58dfa61a7bf421b0ed55184705cee767c Reviewed-on: https://chromium-review.googlesource.com/822973Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#524073}
-
David Bokan authored
VisualViewport:pageLeft and pageTop returns the visual viewport's offset from the document origin. This means it's a combination of the layout viewport's offset and the visualViewport's offset within the layout viewport. Currently, this uses the effective root scroller as the layout viewport. However, this can be used to leak information through a cross origin iframe and will break down for OOPIFs. The sensible thing to do here is to redefine these values to always use the original layout viewport. Bug: 505516 Change-Id: I616d497cc6f1ebe003ff48701da3d6691dc38326 Reviewed-on: https://chromium-review.googlesource.com/806479Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524072}
-
Marc Treib authored
This info is already sent in NavigationEntryCommitted, which covers all relevant cases. No need to re-send almost immediately. Bug: none Change-Id: I125b8dd53a2c487c129cee98eb2d09527394263a Reviewed-on: https://chromium-review.googlesource.com/827071Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#524071}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9daae51c4ad8..63789ccc03f6 $ git log 9daae51c4..63789ccc0 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 mtklein Revert "Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB" 2017-12-13 kjlubick Disable extra CPUs during Nanobench 2017-12-13 rmistry [Infra] Automatically submit docs updates 2017-12-12 update-docs Update markdown files 2017-12-13 rmistry [Infra] Fix skiaserve source location again 2017-12-13 brianosman Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB 2017-12-13 robertphillips Add GrBackendTexture & GrBackendRenderTarget access methods to GrTexture and GrRenderTarget 2017-12-13 liyuqian Add strip 2pt conical GM Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ied30e2d339414d1eb2772d5a837c8870a2cd1053 Reviewed-on: https://chromium-review.googlesource.com/826563Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#524070}
-
Tom Anderson authored
Failing runs on Linux Tests: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65554 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65557 BUG=792739 R=jonross@chromium.org Change-Id: I7e1c151f5eaa108c4416a681d22d26884493ec6a Reviewed-on: https://chromium-review.googlesource.com/826462 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524069}
-
Shanfeng Zhang authored
Bug: None Change-Id: Ie29f7c76a60ec8b7f4c0b383fe8ca3eb6ed009a2 Reviewed-on: https://chromium-review.googlesource.com/826246Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#524068}
-
Daniel Bratell authored
In jumbo builds symbols with the same name that end up in the same translation unit might clash even if they don't normally clash. That was the case with a couple of constants in the ui/base clipboard code for X11. This patch shares some of the constants (the ones with the same value) and renames the remaining one. Bug: 773275 Change-Id: I718cecdf5e490de17217962767322f3c847a3e53 Reviewed-on: https://chromium-review.googlesource.com/824522Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#524067}
-
Xi Han authored
Currently the offline dialog only handles ERR_INTERNET_DISCONNECTED error, and we would like it to catch up more network errors. A generic message is added to shown on the dialog. Bug: 789566 Change-Id: I9c36319241f8754822e6336eca8ae13379edc764 Reviewed-on: https://chromium-review.googlesource.com/803835 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#524066}
-
Francois Doray authored
Having a single TabManager initialization path in TabManagerTest will simplify adding common initialization code in an upcoming CL. Bug: 775644 Change-Id: Icb648e1591127a1a5f4acf847208cd53e2dfb278 Reviewed-on: https://chromium-review.googlesource.com/820201Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#524065}
-
Louis Romero authored
To be able to roll MDC, we'll temporarily build MDFInternationalization as a framework. This is the first CL out of 3 CL, including one downstream. Bug: 785248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibbacbca687316252e28be985a7952b5449b164bb Reviewed-on: https://chromium-review.googlesource.com/825202Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#524064}
-
Daniel Bratell authored
Jumbo is a unity build system for Chromium, aimed at dramatically reducing the compilation times. So far support has been added to blink, v8, content/browser and a few smaller targets, reducing the effort by about half. How that maps to real time depends on hardware. It scales proportionally for 4 core/8 thread machines, but not in 48 core machines or in goma. The effort to compile content/renderer in a use_jumbo_build=true build is right now about 6% of the total effort when compiling chrome+content_shell+blink_tests. That is about 51 CPU minutes on the test hardware. With jumbo that can be brought down to 6-7 CPU minutes, saving about 5 minutes real time on a 4 core/8 thread machine for every full compilation. Part of the support is to split away IPC code generation since its macro based design isn't compatible with jumbo. See comment in the code for more information. Bug: 746953 Change-Id: If0cfe05986cdfbdd4974f03119c46c3493f6c63e Reviewed-on: https://chromium-review.googlesource.com/822417 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524063}
-
Gauthier Ambard authored
This CL creates a OmniboxPopupCoordinator and boxes the ViewController, mediator and presenter inside. For now the coordinator is still owned and activated by the OmniboxPopupViewIOS. In future CL the coordinator will own the OmniboxPopupViewIOS. Bug: 762597,788640 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ief006d3c8e8668824111fd513d249dc90be51d1e Reviewed-on: https://chromium-review.googlesource.com/824664Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524062}
-
Mostyn Bramley-Moore authored
orientation_quaternion_fusion_algorithm_using_euler_angles.cc and orientation_euler_angles_fusion_algorithm_using_quaternion.cc both contain GetFusedType and GetSourceType constexpr's with the same argument type, which conflict in jumbo builds. Let's rename them both. BUG=794692 Change-Id: I707873b5e554dba9a98df27a2a5554e355a275c9 Reviewed-on: https://chromium-review.googlesource.com/825862 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#524061}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9af765dd2e44..9d4d7f06facb $ git log 9af765dd2..9d4d7f06f --date=short --no-merges --format='%ad %ae %s' 2017-12-07 oetuaho Classify TSymbols using an enum Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I22d01ab539400963facf9d1cd10bcd15a1709f33 Reviewed-on: https://chromium-review.googlesource.com/826698Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524060}
-
Guido Urdaneta authored
This reverts commit 3d9bdee7. Reason for revert: Speculative revert as we've seen regressions in decode time for WebRTC sessions. Please contact stefan@webrtc.org for more details. Original change's description: > Roll src/third_party/libvpx/source/libvpx/ cbe62b9c2..14dbdd95e (25 commits) > > https://chromium.googlesource.com/webm/libvpx.git/+log/cbe62b9c2d2b..14dbdd95e686 > > $ git log cbe62b9c2..14dbdd95e --date=short --no-merges --format='%ad %ae %s' > 2017-11-29 jianj Add frame width & height to frame pkt. Add test. > 2017-12-06 marpan vp9-svc: Set downsampling filter for VGA layer. > 2017-12-06 marpan vp9: Nonrd-pickmode: move some early exits up. > 2017-12-01 marpan vp9-svc: Allow for nonzero motion on spatial reference. > 2017-11-28 huisu Add max luma picture width/height constraint in VP9 level > 2017-12-01 johannkoenig filter out asm includes > 2017-12-01 johannkoenig explicitly label .text sections > 2017-12-01 johannkoenig nasm defaults to -Ox > 2017-12-01 johannkoenig pass 'win64' instead of 'x64' to the assembler > 2017-12-01 marpan vp9-svc: Set num_inter_modes in non-rd pickmode. > 2017-12-01 yinshiyou-hf vpx_dsp: [loongson] optimize variance v2. > 2017-11-30 marpan Nonrd-pickmode: avoid duplicate computation of UV predictor. > 2017-11-30 jzern decouple spatial-svc from encoder abi > 2017-11-29 marpan Fix to copy partition. > 2017-11-29 marpan vp9-svc: Don't allow encode_breakout on golden ref. > 2017-11-29 marpan vp9-svc: Clean conditon for allowing copy_partition. > 2017-11-29 kylesiefring Remove unnecessary includes of emmintrin_compat.h > 2017-11-29 yinshiyou-hf vp8: [loongson] optimize regular quantize v2. > 2017-11-29 kaustubh.raste mips msa optimize vpx_scaled_2d function > 2017-11-29 yinshiyou-hf vp8: [loongson] optimize vp8_short_fdct4x4_mmi v2. > (...) > > Created with: > roll-dep src/third_party/libvpx/source/libvpx > R=johannkoenig@google.com > > BUG=webrtc:5749 > > Change-Id: I2e26d723eaffb7fb999f4d1d77ea678519f0ef50 > Reviewed-on: https://chromium-review.googlesource.com/813088 > Reviewed-by: Johann Koenig <johannkoenig@google.com> > Commit-Queue: Jerome Jiang <jianj@google.com> > Cr-Commit-Position: refs/heads/master@{#522479} TBR=johannkoenig@google.com,jianj@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:5749 Change-Id: Ief68207a88a516ee0470078f7f7f02f711f8f6ef Reviewed-on: https://chromium-review.googlesource.com/826983 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#524059}
-
Marti Wong authored
Fix the issue that when editing the new folder name on iPad and tap on the 'hide keyboard' button, the folder name is supposed to commit but doesn't. An egtest is added to prevent this bug from happening again. Bug: 794155 Change-Id: Ie0ef4c1af7f87c55051876bd08331c5d0a0e40a8 Reviewed-on: https://chromium-review.googlesource.com/826585Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#524058}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c8aaa8d..2c617901 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6518fb5b1ca215e5babc7a37291298de63b29d3b Reviewed-on: https://chromium-review.googlesource.com/826285Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524057}
-
Max Morin authored
After https://chromium-review.googlesource.com/c/chromium/src/+/771196, the interface MojoAudioInputIPC should conform to is slightly different than originally expected. This CL updates it to fit the new interface. Bug: 653871 Change-Id: Iea76d3033087742a93943fad94a8875c12459236 Reviewed-on: https://chromium-review.googlesource.com/806222 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#524056}
-
Robert Flack authored
This reverts commit 9966b73a. Reason for revert: I suspect this caused the compile failure here: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20(dbg)/116281 Original change's description: > [oilpan] Move incremental marking behind a build-time flag > > Move Oilpan's incremental marking work behind a build-time flag > enable_blink_heap_incremental_marking > > Bug: chromium:757440 > Change-Id: Id4adddcf0669dc165935eced90e8caefbb76a094 > Reviewed-on: https://chromium-review.googlesource.com/822492 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524051} TBR=jbroman@chromium.org,dpranke@chromium.org,haraken@chromium.org,mlippautz@chromium.org Change-Id: I15da11c96b51ede50f4fb0742d6859117b2d4175 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:757440 Reviewed-on: https://chromium-review.googlesource.com/826699Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524055}
-
Henrik Grunell authored
TBR=sunyunjia@chromium.org Bug: 664858 Change-Id: I8d7332fdb6755347177fcf7e736e0d7f4d6e533d No-Try: true Reviewed-on: https://chromium-review.googlesource.com/827016Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524054}
-
Manuel Rego Casasnovas authored
BUG=767015 Change-Id: Id56937cba12dcec0959c6cc78aa83cbde25bea74 Reviewed-on: https://chromium-review.googlesource.com/826639Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#524053}
-
Robert Flack authored
By spec (https://www.w3.org/TR/css-position-3/#sticky-pos) a sticky position offset can cause overflow but must be capable of being scrolled to. Despite not working in Chrome yet this adds web platform tests for this. BUG=752022 Change-Id: I3bc8b384e4459cd4d1498f64c376e764fba71091 Reviewed-on: https://chromium-review.googlesource.com/825165Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524052}
-
Michael Lippautz authored
Move Oilpan's incremental marking work behind a build-time flag enable_blink_heap_incremental_marking Bug: chromium:757440 Change-Id: Id4adddcf0669dc165935eced90e8caefbb76a094 Reviewed-on: https://chromium-review.googlesource.com/822492 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524051}
-
Henrik Grunell authored
TBR= kaznacheev@chromium.org Bug: 794703 Change-Id: I0a8df88bc3b2e911cafdb05230336e2cc2aa04d3 Reviewed-on: https://chromium-review.googlesource.com/827011Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524050}
-
Tatiana Gornak authored
Copy icon from xml isn't displayed. FReverting to using png while figuring out why this is happening. Bug: 788943 Change-Id: Ic2941708a27bfe1019b85db16bbf9fe8bc2137b0 Reviewed-on: https://chromium-review.googlesource.com/803278 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#524049}
-
Henrik Grunell authored
TBR= lwchkg@chromium.org Bug: 794821 Change-Id: Ie3fc909acee14e5bf8b8b80e8c8e0e2b3bf45945 Reviewed-on: https://chromium-review.googlesource.com/827006Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524048}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 00c23f03. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7692 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: I76bf3bfa205dd1ae5e38266db56b13b80c35aa35 Reviewed-on: https://chromium-review.googlesource.com/826384 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524047}
-
josyulavn authored
Refactor V8ScriptRunner & AbstractEventlistener to make v8::Isolate* as first parameter BUG=424446 Change-Id: I6349a8699efb3e69e27b91a313167f310c1219dc Reviewed-on: https://chromium-review.googlesource.com/826765Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#524046}
-
Henrik Grunell authored
This reverts commit 4e246b2e. Reason for revert: Likely to be the reason for breakage of virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html Original change's description: > [LayoutNG] Don't let legacy layout re-enter layout of a scrollable block node. > > We'd end up re-entering NGBlockNode::CopyFragmentDataToLayoutBox() for > the same node. > > After layout of a fragment, NGBlockNode::CopyFragmentDataToLayoutBox() would > call LayoutBlock::UpdateAfterLayout(), which would call > scrollbar was toggled, it'd go ahead and call UpdateLayout() on the object, > which would take us back into the NG layout machinery, on the same node, via > Finally we'd re-enter NGBlockNode::CopyFragmentDataToLayoutBox(), causing misc > kinds of misery, such as not being able to paint the block at all. For > multicol, there'd even be a DCHECK failure "Variable fragment inline size not > supported", because the code got confused as to whether a fragment was a first > fragment or not. > > LayoutBox: :UpdateAfterLayout(), which would call > PaintLayer: :UpdateSizeAndScrollingAfterLayout(), which would call > PaintLayerScrollableArea: :UpdateAfterLayout(). If this code detected that a > LayoutNGBlockFlow: :UpdateBlockLayout(), further to NGBlockNode::Layout(). > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I832372223e324682bb4e38b3177dce30093df2e1 > Reviewed-on: https://chromium-review.googlesource.com/824265 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524039} TBR=eae@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org Change-Id: Idf7eb66a284cb73c4c62217725ef02a9538494a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/826984Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524045}
-
Patrik Höglund authored
This reverts commit 53ccc526. Reason for revert: Now has diagnostic uploading, so we'll at least be able to tell why it fails if it's still failing. I've also tried tweaking the sound config on the machine. Bug: chromium:677256 Change-Id: I96cdf15eff0b9d1e09053560ac5e4c518abc5caa Reviewed-on: https://chromium-review.googlesource.com/826942Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#524044}
-
Mostyn Bramley-Moore authored
There are several kEpsilon constants defined in //services/device/generic_sensor which conflict in jumbo builds. To avoid this, we can move the definition to generic_sensor_consts.h. BUG=794692 Change-Id: Ib31f20957fc8cccab59abb36779fccff9491239e Reviewed-on: https://chromium-review.googlesource.com/826062Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#524043}
-
Daniel Bratell authored
To avoid clashes between test data variables and similar changes, this patch puts tests that would collide in custom namespaces following a pattern used successfully in Blink. Bug: 746953 Change-Id: I49b9d127c513ead92c4743d6e5701b80a91db69e Reviewed-on: https://chromium-review.googlesource.com/824268 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524042}
-