GitLab

This test has become flaky lately:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Findexeddb%2Fupgrade-events.html&testType=webkit_tests

TBR=tmartino

Bug: 735259
Change-Id: I352e6a27368a95750b1bd2dd6902ce16d328fd0d
Reviewed-on: https://chromium-review.googlesource.com/542036Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481072}

Bug: 732898
Change-Id: I411932f8a835a5b0144040f62b71454a16f7a1ac
Reviewed-on: https://chromium-review.googlesource.com/541858Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481071}

Introduce a Mojo struct LoginUserInfo for login users which include
basic information ash::mojom::UserInfo and other login/lock
screen specific information.
UserSelectionScreen will populate LoginUserInfo and send it back to lockscreen views.
Compare to the user info we sent to current UI, LoginUserInfo have almost everything except:
1. user's gaiaId, which doesn't seem to be used by current UI.(user_pod_row.js)
2. public session information which doesn't exist on lockscreen.
We might need it for login screen later and I have added a TODO for this.

BUG=729687

Review-Url: https://codereview.chromium.org/2937553002
Cr-Commit-Position: refs/heads/master@{#481070}

The current IME is always in the list of available IMEs, so just send
its ID.

Also get rid of ash::ImeInfo.selected since that can be inferred by
comparing the ID of an IME to the current ID.

Also cleanup some test init code in ImeControllerClientTest.

Bug: 724305
Test: ash_unittests and chrome unit_tests
Change-Id: Id830048980728e30c6ae39acd833e26beb83ff64
Reviewed-on: https://chromium-review.googlesource.com/540665
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481069}

It's difficult to figure out why the crashes are being seen, so add
explicit checks that will help track down the cause.

These will be removed before the next branch point.

BUG=733096

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic073fb288ff4084614142ff802e9a93457241c6a
Reviewed-on: https://chromium-review.googlesource.com/540781Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481068}

Move class DraggedNodeImageBuilder, DataTransfer::NodeImage(),
DataTransfer::DeviceSpaceBounds(), DataTransfer::CreateDragImageForFrame()
to DataTransfer.cpp.
Move DragController::DragImageForSelection() to DragController.cpp.

BUG=727981

Review-Url: https://codereview.chromium.org/2950793002
Cr-Commit-Position: refs/heads/master@{#481067}

This reverts commit afc31e81.

Reason for revert: WebKit_Win_x64_Builder_dbg failure

Original change's description:
> [SPv2] Rework GeometryMapper transform computation
> 
> When computing the conversion matrix between two spaces, there are two
> types of conversion that are commonly used, but with slightly different
> semantics:
> 
> m1 = destination_to_screen ^ -1 * source_to_screen
> m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen)
> 
> The former computes the space conversion, which is useful for mapping
> 3D points from one space to 3D points in another space. The latter
> computes the "projection through screen", which is useful for mapping
> 2D points from a plane to a backing that is expected to be drawn onto
> the screen.
> 
> To illustrate the difference, see the following example:
> <div style="transform:rotateY(45deg)">A</div>
> <div style="transform:rotateY(-45deg)">B</div>
> 
> The space conversion from A to B is equal to rotateY(90deg), but the
> projection between the two planes is identity.
> 
> Prior to this CL, GeometryMapper implemented a mixed semantics. This is
> okay because all existing code only make queries that are co-planar, in
> which case, either version returns identical result. This is because we
> only make intra-compositing-layer queries, and 3D transform makes a
> compositing boundary.
> 
> This CL changed the implementation to strictly return the "projection
> through screen". The algorithm runs in amortized O(1) by caching the
> matrix between a node and its nearest coplanar ancestor that has a
> invertible projection.
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93
> Reviewed-on: https://chromium-review.googlesource.com/534899
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481049}

TBR=trchen@chromium.org,chrishtr@chromium.org

Change-Id: I0d89ddadaa7889dd43705f9e7c0ef2876afafec2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/541943Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481066}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1556ddcf20a1..a64c010c74cc

$ git log 1556ddcf2..a64c010c7 --date=short --no-merges --format='%ad %ae %s'
2017-06-20 benjhayden Categorize diagnostics in how-to-write-metrics.md.
2017-06-20 erikchen Move symbolize_trace from tracing/bin to tracing/tracing/extras/symbolizer.

Created with:
  roll-dep src/third_party/catapult
BUG=734852


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iaffc9cdd2e7aa37a482dce08c4bde5dd233dfad1
Reviewed-on: https://chromium-review.googlesource.com/541922
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481065}

The context for this change is to allow FindIt, which only speaks GTest,
to run run-webkit-tests.

Bug: 650747
Change-Id: Ic4930cda309395f1a19a619a701140909f6f296c
Reviewed-on: https://chromium-review.googlesource.com/541757
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481064}

[Telemetry] Move oopif, tab_switching, tracing, v8, and cluster telemetery benchmarks to story expectations
TBR=charliea@chromium.org

Bug: 713222
Change-Id: I6b4a71f0212b12cb31f0f53632aca36bef9e6c2d
Reviewed-on: https://chromium-review.googlesource.com/541587Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481063}

The approach ends up pretty close to what's already done for Windows.

On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more
often match what native UI does) and requires RenderTextHarfbuzz to do
less work. However, it doesn't guarantee that the returned font can
display every glyph in the provided string.

So still use CTFontCopyDefaultCascadeListForLanguages (which is now a
public API - hooray) to provide a last-resort list of fallback fonts.

BUG=696867, 619684

Review-Url: https://codereview.chromium.org/2927953003
Cr-Commit-Position: refs/heads/master@{#481062}

https://pdfium.googlesource.com/pdfium.git/+log/e10509a3d2a1..222e1a425e2d

$ git log e10509a3d..222e1a425 --date=short --no-merges --format='%ad %ae %s'
2017-06-20 thestig Use early returns in more CPDFSDK_FormFillEnvironment code.
2017-06-20 npm Cleanup fpdf_parser_decode
2017-06-20 drgage Add FORM_GetSelectedText() function.
2017-06-20 thestig Add sample PDF with comboboxes.

Created with:
  roll-dep src/third_party/pdfium
BUG=59266


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I2204c2ba8126e518115d094200db4b44c6042a8e
Reviewed-on: https://chromium-review.googlesource.com/541859
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481061}

BUG=735145

Review-Url: https://codereview.chromium.org/2949903002
Cr-Commit-Position: refs/heads/master@{#481060}

BUG=734265

Review-Url: https://codereview.chromium.org/2711543002
Cr-Commit-Position: refs/heads/master@{#481059}

Generated by script:
grep -rli "lunalu" * | xargs -i@ sed -i 's/lunalu/loonybear/g' @

Change-Id: I022674b4e6dd8a30380539c38ff1dd949f92ade8
Reviewed-on: https://chromium-review.googlesource.com/533853Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481058}

This is follow-up patch of the patch[1] which introduces |InSameLine()| to
return wrong value for nodes without layout object.

Original code:
while (node && !node->GetLayoutObject() || InSameLine(...)

The patch[1]:

while (InSameLine(node, ...)

InSameLine(Node* node)
  if (!node->GetLayoutObject())
    return false;  // This is wrong. This patch fixes this error.

[1] http://crrev.com/2938923003: Introduce InSameLine() with Node and
VisiblePosition

BUG=734648
TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone

Review-Url: https://codereview.chromium.org/2952563002
Cr-Commit-Position: refs/heads/master@{#481057}

This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving
code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing
const-variable for improving readability.

Note: The diff could be small but changing indentation makes diff larger.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2950763002
Cr-Commit-Position: refs/heads/master@{#481056}

ShouldAutoDetect(), DetectTextEncoding() and SetEncoding() calls and
references to hint_* members are always coupled.
This CL moves these code to AutoDetectEncodingIfAllowed() to make
it clear that these are always coupled and executed only for
|kUseAllAutoDetection|.

Bug: 725654, 732893
Change-Id: Ia5a295bb2f600a4566f28738d421266ebb900343
Reviewed-on: https://chromium-review.googlesource.com/540179
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481055}

Apply switches as previosuly discussed so we easily turn off
language detection logging or translation logging if something
goes wrong.

BUG=728491, 722679

Review-Url: https://codereview.chromium.org/2941953002
Cr-Commit-Position: refs/heads/master@{#481054}

We applied too much abstraction to the logic to retrieve, or to compute
if required, the grid item's margin so it was flow-aware. However, we
don't need to apply such abstraction when accesing data that depends
only on the grid item's writing mode.

We are already applying a flow-aware logic to determine whether we need
to use item's logical width or height; for example, we do this during
the track sizing algorithm when computed content-sized tracks.

There is no specific bug associated to this CL, this is just a
refactoring. Hence, no specific additional tests are required.

Change-Id: I0a50d1224588e71f99699be6d7fdbe55952a1db6
Reviewed-on: https://chromium-review.googlesource.com/540595
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#481053}

While my original CL strived to maintain conformity with Chrome, it
turns out that Features names are not at all consistent. Switch to
snake_case, which both supports our legacy features and is more
comfortable for developers. This will avoid the inevitable error in the
backend where a developer uses underscores and fails to activate their
feature.

BUG= b/35424335

Change-Id: Ie2da5666964720c7134e7375189ea84f1e34ea34
Reviewed-on: https://chromium-review.googlesource.com/542035
Commit-Queue: Stephen Lanham <slan@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481052}

Update the icon and the string used for the infobar that shows up when changing
the site settings via the Page Info bubble.

See https://drive.google.com/open?id=0BzEa5HU1aAqBamtNSUlFNTBZM3M for
before/after screenshots of the infobar.

BUG=734831
TEST=Navigate to https://www.google.com/. Open the Page Info bubble by clicking
the "Secure" lock, and change "Location" to "Block". Close the Page Info bubble
and observe the infobar's new string and icon.

Review-Url: https://codereview.chromium.org/2952543002
Cr-Commit-Position: refs/heads/master@{#481051}

https://crrev.com/480682 left behind some includes no longer needed by
mojo bindings to avoid updating clients that relied on those transitive
includes in that CL. This removes those includes and updates those
clients.

TBR=piman@chromium.org,imcheng@chromium.org,emircan@chromium.org

Bug: 678155
Change-Id: Id5ed5671bd58b8c91b3e7cb2edab827e819e1f5b
Reviewed-on: https://chromium-review.googlesource.com/541116
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481050}

When computing the conversion matrix between two spaces, there are two
types of conversion that are commonly used, but with slightly different
semantics:

m1 = destination_to_screen ^ -1 * source_to_screen
m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen)

The former computes the space conversion, which is useful for mapping
3D points from one space to 3D points in another space. The latter
computes the "projection through screen", which is useful for mapping
2D points from a plane to a backing that is expected to be drawn onto
the screen.

To illustrate the difference, see the following example:
<div style="transform:rotateY(45deg)">A</div>
<div style="transform:rotateY(-45deg)">B</div>

The space conversion from A to B is equal to rotateY(90deg), but the
projection between the two planes is identity.

Prior to this CL, GeometryMapper implemented a mixed semantics. This is
okay because all existing code only make queries that are co-planar, in
which case, either version returns identical result. This is because we
only make intra-compositing-layer queries, and 3D transform makes a
compositing boundary.

This CL changed the implementation to strictly return the "projection
through screen". The algorithm runs in amortized O(1) by caching the
matrix between a node and its nearest coplanar ancestor that has a
invertible projection.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93
Reviewed-on: https://chromium-review.googlesource.com/534899
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481049}

Previously, the method was visible, but calling it resulted in a
SecurityError. Now it is simply gone (via [SecureContext] in the IDL).

This brings the implementation in line with the draft spec at
https://wicg.github.io/web-share.

Bug: 734493
Change-Id: Ia246108fd7441f9b93bb0cbcf6a6fda4562d3a55
Reviewed-on: https://chromium-review.googlesource.com/541255
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481048}

dependency will be removed and replaced by ViewTestBase. Appropriate
UIElement trees are also created to test DevTools.

BUG=701835

Review-Url: https://codereview.chromium.org/2899783002
Cr-Commit-Position: refs/heads/master@{#481047}

The Previews infobar should read "Simplified page to save data and load
faster. Options available near bottom of the screen." when shown, rather
than reading the infobar strings.

BUG=732944

Review-Url: https://codereview.chromium.org/2939143002
Cr-Commit-Position: refs/heads/master@{#481046}

Improvements:
* devtools drives the test, not the inspected page
* tests are pure JS
* doc-typed test harness
* improved debugging experience (surround test function with TestRunner.debugTest)

This copies a couple of existing tests - once this infra has been proven,
we'll delete the originals.

Perf:
- Old (66 sec) [0]
- New (45 sec) [1]

[0] src/blink/tools/run_layout_tests.py --repeat-each=100 inspector/console/console-clear.html
[1] src/blink/tools/run_layout_tests.py --repeat-each=100 http/tests/inspector/devtools-js/console-clear.js

BUG=667560

Review-Url: https://codereview.chromium.org/2837083003
Cr-Commit-Position: refs/heads/master@{#481045}

This patch fully removes the dependency from NetworkRequest to
NetworkManager.

R=dgozman,pfeldman
BUG=374557

Review-Url: https://codereview.chromium.org/2921963002
Cr-Commit-Position: refs/heads/master@{#481044}

BUG=723734
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2909533002
Cr-Commit-Position: refs/heads/master@{#481043}

* Remove unsupported 1.5x.
* Removed obsolete  use_125_dsf_for_ui_scaling flag. (it should be always true)
* Added large FHD screen scenario.

BUG=734204
BUG=b/62475614
TEST=Updated unit tests. Manual test on cave with manually teaking the scale.

Review-Url: https://codereview.chromium.org/2945913003
Cr-Commit-Position: refs/heads/master@{#481042}

Converted a LOG_IF to a DLOG_IF to eliminate spam.

BUG=735249

Change-Id: Ic2642d5dc860ad6a43c2a54d1548018611024c84
Reviewed-on: https://chromium-review.googlesource.com/541899Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481041}

these are currently intended to be built using the host toolchain and
used on the host rather than the target; modeled after imagediff.

BUG=695482,732565

Change-Id: I3d95d9526ecef3026bbbaf4a13525cf6add02062
Reviewed-on: https://chromium-review.googlesource.com/540703Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#481040}

In LayoutGeometryMap, when there's a non-uniform step (e.g. when inside
multicol), we fall back on doing it the slow way, i.e. we involve
LayoutObject::MapLocalToAncestor(). The mode flags initially passed from
ClientQuads() will just be echoed here, so we need to make sure that
kUseTransforms is specified.

BUG=683925

Change-Id: I2a6fe83fb1332a19a581203d6c44c6924da3f027
Reviewed-on: https://chromium-review.googlesource.com/541339Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#481039}

Also add self to AUTHORS.

Bug: v8:6504
Change-Id: Ia5bceee91c7589bc53198e69c5623f1a26918c02
Reviewed-on: https://chromium-review.googlesource.com/541718
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481038}

This cl contains the following changes
* API impl of the three shorthand properties (CSSShorthandPropertyAPIOverflow,
 CSSShorthandPropertyAPIFont, CSSShorthandPropertyAPIFontVariant).

* Moved ConsumeFontVariantCSS21 from CSSPropertyParser.cpp to CSSPropertyFontUtils.
- this function is being used by CSSShorthandPropertyAPIFont and also another function
from CSSPropertyParser.cpp.

* Changed CSSPropertyParser.cpp to use the new API parseShorthand for the three properties
above. Additional changes are:
- moved two helper functions (ConsumeSystemFont and ConsumeFont) to be private functions of CSSShorthandPropertyAPIFont.
- removed ConsumeFontVariantShorthand that's no longer needed.

* Added the properties API to BUILD file and CSSProperties.json5.

* Changed AddProperty signature so that "implicit" is now an enum.
- We previously passed on bool literals to this function. This change makes the function follow the style guide.

Diff: https://gist.github.com/810c7e46324ff8db8efb6f34ddfdad42/revisions
Review-Url: https://codereview.chromium.org/2938983002
Cr-Commit-Position: refs/heads/master@{#481037}

This CL replaces ScopedVector with std::vector<std::unique_ptr>
in components/cronet.
ScopedVector is deprecated, see bug.

BUG=554289

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I93ed1cac20093344cc9d46c648f02cb579629794
Reviewed-on: https://chromium-review.googlesource.com/536240
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481036}

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c20

BUG=705816

Review-Url: https://codereview.chromium.org/2950673002
Cr-Commit-Position: refs/heads/master@{#481035}

TBR=wez

Bug: 
Change-Id: I3016dea4130a0020158cb5d0ff610b6c4fa19268
Reviewed-on: https://chromium-review.googlesource.com/541897Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481034}

We currently build Skia with SK_IGNORE_GPU_DITHER, effectively disabling GPU dithering.

Remove the build flag to align Ganesh with the sw rasterizer dithering behavior.

Note: Blink only sets the SkPaint dither flag for gradients at this time.

Aside from the flag change, this CL includes:

  * a handful of trivial layout tests rebaselines
  * some Canvas layout/unit test adjustments (relaxed exact pixel value checks to
    accommodate dithering)
  * a couple of trivial GPU pixel test rebaselines

BUG=731693

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2fc6f8d23272504838c55427c48c4ea7d641deae
Reviewed-on: https://chromium-review.googlesource.com/535714Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Mike Reed <reed@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481033}