GitLab

        Reviewed by David Levin.

        Make MathExtras.h compatible with <cmath>
        https://bugs.webkit.org/show_bug.cgi?id=34618

        * wtf/MathExtras.h: Include <cmath> instead of <math.h>.
        Use "using" as we do elsewhere in WTF for the four functions from <cmath>
        we want to use without the prefix. Later we could consider making the std
        explicit at call sites instead.


git-svn-id: svn://svn.chromium.org/blink/trunk@54388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, build fix.

        Fix for Chromium/Mac after palindromic scrollbar change (54345).

        Covered by many layout tests.

        * platform/chromium/ScrollbarThemeChromiumMac.h:
        (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):


git-svn-id: svn://svn.chromium.org/blink/trunk@54387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
        Updated WebCore/GNUmakefile.am to include needed files in build.

        https://bugs.webkit.org/show_bug.cgi?id=34387

        No new tests.

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@54386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        Misc coding style fixes in Haiku port code.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        No tests needed.

        * platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
        * platform/haiku/DragImageHaiku.cpp: Trailing white space.
        * platform/haiku/FileChooserHaiku.cpp: Sorted headers.
        * platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h

git-svn-id: svn://svn.chromium.org/blink/trunk@54383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/qt/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@54381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        WorkerContext.close() does not work in the chromium port
        https://bugs.webkit.org/show_bug.cgi?id=34551

        Test: Adding new downstream test.

        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::workerContextClosedTask):
        Now shuts down the worker thread when WorkerContext::close() is invoked.

git-svn-id: svn://svn.chromium.org/blink/trunk@54380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

introduced in r54368 skipped because of missing DnD support.

* platform/gtk/Skipped:
* platform/qt/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@54379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add and cleanup return values of signals in view and frame
        https://bugs.webkit.org/show_bug.cgi?id=33484

        Add missing and cleanup return values of web frame and web view signals.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_class_init):

git-svn-id: svn://svn.chromium.org/blink/trunk@54378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Csaba Osztrogonac.

The test has been added with the original patch.
        
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.



git-svn-id: svn://svn.chromium.org/blink/trunk@54377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>

Reviewed by Jon Honeycutt.

* AccessibleBase.cpp:
(AccessibleBase::accSelect):
- Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that 
  aren't beneath listboxes or menupopups.  This was too restrictive since 
  any element can be selectable.
- Correct the misinterpretation of MSDN's stipulation of situations involving 
  adding, removing, and extending selection on single-select elements



git-svn-id: svn://svn.chromium.org/blink/trunk@54376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        Require either libsoup 2.28.2 or 2.29.90.

        * configure.ac:

2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Xan Lopez.

        Conditionalize third party cookie policy for libsoup 2.29.90.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::setCookies):
        * platform/network/soup/DNSSoup.cpp:
        (WebCore::prefetchDNS):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: svn://svn.chromium.org/blink/trunk@54375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Gustavo Noronha Silva.

        Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.

        * platform/gtk/GOwnPtrGtk.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@54374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@54373 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
        https://bugs.webkit.org/show_bug.cgi?id=34520

        Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html

        * dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute
        properties before attributes. Otherwise, copying "checked" property would make the cloned
        node checked, unchecking original (they share a name, and are thus in the same radio group).
        We do want the original to be unchecked, but we also want to know its original state in
        HTMLInputElement::copyNonAttributeProperties().

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties):
        Use setChecked instead of plain assignment to prevent m_checked getting out of sync with
        checkedRadioButtons. Also, copy field related to default checked state, so that m_checked
        won't be overridden when copying attributes.



git-svn-id: svn://svn.chromium.org/blink/trunk@54372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@54371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34613

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::spoolPage): Adjust the GraphicsContext passed to the
  paintContents method so that the World Transform is properly
  positioned to account for margin settings at the time that
  PluginViewWin.cpp processes the drawing operations.



git-svn-id: svn://svn.chromium.org/blink/trunk@54370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and the case when WEBKITLIBRARIESDIR is not set.

Reviewed by Steve Falkenburg.

* win/tools/scripts/auto-version.sh:

git-svn-id: svn://svn.chromium.org/blink/trunk@54369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Oliver Hunt.

WebCore: 

Test: editing/pasteboard/drop-inputtext-acquires-style.html

The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.
        
* dom/Clipboard.h: Added writePlainText pure virtual function.
* editing/Editor.cpp:
(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
* editing/htmlediting.cpp:
(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp
* editing/htmlediting.h:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
* platform/Pasteboard.h:
* platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::writePlainText): Added.
* platform/android/ClipboardAndroid.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writePlainText): Added.
* platform/chromium/ClipboardChromium.h:
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writePlainText): Added.
* platform/gtk/ClipboardGtk.h:
* platform/haiku/ClipboardHaiku.cpp:
(WebCore::ClipboardHaiku::writePlainText): Added.
* platform/haiku/ClipboardHaiku.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writePlainText): Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writePlainText): Added helper function.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added.
* platform/qt/ClipboardQt.h:
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writePlainText): Added.
* platform/win/ClipboardWin.h:

LayoutTests: 

* editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
* editing/pasteboard/drop-inputtext-acquires-style.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@54368 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebLocalizedString() could use an assertion that it is being called on the main thread

Reviewed by Tim Hatcher.

WebKit: 

* WebKit.xcodeproj/project.pbxproj:
Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)

WebKit/mac: 

* Misc/WebLocalizableStrings.m: Removed.
* Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.



git-svn-id: svn://svn.chromium.org/blink/trunk@54367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Nate Chapin.

        Fix bug in V8 convertNPVariantToJValue when converting float and double types
        https://bugs.webkit.org/show_bug.cgi?id=34593

        No new tests, build fix only.

        * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
        (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.

git-svn-id: svn://svn.chromium.org/blink/trunk@54366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        [Chromium] Notify ChromeClientChromium of AccessibilityObject state
        change notifications.
        
        https://bugs.webkit.org/show_bug.cgi?id=34464

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::toChromeClientChromium):
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@54364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        Update comments to better document the possible values of the
        writing direction menu state variables.

        * public/WebContextMenuData.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34424

Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
Reviewed by Gavin Barraclough.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):



git-svn-id: svn://svn.chromium.org/blink/trunk@54362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, build fix for Chromium.

        Revert r54341 ("[v8] Remove clear method from DOM object maps"),
        since it causes the worker tests to fail on Chromium.

        * bindings/v8/DOMData.h:
        (WebCore::DOMData::removeObjectsFromWrapperMap):
        * bindings/v8/DOMDataStore.h:
        (WebCore::ChunkedTable::clear):
        (WebCore::ChunkedTable::clearEntries):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
        (WebCore::removeAllDOMObjectsInCurrentThread):
        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::clear):
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::~WorkerScriptController):


git-svn-id: svn://svn.chromium.org/blink/trunk@54361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@54360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        [GTK] Crashes when an invalid hostname is pre-fetched
        https://bugs.webkit.org/show_bug.cgi?id=34602

        * http/tests/misc/dns-prefetch-control-expected.txt:
        * http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.
2010-02-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Crashes when an invalid hostname is pre-fetched
        https://bugs.webkit.org/show_bug.cgi?id=34602

        * platform/network/soup/DNSSoup.cpp:
        (WebCore::prefetchDNS): NULL-check the SoupURI that is created
        from the hostname; that will happen for invalid hostnames.

git-svn-id: svn://svn.chromium.org/blink/trunk@54359 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add Windows expected results to the new scrollbar test because Windows was trying
to compare to platform/mac first instead of cross-platform.

* platform/win/fast/events/scrollbar-double-click-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@54358 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Qt] QtLauncher cleanup.

Refactor option handling out in utility functions and make the
arguments more Qt compatible.

* QtLauncher/main.cpp:
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
* QtLauncher/utils.cpp:
(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
* QtLauncher/utils.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34545

Reviewed by Adam Roben.

* WebFrame.cpp:
(scaleFactor): Require the margin information as an input
  parameter, and use them when computing the scaling factor.
(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):
  1. Pass margin size to scaleFactor.
  2. Recognize that the return value of printerMarginRect is
     already in device units, and therefore scale it so that
     the Cairo drawing is correct.
  3. Remove scaling call for margins in GDI code, as it is
     already in scaled units.



git-svn-id: svn://svn.chromium.org/blink/trunk@54356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        [Gtk] webkitgtk crashed when Orca open
        https://bugs.webkit.org/show_bug.cgi?id=34463

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (textForObject):
        Checking if render objects are texts before calling toRenderText

git-svn-id: svn://svn.chromium.org/blink/trunk@54355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        Bump minimum libsoup requirement to 2.29.90

        * configure.ac:

WebCore:

2010-02-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Set first party URI in all SoupMessages. This allows libsoup to
        implement a "no third party cookies" policy in case it wants
        to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
        use it for SoupURI.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::setCookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: svn://svn.chromium.org/blink/trunk@54352 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Timothy Hatcher.

        Web Inspector: group cookies by domains, not frame's domains.

        https://bugs.webkit.org/show_bug.cgi?id=34599

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._cookiesForDomain):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):
        (WebInspector._addCookieDomain):


git-svn-id: svn://svn.chromium.org/blink/trunk@54351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        [V8] Delete V8CustomBinding.h and all references to V8Custom

        https://bugs.webkit.org/show_bug.cgi?id=32638

        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/V8Utilities.cpp:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        * bindings/v8/custom/V8AttrCustom.cpp:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        * bindings/v8/custom/V8CoordinatesCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h: Removed.
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DataGridColumnListCustom.cpp:
        * bindings/v8/custom/V8DatabaseCustom.cpp:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8EventSourceConstructor.cpp:
        * bindings/v8/custom/V8EventSourceCustom.cpp:
        * bindings/v8/custom/V8GeolocationCustom.cpp:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::v8HTMLAudioElementConstructorCallback):
        (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::v8HTMLImageElementConstructorCallback):
        (WebCore::V8HTMLImageElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::v8HTMLOptionElementConstructorCallback):
        (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        * bindings/v8/custom/V8HistoryCustom.cpp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp:
        * bindings/v8/custom/V8NodeFilterCustom.cpp:
        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
        * bindings/v8/custom/V8SQLTransactionCustom.cpp:
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        * bindings/v8/custom/V8SharedWorkerCustom.cpp:
        * bindings/v8/custom/V8StorageCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayCustom.h:
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebKitPointConstructor.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:


git-svn-id: svn://svn.chromium.org/blink/trunk@54349 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@54348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Hausmann.

        [Qt] Unnecessary QBrush construction for doing a solid fill
        https://bugs.webkit.org/show_bug.cgi?id=34559

        Use the similar trick like r37421, i.e. use the special brush for
        solid color to avoid creating QBrush again and again.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::setPlatformFillColor):

git-svn-id: svn://svn.chromium.org/blink/trunk@54347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

* platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@54346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

WebCore: 

Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.

* WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.
* platform/Scrollbar.h: Replaced scroll amount constants with static methods.
(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.
* platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/haiku/PlatformWheelEventHaiku.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.

WebKit/mac: 

* WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.

WebKit/wx: 

* WebView.cpp:
(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.



git-svn-id: svn://svn.chromium.org/blink/trunk@54345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ariya Hidayat.

        [Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
        recaching, remove QTimer::singleShot and QPixmap::scaled, more
        accurate strategy of handling transform operation blends. Rotating a
        bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

        https://bugs.webkit.org/show_bug.cgi?id=34062

        This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
        (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
        (WebCore::OpacityAnimationQt::updateState): style change
2010-02-04  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
        of QTimer::singleShot, and moved syncLayers() from paint() to update()
        https://bugs.webkit.org/show_bug.cgi?id=34062

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::update): Moved the sync operation to update
        (QGraphicsWebView::paint): Moved the sync operation to update

git-svn-id: svn://svn.chromium.org/blink/trunk@54344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Timothy Hatcher.

        Web Inspector: Cookies for resources are not shown in storage panel.

        https://bugs.webkit.org/show_bug.cgi?id=34594

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getCookies):
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::cachedResource):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::requestURL):


git-svn-id: svn://svn.chromium.org/blink/trunk@54343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
        Reviewed by Tor Arne Vestbø.

        Implement a locking and scheduling mechanism for http testing sessions to be able
        to run multiple instances of run-webkit-tests parallel on the same machine.
        If a test session wants to run http tests and this feature is enabled, the pending
        sessions create lockfiles with sequential lock numbers. These locks are used to schedule
        the running test sessions in first come first served order. An exclusive lock ensures
        that the lock numbers are sequential to avoid deadlocks and starvation.
        Because the buildbot master specifies the flags used by slaves we need an environment
        variable too to be able to use the feature per-slave.
        Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
        flag enables this feature, otherwise this patch has no effect on the testing whatsoever.

        https://bugs.webkit.org/show_bug.cgi?id=33153



git-svn-id: svn://svn.chromium.org/blink/trunk@54342 bbb929c8-8fbe-4397-9dbb-9b2b20218538