- 24 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49e6f89bf28a..42297a7669fc 2020-06-23 jalyn@microsoft.com Reveal which shortcuts are provided by preset 2020-06-23 mamir@chromium.org [Autofill] Remove unnecessary keypress in a test in Test.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1030649,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd7177cc54aadbd47b92be16857197628abb02fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781664}
-
Bruce Dawson authored
This reverts commit ed0697fc. Reason for revert: crrev.com/c/2255126 fixes the midl.py failures on Windows 7 class OSes and crrev.com/c/2260933 rolls in a native_client change that stops preprocessing .S files with cl.exe. With those changes cl.exe is not used in the build on Windows 7 anymore and that should let this toolchain land. This change now locks the SDK version to 10.0.19041.0 for users who don't use a packaged toolchain which ensures consistency and should simplify future toolchain upgrades. This change was tested with the lock as shown and with a lock to a previous SDK version. Original change's description: > Revert "Reland "New toolchain for Windows 10 19041 SDK"" > > This reverts commit 424526a0. > > Reason for revert: win64-chrome build succeeded (progress) but > win32-chrome builder failed with a previously unseen error, shown > here: > > [170/58214] ACTION //remoting/host/win:remoting_lib_idl_idl_action(//build/toolchain/win:win_clang_x86) > FAILED: gen/remoting/host/win/chromoting_lib.h gen/remoting/host/win/chromoting_lib.dlldata.c gen/remoting/host/win/chromoting_lib_i.c gen/remoting/host/win/chromoting_lib_p.c gen/remoting/host/win/chromoting_lib.tlb > c:\b\s\w\ir\cipd_bin_packages\cpython\bin\python.exe ../../build/toolchain/win/midl.py environment.x86 c:/b/s/w/ir/cache/builder/src/third_party/win_build_output/midl/remoting/host/win gen/remoting/host/win 7219b935-4873-533b-9ce1-20c9e9b12def chromoting_lib.tlb chromoting_lib.h chromoting_lib.dlldata.c chromoting_lib_i.c chromoting_lib_p.c gen/remoting/host/win/chromoting_lib.idl /char signed /env win32 /Oicf > cl : Command line error D8027 : cannot execute 'c:\b\s\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\bin\..\..\VC\Tools\MSVC\14.26.28801\bin\HostX64\x86\c1.dll' > midl : command line error MIDL1003 : error returned by the C preprocessor (2) > > Original change's description: > > Reland "New toolchain for Windows 10 19041 SDK" > > > > This is a reland of 4a4f53a7 > > > > The original patch would fail to build on the mksnapshot step on > > Windows 7 (and server equivalents). This was due to two APISet DLLs > > that are required for the new dbghelp.dll. This change copies the two > > of them during gn gen. In order to have them as part of the isolates > > for cdb and in order to avoid dangerous ambiguity they are now > > required, which means that when this change lands the new SDK will be > > required. This is slightly disruptive for developers who aren't using > > our toolchain, but it seems unavoidable. > > > > Developers who don't have the latest SDK installed will hit this error > > message during gn gen: > > > > Exception: api-ms-win-downlevel-kernel32-l2-1-0.dll not found in "..." > > You must install the "Debugging Tools for Windows" feature from the > > Windows 10 SDK, the 10.0.19041.0 version. > > > > Original change's description: > > > New toolchain for Windows 10 19041 SDK > > > > > > This change updates the toolchain package used to build Chromium with > > > the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll > > > DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as > > > usual). > > > > > > The Debuggers directory was not swapped out this time because the > > > problem with loading dbghelp.dll on Windows 7 > > > (https://crbug.com/1021650) has been resolved. > > > > > > The output for the cdb copy step was updated because one additional UCRT > > > DLL is now copied. > > > > > > Packaging was done on a Windows Server 2019 VM, cleanly created for this > > > purpose. > > > > > > The package was created by downloading the VS Professional 2019 > > > installer from https://visualstudio.microsoft.com/downloads/ > > > (free trial, not preview) and then running the installer like this: > > > > > > $ PATH_TO_INSTALLER.EXE ^ > > > --add Microsoft.VisualStudio.Workload.NativeDesktop ^ > > > --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ > > > --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ > > > --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ > > > --includeRecommended --passive > > > > > > Then the latest Windows 10 SDK was downloaded and installed from > > > https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ > > > > > > Then the packaging script was run like this: > > > > > > python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0 > > > > > > Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid > > > shipping that (https://crbug.com/920704) the final packaging step was to > > > unzip the package, copy over the two copies of that DLL from the > > > previous toolchain's win_sdk\Redist, and then repackage the toolchain > > > with: > > > > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir> > > > > > > UWP and ARM64 support and Python 3 compatibility were previously added > > > to package_from_installed.py. > > > > > > Future changes will require the new SDK, but for now the previous SDK > > > can also be used to build Chromium. > > > > > > The failures on the win*msvc* bots are unrelated. This was proven by > > > creating crrev.com/c/2245914 which is a NOP toolchain test. The existing > > > toolchain was repackaged with a single text file added and that caused > > > identical failures. > > > > > > Bug: 920704, 1014701, 10216507, 1089996 > > > Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224 > > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#778924} > > > > Bug: 920704, 1014701, 10216507, 1089996, 1095767 > > Change-Id: I75e7653d57964e2929106e41b3f50594d3969e5f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249394 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Jesse McKenna <jessemckenna@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780431} > > TBR=dcheng@chromium.org,henrika@webrtc.org,thakis@chromium.org,brucedawson@chromium.org,henrika@chromium.org,jessemckenna@google.com,jmadill@chromium.org > > Change-Id: If00e3865e66d9071189b2aca28f7541ecbdc6486 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 920704, 1014701, 10216507, 1089996, 1095767 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255558 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780467} TBR=dcheng@chromium.org,henrika@webrtc.org,thakis@chromium.org,brucedawson@chromium.org,henrika@chromium.org,jessemckenna@google.com,jmadill@chromium.org Bug: 920704, 1014701, 10216507, 1089996, 1095767 Change-Id: I68e4c246ee903ba48d59b3bdea913ea3975c49d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255527Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#781663}
-
James Cook authored
This CL introduces AshChromeService, which is a set of APIs that lacros-chrome will call into. With this CL, Mojo connection between ash-chrome and lacros-chrome is now bidirectional. Bug: 1094106 Test: Ran locally. Change-Id: I169d55ad964073e8faebe069917a6a3a67ed5c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254638Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#781662}
-
Saho Kobayashi authored
send api::automation::EVENT_TYPE_ARIAATTRIBUTECHANGED when ui::AXEventGenerator::Event::DESCRIPTION_CHANGED is sent to send description changed event when state description is changed. DESCRIPTION_CHANGED is disabled in CL:1073926, because state changes were noisy, but it should be safe to send DESCRIPTION_CHANGED. Bug: b:154433831 Test: manual Change-Id: I34f540a443eb58ff2978bdc17491c3117826afbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255737Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Saho Kobayashi <sahok@chromium.org> Cr-Commit-Position: refs/heads/master@{#781661}
-
Nick Harper authored
Change-Id: I4b09aff4eb42b4682c24bc0fc7e325f619e6acd1 Bug: 1090838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261616 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#781660}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592935173-d1033b26c7b78c08aca84bf70b5b5eb9d34e3499.profdata to chrome-mac-master-1592956785-31e85dda22463f39949762c5e4ca2295e5fc2ed3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibbf97b304722240d3b4370023a571983c5241328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260902Reviewed-by:
-
Claudio M authored
The flag has been enabled by default since Sept 02 2017: https://chromium.googlesource.com/chromium/src/+/6ddc1c3486a8c1bf76b69268984bb05409a2fb31 Bug: NONE Change-Id: I9c5c1db1113df9369656881906f687888c3c95d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260093Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Claudio M <claudiomagni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781658}
-
Hiroki Sato authored
Current AXTreeSourceArcTest is large, and some of them tests only the serialization of some nodes and don't need to interact with AXTreeSourceArc. This CL adds AccessibilityNodeInfoDataWrapperTest and moves some unit tests from AXTreeSourceArcTest. AX-Relnotes: n/a. Bug: b:158141903 Test: AXTreeSourceArcTest, AccessibilityNodeInfoDataWrapperTest Change-Id: I7505078b2df463a99dcbe20fa62ce3ca1f0a391c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241092 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibd49454470abb8d876abbff2a23a91781e2944c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261109Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5afeb6651bad..bdfbdd275b29 2020-06-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ieb3b3ea602767ee28f38e82473a384def5620bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261776Reviewed-by:
-
Peng Huang authored
The bug is because X11 will present hided Window at 1Hz. So if there are two windows on screen. One is hided, vkAcquireNextImageKHR() will be blocked for 1 second, so the GPU main thread will be blocked with it. Fix this problem by add PostSubBufferAsync(). It will call vkAcquireNextImageKHR() off the GPU main thread. Bug: 1097014 Change-Id: I2dc7988d5c6320d167b3280b3f92ac9979644887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256589 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#781654}
-
Nate Fischer authored
This adds an architecture overview to public docs, based on the Android WebView 101 talk. Fixed: 1064147 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I7f01707f7ca57a92939df53f60bd6eca96470ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261427 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781653}
-
Anand K Mistry authored
In normal execution, there is a ping-pong between ServiceDeviceTask() and DevicePollTask(), posting each other onto their respective threads. There should only be one instance of this ping-pong at any given time. However, if there is a resolution change event, |device_poll_thread_| is stopped, but there could be a ServiceDeviceTask() task pending. In this case, when |device_poll_thread_| is started again at the end of FinishResolutionChange(), there is both a pending ServiceDeviceTask() and DevicePollTask() which will result in _two_ instances of the ping-pong existing. This may, depending on timing, increase by one on every resolution change event. To solve this, use a CancelableCallback to cancel any pending ServiceDeviceTask() when |device_poll_thread_| is stopped. BUG=b:140420307,b:148355507 Change-Id: I267625f93cd8a36a5a1f4ea0c99a7d7289151795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247435Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#781652}
-
Anastasia Helfinstein authored
Reduce lag of several seconds following actions such as resizing a window by only responding to the most recent AutomationEvent. AX-Relnotes: n/a. Bug: 1095232 Change-Id: Ib797fd27415f937a550b6edf5dd0371ea3859fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255673 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
Donn Denman authored
Adds support for a new Contextual Search Resolve-request parameter to provide a list of fluent languages. The server can use these as additional hints from the Chrome Language Model for the user's preferred languages to translate into. BUG= 1084600, 1093833, 1095090 Change-Id: Ieece911ca84854effcd830f4d0d7ec64e088f700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261422 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#781650}
-
Chong Gu authored
Adds support for sharding of Fuchsia gpu integration tests. Filter flaky tests. Bug: 1058255 Change-Id: Ie935d20182733f68cffb61142a35b811a7654798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261161Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#781649}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07db5c8e7e39..825e09a61fc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1087037 Tbr: chanli@google.com Change-Id: I24fadd4cfd57de4e22ab8bb4dde3138080f06e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261458Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781648}
-
Tibor Goldschwendt authored
If available we show the dark image doodle on dark themed NTPs. If the NTP is dark but there is no dark image doodle we show the Google logo. Bug: 688960 Change-Id: Iff61490632eb6716dbdb747a83b3d6f78ac641fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255671 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781647}
-
Juan Pablo de Lima authored
Bug: b:158760308 Change-Id: I72a187a787b914d4ae99ae9081690e780f919d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255114Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Cr-Commit-Position: refs/heads/master@{#781646}
-
David Schinazi authored
This CL rolls QUICHE to include two changes: Legacy Version Encapsulation, and a fix to ParseQuicTagVector. It additionally adds the support required for Legacy Version Encapsulation to work, and adds a command-line flag that allows us to test it. This CL also removes quic_utils_chromium since every method in it has now been moved to QUICHE. R=renjietang@chromium.org Change-Id: Iac2423df461656a47398f4579c279a22254390e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261103 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#781645}
-
Christopher Cameron authored
SharedImageBackingGLImage doesn't correctly bind and copy GLImages to GL textures. There are some rebinds and copies sprinkled here and there in haphazard ways that only happen to be right most of the time. Update SharedImageBackingGLImage to have a boolean indicating if the GLImage has been changed and a re-bind or copy is needed. This variable - starts true - is set to false at a re-bind or copy - is set back to true in the Update method Do a bind at initialization because various other bugs require it for now (I'll get to them later). Do a re-bind or copy lazily whenever Skia or GL access is requested. Skip the re-bind or copy when the mode GL_SHARED_IMAGE_ACCESS_MODE_OVERLAY_CHROMIUM is specified, because that type of GL access will access the GLImage directly. When GLRenderer is removed, this mode can be removed. Bug: 1092155 Change-Id: Ia5eb4ec87497ee14b06eb08404af312542926a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255884 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#781644}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e6867ba7c785..57186883cdf3 2020-06-23 jbudorick@chromium.org devil: temporarily continue accepting blacklist in HealthyDevices. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097306 Tbr: nuskos@google.com Change-Id: Iff439e98ad53c4dce1be6e8edf216f5dd2c933ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261065Reviewed-by:
-
Darren Shen authored
This is a key metric used for the native PK work, which will go on for the next few quarters. Bug: 1097823 Fixed: 1097823 Change-Id: I5800a2cfafd572c5fe9794e3e4dc78e19ae130df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257465Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#781642}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c865364ae842..babfc6e9a020 2020-06-23 dproy@google.com build: Remove deps on metrics:zero If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I679c43aa3143a6da05db148e70038539230df219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261064Reviewed-by:
-
zhaoyangli authored
https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/243fc89ae95b..97121c64019f $ git log 243fc89ae..97121c640 --date=short --no-merges --format='%ad %ae %s' 2020-06-20 mobile-devx-github-bot Wrap EDOClientService::errorHandler c functions in extern "C" 2020-06-10 albertbow Add warning message to `isKindOfClass:`. 2020-05-02 sskhandp Add -Wunguarded-availability and fix availability warning 2020-04-29 mobile-devx-github-bot Fix up EDO to work with OCMock 3.6 2020-04-21 haowoo Use lightweight generics to retrieve root objects. 2020-04-18 albertbow Internal change 2020-04-16 mobile-devx-github-bot Internal change 2020-04-16 sskhandp Internal change 2020-04-09 mobile-devx-github-bot Fix up .andDo blocks to not call retainArguments that can accidentally cause retain loops in mocks. 2020-02-19 sskhandp Store queue in variable to avoid repetitive calls. 2020-02-13 mobile-devx-github-bot Make sure strongSelf and strongSelf.handlerSyncQueue is not nil. 2020-02-11 albertbow Minor fix on comments. 2020-02-03 tirodkar Fix project name 2020-01-10 albertbow Rollforward EDORemoteException for user-thrown exceptions in remote invocation. 2020-01-07 albertbow Roll forward the fallback of EDORemoteException to be the subclass of NSException. 2020-01-02 mobile-devx-github-bot Internal change 2020-01-02 albertbow Fallback EDORemoteException to be the subclass of NSException. 2019-12-18 albertbow Rollback EDORemoteException. 2019-12-17 albertbow Allow one-way blacklisting types in remote invocation. 2019-12-17 albertbow Use EDORemoteException for user-thrown exceptions in remote invocation. 2019-12-16 albertbow Expose EDORemoteException. 2019-12-12 albertbow Create EDOInvocationException class. Created with: roll-dep src/ios/third_party/edo/src Changed BUILD.gn file and a test file in crashpad for the test to pass. Bug: 1097387 Change-Id: Id6af6c2098ad32df72038efadd4cfbcd533bfb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258418Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#781640}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df9f2eb5..613777a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idfd4532b97c2cc04653dadd01c2b1c8c00797b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781639}
-
Bruce Dawson authored
When midl.py is finished its work it invokes midl.exe to ensure that the results are the same. midl.exe defaults to invoking cl.exe, and we want to consistently use clang-cl.exe. This change uses /cpp_cmd to specify the clang-cl compiler. It then uses /cpp_opt to specify -Wno-nonportable-include-path because some of the SDK .idl files include files using different case from the file on disk. Typical warnings look like this: include\10.0.19041.0\um\unknwn.idl(28,10): warning: non-portable path to file '"Unknwnbase.Idl"'; specified path differs in case from file name on disk [-Wnonportable-include-path] #include "unknwnbase.idl" ^~~~~~~~~~~~~~~~ "Unknwnbase.Idl" When you use /cpp_opt then you are also responsible for specifying -E and -nologo and for passing along all of the /D commands, so this change does that as well. Bug: 1097510 Change-Id: Iece8ae7395d9afb05652d0a40f333721b3207a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261267 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: -
Lei Zhang authored
s/outter/outer/ Bug: 567351 Change-Id: I84df95a3e0955e8c6ba2c01e2192d30be3e28d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261476Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781637}
-
Mike Dougherty authored
This CL only removes the individual EG1 targets from the "all" target. The EG1 source_set entries will be cleaned up in separate follow-up CLs. Bug: 1085525 Change-Id: I5dbc8b55b027e16d8d82498dfda8121e0ad1cea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259139 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Chris Cunningham authored
Patch removes stale config for past DB window experiment and adds a new config for MediaLearningSmoothnessExperiment. Bug: 1049339 Change-Id: I5be2b21c0a5be90734a82e389f4d161941e582ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253460 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#781635}
-
James Vecore authored
This is a reland of https://crrev.com/c/2251062 This CL adds and verifies Polymer3 support in the Nearby Share subpage. A browser test is used to verify the Polymer3 setup is working correctly. The test suites added are: OSSettingsNearbyShareSubPageTest.* and OSSettingsNearbyShareSubPageV3Test.* Change-Id: Id9b6d7303b5c42ecda65aed0e558cc41e245b9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261175Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#781634}
-
wutao authored
This metric is useful to catch UI perf regressions. Bug: 1095029 Test: None Change-Id: I9dedaf938ef4bd65250e4088c68bc692b1779354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259477Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#781633}
-
chrome://media-appTrent Apted authored
The API was transitioned in r781392. Bug: 1096225, 996088 Change-Id: I4c83e0e6cddd4b5ee22bb0308636fb5a3fad6723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260296Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#781632}
-
Nate Chapin authored
* Remove Document::SetReferrerPolicy and OutgoingReferrer, use the LocalDOMWindow variants * Remove most of the uses of Document::GetReferrerPolicy Bug: 1029822 Change-Id: I33bd81b95b033307ccdb2a9a835f2c952006e12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258426Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#781631}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592927234-6bc8fa97bba2bd68cb01fd0ff8ce06df7602d283.profdata to chrome-win32-master-1592936751-767ef07082a8dc3f12048c56b1a9381a023bc8f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic825e4b820f65e673cd0feada9f6db37637b2c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261450Reviewed-by:
-
Nate Chapin authored
This ensures that ExecutionContext is the primary FeatureContext (SecurityContextInit is also a FeatureContext for its brief lifetime). RuntimeEnabledFeatures must now be called with an ExecutionContext instead of a Document. Bug: 1029822 Change-Id: I4b1e390ed507967246472a466f60e9488177e37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255552 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
James Hollyer authored
This uses the InputControllerEvDev to allow application to turn off mouse acceleration when using pointer lock on Chrome OS. Bug: 982379 Change-Id: Ie3b9d5f67d7a5514b90b25d8b13e9f6f5b01e390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188908 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#781628}
-
Robert Ogden authored
Adds a few histograms which are useful for tracking in the wild. Bug: 1082505 Change-Id: If99f482c86e57599db33f181b0ef8c88d8e660c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255522 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#781627}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: Ie306e67fbdbdb6c5e98c4edcda9b86dd3d1e9251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261484 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Rachel Wong authored
There is a bug where the Suggested Content shown count could be incremented even if it was not shown in the launcher. MaybeIncreaseSuggestedContentInfoShownCount currently depends on the value of ShouldShowAssistantPrivacyInfo. Since the Assistant count is incremented first, the value of ShouldShowAssistantPrivacyInfo could change and be outdated by the time Suggested Content does its own increment. This change fixes the logic so that Suggested Content shown count is not incremented if Assistant is incremented. Bug: 1079169 Change-Id: Ib632312504ce4d5102d47355fef2e1dbfe81cbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259694Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781625}
-
