- 14 Jan, 2021 40 commits
-
-
Muhammad Hasan Khan authored
BUG=1165220 TEST=none Change-Id: I1aa6eed9ffa83df65019ec23b2763ba427d4e3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622004Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#843659}
-
Jarryd authored
* Add three new testing journeys to the test cases input file. * Implement |assert_app_in_list_not_windowed| testing action. Bug: 1156693 Change-Id: Icd01b43ff2bfaec12a136e232d46376707c5d168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625527 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#843658}
-
Yuta Hijikata authored
This change is a mechanical change replacing is_chromeos with is_chromeos_ash. This is in preparation to switching lacros from target_os="linux" to target_os="chromeos". More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I714585aea9ccd0973551c89fc535331b39ce713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628710 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#843657}
-
minch authored
Bug: 1158583 Change-Id: I9c444c57c86d368477827f48f75cf9fd3197d117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623714 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#843656}
-
Xiaocheng Hu authored
This patch changes list markers to use custom counter style to generate counter text and calculate marker margin. The major complications are: - Predefined symbol marker styles ('disc', 'circle', etc.) require special handling, especially for margin calculation and painting - Legacy ListMarkerPainter paints marker text and prefix/suffix as separate text runs instead of a whole string Test failures are due to predefined counter styles not implemented as @counter-style yet, or not implemented exactly the same as the existing (non-custom) behavior. This will be fixed by follow up patches. Bug: 687225 Change-Id: Icf5468c6f12358aed291dbf60d75cc79ac7fdc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596826Reviewed-by:Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843655}
-
Yao Xiao authored
Incognito doesn't save history at all, so avoid calling HistoryService::SetFlocAllowed in incognito. Also don't set it when the history service is null. This aligns with the pattern elsewhere (e.g. calling hs->UpdateWithPageEndTime inside HistoryTabHelper::WebContentsDestroyed). Besides, this is a speculative fix for the crash crbug.com/1166194, as dereferencing a null history_service can trigger undefined behavior. Bug: 1162874, 1166194 Change-Id: Icb3adbd4ce311d4153bfd2b08b2bd43c4b4aa726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628927 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#843654}
-
Mike Pinkerton authored
Remove the pointer interaction when the view goes away. Also check the view is in a window before creating a pointer style. Bug: 1162914 Change-Id: I2835f453391b291afdce3baabfedf40a3fee10fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627709Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#843653}
-
Ramya Nagarajan authored
Replace uses with blocklist. Bug: 1097269 Change-Id: I61ba36afd6fc9a121dc7979091fe87b637786c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603853Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843652}
-
Yi Chou authored
BUG=b:175781791 Change-Id: I30304f1f17195eb1cc6d867bc23d972f740986f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599561Reviewed-by:
-
Aaron Tagliaboschi authored
Make client hints available to other inheritors (i.e. WorkerFetchContext). Also a little bit of refactoring. Should be a purely mechanical change. The purpose behind the refactor is to pull out the dependence on the Document to the calling site and make everything Document- dependent optional, so non-Document-related calls can be made (specifically Service Workers initializing their own requests). Bug: 1151050 Change-Id: I964585e7a1509b96e8a36ea673be81ff85e6a208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557225 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#843650}
-
Ulan Degenbaev authored
An about:blank frame inherits its origin from its parent [1, 2]. This adjust the node aggregation type computation return kSameOriginAggregationPoint in the case when - the current frame is about:blank and - its parent has the same origin as the requesting origin. This change provides better results for pages that create and pool many about:blank iframe for warming up. [1]: https://html.spec.whatwg.org/multipage/browsers.html#determining-the-origin [2]: https://developer.mozilla.org/en-US/docs/Web/Security/Same-origin_policy#inherited_origins Bug: 1085129 Change-Id: Iffe6b09a6b8ec1e2fd7b9a293e4b714a955d95fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627492 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843649}
-
Cattalyya Nuengsigkapian authored
Bug: 1142726 Test: `ash_unittests --gtest_filter=*LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows*` Change-Id: If6b4241c96b7b4f94bf35103d352e2d73217d353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626606Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#843648}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610625483-0e8af23579a6861bbbc901692aa081cb0bce75b1.profdata to chrome-win64-master-1610636358-77f55f013156712d320ba2c348ceb07dee8d46f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ief6f04befd33d171724a625fb094be8210f80b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843647}
-
Sky Malice authored
BYPASS_POLICY_COMPATIBILITY_CHECK=Marking value 0 as deprecated would not be as clear. 0 will still continue to be handled the same as it was previously. Bug: 1159662 Change-Id: Id179a043a37b844fa54afa44ff87aeb44b3633c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626984Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#843646}
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. This CL adds changes to IsSyncable method to use policy enforced update URL. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. Bug: b:175767504 Change-Id: I5aeb99061affbb47339a1b1bf385cea1603f3642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593103Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#843645}
-
Scott Violet authored
Specifically adds the following: 1. fullscreen for background tabs is processed when the tab is made active. This matches what clank does. 2. Ensure the callback supplied to the delegate to exit fullscreen is only applicable to the request it was created for. For example, if the the delegate is supplied callback C1, fullscreen exits, then fullscreen enters again with callback C2, callback C1 is no longer applicable. 3. Make the java side have similar logic to (2). BUG=1142101 TEST=none Change-Id: Ic28d6cbc761ff8b0f9651c018c258d569b9c556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628086Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843644}
-
Owen Min authored
When a boolean policy has a undefined value in the 'items' attributions, the error message uses undefined variables and causes crash. Bug: 1165816 Change-Id: I4600d0d8ba51472e8d69035c368f462a7f645b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629430 Commit-Queue: Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: I96626e524014efb5dd2b340e0c8eb3c0e1f810c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616703 Commit-Queue: James Cook <jamescook@chromium.org> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
Because base::ScopedObservation is strictly a singular observation, it has exposed at least one latent release blocker bug on replacing ScopedObserver. Unfortunately this manifested as a use-after-free, as there was no test or build with DCHECK_IS_ON that covered this case. See https://crbug.com/1153961#c14 for the details. Bug: 1145565 Change-Id: Ibe198ca413e94676fa5dac3b94837b9999b3cb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627763Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843641}
-
Michael Bai authored
Make the server prediction available as ViewType, separate it from mServerType to consistent with AutofillServer protobuf. Add the tests to cover it. Bug: 1151542 Change-Id: I1083cdc621d586d32327ee40e973b26f3d724f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623673 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#843640}
-
Joe Downing authored
I know it seems like you just approved this but I found another instance of the copyright. It turns out we have 2, one for official builds and another for unofficial builds. AFAIK this is the last one : ) Skip-Translation-Screenshots-Check: True Change-Id: I80ad05d04facdb6e9c2ffe2126ba01b519b09681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628892 Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#843639}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..94ca9a9578a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8a692a96a9bc19808542fbe3f3c53e558e0bd8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629401Reviewed-by:
-
Connie Wan authored
Bug: 1106846 Change-Id: I674faa4aa0e34ac6d8294e2c7c6cc096c409568f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626891Reviewed-by:
-
James Cook authored
The "Lacros-chrome is not supported" was printing 7 times in each Chrome OS browser_tests test run. This confused some developers, who thought their test failures might be caused by lacros. Since the flag being off is the common case, don't log. Bug: none Change-Id: I38b46b0a0390d39fae5ca1f095c9131aa25692f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627714 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843636}
-
Bailey Berro authored
The Diagnostics TelemetryLog class is used to cache the most recent info fetched by SystemDataProvider. Bug: 1128204 Change-Id: I9ea328921be4316a2d57920d3aa8d0e4291f14d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626077Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#843635}
-
Theo Johnson-kanu authored
This reverts commit 8aa524c7 Reason for revert: The original commit was not the cause of the issue in the revert. The bots which was failing chromeos-betty-pi-arc-chrome is passing. original description: > Revert "[CrOS cellular] Respond to cellular route params in internet page" > > This reverts commit 9ca977e3. > > Reason for revert: I suspect this CL caused a failure https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome > > Two builds: > https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/11124/overview > Test 'arc.DragDrop' completed with the following status(es): 'FAILURE' > > Test 'arc.DragDrop' had the following logs when run: > > ================================================================================ > > Failed initializing UI Automator > at chromiumos/tast/local/bundles/cros/arc.DragDrop (drag_drop.go:93) > at chromiumos/tast/internal/planner.runTestWithRoot.func3 (run.go:755) > at chromiumos/tast/internal/planner.safeCall.func2 (safe.go:92) > at runtime.goexit (asm_amd64.s:1357) > failed installing /usr/local/share/android-uiautomator-server/app-uiautomator.apk > at chromiumos/tast/local/android/ui.installServer (device.go:119) > at chromiumos/tast/local/android/ui.NewDevice (device.go:91) > at chromiumos/tast/local/arc.(*ARC).NewUIDevice (ui.go:16) > at chromiumos/tast/local/bundles/cros/arc.DragDrop (drag_drop.go:91) > at chromiumos/tast/internal/planner.runTestWithRoot.func3 (run.go:755) > at chromiumos/tast/internal/planner.safeCall.func2 (safe.go:92) > at runtime.goexit (asm_amd64.s:1357) > context deadline exceeded > at ??? > > https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/11125/overview > Test 'chrome_all_tast_tests' completed with the following status(es): 'FAILURE' > > Test 'chrome_all_tast_tests' had the following logs when run: > > > > Original change's description: > > [CrOS cellular] Respond to cellular route params in internet page > > > >Bug: 1163556 > >Change-Id: I196b9c9f73fecb169b53ac3d3ed5635a799b7138 > >Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625275 > >Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > >Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > >Cr-Commit-Position: refs/heads/master@{#842903} > > TBR=azeemarshad@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,tjohnsonkanu@google.com > > Change-Id: Icd511320cc5b1df0ad54057e372b4d353fc90778 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1163556 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626432 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842952} Bug: 1093185 Change-Id: I4cf802484486a9cbb77c8fb9c028ec0b284b8622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626917Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#843634}
-
Daniel Nicoara authored
As per WebContents::SetUserAgentOverride documentation navigation entries need to be updated to allow user agent override. Bug: b:175857659 Test: cast_shell_browsertests Change-Id: Ic829c5130451d2afa4eda598b535c65997a458f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627883Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#843633}
-
Liquan (Max) Gu authored
Since Expandable payment handler has been enabled by default, this CL cleans up all occurrences of "ScrollToExpand" in the code base. Bug: 1094549 Change-Id: Idbf863db8d08b583188bcf923879e9933b497b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626418 Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#843632}
-
Robert Sesek authored
This is a reland of 11748b2a Disables an expectation on CrOS because it fails for unknown reasons (https://crbug.com/1166533). Also addresses one comment from the initial CL. Original change's description: > Add a new Android.ArmCpuPart UMA. > > This will record the ARM CPU's implementer and part number values. > > Bug: 1164549 > Change-Id: I09ea0d852fda6b05c50a16b64bfcde6f4f5f62b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615326 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843243} Bug: 1164549 Change-Id: I95d6788d62bb859bf8a71fe0e6410993f6da02f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627761Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL sets the right flex specifications so that the heading label does not overflow the size of its parent. Before: https://screenshot.googleplex.com/XowRbDCxFuxxnwZ After: https://screenshot.googleplex.com/7KL7g5SN3dX2ZEy Bug: 1166687 Change-Id: I072a651e838ed46df0cc4584638930911224de7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628957Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#843630}
-
Jonathan Backer authored
IsUsingVulkan is checked by IsUsingSkiaRenderer. So this CL enables both for Android 10+ devices. Some code was added to: - disable Vulkan for Android < 10 --- we use some Android 10 specific APIs and it has significant market share (~40% by frame count yesterday on UMA) - disable Vulkan on QCOM GPU by default --- performance is not yet as good as GL there - add an enable_by_device_name finch param so that we can bypass the Android Vulkan blocklist and test new GPUs on canary/dev/beta Bug: 1012393 Change-Id: I1211743519c8cbe18025adea1696ab7d52a0b949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623951 Auto-Submit: Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843629}
-
Ulan Degenbaev authored
This also adds a support for the --disable-web-security flag that is useful for local testing. Bug: 1085129 Change-Id: Ia76fb151d6d97a141d69ecf48b17b172513d5225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629509Reviewed-by:
-
Peter Kasting authored
Bug: 1159562 Change-Id: Ib43a3205a0c553e97693e63ecc8838edaa540a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628020 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843627}
-
Stepan Khapugin authored
Also fixes a potential race condition in a BVC animation, just in case. Fixed: 1163905 Change-Id: I5d0f900512b4620dff1b6499bd211f4f100a2cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626391 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843626}
-
Dave Tapuska authored
There are a series of messages that are relayed to the IO thread of the browser process. Add a new interface to handle these messages. FrameHostMsg_DidCreateInProcessInstance message is the first message to be converted. BUG=1157519 Change-Id: I11441cddcff8a09e1514091d9e6042f2e2bf01e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626181Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Will Cassella authored
This CL removes the `blink::features::kAVIF` flag, since that has been enabled by default for a while, and this allows some code to be cleaned up considerably. The `ENABLE_AV1_DECODER` build option is still kept, so that AV1 support can still be toggled at compile-time. Change-Id: Ic6cd3608eaa69305fa1fdafb6137f9662c4fcd94 Bug: 960620, 1117843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625510 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#843624}
-
Toni Baržić authored
This reverts commit 3d1384d2. Reason for revert: The CL effectively removed the delay between items getting added to holding space and their preview showing up in the tray icon, leaving less time for the preview icon to get generated, and causing some jank (flash of empty white icon) during the tray icon visibility animation. Original change's description: > Don't animate holding space previews on initial show > > Adds a way to update holding space icon preview layer without an > animation, and utilizes it when the icon previews are first being shown > (i.e. when the list of previews is updated from an empty list). In this > case, tray icon will have it's own visibility animation, so there's no > need for running a separate bounce in animation within the tray icon. > > Also, updates how tray icon updates are scheduled - instead of updating > the tray visibility synchronously, and then scheduling a previews > update, the logic is changed to update previews icon synchronously, too. > (the throttling became less important now that additions of multiple > items to the holding space are done in a batch, instead of one-by-one). > > BUG=1166014 > > Change-Id: I3211672072262e9fff75b04a3316c6049099c749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627169 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#843358} TBR=tbarzic@chromium.org,dmblack@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I9f7445104feac5cacc1bc27e9aebe7f4bef091cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628382Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843623}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..94ca9a9578a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7ac5dd4f316d9157dd8818aa38af083d8a454a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629400Reviewed-by:
-
danakj authored
When making a frame from the browser we will call into blink to make the WebLocalFrame, which will also create the core LocalFrame, then on return we will initialize the RenderFrame. So we have - Create RenderFrame - Create WebLocalFrameImpl - Create LocalFrame - Initialize RenderFrame This means that RenderFrame observers are told about the RenderFrame after the initial about:blank document is already created, so they see the RenderFrame created with it, and do not receive a notification about the about:blank document being created. But when the renderer makes a child frame the order is currently different, the RenderFrame initialization is done before creating the LocalFrame, which means observers see different events for these child frames and need to work around them. This brings the child frame path into alignment with the browser-initiated path and adjusts expectations in tests. The SubresourceFilterAgent no longer needs special case code to handle the initial about:blank document, and it sends its mojom message immediately on creation now. Its unit tests are adjusted to allow creating the filter for what appears to be a main/child frame without requiring an instance of RenderFrame. It also always constructs a filter for child frames at creation time as it did when hearing about the initial blank document before, which would have been only for child frames though the code is not clear about that intention before. MetricsRenderFrameObserver skips the first document which was because it would hear about the about:blank creation in child frames, but that would also make it skip the first non-initial-blank-document in main frames too. This is removed now. TBR=dcheng@chromium.org Bug: 1158869 Change-Id: I57050b251eea53979d8c546c9942430346a5aa74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601063 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843621}
-
Stephen Roe authored
Move test parameters from script arguments to json file. The tryjob fuchsia-fyi-arm64-rel build failure is expected. It does not affect CQ or CI. Bug: 1126177 Change-Id: I3b2c3458afcf9b1b2614b0d5fa7d3653c0e5c232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617052 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843620}
-
