- 07 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48dc2da07f5b..afa7840d8e0c git log 48dc2da07f5b..afa7840d8e0c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 cjmcdonald@chromium.org Revert "DependencyService: Provide exact eclass dependency paths" Created with: gclient setdep -r src/third_party/chromite@afa7840d8e0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I366a74a7112265e6036acbcfda643b4a13966976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713548}
-
Vladislav Kaznacheev authored
This is a reland of b2af1539 which was reverted due to being pointed out by SoM as a cause of an Android compile failure. Original change's description: > Fix crash when exiting mirror mode on tablet > > Attempting to create ShelfWidget while shelf is in-app is causing > a crash because ShelfWidget::DelegateView::UpdateOpaqueBackground is > called before the widget is initialized. > > Moving that call from ShelfWidget::DelegateView constructor into > ShelfWidget::DelegateView::OnWidgetInitialized. > > Added a unit test. > > Bug: 1021662 > Test: manual, DisplayManagerTest.ExitMirrorModeInTabletMode > Change-Id: I32a5f91c834d673b109ab518bc2600908d8dea5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902273 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713464} TBR=oshima@chromium.org Bug: 1021662 Change-Id: If28233c15d870fca0c9f6818e9031d98276bfe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904159 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#713547}
-
Jeroen Dhollander authored
This CL introduces the Autotest APIs used to test that the |NEW_READY| signal is sent out when the Assistant is ready to handle queries. Change-Id: I1dd1c366dece11be8b4c6c84e6a5c808bb110453 BUG: b/143381021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881968 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713546}
-
Tobias Sargeant authored
Change-Id: Ia3add86b7cab7697b5f48f6412932563cbd8af2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901084Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713545}
-
Hongchan Choi authored
See details in: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw TBR=reillyg@chromium.org Bug: 1022321 Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713544}
-
Wei-Yin Chen (陳威尹) authored
Add some basic render tests in StartSurfaceLayoutTest, including a test for INITIAL_SCROLL_INDEX_OFFSET. Bug: 983170 Change-Id: Ie06cd2f3620a980b3c095eb0619704a7c714fd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903402 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713543}
-
Scott Violet authored
This informs observers of events related to the set of tabs. BUG=none TEST=TabListCallbackTest* Change-Id: I6e1975f7d59ffcf1a92dce072fc7d8f0194f10ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902130 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713542}
-
David Benjamin authored
Client certificates involve unnecessary IO/UI hops. We go from network service to UI to IO (for ClientCertStore) to worker, back to IO, to UI, back to IO, and then back to network service. The IO thread is just a remnant of the old ResourceDispatcherHost logic where everything lived on the IO thread, because ClientCertStores live on IO. This CL moves the ClientCertStore to the UI thread (it just wraps an async worker PostTask) which then drags the rest along with it. Two complications: 1. We now need to worry about reentrant callbacks. To avoid surprising callers, I've added PostTasks where necessary. 2. CrOS's ResourceContext dependency is messier. See https://crbug.com/1018972 for a summary. This CL hides a UI/IO round-trip in ClientCertFilterChromeOS for now. This is still the same number of thread hops as before. Notes for reviewers: start by reading the (tiny) //content/public changes. The rest of //content can be reviewed relative to the API change. chrome_content_browser_client.{cc,h}, chrome/browser/profiles and chrome/browser/net can then be reviewed as one unit. chrome/browser/chromeos/certificate_provider can be reviewed as a unit. This CL just removes the now unnecessary thread-hopping. Finally, chrome/browser/chromeos/net preserves the CrOS threading constraints, and the rest is mechanical. Bug: 1011576 Change-Id: I414077aa8979753a2b6418b9dd437eba566701a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888118 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713541}
-
meacer authored
Bug: 991726 Change-Id: I9083f49ea712cecd0f23d1c434c3d8d813d36137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903749 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#713540}
-
James Vecore authored
The Bluetooth toggle button disables itself after being pressed while the hardware state is changing (to prevent click spamming) and re-enables when the new state takes effect. The problem is that Chromevox is reading the disabled state after a toggle and never announces the updated enabled state after the hardware state is applied. By making the element "aria-live" we request that Chromevox announces the new state when the element state changes. This solution results is some spammy Chromevox output, but that is better than never announcing the state change at all. Fixed: 1007378 Change-Id: I0632138bdea96c56edb0a0f1b9cca05d3ca2d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895255Reviewed-by:
-
Patrick Monette authored
This CL is mostly a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1195682/, and also adds a DCHECK that ensures that we don't enable third-party blocking if the QuarantineFile() functions doesn't run out-of-process. Bug: 870998 Change-Id: I7ff74b1595aa889c12564847d7735825b33f7ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899752Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#713538}
-
Mason Freed authored
```yaml IN CASE OF PROBLEMS: If this CL causes your site/app to break, you are using deprecated features that have now been removed. Please see [2] to enroll in the Deprecation Extension program to give yourself more time. ``` With this CL, the HTML Imports Web Components v0 API is disabled by default. The other two Web Components v0 APIs were already disabled by another CL ([4]). These features were deprecated in August, 2018, in [1]. The original removal timeline called for a deadline of M73. Due to high use counters for the features, this deadline was extended to M80, which is now here. For those sites that need additional time, there is a "deprecation extension" (sometimes called a "reverse origin trial") that can be used to extend this removal for specific sites through M87. For more information on that, see [2]. For overall context on this removal, including motivation and ways to test/upgrade, see [3]. With this CL, these features will still be enabled for testing across all test suites. Once this CL has had a chance to land and stabilize, subsequent CLs will disable the features for all tests by default, and enable a virtual test suite to continue testing specific code with WCv0 features enabled, to ensure the features continue to function through the end of the deprecation extension period. Note that this CL re-enables all three Web Components v0 APIs on Android Webview, due to lingering issues with origin trial support. See crbug.com/1021631 for more information. See https://crbug.com/1020737 for why all three APIs are being re-enabled. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841 [3] https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade [4] https://chromium.googlesource.com/chromium/src/+/f52dff0d3c5bc52ba608920f843162832f2da6b1 Bug: 911943, 1021631, 1020737 Change-Id: I0df0898674cfec7c0db50ada9900a9a4027eb226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869562 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713537}
-
Jarryd authored
isInstalled will be used to determine whether or not the browser should warn the user about deleting offline data for associated apps when the user goes to clear site data. The UI changes will come in a follow up CL. Change-Id: Ia9d3f7b51e6fc1b5584044750b3bb32479dc220f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761587Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713536}
-
George Steel authored
Adds new WPT reftest testing the styling of ::before and ::after pseudo-elements within a ::first-line pseudo-element. This currently fails in chromium and passes in firefox. Bug: 892983 Change-Id: If15b4004b8091fa0871e580dc2f059a69174546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900391Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713535}
-
Shivani Sharma authored
Populates Network Isolation Key for network service browser test to support split cache when it is enabled by default. Bug: 910708 Change-Id: I4d62b78a61e3a443468ab9be8666e392591f9809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899729Reviewed-by:
-
Olivier Li authored
This is a reland of ded13f7d Original change's description: > Followup cleanup for ProfileSyncServiceUsesTaskScheduler experiment code. > > 1) Remove sync_thread_ from the ProfileSyncService interface to avoid > accidental use. > 2) Enable experiment in tests to provide coverage. > 3) Add some ScopedAllowBaseSyncPrimitives in code that needed it. > > Bug: 1014464 > Change-Id: I79393edac048a2960b4f2bc7593be326f5d27419 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895797 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713459} Bug: 1014464 Change-Id: I8d9a6d0fcf055f466d7e4a3b30a3c1e4e92042bf TBR=fdoray@chromium.org, mastiz@chromium.org Change-Id: I8d9a6d0fcf055f466d7e4a3b30a3c1e4e92042bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904309 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713533}
-
Reilly Grant authored
The usbi_transfer object should not be accessed after dropping the flying_transfers lock as it could be freed by another thread. The simple fix is to copy the timeout from the transfer rather than holding a pointer to it. Bug: 1017020 Change-Id: I00c349caf2e87b79c8e6f89f35fda673cf47e9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901355Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713532}
-
Henrique Ferreiro authored
Migrate the class member |code_| from int32_t to blink::DOMExceptionCode. Bug: 1022358 Change-Id: Ibc957290e1a8eeec719881280e7cf4cc1256b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899453Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#713531}
-
Anatoliy Potapchuk authored
Bug: 1015383 Change-Id: Iff0f5671b4503d9e1f8e806946da56db08c157e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904187 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713530}
-
Hongchan Choi authored
See details in: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXQsSBUZsYWtlIlJjaHJvbWl1bUBhc2hfdW5pdHRlc3RzQERyYWdXaW5kb3dGcm9tU2hlbGZDb250cm9sbGVyVGVzdC5DYW5jZWxEcmFnRGlzbWlzc092ZXJ2aWV3DA TBR=sky@chromium.org Bug: 1022319 Change-Id: I772b15cae2066696ae719af76034c6a4b497dc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903756Reviewed-by:
-
Oksana Zhuravlova authored
This is a reland of 3e01d61b Removed the remaining #include for frame_host_test_interface.mojom.h Original change's description: > [mojo] Remove DocumentInterfaceBroker > > This change removes the DocumentInterfaceBroker mojom interface and all > related plumbing. No functional changes since the interface was not used > by anything (clients migrated to BrowserInterfaceBroker). > > TBR=tommycli@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,kenrb@chromium.org,alexmos@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org > > Bug: 985120 > Change-Id: I893f940bc2c5d237aac5fb6b3962c06bfa98e938 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881394 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713278} Bug: 985120 Change-Id: If3a080592aef38d0c143f6a0d150991c091a4b6d TBR=tommycli@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,kenrb@chromium.org,alexmos@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org Change-Id: If3a080592aef38d0c143f6a0d150991c091a4b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903007Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713528}
-
Lei Zhang authored
BrowserAccessibility and BrowserAccessibilityManager are classes in content/browser that should not be exposed in content/public. Move AccessibilityTreeFormatter::BuildAccessibilityTree(), which takes a BrowserAccessibility*, to AccessibilityTreeFormatterBase, which is in content/browser/accessibility/accessibility_tree_formatter_base.h. Similarly, move DumpAccessibilityTreeFromManager(), which takes a BrowserAccessibilityManager*, to AccessibilityTreeFormatterBase. Fix some lint errors along the way. Change-Id: I93e974749b41313bd84ce417c535041a29c853ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900568Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713527}
-
Eric Roman authored
The various bluetooth address parsing functions each accepted a different format by virtue of their implementation. The shared implementation accepts these three formats of bluetooth address: 00:11:22:33:44:55 00-11-22-33-44-55 001122334455 In some cases this is more strict, and in other cases it is less strict than what was previously accepted: [tray_bluetooth_helper_legacy.cc] AddressStrToBluetoothAddress() No longer accepts: 0:0:11::::22:33:44:5::::5 Will additionally accept: 00-11-22-33-44-55 [bluetooth_device.cc] BluetoothDevice::CanonicalizeAddress No longer accepts: 00/11/22/33/44/55 00|11|22|33|44|55 [bluetooth_system.cc] ParseAddress Will additionally accept 00-11-22-33-44-55 001122334455 Bug: 1021236 Change-Id: I1c293ae8ba0ee27d56dc45f0454ae2c01a001e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901908Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Changwan Ryu authored
Test that source origin is a non-null string of n,u,l,l when posting a message from loadData API. Bug: 1021622 Change-Id: I93fff4ac9962fd9d0637a53e51162f55e7777a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900153Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713525}
-
Anatoliy Potapchuk authored
For some reason, during switch from WebUI to Mojo, only bailout hotkey was transferred. Bringing it back to kiosk splash screen. Bug: 1022444 Change-Id: Id0deb7e56a619b9513b31df0e93367c7f1f1f069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904190 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
-
Hongchan Choi authored
See details in: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUBhc2hfdW5pdHRlc3RzQERyYWdXaW5kb3dGcm9tU2hlbGZDb250cm9sbGVyVGVzdC5TcGxpdFZpZXdEcmFnSW5kaWNhdG9yc1dpbmRvd0RyYWdnaW5nU3RhdGVzDA TBR=sky@chromium.org Bug: 1022320 Change-Id: Ifabbbefaf11dbdfb1a9e5010d2013db52e80cac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904034Reviewed-by:
-
David Bokan authored
This flag is useful both for debugging and accessibility. While we wait for an accessibility UI we shouldn't remove the flag. Bug: 817814 Change-Id: I85c8dbf2479f3ea36552d6b00794695f81284858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898331Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713522}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/62a814392cf5..50d2ff30828b git log 62a814392cf5..50d2ff30828b --date=short --no-merges --format='%ad %ae %s' 2019-11-07 fmayer@google.com Merge "Add disabled test-case for incorrect unique_retained." 2019-11-07 treehugger-gerrit@google.com Merge "Move CopyablePtr from base to protozero" Created with: gclient setdep -r src/third_party/perfetto@50d2ff30828b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I681b87f4726d9cbddbcd55e1e2d4b8161789f82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903655Reviewed-by:
-
Shawn Gallea authored
This is needed to notify cast apps when they are covered by other activities. Bug: b/120809866 Test: Compile Change-Id: I312117a7b051183ad0056cfeff2d0edff49a6f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900388Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#713520}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/252d1eb47f23..c3284fa40ec6 git log 252d1eb47f23..c3284fa40ec6 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 rharrison@chromium.org Migrate away from using recently deprecated APIs Created with: gclient setdep -r src/third_party/dawn@c3284fa40ec6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I14860f2313eaef07f738d5113d6260ae48fafaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904333Reviewed-by:
-
Kurt Catti-Schmidt authored
This is a reland of cc2f9f85 There are two issues that occurred once the reland was checked in yesterday, which this "reland reland" addresses. First, https://chromium-review.googlesource.com/c/chromium/src/+/1872409 updated the AuraLinux dumps to output "[static]" instead of "[text]" for text nodes. Since this was a new test file, it was missed in the update and started reliably failing once that change went in. This was addressed by updating the expected dump file for Linux. Additionally, Windows 7 outputs a different date format, with commas in between the month and year. This is addressed by adding DENY filters for the name attribute on Windows on the node where formatting differs, as well as removing all IA2 Hypertext from the tree, which isn't relevant to this test either. TBR=sky@chromium.org TBR=nektar@chromium.org Original change's description: > Reland "Fix UIA Fragment Root Navigation in Inspect" > > This is a reland of 5e7f2837 > > This was reverted due to flaky tests. I was not able to reproduce the > failures, but I was able to see via the logs that the failed cases > were opening the first popup instead of the third. As a mitigation, I > have switched the logic to find the third popup. Previously, I had > added a count parameter to FindNode, so it would find the third node > with that name. This change adds a name to the parent node (in this > case the <input> node), and updated the logic to search for that node > as a parent. > > Original change's description: > > Fix UIA Fragment Root Navigation in Inspect > > > > We discovered that the fragment root change that was recently submitted > > here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822 > > regressed fragment root navigation in Inspect. This was not the case > > when Kevin had first submitted it. I traced it down to the changes that > > I made for Controller-For elements, so this change undoes those > > modifications. > > > > In order to stabilize the content_browsertest that prompted the changes > > (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it > > was discovered that there were several issues in how we were > > handling date-time popups. > > > > The first issue is that we were failing to return the proper parent > > window for the fragment root. In > > RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were > > returning nullptr as the parent of datetime popups, which was > > parenting the popup under the root desktop window in Inspect. This > > change now returns the host's window, which places the popup under > > the correct parent window in Inspect. > > > > The second issue is that there was a cardinality problem with datetime > > popup windows. Since they share a BrowserAccessibilityManager with > > the main window (but are under a different fragment root), > > LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would > > always return the main window's root kRootWebArea instead of the > > popup window's kRootWebArea. So we'd have two different fragment roots > > that map to the same gfx::NativeViewAccessible. This would cause > > GetFragmentRootParentOf to return the incorrect parent most of the > > time. This change fixes that issue by adding an extra step for popup > > windows that traverses the root node and searches for the popup web > > root via OneShotAccessibilityTreeSearch. > > > > Bug: 1019016 > > Change-Id: I678425c8417334275727053243a39b1039e6f135 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102 > > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711358} > > TBR=sky@chromium.org > > Bug: 1019016 > Change-Id: I73dc98eeb049788b3a7a086f5e6ac2927e2b0473 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894761 > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#712774} Bug: 1019016 Change-Id: I0fc44bf62612cc480f3bb4f818a584694bbaafe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899202Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
-
Sara Kato authored
Bug: none Change-Id: I7317204057092f41ee40128f6ecb264340e84da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903233Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#713517}
-
Alex Ilin authored
Since the test file now contains real tests, it shouldn't be called demo. Change-Id: I46d4cc153543451ddc66265c334e91c100d778a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899505Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713516}
-
Abigail Klein authored
Observe AXEvents received by the RenderFrameHost. Log them in the the accessibility events recorder, which records events from the OS. chrome: accessibility page, intermixed with the events recorded by Bug: 785493 Change-Id: I7a72f786567c1f661de9f0945c01dc4d46789e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900209 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Patrick Monette authored
This CL changes RegisterWithOSAsDefaultClient() and CheckDefaultClientWithOS() to directly receive the callback instead of calling GetDefaultWebClientCallback() on the registry. Bug: 1021600 Change-Id: Ic71173e91121f0f3576b38532e030227f3f23797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894698 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713514}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/efd8b7f5..500af51d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I370b41ce9efbdfe83fae373012fb8f02d28b425e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902439Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713513}
-
Vasiliy Telezhnikov authored
Some examples and tests create InProcessCommandBuffer without GpuChannelManagerDelegate. Some of them would crash trying to report new GpuBlockedTimeBetweenSwaps metric because of it. This CL fixes crash. Fixed: 1022412 Change-Id: I61a0a8a663d91bcf608ec2992d01b9d0752de8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903841Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713512}
-
Elly Fong-Jones authored
Something is wrong with the fallback font path that these tests hit, on 10.15.1 and probably other releases. Bug: 1022455 Change-Id: Ib82a5e27a5f0203f700363e663a08496da2df466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902440Reviewed-by:
-
Aleks Totic authored
Change-Id: I06dc5c8977761e32c468fb43e91739d872f2a6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900925 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713510}
-
Nektarios Paisios authored
This is the first patch resulting from splitting into multiple patches. The CreateBoundaryStartPosition and CreateBoundaryEndPosition methods were re-written to work with boundaries that are not only at the beginning or the end of specific nodes, but could also fall on a text offset *within* a node. This patch doesn't create any new publicly exposed functionality in AXPosition. Even though all existing tests should be passing unmodified, this patch has uncovered a bug on how we used to compute upstream affinity which has now been fixed. A followup patch will re-write word navigation functionality to use the above two methods. A second followup patch will introduce support for document markers in AXPosition. R=kschmi@microsoft.com, aleventhal@chromium.org, ethavar@microsoft.com https: //crrev.com/c/1874254/ Bug: 1008031 Change-Id: I1ed67028c950cda1226c3a1b9b732a8d5a2af036 Change-Id: I1ed67028c950cda1226c3a1b9b732a8d5a2af036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894159 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
