- 21 Dec, 2019 40 commits
-
-
Bartek Nowierski authored
Privacy review: https://docs.google.com/document/d/1cgwwc8jY7A3MLCHAh7yvONTAWTUTlsjnBsHp2oIuMv0/edit?usp=sharing Change-Id: Ic7ee5a3664d592230e1e120391724dd4e7a0c5dd Bug: chromium:1018156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965747Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727045}
-
Mansi Awasthi authored
Added a new action PP_PDF_SET_SELECTION to PP_PdfAccessibilityAction and selection specific data in PP_PdfAccessibilityActionData. Implemented PdfAXActionTarget::SetSelection method to send selection data to plugin. PDFiumEngine handles PP_PDF_SET_SELECTION action and set the selection in plugin. Added the tests to validate if write action data is sent from Mimehandler to Plugin for selection and also if the action is correctly executed in Plugin. Bug: 1023283 Change-Id: I9112698757d7516d38f29e88174f10da71673b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934127 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727044}
-
Archie Pusaka authored
Bluetooth debug is handled through the btdispatch daemon using org.chromium.Bluetooth service name. However, as btdispatch is going to be taken out, we need to migrate to bluez with org.bluez as the service name. Most of the API calls have been migrated to bluez, but debugging has not been made ready yet. This CL directly use org.chromium.Bluetooth for debugging, instead of org.bluez like the rest of the clients. This needs to be updated when debugging is migrated completely. BUG=b:145967589 Change-Id: I36da87f1e860ca9c65edc8f984596ded3a711a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960048Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#727043}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.0-1576497268-benchmark-81.0.3995.0-r1 to 81-3987.0-1576497268-benchmark-81.0.4001.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icee99a50abbaaa67cbe705c4cbef81c844452697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727042}
-
Emily Stark authored
With HTTP auth committed interstitials enabled, extensions were getting notified of each auth request twice: once when LoginHandler is first called to cancel the auth request and show a blank error page, and again when LoginHandler is called after committing the error page to show a login prompt on top of it. In common operation, the second extension dispatch was a no-op, because the request had been destroyed already by the second entry into LoginHandler. But, there was a race ticked by long response bodies. That is, it was possible that the second onAuthRequired event would be dispatched to an extension before the request was destroyed. The request was destroyed between the second dispatch and the extension's reply. When the extension replied,the WebRequestAPI would simply drop the reply for the now non-existent request, never returning control to LoginHandler so that it can proceed to show the login prompt. The fix is to ensure that auth requests are dispatched to extensions only once, on the first time LoginHandler is called, before the request is cancelled. Bug: 1034468 Change-Id: If9eb71b38dd1738a471c3dadab4093367ab0d03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978898Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#727041}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/041b5b6ffaa5..dc33b15dc48f Created with: gclient setdep -r src-internal@dc33b15dc48f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If3afd8a97c5532c43f14356eb6d8432ffa0403cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979709Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727040}
-
Hans Wennborg authored
This reverts commit 6f7e5e79. Reason for revert: This broke the build, e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-device/144512 ../../third_party/zlib/cpu_features.c:75:13: error: unused function '_cpu_check_features' [-Werror,-Wunused-function] static void _cpu_check_features(void) ^ Original change's description: > Unify CPU features detection code > > This will allow to remove some duplicated code (i.e. thread synchronization) > while at same time removing unnecessary use of inline ASM for Intel features > detection. > > A few other advantages: > - remove some extra logic (e.g. no need to test the platform to include the > correct CPU detection header). > - simplifies the buildsystem (i.e. we always include cpu_features.c) > - get rid of the simd_stub file. > > Bug: 1032721 > Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820 > Reviewed-by: Chris Blume <cblume@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727038} TBR=cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com Change-Id: I20c5dedb98ba8b5d304ff1339042bcf243505e88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979790Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727039}
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#727038}
-
Nate Chapin authored
While there are some differences in how we determine whether it is a secure context depending on window vs worker, the core logic is the same and the policy is set at construction time. Also, this allows us to merge the SecureContextState and SecureContextMode enums. Bug: 1029822 Change-Id: Ia15fbe12c8874426228f6a8ebee19560c4f862c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978839 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Avi Drissman authored
Widgets, GetNativeWindow(), and GetNativeView() should always be in 1:1:1 correspondence. NativeWidgetPrivate::ReparentNativeView() violates that correspondence on some code paths; remove those paths. Also rename some variables in that function for clarity. BUG=1035131, 957362 Change-Id: I761b86e6e53f27c562aa1444d13e5fc050d8faed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972851Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#727036}
-
Manu Cornet authored
This is a pure cleanup with no expected behavior change. Change-Id: I074c8d7a8019ea50c37ba31249f9367dad970b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978466Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#727035}
-
Samuel Huang authored
This reverts commit 2359557a. Reason for revert: heap-buffer-overflow found by ASAN bot, likely due to accessing std::map<>::end() returned by std::map<>::find(). Original change's description: > Fix the issue that ARC app can't start from shelf after switch users. > > The reason is that OnItemDelegateDiscarded is called, and the > controller is deleted from app_shelf_group_to_controller_map_, even > though the parameter delegate is not the controller saved in > app_shelf_group_to_controller_map_. So adding a checking in > OnItemDelegateDiscarded, only when the parameter delegate is the > controller saved in app_shelf_group_to_controller_map_, delete it, > otherwise, don't delete the controller in > app_shelf_group_to_controller_map_. > > BUG=1011235 > > Change-Id: I300b5fc4a46b9441a063c34bac745a5018aa5b82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976140 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726710} TBR=xiyuan@chromium.org,nancylingwang@chromium.org Change-Id: I3c8ee654bd33b2a5235815c01ad6ed1957309c0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979539Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727034}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84f45f105bce..291be9acc1d0 git log 84f45f105bce..291be9acc1d0 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 cnorthrop@google.com Add DEP to pull internal capture files Created with: gclient setdep -r src/third_party/angle@291be9acc1d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Iedc20cacfe6b08879adb60ff765c85547cd3f726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979622Reviewed-by:
-
Samuel Huang authored
This reverts commit 268d26b8. Reason for revert: stack-use-after-return error found by ASAN bot, likely due to returning reference of local variable. Original change's description: > ARC: Add a mojo method for getting the primary account > > ARC needs to know the identity of the primary account, but it cannot > retrieve that from Android account manager. > > Add a mojo method in ArcAuthService for returning the primary account > information from Chrome OS. > > Bug: b/141108534 > Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" > Change-Id: I01ec976a330d52421ab2ddfe5155c712c81967af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810359 > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726738} TBR=mnissler@chromium.org,khmel@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Change-Id: Ibb01613e8f4a7e640b3c1d9983fdf669f3f17271 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/141108534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978255Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/254ce3f8dfb0..d892991127bf git log 254ce3f8dfb0..d892991127bf --date=short --first-parent --format='%ad %ae %s' 2019-12-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d892991127bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I30389b571f7567202ddbb3a01a5465eb9f8504af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979693Reviewed-by:
-
David Black authored
Currently Assistant uses Content Service for embedding WebContents in Ash. Moving forward, we're migrating back to WebView as it better handles focus and ChromeVox related corner cases. To work around dependency restrictions in Ash, this CL adds a new: - AssistantWebViewFactory, and - AssistantWebView2 which are implemented in Browser. AssistantWebView2 is named as it is because there already exists an AssistantWebView in Ash, but the existing AssistantWebView is soon to be removed and the name will free up. AssistantWebView2 abstracts away the concept of WebContents so that the APIs invoked on AssistantWebView2 are delegated to the underlying WebView or WebContents as needed. Bug: b:146351046 Change-Id: Ica75899ca8d5426333b0501a7c4e34698bab4b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974460 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727030}
-
Hirokazu Honda authored
This removed raw images used in image processor test. They are created from bear_320x192.i420.yuv.webm and puppets-1280x720.i420.yuv.webm. bear_320x192.i420.yuv.webm is 40KB and puppets-1280x720.i420.yuv.webm is 334KB. Bug: None Test: None Change-Id: I20af7ecaff514b3c7b22e6e56e86106cb6a47ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976143Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727029}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I12ed7ebb633a983bcf40d0fd139ed3c94eaa5d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978220Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727028}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2723af6a6d43..af203a677aac git log 2723af6a6d43..af203a677aac --date=short --first-parent --format='%ad %ae %s' 2019-12-21 reed@google.com make clipIsWideOpen virtual, so device's don't have to rely on regions Created with: gclient setdep -r src/third_party/skia@af203a677aac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Idf33757b31ec2d20e108dbda7349940f5c0cd3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979627Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79f568e2863e..041b5b6ffaa5 Created with: gclient setdep -r src-internal@041b5b6ffaa5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:998161 Tbr: jbudorick@google.com Change-Id: If247eec3afb78ac6bff733506502f8cd7ec4e7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979624Reviewed-by:
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: I3862d89fd6a381c061868af75e4d24dd8e66a2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976704 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727025}
-
Fish Lin authored
With device's native orientation being Portrait mode, for devices with camera orientation of 0 or 180 degs, the capturing width and height needs to be swapped in order to capture in respect to device's current orientation. Bug: 1032902 Test: Duo calling on devices with different camera orientation Change-Id: Ib8d718cd2787011003ba9b1e2e578eaf310d50de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961300 Commit-Queue: Fish Lin <linfish@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#727024}
-
Natalie Chouinard authored
Replace usages of java_files with sources in all //chrome/browser BUILD.gn files, and automatically format. TBR=yfriedman@chromium.org Bug: 1035074 Change-Id: I50923d85e311ba9b072684beb2d0099910903005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973236 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727023}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Icafcd889b4e28c8200da9316bd2af6efb7d13593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979628Reviewed-by:
-
Peter Kotwicz authored
This CL makes WebappActivity use: - TabModelImpl - CustomTabTabPersistencePolicy instead of WebappDirectoryManager BUG=1032291 Change-Id: I7adc8288105aa161eedbab4ba37724d91c305e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965900 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727021}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1c9b1c07affb..a919e1bd9dd0 git log 1c9b1c07affb..a919e1bd9dd0 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 thestig@chromium.org Update documentation for PDFium initialization. 2019-12-20 tsepez@chromium.org Add CXFA_FFWidget::{Has,Process}EventUnderHandler(). 2019-12-20 thestig@chromium.org Use NoDestructor in a couple obvious places. 2019-12-20 thestig@chromium.org Use spans in testing/image_diff/image_diff_png.h and related code. 2019-12-20 thestig@chromium.org Import Chromium's base/no_destructor.h. 2019-12-20 tsepez@chromium.org Avoid directly including xfa/ layer in fpdf_save.cpp. 2019-12-20 thestig@chromium.org Do IWYU in testing/utils/file_util.cpp. 2019-12-20 thestig@chromium.org Only hash pixel data in EmbedderTest::HashBitmap(). Created with: gclient setdep -r src/third_party/pdfium@a919e1bd9dd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie2b0a1b6b307f42286b3ac88159236fef28c27ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979618Reviewed-by:
-
rbpotter authored
- Delete powerwash dialog from browser settings - Remove settings animated pages, main page behavior, and route observer behavior from browser about page Bug: 990170 Change-Id: I1f2f0a1eb454d55c8f84b7374c7be4e66b238ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979082 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727019}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/988db63351c4..2723af6a6d43 git log 988db63351c4..2723af6a6d43 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2723af6a6d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I15353fa613fede632e3c02f83d7050daae70ee3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979599Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2cb76ab598e5..87d31381588b git log 2cb76ab598e5..87d31381588b --date=short --first-parent --format='%ad %ae %s' 2019-12-20 enga@chromium.org Revert "fuzzing: Add supportsErrorInjection option to DawnWireServerFuzzer" Created with: gclient setdep -r src/third_party/dawn@87d31381588b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id57ba22aa1a07ef4ba52ac39506ef393eabc7dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979507Reviewed-by:
-
Peter Kasting authored
The biggest change here is removing the idea of load success callbacks, which are never used. Bug: none Change-Id: I31c1790e2c7e3bb1c3275327893ddee32533c808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962610 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#727016}
-
chrome://flagsMoe Ahmadi authored
Adds an option to chrome://flags/#omnibox-on-focus-suggestions to enable zero-prefix suggestions on the extension NTP. Bug: 1035711 Change-Id: I5e327828d9b0d7c2895262b00d221f49af0b256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978043 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#727015}
-
Caleb Rouleau authored
I copied the existing win-10-perf shard map since we don't have test runtime data for this yet. That is also why I used only 26 shards for this for now. We can add more shards in later. TBR'ing John since I have Haiyang's non-committer review and this change is low-risk (it only adds a new perf builder and does not affect Chrome.) TBR=johnchen@chromium.org Bug: 998161 Change-Id: I98ab934614380bf5a9678f1765c7f67001a3c7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979094Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727014}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic0add2d836abd30fb2ef89afcce3e2b1ac3d9a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979597Reviewed-by:
-
Regan Hsu authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1967803, addressing more complicated cases of using the settings-localized-link element. Bug: 1015924d Change-Id: I38d64731511f8fd64ec474db47327ff4241b4841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971056Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Evan Stade authored
TBR=avi@chromium.org Bug: 1025256 Change-Id: I2cdc1c86559e3c9217326a452563946fcff149ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972137Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#727011}
-
Connie Wan authored
Changes in this CL: Theme updates: - Refactored TabGroupVisualData to take a TabGroupColorId as the color rather than an SkColor. This required creating a TabGroupColor enum and refactoring restore. - Updated all tab group UI elements to paint a theme-appropriate color (dark or light). ^ This is the source of most of the wide-reaching changes here. Everything below is isolated to 1 or 2 chunks of code, pointed out in comments. Color set updates: - Changed the color values according to crbug.com/1005502 - Changed the hard-coded labels to localized ones. Group updates: - Changed groups to be initialized with the next unused color, rather than a random or default color. - Added tests for group color initialization. Bug: 1030737, 1005502, 1003165 Change-Id: I6c4f8f4df03b6d42a380b38d02334cd90ea4fc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968039 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#727010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/abc8f2777133..84f45f105bce git log abc8f2777133..84f45f105bce --date=short --first-parent --format='%ad %ae %s' 2019-12-20 cnorthrop@google.com Use checkout_angle_internal for non-public files Created with: gclient setdep -r src/third_party/angle@84f45f105bce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032708 Tbr: jmadill@google.com Change-Id: Ib3ce9e398b9161b0506c1b61d922e24cfea8a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979405Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16caad77d2b7..79f568e2863e Created with: gclient setdep -r src-internal@79f568e2863e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifde1035308493255599573c321f026a6e2f4adc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979589Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8b876bd4074b..44134341fa8b git log 8b876bd4074b..44134341fa8b --date=short --first-parent --format='%ad %ae %s' 2019-12-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@44134341fa8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I85b7ceb7932186c56c8009d7326a19d214f2f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979593Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d98b8aed. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 779c13f2 "[IndexedDB] Adding web platform test for File object in IndexedDB." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3085d67f4f3925aaa0f75864e4432785b89f5217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979086Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727006}
-
