- 13 Jul, 2018 40 commits
-
-
Kurt Horimoto authored
This CL updates the reading list table view edit animations from using UITableViewRowAnimationFade to using UITableViewRowAnimationAutomatic. Bug: 862172 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6cdb098dcf7f454a782adb820b9e0f665a54acb Reviewed-on: https://chromium-review.googlesource.com/1132420 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575087}
-
Eric Karl authored
This CL causes us to re-use computed cache keys in the GPU image decode cache rather than re-computing them each frame. Improves the speed of re-acquiring an already-decoded image by 10% in the included perf test. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idfe6b6bb96dded1903c24cc82da9243fe85f00dc Reviewed-on: https://chromium-review.googlesource.com/1135650 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#575086}
-
Eric Orth authored
Starting a TCP DNS attempt cancels and deletes any previous running attempts. Fix the filtering to skip retriable errors that will not retry because we have exhausted available attempts. Otherwise, if an attempt has already completed synchronously and posted to handle the result, it could try to handle the result of a deleted attempt. Also replace the raw Attempt pointer in AttemptResult with a WeakPtr, so any future similar bugs will safely DCHECK and crash instead of UAF. Bug: 860292 Change-Id: I4a012a078b9b35f87b95a9592f4e43573c6a0708 Reviewed-on: https://chromium-review.googlesource.com/1134028 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#575085}
-
Findit authored
This reverts commit fac52799. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 575065 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhYzUyNzk5YjIzNGIxZDQ4MmEyZDljYjQwNjVhZjFmZDkxMGNkODIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/15781 Sample Failed Step: net_unittests Original change's description: > Add new ResolveHost API. > > Primarily an interface-only change. Only change past the interface level > of the stack was to internally pass rawer information rather than > use RequestInfo as that struct is specific to the old Resolve API. > > Only handles the basic case for now (HostPortPair input without any > significant options), but additional funtionality will be added in > subsequent changes. > > Copy and convert all the unittests that can be implemented using the new > method with its current basic functionality. If we ever convert all > usage to the new method and delete the old, we'll be able to cleanly > delete all the old tests. > > Design doc: > https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU > > Bug: 821021 > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I4fe454761e2930d6f235e8e505b689f8917fdeed > Reviewed-on: https://chromium-review.googlesource.com/1099427 > Commit-Queue: Eric Orth <ericorth@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575065} Change-Id: Ifa50c76a409dde3580599275aade1686795d6c17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1137111 Cr-Commit-Position: refs/heads/master@{#575084}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/210610261006..ecbaf6663915 git log 210610261006..ecbaf6663915 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org dEQP: Fix non-GTest error logging. 2018-07-13 lucferron@chromium.org Vulkan: Implement gl_DepthRange support using driver uniform 2018-07-13 lucferron@chromium.org Vulkan: Enable viewport Y flipping Created with: gclient setdep -r src/third_party/angle@ecbaf6663915 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I79233d62143b89d8dd41df36c7e7229c882202a3 Reviewed-on: https://chromium-review.googlesource.com/1136912Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575083}
-
David Tseng authored
1. a few more places where we need to go from dip back to screen (e.g. when dispatching events as part of pass through). 2. InOneFingerPassThrough was taking the event location and subtracting a |passthrough_offset_|. However, it appears downstream there was a syntax or semantic error as the parens were off. We were subtracting the event location *after* being converted to screen with the pass through offset which is in dips. Bug: 862830 Change-Id: I2ca08e2e785e23aae980ea1138f8f57876808b34 Reviewed-on: https://chromium-review.googlesource.com/1135656Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575082}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie86c12f331845a732f8e01840e465a6389c9c01b Reviewed-on: https://chromium-review.googlesource.com/1136931Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575081}
-
Charlie Harrison authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I0fd84010f51370df1b1537ee6eb415aeb363972a Reviewed-on: https://chromium-review.googlesource.com/1136645 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575080}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8e093bc7. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21204 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I3b5057a625e08474add7f4ea48130310d40bdf9a Reviewed-on: https://chromium-review.googlesource.com/1136861 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575079}
-
edchin authored
The tab grid cell titles were previously being updated too late on "page loaded", rather than earlier on "title changed". This CL also sets a default icon for cells. This CL also removes an old snapshot in the tab grid once the title has changed, so that the title and snapshot are in sync. Video: https://drive.google.com/open?id=1NvSuQ039jsl0YTqO6ua_IREk7f2Z807C Bug: 860245, 853569 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic3317ddc50ceb16fe0d89b41e8b26fc2bac203e9 Reviewed-on: https://chromium-review.googlesource.com/1136836Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575078}
-
Scott Chen authored
<iron-list> introduced a bug that causes a focused item to lose focus when the user scrolls away then tab back. A fix was landed in the iron-list repository but a new version had not been released yet, so this CL patches the fix locally first. The local patch should be removed later once iron-list releases the new version and is patched into our code-base. Bug: 854571 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b70ce4188b882839e7a322270847fde85690011 Reviewed-on: https://chromium-review.googlesource.com/1135652Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575077}
-
Nektarios Paisios authored
Removes the word "accessibility" from many Views classes and deletes unused NativeViewAccessibility class There are still a few changes required in Views components that use accessibility classes. I'll ask for other owners to approve when accessibility people are fine. R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: Ie86e2934fe58607a184af44b94ca6cd6ed50c56c Reviewed-on: https://chromium-review.googlesource.com/1123197 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#575076}
-
David Black authored
DeepLinkType enum is more easily consumed by event observers. DeepLinkType + params adequately represents the complete deep link. Bug: b:111437390 Change-Id: I62618b9ae84a1240232bd2f9e50f999cb2be9055 Reviewed-on: https://chromium-review.googlesource.com/1136855 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575075}
-
Dan Zhang authored
Existing crashes are not use-after-free. The CHECK's haven't been triggered so far. Merge internal changelist: 204339592 R=zhongyi@chromium.org Change-Id: I2b0549aafff5f639a3a86803aef364dc8c4e059c Bug: 664200 Change-Id: I2b0549aafff5f639a3a86803aef364dc8c4e059c Reviewed-on: https://chromium-review.googlesource.com/1135871 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575074}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6a990f8..8fb6f6a BUG=861882 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5a89accaec0bd01697ca9c4f0e4a6ac62de23e54 Reviewed-on: https://chromium-review.googlesource.com/1136867Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575073}
-
Xiaohui Chen authored
Bug: b:79879196 Test: locally build and run Change-Id: I299b82477c2ce153e5639426343be946757c3460 Reviewed-on: https://chromium-review.googlesource.com/1132118Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575072}
-
Tommy Steimel authored
This CL adds a MediaLauncherActivity.MediaType histogram to track the type of media the user opens with the MediaLauncherActivity (audio/image/video). Bug: 861954 Change-Id: I28cc0a379ad2bc70d34f2d2f5751c3eb2ebbda45 Reviewed-on: https://chromium-review.googlesource.com/1135522Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575071}
-
Bill Orr authored
This is similar to a change made for Oculus devices. OpenVR is initialized when we have a magic window session, and can only be used on the UI thread, or it can be initialized on the render-loop thread, and we will only use it on that thread. Gamepad data is now updated per-frame by the render loop, with data passed over to the gamepad fetcher and read in its polling thread. BUG=820288, 793364 Change-Id: I543487f823f7ac08e9b0f01889d227f455d0482c Reviewed-on: https://chromium-review.googlesource.com/1136056 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575070}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed1205ae20b2..a80a012456a9 git log ed1205ae20b2..a80a012456a9 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 timliang@google.com Revert "implemented metal gpu backend texture upload testing" 2018-07-13 weiliangc@chromium.org Reland: Check for ANGLE's implementation of texture_rectangle 2018-07-13 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6a6692214c26..8fb6f6a129f5 (1 commits) 2018-07-13 fmalita@chromium.org [skottie] Make stroke width optional 2018-07-13 timliang@google.com implemented metal gpu backend texture upload testing 2018-07-13 ethannicholas@google.com Fixed SPIR-V geometry shaders 2018-07-13 ziadb@google.com SkAR Java: Animation support 2018-07-13 ethannicholas@google.com fixed SPIR-V matrix operations Created with: gclient setdep -r src/third_party/skia@a80a012456a9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Id572c54e9699536fe4be44f65da75295c4613a11 Reviewed-on: https://chromium-review.googlesource.com/1136913Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575069}
-
bsheedy authored
Enables the VR instrumentation tests on Oreo Phone Tester. Change-Id: Ie5d863c8bac56eb62b8db619c8ef4e8925afeef7 Reviewed-on: https://chromium-review.googlesource.com/1136806Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575068}
-
Francois Doray authored
This method the last time at which the state of a LifecycleUnit changed. It will be used to determine if a LifeycleUnit has been unfrozen long enough and should be frozen again. Bug: 775644 Change-Id: I2ba04b9ed4085767e67108cd46901d876efc2217 Reviewed-on: https://chromium-review.googlesource.com/1134029 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#575067}
-
Scott Chen authored
Bug: 860274 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic80b484b6611f960c8fc3a68c39b17795c4c75b3 Reviewed-on: https://chromium-review.googlesource.com/1132321Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575066}
-
Eric Orth authored
Primarily an interface-only change. Only change past the interface level of the stack was to internally pass rawer information rather than use RequestInfo as that struct is specific to the old Resolve API. Only handles the basic case for now (HostPortPair input without any significant options), but additional funtionality will be added in subsequent changes. Copy and convert all the unittests that can be implemented using the new method with its current basic functionality. If we ever convert all usage to the new method and delete the old, we'll be able to cleanly delete all the old tests. Design doc: https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fe454761e2930d6f235e8e505b689f8917fdeed Reviewed-on: https://chromium-review.googlesource.com/1099427 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#575065}
-
Sebastien Marchand authored
Don't enable the "StaggeredBackgroundTabOpening*" features in this experiment, they are independent now. Bug: 829933 Change-Id: Ie30c540974773cc7f9dc53f764766f05aa0e1d14 Reviewed-on: https://chromium-review.googlesource.com/1136652Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#575064}
-
Min Chen authored
Bug: 847587 Change-Id: I4f274158d78f8935339c42bbe15b21dbd4a72736 Reviewed-on: https://chromium-review.googlesource.com/1130464 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#575063}
-
Samuel Huang authored
This is a code movement CL with minimal changes. Details: - Add obj_analyzer.py: New home for BulkObjectFilenalyzer, along with helper functions. Also inherits main() from nm.py for testing. - Add string_extract.py: New home for {LookupElfRodataInfo(), ReadFileChunks(), and ResolveStringPieces()}. Add top-level comments. - nm.py: Have content moved to the new files. Also, exposing RunNmOnIntermediates(), to be called from obj_analyzer.py. - Update archive.py and console.py to adapt to new code locations. Bug: 723798 Change-Id: I1d1670f04549a416f06de1da03c1a2b03c378461 Reviewed-on: https://chromium-review.googlesource.com/1136943 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#575062}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b17b7db7523..a9c02104635b git log 0b17b7db7523..a9c02104635b --date=short --no-merges --format='%ad %ae %s' 2018-07-13 dproy@google.com Merge "Move node_modules install to install-build-deps" 2018-07-13 dproy@google.com Move node_modules install to install-build-deps Created with: gclient setdep -r src/third_party/perfetto@a9c02104635b The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I392ce06446d9ccf7db5ecab0c5b0597c53411734 Reviewed-on: https://chromium-review.googlesource.com/1136737 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575061}
-
Lily Houghton authored
Per https://codereview.chromium.org/2460653003/ ENABLE_MDSN has been migrated from a #define to a buildflag; however, there are two instances of it in PrivetNotificationService that have not been changed yet. This CL fixes those. Bug: 863508 Change-Id: I273afb99ced733012ce58dcfa061d18faa8508de Reviewed-on: https://chromium-review.googlesource.com/1136864Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#575060}
-
chrome://proximity_authJeremy Klein authored
This is needed because multidevice_setup now depends on DeviceSync. I also needed to add base/time because DeviceSync needs it. R=khorimoto@google.com Bug: none Change-Id: I53c9ea62f5e2c4ed90ac8c51221c1d64980fbca9 Reviewed-on: https://chromium-review.googlesource.com/1135949Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#575059}
-
Yuwei Huang authored
Per discussion in the a11y meeting on May 30, this CL re-introduces a 10s timeout for touch triggered FAB so that people using screen reader can easily get back from the FAB to the web content. Bug: 829613 Change-Id: I727d78967f6fb7780eaaaa40e5f5e9cf59b58613 Reviewed-on: https://chromium-review.googlesource.com/1132340 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575058}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d464e6a80005..5e752946b94c Created with: gclient setdep -r src-internal@5e752946b94c The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8b6d86982a32a8d16523ec52b563742a1b72e6e8 Reviewed-on: https://chromium-review.googlesource.com/1136740Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575057}
-
Emily Stark authored
This will allow us to see whether the recurrent interstitial message affects CTR for CT errors specifically (rather than lumping them in with Symantec distrust errors, which can also trigger the recurrent error message). Bug: 839969 Change-Id: I04764573c6f225ab25c61fb268983f02f38fdc3f Reviewed-on: https://chromium-review.googlesource.com/1136717Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575056}
-
Peter Kasting authored
This moves the padding outside the NTB into the NTB, allowing more consistent positioning. Bug: 851044 Test: Open two tabs. The leftmost tab's left curve should taper out to the very corner of the toolbar, not 8 DIP later. Change-Id: I01487e3c416a24b8387bf67c2b1a3e0817125cd9 Reviewed-on: https://chromium-review.googlesource.com/1135965 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#575055}
-
Emily Stark authored
Bug: 839969 Change-Id: I07ad560f50aa25a10a5a9fb55ebdd525d0fa6e84 Reviewed-on: https://chromium-review.googlesource.com/1136711Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575054}
-
Ramya Nagarajan authored
If this is not set, the #ntp-contents height is inherited, which applies from the "top" location specified in .non-google-page, but using the size of the overall NTP content area (at 100%), resulting in an unnecessary scrollbar. The chosen height corresponds to MV tile height for a single row, but also works for a row of icons, and works well on small screens (like Pixelbook), as well as high-res screens. Bug: 855834 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8b342e066c8ddcb51b51e9f03a85e9181a001020 Reviewed-on: https://chromium-review.googlesource.com/1136860 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#575053}
-
Michael Thiessen authored
Bug: 863533 Change-Id: If0579797b75f45308c50ddbf55ac19f007b7e12f Reviewed-on: https://chromium-review.googlesource.com/1136907Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575052}
-
Tommy Steimel authored
This CL modifies the overlay play button ShouldCausePlayPause function to take CSS and Document zoom into account. This fixes a bug where a zoomed video had an incorrect hitbox for the overlay play button. Bug: 862063 Change-Id: I3f51454618e5c455bba62b4b019701d67fd8886c Reviewed-on: https://chromium-review.googlesource.com/1135663Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575051}
-
Peter Kasting authored
This was only used for the new tab button, but the new tab button now reports the relevant size as its preferred size. So we can use that directly everywhere. This will make it easier to add padding around the new tab button, because the button can report a larger size to other callers without having to keep the layout size in sync with a padding value local to new_tab_button.cc. Bug: none Change-Id: Id513c23ba458857032b05ed8e266387d9e1f1f55 Reviewed-on: https://chromium-review.googlesource.com/1135764 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#575050}
-
liberato@chromium.org authored
Since we haven't used ContentVideoView for video playback since ~M64, this CL removes it. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3f9b005bf2b4c7e8d3dd1b1250e42c0089cc1092 Reviewed-on: https://chromium-review.googlesource.com/1112741 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575049}
-
Mike Reed authored
Bug: 863042 Change-Id: Ibde119026dfc6d7a4ba470cc836a834b9a4e5d2f Reviewed-on: https://chromium-review.googlesource.com/1135592 Commit-Queue: Mike Reed <reed@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#575048}
-