- 05 Nov, 2019 40 commits
-
-
Xiaohan Wang authored
This reverts commit f1326b9e and relands 549944d5 without change. Reason for revert: The flaky test has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1900158 Original change's description: > Revert "media: Move Renderer creation to PipelineImpl" > > This reverts commit 549944d5. > > Reason for revert: Suspected culprit of WebMediaPlayerImplTest.Encrypted test failures > > The failure appears deterministic on windows: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/42005 > > but also will flake often on other platforms: > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySgsSBUZsYWtlIj9jaHJvbWl1bUBtZWRpYV9ibGlua191bml0dGVzdHNAV2ViTWVkaWFQbGF5ZXJJbXBsVGVzdC5FbmNyeXB0ZWQM > > Original change's description: > > media: Move Renderer creation to PipelineImpl > > > > Instead of creating the Renderer in PipelineController before pipeline > > start which includes Demuxer initialization, this CL moves Renderer > > creation to PipelineImpl as a step in PipelineImpl::Start() so that the > > Renderer is only created after the Demuxer has been initialized. This > > makes it possible to have more flexible Renderer creation, e.g. create > > different Renderers based on different stream or CDM. > > > > Bug: 1018372, 827990 > > Test: No functionality change. > > Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#712397} > > TBR=dalecurtis@chromium.org,xhwang@chromium.org > > Change-Id: Iac06fd02de8b4e436ecb16638994cd1b9fb1f7e7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1018372, 827990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899873 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712594} TBR=dalecurtis@chromium.org,xhwang@chromium.org,andypaicu@chromium.org Change-Id: I64ab3d453034bf0faf7250bcfb3d0015972a9bc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018372, 827990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900287Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712723}
-
Dave Tapuska authored
Content/renderer does not need to know about this message so define it solely on the blink interface. BUG=1008432 Change-Id: I522c1bb8462c75e85b480f7784900da75d72e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895511 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712722}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I97baf50eab960fc9cbd6577ad1da4b2bda9632c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900150Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#712721}
-
Matthias Körber authored
Bug: 1021543 Change-Id: I794550c57e46d78bbca1ae9ec857e2a27d338874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899779 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712720}
-
Peter Kvitek authored
The function is anonymous::SelectedLinuxBackendToString() and it is called from KeyStorageLinux::CreateService from under a bunch of #ifdef's Change-Id: Ia087cf602b0fc09c76e2f3c77322a66680ed6d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900114 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#712719}
-
Clark DuVall authored
This adds a bool to BrowserController.executeScript() which allows running the script in the main world instead of an isolate. Change-Id: I0574de6493c99b187963217341c7e003fcfedb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895320Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712718}
-
George Zhang authored
The main purpose of the java heap profiler is to obtain a heap dump in the form of an hprof file and then parse the hprof file. Currently,there exists a way to obtain the heap dump but there is no way to parse the hprof file. This CL includes a barebones parser for these hprof files. Bug: 1012072 Change-Id: I7a5d19ba8a4c0284fcae41d7057ad44a0b0acdab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861103 Commit-Queue: George Zhang <zhanggeorge@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#712717}
-
Rouslan Solomakhin authored
Before this patch, multiple places in code either used literals for payment method names (such as "basic-card", "https://google.com/pay") or defined constants, which were sometimes redundant across platforms. This slowed down the process of management of these constants, e.g., adding new method names or tracking down all usage of a single method name. This patch adds payment_strings.cc (similar to error_strings.cc) with several constants for payment method names used across iOS, Android, and desktop non-test code. The patch adds PaymentStrings.java generated from payment_strings.cc (similarto ErrorStrings.java). After this patch, iOS, Android, and desktop non-test code re-use the same string constants for payment method identifiers. This makes adding a new method names and tracking down usage of each method name easier. Bug: 1017348 Change-Id: I3a879192a6a383d53089547a567f4127897a7bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876756 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712716}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcSessionDescriptionRequest directly. Note that the CL temporarily duplicates some template definitions in blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc, but it will be sorted out when RTCVoidRequest replaces the uses of WebRTCVoidRequest. The duplication is removed right way in https://crrev.com/c/1899786 (see relation chain). Similar CLs: https://crrev.com/c/1890794 and https://crrev.com/c/1884931. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic23698aa0fcee899f19ac17c3fe464bf2c11c395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897772 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712715}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6e71a5063590..bce667b745aa git log 6e71a5063590..bce667b745aa --date=short --no-merges --format='%ad %ae %s' 2019-11-05 perezju@chromium.org [Telemetry] Do not percent encode story names Created with: gclient setdep -r src/third_party/catapult@bce667b745aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:981349 Change-Id: I74905d3cb5cee230d5ec2f79f6a7430b9f6efea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712714}
-
Francois Doray authored
Reland #2 "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode." This is a reland of 9d6a01ba //base now supports ::GetThreadPriority() returning 3, so this shouldn't cause problems on bots. https://crrev.com/712564 Original change's description: > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > This experiment enables: > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > background threads. This affects memory and IO priority in addition > to CPU priority. > - Increase thread priority to "normal" in scopes where background > threads load modules. > > The expectation is that this will improve responsiveness of Chrome > (input delay, first contentful paint), without regressing jank. > > We are adding the testing config in preparation for enabling this > via Finch in M79. > > Bug: 973868 > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705960} TBR=rkaplow@chromium.org Bug: 973868 Change-Id: I26127cc8e545a1f187a806ed5247c6b91f2f4db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899790Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#712713}
-
Jun Mukai authored
This property was added for Mus and it's been here, though it is always true now. Let's just remove it. Bug: none Test: build passes Change-Id: I1ddbf44e5563984a4516b5800191c5f3b00a0f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898399 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712712}
-
Josh Nohle authored
This CL prepares the way for the addition of SetFeatureStatus() to the DeviceSync mojo service. See http://crrev/c/1831010. Bug: 951969 Change-Id: I488984c741ed7050bef2a78163ef6e93f7aee2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895887Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#712711}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/69dd6b02511c..14c3436191d3 git log 69dd6b02511c..14c3436191d3 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 tsepez@chromium.org Add some missing ObservedPtr<> comparison operators Created with: gclient setdep -r src/third_party/pdfium@14c3436191d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I0c6d437c58d3cba4f762ac6041b1b61a44658c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712710}
-
Xiaohan Wang authored
The current test has a race condition that by the time MetaData is reported (right after Demuxer initialization), the Renderer might not have been initialized (which triggers the "waitingforkey" event, that will trigger DidBlockPlaybackWaitingForKey(). This CL fixes the test so that Load() will wait for DidBlockPlaybackWaitingForKey() to avoid this race condition. Bug: 1021574 Test: Fix flaky test. Change-Id: Icd3bdae9ceb2a5bb7791418e729e68e323ff74fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900158Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712709}
-
Christopher Grant authored
When feature libraries for DFMs were introduced, the library name matched the .so name (eg. libvr.so). This made library loading easier. However, it necessitated placing these libraries into a build subdirectory, so that Monochrome's libvr.so wouldn't collide with Chrome's libvr.so (with the same applying to the test dummy module, and any future DFMs). Since then, we've learned that this puts a tax on other parts of the system, such as stack decoding tools, when trying to locate such libraries. Further, the module build framework has been improved to package and load feature libraries automatically, which means the files can have arbitrary names. This lets us move to a system where (using VR as an example), we have libmonochrome.so and libmonochrome_vr.so created in the conventional build output directory. VR, for now, still has a factory that loads its own library. Normally, this wouldn't be an issue, since loading a library twice results in a no-op the second time. However, we've been warned that because the soname ("vr") and the library file name don't match, that there could be issues with Android actually loading the library twice. This shouldn't be a problem for VR, but if it is, we could temporarily blacklist VR from being loaded by the module library, until it's native code is fully in the VR DFM, and it's custom factory disappears. Bug: 1015159 Change-Id: Icd20399756d1c4876df922d9c111cda0e67773d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897910Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#712708}
-
Changwan Ryu authored
Even '*' can be injected as valid js object name and used as window property. This is a test to show that. Bug: 918065 Change-Id: I1a91b658e1c6357a7b61197a487c848a1980b5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899183Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712707}
-
Shivani Sharma authored
This CL disables Split Cache explicitly for the test NetworkContextTest.NotifyExternalCacheHit and updates expectations accordingly. This is because the test NetworkContextTest.NotifyExternalCacheHit_Split is already testing the expectations for when split cache is enabled. Bug: 1009597 Change-Id: If987208f59cd9d41de52d2f2aacc3ff7e78644b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899893Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#712706}
-
Christopher Grant authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/c46151db0ffd..5915ea929c43 $ git log c46151db0..5915ea929 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 cjgrant Add fallthrough annotations on new C++ switches 2019-11-01 mark Revert "Remove use of "register" keyword, deprecated in C++17" 2019-10-29 jperaza linux, client: set module name from DT_SONAME 2019-10-29 cjgrant linux, dump_syms: Make style consistent in module unittest 2019-10-29 cjgrant linux, dump_syms: Filter module entries outside specified ranges 2019-10-04 jakehehrlich Add options to set OS and filename 2019-10-24 jperaza linux, dump_syms: set module name from DT_SONAME 2019-08-03 vapier convert_UTF: rewrite in C++ 2019-08-14 vapier codereview.settings: do not force squashing behavior 2019-08-12 mark Remove use of "register" keyword, deprecated in C++17 2019-08-07 mark Mac dump_syms: accept __DWARF segment without __debug_info section 2019-08-03 vapier string_conversion: fix pointer math 2019-08-03 vapier guid_creater: include string.h for memcpy 2019-08-03 vapier minidump_processor: fix typo in BUS_ADRALN 2019-08-03 henri.hyyrylainen Updated lss to fix compiling with GCC 9 2019-07-22 jperaza arm64: strip PACs from link register values 2019-07-11 ivanpe Improving the support for Fuchsia in Breakpad Processor. 2019-07-03 mark Remove base_logging::LogMessage Created with: roll-dep src/third_party/breakpad/breakpad Bug: 990190 Change-Id: If18e57e7f360e8bb514ab61164c1049135c5d27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894258Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#712705}
-
Etienne Bergeron authored
This CL is a refactoring on the way RenderText do ItemizeTextToRuns for the corner cases where a run should be split in grapheme clusters. The previous code was naming these cases: * Unusual characters * Special characters * Non-regular characters But they should be more specific on the purpose of splitting the runs. Also, the algorithm used for splitting a sequence of codepoint was based on the code block of the corresponding codepoints and few cases where trying to merge adjacent codepoint in a grapheme. The algorithm was incorrect multiple cases (e.g. emoji). Unicode provide a way to split a sequence of codepoints into grapheme and grapheme clusters. They provide a state machine which is using the codepoint proporties to decide if the current location is a grapheme boundaries. The ICU library is providing an API over the character properties to help iterating over graphemes. * ubrk_open * ubrk_first * ubrk_next * ubrk_close The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is providing an easy to use wrapper over that API. The current CL is replacing the previous characters based splitting algorithm by the graphemes based version. See emoji sequence: http://www.unicode.org/reports/tr51/ 1.4.5 Emoji Sequences The full emoji list: * http://unicode.org/emoji/charts/full-emoji-list.html Emoji data, used to make our unittests: * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/) see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712704}
-
Friedrich Horschig authored
If the touch to fill sheet is dismissed, it triggers a second call to BottomSheetController#hideContent. That call triggers an observer in the BottomContainer again which then moves itself out of the visible view port. (The latter can only happen since a division by zero bypasses some guard conditions. It might make sense to abort attempts at repeatedly dismissing the bottomsheet but this exceeds the scope of this CL.) Bug: 1021550 Change-Id: Ida2b6bc9ffd18513419bed40b29ca84528310907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899882Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#712703}
-
Theresa Wellington authored
Adds an AppMenuTest for app menu integration tests - #testShowHideAppMenu - #testShowDestroyAppMenu - #testClickMenuItem - #testAppMenuBlockers - #testSetMenuHighlight_StandardItem - #testSetMenuHighlight_Icon - #testMenuItemContentChnaged - #testHeaderFooter - #testAppMenuHiddenOnStopWithNative - #testAppMenuHiddenOnConfigurationChange Also adds a few more tests to AppMenuAdapterTest to shore up test coverage and adds an AppMenuAdapterRenderTest that runs a suite of render tests for the various types of menu items supported natively by the app menu. This patch includes an update to AnimationFrameTimeHistogram to allow histogram recording to be disabled for tests. BUG=966644 Change-Id: I035b10557a9e35ef0e86b315ccd926230bb18bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893984 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712702}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9b546970ec2..7a13b461e6e0 git log e9b546970ec2..7a13b461e6e0 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mtklein@google.com x86-64 JIT support for Op::index 2019-11-05 csmartdalton@google.com ccpr: Fail gracefully when atlas instantiation fails Created with: gclient setdep -r src/third_party/skia@7a13b461e6e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ifae4d72e4f1461a247a03c17cf72df7bea4522d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712701}
-
Christopher Cameron authored
When an app is profile-agnostic, change the Info.plist to: - Not embed the profile name in the kCFBundleIdentifierKey value - Not specify the kCrAppModeProfileDirKey value at all - Not specify the kCrAppModeProfileNameKey value at all - Strip the profile path out of the kCrAppModeUserDataDirKey value - Note that the user data dir still references the launching user's home directory, so these shims cannot be moved to /Applications. - That is tracked in the separate https://crbug.com/1021237 When searching for an app shim via bundle identifier, allow profile- agnostic apps to use either the profile-scoped or profile-agnostic shim. This will allow users to continue using pre-existing shims. A follow-on patch will add UMAs to query how often this occurs, so we can decide when to remove that code. This is all still behind a flag. Bug: 1001222 Change-Id: I2515fb179b6fde5ffa3b04c32e50fb93c6329860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894164 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712700}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia7250dd603ab0edaf6e49dcf60058b311b401842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712699}
-
Scott Violet authored
Now that launching waits for a first paint, this no longer seems flaky. At least I couldn't repro locally after ~10ish tries. BUG=1020065 TEST=test only change Change-Id: I1530fcb3f9811b0251a20bd151be5d55322283f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899336Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712698}
-
Vadym Doroshenko authored
The only left warnings were recently introduced by CL https://chromium-review.googlesource.com/c/chromium/src/+/1811197 in files compositor_frame_reporter.cc and frame_sequence_tracker.cc. Bug: 999871 Change-Id: I77d50266a87ee8b3dbe9d9ed313b5019a364a8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899986 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#712697}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dbf9f7c39cbe..c277c38d9064 git log dbf9f7c39cbe..c277c38d9064 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 cwallez@chromium.org Suppress failing VertexFormat tests on Mac Intel 2019-11-05 kainino@chromium.org Enable EmulateStoreAndMSAAResolve correctly by platform 2019-11-05 cwallez@chromium.org Vulkan: Reuse descriptor pools Created with: gclient setdep -r src/third_party/dawn@c277c38d9064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I59a112ca5266d4138cc573ea4acfda2337225366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712696}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ac36a55cc2de..1bae56151db3 git log ac36a55cc2de..1bae56151db3 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 jmadill@chromium.org Remove some ignores from export_targets.py. Created with: gclient setdep -r src/third_party/angle@1bae56151db3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I3e42c4e358433232327556b899f483de3467a3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712695}
-
Megan Jablonski authored
Bug: 976352 Change-Id: I0e8a1edd503654268c9b80f056107bf7bde88065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898089Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712694}
-
Doug Arnett authored
Bug: 960961 Change-Id: I0d1003f4723d7482860e35cae50aeea8c77b835b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894322 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712693}
-
Maksim Sisov authored
The feature was accidentaly removed by crrev.com/c/1772537 This CL adds it back by adding necessary interfaces to DWTHLinux, PlatformWindowLinux and X11Window. The method is X11 specific and not in use for Wayland as long as Wayland does not allow to manipulate clients' windows. Bug: 1002358 Change-Id: Id43d5991f662f8986670ebef45f2443472806590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899464 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712692}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a0fd7570. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie3df3537178159264e4143564d1fc648c15d9369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899789Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712691}
-
Esmael El-Moslimany authored
The enhancements flag can be enabled by searching for webui-a11y-enhancements on chrome://flags or by adding the command-line switch --enable-features=WebUIA11yEnhancements. Bug: 1001742 Change-Id: I1d2b4162a8a5954172062d64aab871f4ca5b72ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898479 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#712690}
-
Mikhail Khokhlov authored
To avoid issues with quoting/unquoting cloud urls, we remove all unsafe characters from the remote name. Bug: 981349 Change-Id: Ia9a17642072d435141eb19d42c0692a5de86558b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899881 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#712689}
-
Nate Fischer authored
No change to logic, only docs. This clarifies that embedders may return the empty string from GetAppPackageName() for privacy concerns (previously this was not documented as a supported case). This removes embedder-specific terminology from the metrics component, and clarifies WebView's behavior in its method override. Bug: 969803 Test: N/A Change-Id: Idb57e4de11cc8c40b58f95a012a5110ba9bdf8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897012Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712688}
-
Dale Curtis authored
BUG=1016765 TBR=rsesek Change-Id: If47516e072201bf04750e76adb01420a999645eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900155Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712687}
-
Dan Beam authored
Bug: None Change-Id: I8b7f574b49b92a6221462fd1b1139d4ab168731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899007 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#712686}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 145 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-05-03. Change-Id: I8fac8b4855e04e7bd9ba563ee428ec27c040c92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899287 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#712685}
-
Lan Wei authored
For the multiple touch points case, if we have one point move and the other point stay still, such as point 1: pointerdown, pointermove, pointerup point 2: pointerdown, pause, pointerup We should send five touch point events of "pointerdown", "pointerdown", "pointermove", "pointerup", "pointerup" with pointer id 1, 2, 1, 1, 2. Bug: 1020674 Change-Id: I2a738154fee5a4356b64467fd9483c69429217d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895861Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712684}
-